D4151: linelog: fix infinite loop vulnerability

2018-08-06 Thread quark (Jun Wu)
quark updated this revision to Diff 10032. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4151?vs=10031=10032 REVISION DETAIL https://phab.mercurial-scm.org/D4151 AFFECTED FILES mercurial/linelog.py tests/test-linelog.py CHANGE DETAILS diff --git

D4151: linelog: fix infinite loop vulnerability

2018-08-06 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Checking `len(lines)` is not a great way of detecting infinite loops, as demonstrated in the added test. Therefore check instruction count instead. The

D4144: changegroup: assign to proper attribute

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9134c4e46084: changegroup: assign to proper attribute (authored by indygreg, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4144?vs=10019=10030#toc REPOSITORY rHG Mercurial

D4147: linelog: update internal help text

2018-08-06 Thread quark (Jun Wu)
quark updated this revision to Diff 10027. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4147?vs=10022=10027 REVISION DETAIL https://phab.mercurial-scm.org/D4147 AFFECTED FILES mercurial/help/internals/linelog.txt CHANGE DETAILS diff --git

D4149: linelog: extract `len(self._program)` to a local function

2018-08-06 Thread quark (Jun Wu)
quark updated this revision to Diff 10026. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4149?vs=10024=10026 REVISION DETAIL https://phab.mercurial-scm.org/D4149 AFFECTED FILES mercurial/linelog.py CHANGE DETAILS diff --git a/mercurial/linelog.py

D4148: perf: add a command to benchmark linelog edits

2018-08-06 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The use pattern of creating a linelog is usually by calling "replacelines" multiple times. Add a command to benchmark it. REPOSITORY rHG Mercurial REVISION

D4147: linelog: update internal help text

2018-08-06 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This clarifies the details asked by @martinvonz on https://phab.mercurial-scm.org/D3990. REPOSITORY rHG Mercurial REVISION DETAIL

D4150: linelog: optimize replacelines

2018-08-06 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The optimization to avoid calling `annotate` inside replacelines is critical for practical uses. Before this patch: hg perflinelogedits ! wall

D4149: linelog: extract `len(self._program)` to a local function

2018-08-06 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a micro optimization prepared for following changes where `len(self._program)` is used in a loop. REPOSITORY rHG Mercurial REVISION DETAIL

D4088: changegroup: move revision maps to cgpacker

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg added subscribers: spectral, martinvonz, durin42. indygreg added inline comments. INLINE COMMENTS > changegroup.py:599-600 > +if self._nextclrevtolocalrev: > +self.clrevtolocalrev = self._nextclrevtolocalrev > +self._nextclrevtolocalrev.clear() >

D4146: fix: correctly set wdirwritten given that the dict item is deleted

2018-08-06 Thread hooper (Danny Hooper)
hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4146 AFFECTED FILES hgext/fix.py CHANGE DETAILS diff --git a/hgext/fix.py b/hgext/fix.py ---

D4145: fix: pull out flag definitions to make them re-usable from extensions

2018-08-06 Thread hooper (Danny Hooper)
hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes it cleaner to implement fix-related commands with additional functionality while sharing some flags with the core implementation. REPOSITORY rHG

D4144: changegroup: assign to proper attribute

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY https://phab.mercurial-scm.org/rHG0548f696795b6f30c32f11620ddc274a112260d3 accidentally assigned to self.clrevtolocalrev instead of self._clrevtolocalrev.

D4143: tests: fix bytes/str issues in run-tests.py caught by python3

2018-08-06 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4143 AFFECTED FILES tests/run-tests.py CHANGE DETAILS diff --git a/tests/run-tests.py

D4130: match: add visitchildrenset complement to visitdir

2018-08-06 Thread spectral (Kyle Lippincott)
spectral updated this revision to Diff 10017. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4130?vs==10017 REVISION DETAIL https://phab.mercurial-scm.org/D4130 AFFECTED FILES mercurial/match.py tests/test-match.py CHANGE DETAILS diff --git

D4129: includematcher: separate "parents" from "dirs"

2018-08-06 Thread spectral (Kyle Lippincott)
spectral updated this revision to Diff 10016. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4129?vs=9998=10016 REVISION DETAIL https://phab.mercurial-scm.org/D4129 AFFECTED FILES mercurial/match.py CHANGE DETAILS diff --git a/mercurial/match.py

D4128: match: add tests for visitdir functionality

2018-08-06 Thread spectral (Kyle Lippincott)
spectral updated this revision to Diff 10015. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4128?vs=9997=10015 REVISION DETAIL https://phab.mercurial-scm.org/D4128 AFFECTED FILES tests/test-match.py CHANGE DETAILS diff --git a/tests/test-match.py

D4126: absorb: remove sf alias for command

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG80749ff64ef4: absorb: remove sf alias for command (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4126?vs=9993=10014

D4126: absorb: remove sf alias for command

2018-08-06 Thread durin42 (Augie Fackler)
durin42 added a comment. I think it was `smartfixup`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4126 To: indygreg, #hg-reviewers, durin42 Cc: mercurial-devel ___ Mercurial-devel mailing list

D2679: [PoC] obsolete: config option to enable local only obsolescence mode

2018-08-06 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D2679#62662, @pulkit wrote: > These patches were result of a very extensive discussion about what ways we have to start supporting obsmarkers by default. I will like to push these changesets so that we can try these in this

mercurial@38841: new changeset

2018-08-06 Thread Mercurial Commits
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/df0873ab5c14 changeset: 38841:df0873ab5c14 bookmark:@ tag: tip user:Martin von Zweigbergk date:Fri Apr 13 23:37:53 2018 -0700 summary: revlog: use specialized exception for ambiguous prefix

D4108: index: extract a type for the nodetree

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg added a comment. For the record, I'm not thrilled about queuing C code with known bugs. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4108 To: martinvonz, #hg-reviewers Cc: indygreg, yuja, mercurial-devel

D4128: match: add tests for visitdir functionality

2018-08-06 Thread spectral (Kyle Lippincott)
spectral planned changes to this revision. spectral added a comment. Need to fix some lint errors REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4128 To: spectral, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel

D4139: changegroup: pass sorted revisions into group() (API)

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Currently, group() receives a list of nodes and calls _sortgroup() to sort them and turn them into revs. Since the sorting behavior varies depending on the

D4142: changegroup: extract _revisiondeltanormal() to standalone function

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It wasn't accessing anything important on the cgpacker that warranted it being a method instead of a function. REPOSITORY rHG Mercurial REVISION DETAIL

D4138: changegroup: pull _fileheader out of cgpacker

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It doesn't need any state from the packer. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4138 AFFECTED FILES

D4132: changegroup: pass function to resolve delta parents into constructor

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, _deltaparent() encapsulated the logic for all 3 delta parent modes of operation. The choice of delta parent is static for the lifetime of the

D4141: changegroup: inline _revchunk() into group()

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY _revchunk() was pretty minimal. I think having all the code for generating data composing the changegroup in one function makes things easier to understand.

D4137: changegroup: factor changelogdone into an argument

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The variable was basically tracking whether the current operation is being performed against the changelog or something else. So let's just pass such a flag to

D4133: changegroup: factor changelog chunk generation into own function

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have separate functions for generating manifests and filelogs. Let's split changelog into its own function so things are consistent. As part of this, we

D4135: changegroup: key off changelogdone

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We use self._changelogdone for similar checks. Let's make things consistent. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4135

D4140: changegroup: pass mfdicts properly

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With the narrow code part of core, the hacky pass-argument-via- attribute-on-self can be accomplished with a regular function argument. REPOSITORY rHG

D4136: changegroup: record changelogdone after fully consuming its data

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Setting this as a side-effect of calling _close() is wonky. There's only one group for changelog data. So we can wait until after all data has been emitted

D4134: perf: call _generatechangelog() instead of group()

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we have a separate function for generating just the changelog bits, the perf command should call it so it gets more accurate behavior. This

D4131: dirstate: use visitchildrenset in traverse

2018-08-06 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This speeds up `hg status` a fair amount when there is a very large directory and narrow is in use. Timing numbers according to command: hyperfine

D4129: includematcher: separate "parents" from "dirs"

2018-08-06 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A future patch will make use of this separation so that we can make more intelligent decisions about what to investigate/load when the matcher is in use.

D4128: match: add tests for visitdir functionality

2018-08-06 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are a few cases that we could have done better with some additional logic; I tried to annotate these when I noticed them, but may have missed some. The

D4130: match: add visitchildrenset complement to visitdir

2018-08-06 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `visitdir(d)` lets a caller query whether the directory is part of the matcher. It can receive a response of 'all' (yes, and all children, you can stop calling

D4124: changegroup: always use the treemanifest-enabled version of _packmanifests()

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8a13855c8dbe: changegroup: always use the treemanifest-enabled version of _packmanifests() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3993: linelog: add replacelines_vec for fastannotate

2018-08-06 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6fed8b323651: linelog: add replacelines_vec for fastannotate (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4127: changegroup: rename _packtreemanifests and adjust comment

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg abandoned this revision. indygreg added a comment. https://phab.mercurial-scm.org/D4124 is the better solution here. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4127 To: indygreg, #hg-reviewers Cc: mercurial-devel

D4127: changegroup: rename _packtreemanifests and adjust comment

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Follow-up from review comments in https://phab.mercurial-scm.org/D4081. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4127

D4126: absorb: remove sf alias for command

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not even sure what it is supposed to stand for. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4126 AFFECTED FILES

D3992: absorb: drop wrapper around the amend command

2018-08-06 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8460c3cbca7e: absorb: drop wrapper around the amend command (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3991: absorb: import extension from Facebook's hg-experimental

2018-08-06 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5111d11b8719: absorb: import extension from Facebooks hg-experimental (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4047: absorb: note some TODOs from the code review

2018-08-06 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGec0697f4f9c9: absorb: note some TODOs from the code review (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4047?vs=9764=9991

D4046: absorb: use ui.debug() instead of open-coding it

2018-08-06 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe930df0f9a55: absorb: use ui.debug() instead of open-coding it (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4045: absorb: use pycompat to get xrange

2018-08-06 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa5c8c5476339: absorb: use pycompat to get xrange (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4045?vs=9762=9989 REVISION

D4044: absorb: use set literal to avoid intermediate list

2018-08-06 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdc4750b2a04e: absorb: use set literal to avoid intermediate list (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4043: absorb: avoid mutable default arg

2018-08-06 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2ac40e86f604: absorb: avoid mutable default arg (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4043?vs=9760=9987 REVISION

D3991: absorb: import extension from Facebook's hg-experimental

2018-08-06 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. I'm fine taking this as-is. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3991 To: durin42, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel

[PATCH 1 of 3] hgweb: use registrar to add "motd" template keyword

2018-08-06 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1532779325 -32400 # Sat Jul 28 21:02:05 2018 +0900 # Node ID 85ca5ee20667c00b087d4a817f240545704f547d # Parent 3027a1bfe1424ded9114da1061c455c40d2c4740 hgweb: use registrar to add "motd" template keyword This prepares for deprecation of

[PATCH 3 of 3] templatekw: deprecate old-style template keyword function (API)

2018-08-06 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1519560273 -32400 # Sun Feb 25 21:04:33 2018 +0900 # Node ID c31ae8d0e6c30b7acc2abfe1299c1122b05429e6 # Parent 7633562bfbe0ca069194cd0f86043cf31a6d78e0 templatekw: deprecate old-style template keyword function (API) .. api::

[PATCH 2 of 3] hgweb: mark all lambda template keywords as new-style function

2018-08-06 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1532780364 -32400 # Sat Jul 28 21:19:24 2018 +0900 # Node ID 7633562bfbe0ca069194cd0f86043cf31a6d78e0 # Parent 85ca5ee20667c00b087d4a817f240545704f547d hgweb: mark all lambda template keywords as new-style function This is just a temporary

[PATCH 2 of 2] fileset: load core predicates directly to symbols dict

2018-08-06 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1532226103 -32400 # Sun Jul 22 11:21:43 2018 +0900 # Node ID 3027a1bfe1424ded9114da1061c455c40d2c4740 # Parent cd4c0681c2a56a79aaa19d5ba48647e47b6e1161 fileset: load core predicates directly to symbols dict We no longer have any side effect

[PATCH 1 of 2] fileset: turn on listclean conditionally

2018-08-06 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1532227752 -32400 # Sun Jul 22 11:49:12 2018 +0900 # Node ID cd4c0681c2a56a79aaa19d5ba48647e47b6e1161 # Parent 49b51f41fb46d497487ee2211b88387230f504b8 fileset: turn on listclean conditionally This is just a micro optimization. diff --git

D4119: index: move raise_revlog_error() further up

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 9984. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4119?vs=9925=9984 REVISION DETAIL https://phab.mercurial-scm.org/D4119 AFFECTED FILES mercurial/cext/revlog.c CHANGE DETAILS diff --git

D4111: index: pass only nodetree to nt_new()

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D4111#63861, @yuja wrote: > Queued up to this, thanks. Can you rebase https://phab.mercurial-scm.org/D4113:? Done. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4111 To: martinvonz,

D4117: index: move index_clearcaches() further down

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 9982. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4117?vs=9920=9982 REVISION DETAIL https://phab.mercurial-scm.org/D4117 AFFECTED FILES mercurial/cext/revlog.c CHANGE DETAILS diff --git

D4115: index: rename "nt_*(indexObject *self, ...)" functions to "index_*"

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 9980. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4115?vs=9918=9980 REVISION DETAIL https://phab.mercurial-scm.org/D4115 AFFECTED FILES mercurial/cext/revlog.c CHANGE DETAILS diff --git

D4112: index: add pointer from nodetree back to index

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 9977. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4112?vs=9915=9977 REVISION DETAIL https://phab.mercurial-scm.org/D4112 AFFECTED FILES mercurial/cext/revlog.c CHANGE DETAILS diff --git

D4116: index: move all "nt_*" functions to one place

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 9981. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4116?vs=9919=9981 REVISION DETAIL https://phab.mercurial-scm.org/D4116 AFFECTED FILES mercurial/cext/revlog.c CHANGE DETAILS diff --git

D4118: index: make node tree a Python object

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 9983. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4118?vs=9924=9983 REVISION DETAIL https://phab.mercurial-scm.org/D4118 AFFECTED FILES mercurial/cext/revlog.c CHANGE DETAILS diff --git

D4120: shortest: use nodetree for finding shortest node within revset

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 9985. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4120?vs=9926=9985 REVISION DETAIL https://phab.mercurial-scm.org/D4120 AFFECTED FILES mercurial/cext/revlog.c mercurial/scmutil.py CHANGE DETAILS diff

D4114: index: split up nt_init() in two

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 9979. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4114?vs=9917=9979 REVISION DETAIL https://phab.mercurial-scm.org/D4114 AFFECTED FILES mercurial/cext/revlog.c CHANGE DETAILS diff --git

D4113: index: make most "nt_*" functions take a nodetree

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 9978. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4113?vs=9916=9978 REVISION DETAIL https://phab.mercurial-scm.org/D4113 AFFECTED FILES mercurial/cext/revlog.c CHANGE DETAILS diff --git

Re: D3976: grep: add MULTIREV support to --allfiles flag

2018-08-06 Thread Yuya Nishihara
Looks mostly good. One nit. > @@ -2748,7 +2749,7 @@ > for fn in sorted(revfiles.get(rev, [])): > states = matches[rev][fn] > copy = copies.get(rev, {}).get(fn) > -if fn in skip: > +if fn in skip and not all_files: > if

D3976: grep: add MULTIREV support to --allfiles flag

2018-08-06 Thread yuja (Yuya Nishihara)
yuja added a comment. Looks mostly good. One nit. > @@ -2748,7 +2749,7 @@ > > for fn in sorted(revfiles.get(rev, [])): > states = matches[rev][fn] > copy = copies.get(rev, {}).get(fn) > > - if fn in skip: +if fn in skip and not all_files: if copy:

D4123: resolve: organize 'if confirm' conditionals

2018-08-06 Thread khanchi97 (Sushil khanchi)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG49b51f41fb46: resolve: organize if confirm conditionals (authored by khanchi97, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4123?vs=9940=9976

D4109: index: move more fields onto nodetree type

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc2c253558e3c: index: move more fields onto nodetree type (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4110: index: drop now-redundant "nt" prefix of fields in nodetree struct

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf28e64bbdd29: index: drop now-redundant nt prefix of fields in nodetree struct (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4111: index: pass only nodetree to nt_new()

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfff675dfb80b: index: pass only nodetree to nt_new() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4111?vs=9914=9975

D4107: index: make "nt_*" functions work on an initialized nodetree

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2aa4f06c1e91: index: make nt_* functions work on an initialized nodetree (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4108: index: extract a type for the nodetree

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd1bc0e7c862b: index: extract a type for the nodetree (authored by martinvonz, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4108?vs=9911=9972#toc REPOSITORY rHG Mercurial

Re: D4108: index: extract a type for the nodetree

2018-08-06 Thread Yuya Nishihara
Queued, but there seem to be a couple of minor errors. Can you fix them if they remain in the code after the refactor? > static int nt_new(indexObject *self) > { > if (self->ntlength == self->ntcapacity) { > - if (self->ntcapacity >= INT_MAX / (sizeof(nodetree) * 2)) { > +

D4108: index: extract a type for the nodetree

2018-08-06 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued, but there seem to be a couple of minor errors. Can you fix them if they remain in the code after the refactor? > static int nt_new(indexObject *self) > { > if (self->ntlength == self->ntcapacity) { > > - if (self->ntcapacity >= INT_MAX /

D4111: index: pass only nodetree to nt_new()

2018-08-06 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued up to this, thanks. Can you rebase https://phab.mercurial-scm.org/D4113:? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4111 To: martinvonz, #hg-reviewers Cc: yuja, mercurial-devel ___

Re: D4111: index: pass only nodetree to nt_new()

2018-08-06 Thread Yuya Nishihara
Queued up to this, thanks. Can you rebase D4113:? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D4125: narrow: add '--extend' flag to tracked command

2018-08-06 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds a `--extend` flag to tracked command provided by narrow extension. Using the --extend flag, you can pass a

D4124: changegroup: always use the treemanifest-enabled version of _packmanifests()

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It works for flat manifests too. We just cannot use cg1 or cg2 if we have subdirectory manifests. REPOSITORY rHG Mercurial REVISION DETAIL

D4081: changegroup: consolidate tree manifests sending into cg1packer

2018-08-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > changegroup.py:671 > > +def _packtreemanifests(self, dir, mfnodes, lookuplinknode): > +"""Version of _packmanifests that operates on directory manifests. Note that this also works for flat manifests (IIRC). You should be able

D4086: changegroup: declare shallow flag in constructor

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcdb9bc216771: changegroup: declare shallow flag in constructor (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4087: changegroup: move changelogdone into cgpacker

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG379d90327861: changegroup: move changelogdone into cgpacker (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4091: changegroup: move fullnodes into cgpacker

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1af339c22aeb: changegroup: move fullnodes into cgpacker (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4091?vs=9853=9967

D4090: changegroup: specify ellipses mode explicitly

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1469584ad5fe: changegroup: specify ellipses mode explicitly (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4085: changegroup: make some packer attributes private

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG68e490ed640e: changegroup: make some packer attributes private (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4092: changegroup: inline _packellipsischangegroup

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG245c58952298: changegroup: inline _packellipsischangegroup (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4083: changegroup: control delta parent behavior via constructor

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG23ae0c07a3e1: changegroup: control delta parent behavior via constructor (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4089: changegroup: pass ellipsis roots into cgpacker constructor

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGad4c4cc9a5ac: changegroup: pass ellipsis roots into cgpacker constructor (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4088: changegroup: move revision maps to cgpacker

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0548f696795b: changegroup: move revision maps to cgpacker (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4088?vs=9850=9964

D4084: changegroup: rename cg1packer to cgpacker

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4c99c6d1ef95: changegroup: rename cg1packer to cgpacker (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4084?vs=9846=9960

D4074: changegroup: inline ellipsisdata()

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGeb022ce9e505: changegroup: inline ellipsisdata() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4074?vs=9836=9950

D4078: changegroup: make delta header struct formatters actual structs

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG271854adc3a6: changegroup: make delta header struct formatters actual structs (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4079: changegroup: pass function to build delta header into constructor

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbd64b8b8f0dd: changegroup: pass function to build delta header into constructor (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4080: changegroup: pass end of manifests marker into constructor

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG67f37e8a5490: changegroup: pass end of manifests marker into constructor (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4081: changegroup: consolidate tree manifests sending into cg1packer

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7a154778fb46: changegroup: consolidate tree manifests sending into cg1packer (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4082: changegroup: control reordering via constructor argument

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6e999a2d8fe7: changegroup: control reordering via constructor argument (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4077: changegroup: pass version into constructor

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd7ac49c2353c: changegroup: pass version into constructor (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4077?vs=9839=9953

D4076: changegroup: define functions for creating changegroup packers

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG19344024a8e1: changegroup: define functions for creating changegroup packers (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4075: changegroup: capture revision delta in a data structure

2018-08-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG23d582caae30: changegroup: capture revision delta in a data structure (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

  1   2   >