D4372: index: embed nodetree in index object to avoid reference cycle

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9f097214fbf3: index: embed nodetree in index object to avoid reference cycle (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4405: commitextras: no need to special case extras=[]

valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4405 AFFECTED FILES hgext/commitextras.py CHANGE DETAILS diff --git

D4404: commitextras: work nicely with other extensions

valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this change, it doesn't add these extra fields when loaded alongside another extension that does a bunch of things, including wrapping

D4401: run-tests: don't append rtendtracing logs if pipe is /dev/null

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa235ee4cfc1c: run-tests: dont append rtendtracing logs if pipe is /dev/null (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4403: catapipe: make the file executable

This revision was automatically updated to reflect the committed changes. Closed by commit rHG286a666365ec: catapipe: make the file executable (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4403?vs=10606=10609

D4402: run-tests: fix the remaining failure of test-run-tests.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG97f52862b1bd: run-tests: fix the remaining failure of test-run-tests.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4403: catapipe: make the file executable

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This silences test-check-execute.t. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4403 AFFECTED FILES contrib/catapipe.py CHANGE

D4401: run-tests: don't append rtendtracing logs if pipe is /dev/null

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If HGCATAPULTSERVERPIPE is not set, we set it to /dev/null, so we need to make sure the value is not /dev/null before appending logs. This fixes some of

D4402: run-tests: fix the remaining failure of test-run-tests.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Looks like durin42 misindented this. This makes test-run-tests.py passes but I cannot reason why. REPOSITORY rHG Mercurial REVISION DETAIL

D4386: manifest: proxy to revlog instance instead of inheriting

indygreg requested review of this revision. indygreg added a comment. I guess `hg phabsend` doesn't reset the `Changed Planned` state when a summary-only update occurs. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4386 To: indygreg, #hg-reviewers Cc:

D4400: catapipe: remove the shebang from the file

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6d479bca3e15: catapipe: remove the shebang from the file (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4400?vs=10602=10603

D4400: catapipe: remove the execute bit from the file header

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY test-check-execute.t complaints otherwise. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4400 AFFECTED FILES contrib/catapipe.py

D4372: index: embed nodetree in index object to avoid reference cycle

martinvonz updated this revision to Diff 10601. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4372?vs=10550=10601 REVISION DETAIL https://phab.mercurial-scm.org/D4372 AFFECTED FILES mercurial/cext/revlog.c CHANGE DETAILS diff --git

D4372: index: embed nodetree in index object to avoid reference cycle

martinvonz added a comment. In https://phab.mercurial-scm.org/D4372#67157, @yuja wrote: > > -static int nt_init_py(nodetree *self, PyObject *args) > > +static int ntobj_init(nodetreeObject *self, PyObject *args) > > > > { > > PyObject *index; > > unsigned

D4386: manifest: proxy to revlog instance instead of inheriting

martinvonz added a comment. In https://phab.mercurial-scm.org/D4386#67438, @indygreg wrote: > In https://phab.mercurial-scm.org/D4386#67436, @martinvonz wrote: > > > Adding proxies can be costly, but maybe performance only matters for the changelog? I can imagine `hg verify` being

D4386: manifest: proxy to revlog instance instead of inheriting

indygreg planned changes to this revision. indygreg added a comment. In https://phab.mercurial-scm.org/D4386#67436, @martinvonz wrote: > Adding proxies can be costly, but maybe performance only matters for the changelog? I can imagine `hg verify` being the command most affected by this

[PATCH] context: use new names for unstable changesets in docstrings

# HG changeset patch # User Anton Shestakov # Date 1535387530 -28800 # Tue Aug 28 00:32:10 2018 +0800 # Node ID 3e3b9ae9771f965611633ff21b168ac0f7b4bb06 # Parent bb2b462f81daae07d5400aee7db794857959979c context: use new names for unstable changesets in docstrings Plus slight corrections.

D4386: manifest: proxy to revlog instance instead of inheriting

martinvonz added a comment. Adding proxies can be costly, but maybe performance only matters for the changelog? I can imagine `hg verify` being the command most affected by this change. Does that get even measurably slower? Of course, it's not very important that `hg verify` is fast; the

D4399: stringutil: teach pprint() to indent

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will make data structure dumping in various places a bit easier to read and diff. Since I wanted this for `hg debugwireproto` output, I added indentation

D4398: stringutil: emit multiple chunks when pretty printing

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This avoids concatenating output inside pprintgen() itself. But the real reason for this is it will make it easier to add indentation, as we'll need to account

D4396: stringutil: teach pprint() to recognize generators

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise they get serialized as e.g. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4396 AFFECTED FILES

D4397: stringutil: refactor core of pprint so it emits chunks

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit splits the core of pprint() to a new function that is a generator of chunks instead of a function returning a single value. This will make it

D4395: tests: mark manifestfulltextcache as conditional on revlog store

indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This file is currently specific to the revlog store. Other stores may not implement it. Mark it as such in test output. REPOSITORY rHG Mercurial

D4393: manifest: rename manifestlog._revlog to _rootstore

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Because it may not be a revlog. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4393 AFFECTED FILES mercurial/manifest.py CHANGE

D4394: manifest: use fulltextcache instead of _fulltextcache

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY fulltextcache is part of the documented interface and is aliased to _fulltextcache. REPOSITORY rHG Mercurial REVISION DETAIL

D4391: perf: add function for obtaining manifest revision

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will use the modern API if available or fall back to the legacy direct revlog access case. Without this, the perf command won't work on all code bases.

D4392: manifest: use public API for obtaining storage object

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We should not be accessing private attributes on the manifestlog, since its behavior is governed by an interface. REPOSITORY rHG Mercurial REVISION DETAIL

D4387: manifest: make tree a public attribute

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY changegroup generation accesses this attribute. We should make it public and expose it on the interface. REPOSITORY rHG Mercurial REVISION DETAIL

D4390: perf: use storage API for resolving manifest node

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY lookup() isn't part of the storage API. And this code shouldn't be accessing manifestlog._revlog directly for the modern code base. So let's port it to the

D4389: manifest: change terminology for storage in context classes

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Storage may not be backed by revlogs. So it is wrong to refer to storage as "revlog" or use abbreviations like "rl." This commit replaces revlog terminology

D4388: manifest: don't go through revlog to access node symbols

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The revlog module re-exports some node.* symbols courtesy of importing them. Let's access the node.* symbols via our local import. REPOSITORY rHG Mercurial

D4386: manifest: proxy to revlog instance instead of inheriting

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, manifestrevlog inherited revlog.revlog and therefore exposed all its APIs. This inevitably resulted in consumers calling low-level revlog APIs.

[Bug 5972] New: Load-on-scroll is broken on log pages

https://bz.mercurial-scm.org/show_bug.cgi?id=5972 Bug ID: 5972 Summary: Load-on-scroll is broken on log pages Product: Mercurial Version: stable branch Hardware: PC OS: Linux Status: UNCONFIRMED Keywords:

D4381: cmdutil: fix typo in revert()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6b81d2ff118f: cmdutil: fix typo in revert() (authored by khanchi97, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4381?vs=10579=10586 REVISION

D4363: log: respect graphshorten on terminal nodes (collapsing o-~ to just o~)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3c4b2e880273: log: respect graphshorten on terminal nodes (collapsing o-~ to just o~) (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2679: [PoC] obsolete: config option to enable local only obsolescence mode

pulkit added a comment. Hey @lothiraldan, if not the patches itself, can you please explain the approach taken? If I don't hear from you this week, I will push this series so that we can have enough time testing this in current cycle. Thanks! REPOSITORY rHG Mercurial REVISION DETAIL

Re: [PATCH] bookmark: add an --active flag to display the active bookmark

On Mon, 27 Aug 2018 11:20:39 +0200, Boris FELD wrote: > > On 25/08/2018 11:12, Yuya Nishihara wrote: > > On Fri, 17 Aug 2018 18:25:23 +0200, Boris Feld wrote: > >> # HG changeset patch > >> # User Boris Feld > >> # Date 1534432767 -7200 > >> # Thu Aug 16 17:19:27 2018 +0200 > >> # Node ID

D4375: filemerge: fix the wrong placements of messages in prompt

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa3fd84f4fb38: filemerge: fix the wrong placements of messages in prompt (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4384: narrow: update the narrowspecs to new ones after pulling when widening

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The ellipsis case updates the new narrowspecs at bundle2 handling code, and non-ellipsis widening didn't use to work and never

D4385: tests: add flat manifest case in test-narrow-widen-non-ellipsis.t

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We had this test with tree manifest only because the tests were broken and we were fixing them and maintaing two different cases

D4383: narrow: add server logic to send cg while widening without ellipsis

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, if you try to widen a narrow clone without ellipsis enabled, it will be broken and the exchange.pull() done

D4382: tests: add test to show widening is broken without ellipsis

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds a test to show that widening a narrow clone is broken if ellipsis is disabled. I don't think I can add cases

[PATCH 4 of 4] phases: enforce internal phase support

# HG changeset patch # User Boris Feld # Date 1527610399 -7200 # Tue May 29 18:13:19 2018 +0200 # Node ID e3cb6b56869cd8281437a3d0c4f6f60e5cae3836 # Parent e4923ad20f33676790657ac8e3f088180d1312d4 # EXP-Topic internal-phase.new-phase # Available At

[PATCH 3 of 4] phases: add a repository requirement about internal phase

# HG changeset patch # User Boris Feld # Date 1527148750 -7200 # Thu May 24 09:59:10 2018 +0200 # Node ID e4923ad20f33676790657ac8e3f088180d1312d4 # Parent de8fadb2459129a8ee097d2a8cadb23ee02473c7 # EXP-Topic internal-phase.new-phase # Available At

[PATCH 1 of 4] phases: simplify revset in updatephases

# HG changeset patch # User Boris Feld # Date 1535188813 -7200 # Sat Aug 25 11:20:13 2018 +0200 # Node ID 1a32c924756abb3794e81d3fa19136939d83d5e5 # Parent b17d27ea61fb0105abb53e74ff0973ba93574bd6 # EXP-Topic internal-phase.new-phase # Available At

[PATCH 2 of 4] phases: add an internal phases

# HG changeset patch # User Boris Feld # Date 1535152788 -7200 # Sat Aug 25 01:19:48 2018 +0200 # Node ID de8fadb2459129a8ee097d2a8cadb23ee02473c7 # Parent 1a32c924756abb3794e81d3fa19136939d83d5e5 # EXP-Topic internal-phase.new-phase # Available At

[PATCH 07 of 11 V2] revlogdelta: always return a delta info object in finddeltainfo

# HG changeset patch # User Boris Feld # Date 1534387137 -7200 # Thu Aug 16 04:38:57 2018 +0200 # Node ID 2c73ef87329fd8f0a515dad9e2cd6de938615aa7 # Parent 050101b1b6db5bb9a6d6e887ec3145f8bff4188b # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 09 of 11 V2] revlogdeltas: pass revision number to _candidatesgroups

# HG changeset patch # User Boris Feld # Date 1534570325 -7200 # Sat Aug 18 07:32:05 2018 +0200 # Node ID 9368d13b35f9d40ce74ec4f242ff13eef895d2a4 # Parent 9bf51f196a9fc3a08a567957d4253198035939e5 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 11 of 11 V2] revlogdeltas: move finddeltainfo filtering inside _candidategroups

# HG changeset patch # User Boris Feld # Date 1534574496 -7200 # Sat Aug 18 08:41:36 2018 +0200 # Node ID b83d12dd69ab55e139967d9687f643a6bf46f511 # Parent 2bf35ed4bc3d31d07b4dc97cf6f90e34128ca0e6 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 08 of 11 V2] revlogdeltas: extract _getcandidaterevs in a function

# HG changeset patch # User Boris Feld # Date 1534570054 -7200 # Sat Aug 18 07:27:34 2018 +0200 # Node ID 9bf51f196a9fc3a08a567957d4253198035939e5 # Parent 2c73ef87329fd8f0a515dad9e2cd6de938615aa7 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 06 of 11 V2] revlogdeltas: move special cases around raw revisions in finddeltainfo

# HG changeset patch # User Boris Feld # Date 1534386034 -7200 # Thu Aug 16 04:20:34 2018 +0200 # Node ID 050101b1b6db5bb9a6d6e887ec3145f8bff4188b # Parent c92f0df36ad5efafde442870039279f068a64c30 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 10 of 11 V2] revlogdeltas: split candidate groups selection from the filtering logic

# HG changeset patch # User Boris Feld # Date 1534573065 -7200 # Sat Aug 18 08:17:45 2018 +0200 # Node ID 2bf35ed4bc3d31d07b4dc97cf6f90e34128ca0e6 # Parent 9368d13b35f9d40ce74ec4f242ff13eef895d2a4 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 01 of 11 V2] revlog: split constants into a new `revlogutils.constants` module

# HG changeset patch # User Boris Feld # Date 1534378093 -7200 # Thu Aug 16 02:08:13 2018 +0200 # Node ID 1e8bf2a77cbdf8634afe8b987114fb33a6d5f8bd # Parent 72718abe3c8a9be89e62393efc18257cc71db802 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 05 of 11 V2] revlogdeltas: extra fulltext building in its own function

# HG changeset patch # User Boris Feld # Date 1534385554 -7200 # Thu Aug 16 04:12:34 2018 +0200 # Node ID c92f0df36ad5efafde442870039279f068a64c30 # Parent 7e67a3db18113ec4ae6efca9359bcb69ed0d6ee9 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 04 of 11 V2] revlog: move the good delta heuristic in revlogutils.deltas

# HG changeset patch # User Boris Feld # Date 1534380638 -7200 # Thu Aug 16 02:50:38 2018 +0200 # Node ID 7e67a3db18113ec4ae6efca9359bcb69ed0d6ee9 # Parent a061be6dce561b65bf8e008333f7737466dbcdf1 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 03 of 11 V2] revlog: move function related to delta chain slicing in revlogutils.deltas

# HG changeset patch # User Boris Feld # Date 1534380822 -7200 # Thu Aug 16 02:53:42 2018 +0200 # Node ID a061be6dce561b65bf8e008333f7737466dbcdf1 # Parent 7ca654074a1bec3ebe28506d71a2157ce026e7ad # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

Re: [PATCH] bookmark: add an --active flag to display the active bookmark

On 25/08/2018 11:12, Yuya Nishihara wrote: On Fri, 17 Aug 2018 18:25:23 +0200, Boris Feld wrote: # HG changeset patch # User Boris Feld # Date 1534432767 -7200 # Thu Aug 16 17:19:27 2018 +0200 # Node ID 743d3dfd61a275c393a19121de3cc24e70555c5c # Parent