martinvonz added inline comments.
INLINE COMMENTS
> util.py:1302
> try:
> return self._cache[k].value
> except KeyError:
Btw, why doesn't this do `return self[k]` instead? It seems surprising that the
recency is not updated.
REPOSITORY
rHG Mercurial
REVISION
# HG changeset patch
# User Matt Harbison
# Date 1536291444 14400
# Thu Sep 06 23:37:24 2018 -0400
# Node ID e5449ff273d68abd3fd4e7b5766fb6d22edf30b7
# Parent 7df9ae38c75ca7fd4d0d20802fbc4ab489bb1f06
tests: stabilize test-removeemptydirs.t on Windows
diff --git
indygreg updated this revision to Diff 10826.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4478?vs=10776=10826
REVISION DETAIL
https://phab.mercurial-scm.org/D4478
AFFECTED FILES
mercurial/merge.py
mercurial/vfs.py
CHANGE DETAILS
diff --git
indygreg updated this revision to Diff 10825.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4477?vs=10775=10825
REVISION DETAIL
https://phab.mercurial-scm.org/D4477
AFFECTED FILES
hgext/purge.py
mercurial/merge.py
CHANGE DETAILS
diff --git
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
See the inline comment for the reasoning here. This is a pretty
common strategy for garbage collectors, other cache-like primtives.
The performance impact
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Now that lrucachedict entries can have a numeric cost associated
with them and we can easily pop the oldest item in the cache, it
now becomes relatively
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Currently, lrucachedict allows tracking of arbitrary items with the
only limit being the total number of items in the cache.
Caches can be a lot more useful
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Calling popoldest() on insert with cost auditing enabled introduces
significant overhead.
The primary reason for this overhead is that popoldest() needs to
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This allows consumers to prune the oldest item from the cache. This
could be useful for e.g. a consumer that wishes for the size of
items tracked by the cache
indygreg created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This will allow us to easily replace an lrucachedict with one
with a higher or lower capacity as consumers deem necessary.
IMO it is easier to
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
So others can query it. Useful for operations that may want to verify
the cache has capacity for N items before it performs an operation that
may cause cache
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Previously, copy() only worked if the cache was full. We teach
copy() to only copy defined nodes.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This makes the code so much easier to test and debug.
Along the way, I discovered a bug in copy(), which I kind of
added test coverage for.
REPOSITORY
https://bz.mercurial-scm.org/show_bug.cgi?id=5982
Bug ID: 5982
Summary: clone pooling functionality downgrades streaming
clones into slow pull-like clones
Product: Mercurial
Version: 4.7
Hardware: PC
OS:
https://bz.mercurial-scm.org/show_bug.cgi?id=5981
Bug ID: 5981
Summary: Not all MQ commands are disabled during histedit,
qrecord works
Product: Mercurial
Version: 4.7.1
Hardware: PC
OS: Linux
spectral added a comment.
In https://phab.mercurial-scm.org/D4366#67153, @spectral wrote:
> In https://phab.mercurial-scm.org/D4366#67144, @indygreg wrote:
>
> > I'm not sure how I feel about so many methods having the `if dir in
self._lazydirs: self._loadlazy(dir)` pattern.
> >
spectral updated this revision to Diff 10815.
spectral edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4366?vs=10544=10815
REVISION DETAIL
https://phab.mercurial-scm.org/D4366
AFFECTED FILES
mercurial/manifest.py
On Thu, Sep 6, 2018 at 6:35 AM Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1536238530 -32400
> # Thu Sep 06 21:55:30 2018 +0900
> # Node ID 7df9ae38c75ca7fd4d0d20802fbc4ab489bb1f06
> # Parent 35ecaa999a12b2b2a02f15f108a0552e0937bcfb
> help: add
2 new changesets (2 on stable) in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/c68cfc55af9d
changeset: 39454:c68cfc55af9d
branch: stable
parent: 39424:094d1f42c484
user:Augie Fackler
date:Wed Sep 05 16:29:31 2018 -0400
summary: buildrpm: fix embarassing
# HG changeset patch
# User Yuya Nishihara
# Date 1536239541 -32400
# Thu Sep 06 22:12:21 2018 +0900
# Node ID 2fe4d0e1c9baf2e5ac6dc601089a2ce0228b42aa
# Parent 7df9ae38c75ca7fd4d0d20802fbc4ab489bb1f06
doc: use modern import style in runrst
diff --git a/doc/runrst b/doc/runrst
---
# HG changeset patch
# User Yuya Nishihara
# Date 1536238530 -32400
# Thu Sep 06 21:55:30 2018 +0900
# Node ID 7df9ae38c75ca7fd4d0d20802fbc4ab489bb1f06
# Parent 35ecaa999a12b2b2a02f15f108a0552e0937bcfb
help: add internals.wireprotocolv2 to the table, and remove redundant header
diff --git
29 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/2dd9519b8c8a
changeset: 39425:2dd9519b8c8a
parent: 39419:6268fed317d0
user:Pulkit Goyal
date:Tue Sep 04 17:15:17 2018 +0300
summary: py3: make sure we pass str in os.sysconf in
yuja added a comment.
> +def purge(repo, dirs=None, ignored=False, removeemptydirs=True,
> + removefiles=True, abortonerror=False, include=None,
exclude=None,
> + noop=False):
Nit: can't we pass in matcher instead of (dirs, include, exclude)?
> +if
> +def purge(repo, dirs=None, ignored=False, removeemptydirs=True,
> + removefiles=True, abortonerror=False, include=None, exclude=None,
> + noop=False):
Nit: can't we pass in matcher instead of (dirs, include, exclude)?
> +if removefiles:
> +for f in
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6af7765bdb7c: buildrpm: remove TODO that looks done to me
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc68cfc55af9d: buildrpm: fix embarassing bug in shell
variable expansions (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
yuja added a comment.
Queued for stable, thanks.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4493
To: durin42, #hg-reviewers
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Queued for stable, thanks.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG35ecaa999a12: match: improve
includematcher.visitchildrenset to be much faster and cached (authored by
spectral, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4babb55e4503: tests: order the imports in
test-fastannotate-hg.t (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGbc3b99d5627e: py3: add new passing tests spotted by the
buildbot (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
yuja added a comment.
Queued, thanks.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4351
To: spectral, #hg-reviewers
Cc: yuja, durin42, mercurial-devel
___
Mercurial-devel mailing list
Queued, thanks.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
On Thu, 06 Sep 2018 01:02:24 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1536209481 14400
> # Thu Sep 06 00:51:21 2018 -0400
> # Node ID f8b494a211f85738d924f2869102a89c29ecb309
> # Parent 53ed650843c5c1e1b7a829be525ca8087c68906f
> lfs: ensure the blob
On Tue, 04 Sep 2018 23:36:18 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1536114578 14400
> # Tue Sep 04 22:29:38 2018 -0400
> # Node ID 2cce57226251044ce3406ad92e4edbf01efcde72
> # Parent 197521083166579f6c80d7532ec6e919af2fe2cf
> cbor: teach the
On Thu, Sep 6, 2018 at 5:21 AM Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1536108502 14400
> # Tue Sep 04 20:48:22 2018 -0400
> # Node ID 53ed650843c5c1e1b7a829be525ca8087c68906f
> # Parent 481db51c83e9bb5642be1ea1e88771dae5590552
> absorb: clarify the
36 matches
Mail list logo