On Sat, 15 Sep 2018 00:31:37 -0400, Matt Harbison
wrote:
# HG changeset patch
# User Matt Harbison
# Date 1536984246 14400
# Sat Sep 15 00:04:06 2018 -0400
# Node ID 757f2fe237ea1f72d75ff29bd1bb428db38813be
# Parent 289c7157ec4510c619e9e7fdd9ac4995e13ce73e
py3: allow run-tests.py to
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4635
AFFECTED FILES
tests/test-absorb-phase.t
tests/test-absorb-strip.t
CHANGE DETAILS
diff --git
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This attribute is tracking changes to append-only files. It is
an implementation detail and should not be exposed as part of
the public interface.
But
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is used to report the transaction name in __repr__. It is
very obviously an implementation detail and doesn't need to be
exposed as part of the public
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is used to track which files are modified. It is an
implementation detail of current transactions and doesn't need
to be exposed to the public interface.
indygreg created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a callable used for logging. It isn't used outside the
transaction code. It doesn't need to be part of the public interface.
Let's mark it as
indygreg created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The VFS instance is an implementation detail of the transaction
and doesn't belong as part of the public interface. So mark it as
private.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is another callable that is passed in at __init__ time. It
doesn't need to be part of the public interface.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This holds instance state that is passed in at __init__ time. It
doesn't need to be exposed as part of the public interface.
REPOSITORY
rHG Mercurial
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is similar to releasefn. It holds state that doesn't need to be
exposed as part of the public interface.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a handle on a callable that is called when the journal
is closed. The value is specified at __init__ time. It doesn't
need to be exposed on the public
indygreg created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This holds a file handle for the journal file. This file handle
should not be touched outside the journal class and doesn't
belong on the public
indygreg created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This attribute tracks the name of the journal file. It is an
implementation detail of the current transaction and therefore
shouldn't be exposed as
indygreg created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This attribute tracks the file pattern to use for undo files.
It is an implementation detail of the current transaction semantics
and doesn't need to
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I want to formalize the interface for transactions. As part of
doing that, let's take the opportunity to make some attributes
non-public.
"count" and
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
For shallow clone, it is useful to specify a starting node and tell
the server to send up to N ancestors from that starting point. This
enables the server to
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
changesetdata, manifestdata, and filedata all allow the caller to
specify what data fields to request.
Data fields are extensible and may evolve over time.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Previously, we declared command arguments with an example of
their value. After this commit, we declare command arguments
as a dict of metadata. This allows us
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Now that we internally store rich metadata about arguments, it makes
sense to make that metadata available to the client. This will allow
clients to validate
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
While the wire protocol doesn't yet support it, we'll eventually
have commands that accept narrow patterns to specify the set of
files relevant to a command.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This makes call sites simpler since they won't have to deal with
missing keys.
REPOSITORY
rHG Mercurial
REVISION DETAIL
spectral added a comment.
In https://phab.mercurial-scm.org/D4606#70323, @yuja wrote:
> Looks good to me. One nit.
>
> > - a/mercurial/manifest.py +++ b/mercurial/manifest.py @@ -1203,7
+1203,7 @@ s._dirty = False self._loadfunc = _load_for_read
> > - def writesubtrees(self, m1,
spectral updated this revision to Diff 3.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4606?vs=2=3
REVISION DETAIL
https://phab.mercurial-scm.org/D4606
AFFECTED FILES
mercurial/localrepo.py
mercurial/manifest.py
spectral updated this revision to Diff 2.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4606?vs=11095=2
REVISION DETAIL
https://phab.mercurial-scm.org/D4606
AFFECTED FILES
mercurial/localrepo.py
mercurial/manifest.py
pulkit added a comment.
In https://phab.mercurial-scm.org/D4614#70349, @martinvonz wrote:
> I expected some changes would be needed on the client to prevent it from
stripping the existing file nodes, but I suppose is still does that and it
still works because it re-applies that stripped
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc73c7653dfb9: narrow: use diffmatcher to send only new
filelogs in non-ellipses widening (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
martinvonz accepted this revision.
martinvonz added a comment.
This revision is now accepted and ready to land.
Nice! That was a lot simpler than I expected. I expected some changes would
be needed on the client to prevent it from stripping the existing file nodes,
but I suppose is still
# HG changeset patch
# User Gregory Szorc
# Date 1537201528 25200
# Mon Sep 17 09:25:28 2018 -0700
# Node ID eb8410cf882514e7db8cb1ab0ca17be6f2225135
# Parent d3ea35ad88f35c158070077b83fa66e5f708940f
obsdiscovery: adopt to calling convention change
Upstream commits 71d83b315778 and
https://bz.mercurial-scm.org/show_bug.cgi?id=5986
Bug ID: 5986
Summary: evolve is hard-broken against hg @
Product: Mercurial
Version: default branch
Hardware: PC
OS: Mac OS
Status: UNCONFIRMED
Severity:
martinvonz added inline comments.
INLINE COMMENTS
> localrepo.py:2134-2135
> +# ignoring things outside of narrowspec in most cases.
> The
> +# one case where we might have files outside the
> narrowspec
> +# at this point is merges,
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG322aaf80acf3: py3: add missing b prefixes in
couple of test files (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
On Mon, 17 Sep 2018 01:15:16 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1537032701 14400
> # Sat Sep 15 13:31:41 2018 -0400
> # Node ID 91531f9754a5f032fa635dc506091f23519bfdc3
> # Parent 8bfbb25859f1455e908b8cff52d7ef30339a3db8
> py3: partially fix
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Before this patch, when we widen a non-ellipses narrow clone, we downloads all
the filelogs matching the resulting new matcher.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
These were missed in the earlier patch and caught by Yuya.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4613
AFFECTED FILES
av6 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
_hg_branch_bmark_opts used to add these two flags, but had the same
descriptions for the flags regardless of what command took them and didn't
allow specifying
35 matches
Mail list logo
