Re: [PATCH 1 of 6] extensions: import the exthelper class from evolve ff799015d62e

On Mon, 03 Dec 2018 03:37:07 -0500, Boris FELD wrote: On 12/2/18 12:37 PM, Yuya Nishihara wrote: On Fri, 30 Nov 2018 23:10:55 -0500, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1543121473 18000 # Sat Nov 24 23:51:13 2018 -0500 # Node ID

D5370: rust: core implementation of missingancestors (no bindings)

kevincox added a comment. Overall looks good to me. Just a couple of points. - Using random numbers for tests without a seed that is logged will create failures which are basically impossible to reproduce. - A lot of the comments are comparing to the python, I don't know how useful

mercurial@40819: 8 new changesets (7 on stable)

8 new changesets (7 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/9cdd525d97b2 changeset: 40812:9cdd525d97b2 branch: stable parent: 40803:44c2e80db985 user:Yuya Nishihara date:Thu Nov 01 20:32:59 2018 +0900 summary: revlog: fix out-of-bounds

D5371: tests: stabilize test-inherit-mode.t on FreeBSD and macOS again

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is the same fix as https://phab.mercurial-scm.org/rHG90e26ef4cbb168b9a8639b054860b9f236354657, just repeated on the new file location. REPOSITORY rHG

D5361: rebase: fix path auditing to audit path relative to repo root (issue5818)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1c8c54cf9725: rebase: fix path auditing to audit path relative to repo root (issue5818) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5368: tests: show bad path auditing in in-memory rebase

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd10b1dc13431: tests: show bad path auditing in in-memory rebase (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5367: tests: add a missing "cd .." to test-rebase-inmemory.t

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9b1d5eea07f9: tests: add a missing cd .. to test-rebase-inmemory.t (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[PATCH 2 of 2 evolve-ext] resolves 6028: return return (False, None) instead of return (False, '')

# HG changeset patch # User James Reynolds # Date 1543952045 18000 # Tue Dec 04 14:34:05 2018 -0500 # Branch stable # Node ID 6ea3ff2517b9ebf12f0678f28c9942c45c5924ce # Parent 91aec886fc8701398182ab83adcdc04c86735c1d # EXP-Topic issue6028 resolves 6028: return return (False, None) instead

[PATCH 1 of 2 evolve-ext] issue-6028: failing test

# HG changeset patch # User James Reynolds # Date 1543953379 18000 # Tue Dec 04 14:56:19 2018 -0500 # Branch stable # Node ID 91aec886fc8701398182ab83adcdc04c86735c1d # Parent 48da02d7f8ebd7d274ace7bb6c74a856c4a62882 # EXP-Topic issue6028 issue-6028: failing test diff -r 48da02d7f8eb -r

D5370: rust: core implementation of missingancestors (no bindings)

gracinet created this revision. Herald added subscribers: mercurial-devel, mjpieters, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY rust: iterator version of Graph.parents This is handy for callers that want to simply do: for p in graph.parents_iter(rev)

D5369: rust: make clean takes care of rust/target

gracinet created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This isn't the prettiest way of doing it, but it doesn't require looking up cargo, or wondering whether that should be part of setup.py clean. REPOSITORY rHG

D5361: rebase: fix path auditing to audit path relative to repo root (issue5818)

martinvonz updated this revision to Diff 12699. martinvonz edited the summary of this revision. martinvonz retitled this revision from "rebase: fix path auditing to audit path relative to repo root" to "rebase: fix path auditing to audit path relative to repo root (issue5818)". REPOSITORY rHG

D5368: tests: show bad path auditing in in-memory rebase

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Thanks to Yuya for providing this test case in https://bz.mercurial-scm.org/show_bug.cgi?id=5818. REPOSITORY rHG Mercurial REVISION DETAIL

D5367: tests: add a missing "cd .." to test-rebase-inmemory.t

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5367 AFFECTED FILES tests/test-rebase-inmemory.t CHANGE DETAILS diff --git

D5361: rebase: fix path auditing to audit path relative to repo root

martinvonz added a comment. In https://phab.mercurial-scm.org/D5361#79583, @yuja wrote: > > Before this patch, when rebasing a file called "foo/bar", we would > > check e.g. if "/foo" (i.e. rooted at the file system root) was a > > symlink. That's clearly not what we meant to

D5366: tests: drop redundant "#if execbit" from test-rebase-inmemory.t

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The whole file is already guarded by "#require execbit". REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5366 AFFECTED FILES

[Bug 6032] New: Mercurial PPA is not updated from long time

https://bz.mercurial-scm.org/show_bug.cgi?id=6032 Bug ID: 6032 Summary: Mercurial PPA is not updated from long time Product: Mercurial Version: unspecified Hardware: PC OS: Linux Status: UNCONFIRMED

mercurial@40811: 8 new changesets

8 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/bad0053efaf6 changeset: 40804:bad0053efaf6 parent: 40800:69847883 user:Pulkit Goyal date:Mon Dec 03 19:42:46 2018 +0300 summary: py3: listify filter() to call len() on it

Re: Auto-formatting code with black - object now if you have a strong opinion

(+cc people that I saw on this thread with opinions) > On Nov 30, 2018, at 20:35, Matt Harbison wrote: > > On Fri, 30 Nov 2018 07:25:04 -0500, Boris FELD wrote: > >> I think using automatic formatting is a great idea and we should move >> forward with this plan. Black seems a good option. I

mercurial@40803: 3 new changesets (3 on stable)

3 new changesets (3 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/97190b0bb81a changeset: 40801:97190b0bb81a branch: stable parent: 40791:6f679f25fd4d user:Matt Harbison date:Mon Dec 03 20:59:48 2018 -0500 summary: extdiff: register the

D5365: rust: AncestorsIterator::next, renamed local variables

gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It was confusing to have p1 and parents.1 ; (p1, p2) is clearer. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

[PATCH 8 of 8] commandserver: turn server debug messages into logs

# HG changeset patch # User Yuya Nishihara # Date 1542538553 -32400 # Sun Nov 18 19:55:53 2018 +0900 # Node ID ea51845e5a0401ccdd0ff2a5ea1353a391e0552b # Parent 05530c3d01119b718a9fb8ca4ef60ae9624441cd commandserver: turn server debug messages into logs They were ui.debug() just because

[PATCH 7 of 8] commandserver: add config knob for various logging options

# HG changeset patch # User Yuya Nishihara # Date 1542538024 -32400 # Sun Nov 18 19:47:04 2018 +0900 # Node ID 05530c3d01119b718a9fb8ca4ef60ae9624441cd # Parent 6dc23c03f0639d051baeb7c4a8889f59b0217025 commandserver: add config knob for various logging options The default rotating options

[PATCH 6 of 8] commandserver: expand log path for convenience

# HG changeset patch # User Yuya Nishihara # Date 1541845667 -32400 # Sat Nov 10 19:27:47 2018 +0900 # Node ID 6dc23c03f0639d051baeb7c4a8889f59b0217025 # Parent e0e021cac8647338c003145389534f857b851040 commandserver: expand log path for convenience This allows us to set the log path

[PATCH 5 of 8] commandserver: switch logging facility to ui.log() interface

# HG changeset patch # User Yuya Nishihara # Date 1541844577 -32400 # Sat Nov 10 19:09:37 2018 +0900 # Node ID e0e021cac8647338c003145389534f857b851040 # Parent 16b28e741caae51512774eb665071c58c50620b8 commandserver: switch logging facility to ui.log() interface The "pager subcommand"

[PATCH 4 of 8] commandserver: install logger to record server events through canonical API

# HG changeset patch # User Yuya Nishihara # Date 1541844017 -32400 # Sat Nov 10 19:00:17 2018 +0900 # Node ID 16b28e741caae51512774eb665071c58c50620b8 # Parent a784cb45d89bdf7f995a918cd75c3bb3f9e56ded commandserver: install logger to record server events through canonical API The global

[PATCH 3 of 8] commandserver: enable logging when server process started

# HG changeset patch # User Yuya Nishihara # Date 1541841574 -32400 # Sat Nov 10 18:19:34 2018 +0900 # Node ID a784cb45d89bdf7f995a918cd75c3bb3f9e56ded # Parent 168b9226865275da15d00ac3aee11463381f427e commandserver: enable logging when server process started This allows us to keep track

[PATCH 2 of 8] test-commandserver: change way of triggering early crash

# HG changeset patch # User Yuya Nishihara # Date 1541841393 -32400 # Sat Nov 10 18:16:33 2018 +0900 # Node ID 168b9226865275da15d00ac3aee11463381f427e # Parent b740d4b4a1af3d2c4325973be876acb87f3fa1ae test-commandserver: change way of triggering early crash Future patches will move the

[PATCH 1 of 8] loggingutil: add basic logger backends

# HG changeset patch # User Yuya Nishihara # Date 1542535086 -32400 # Sun Nov 18 18:58:06 2018 +0900 # Node ID b740d4b4a1af3d2c4325973be876acb87f3fa1ae # Parent 04ebdb33e5d05f4155d6bb3330a0a4e1b68a96a4 loggingutil: add basic logger backends These classes will be used in command server.

D5358: rust: peek_mut optim for lazy ancestors

This revision was automatically updated to reflect the committed changes. Closed by commit rHG04ebdb33e5d0: rust: peek_mut optim for lazy ancestors (authored by gracinet, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5358?vs=12683=12694#toc REPOSITORY rHG Mercurial

D5363: fuzz: grep away HAVE_GETC_UNLOCKED in pyconfig.h to avoid msan badness

This revision was automatically updated to reflect the committed changes. Closed by commit rHG54554ed8d9bb: fuzz: grep away HAVE_GETC_UNLOCKED in pyconfig.h to avoid msan badness (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT

D5362: fuzz: more correctly specify CFLAGS and LDFLAGS when building Python

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4b83ae1e0387: fuzz: more correctly specify CFLAGS and LDFLAGS when building Python (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5358: rust: peek_mut optim for lazy ancestors

yuja added a comment. Queued, thanks. > +let parents = self > +.graph > +.parents(current) > +.unwrap_or((NULL_REVISION, NULL_REVISION)); > +let p0 = parents.0; I've renamed it to `p1` since that's the convention of

Re: D5358: rust: peek_mut optim for lazy ancestors

Queued, thanks. > +let parents = self > +.graph > +.parents(current) > +.unwrap_or((NULL_REVISION, NULL_REVISION)); > +let p0 = parents.0; I've renamed it to `p1` since that's the convention of Mercurial codebase. Maybe it can be rewritten as

mercurial@40800: 12 new changesets (3 on stable)

12 new changesets (3 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/8ff910b21eef changeset: 40789:8ff910b21eef branch: stable user:Martin von Zweigbergk date:Fri Nov 30 15:08:43 2018 -0800 summary: tests: show that in-mem rebase falling back loses

D5360: rebase: fix dir/file conflict detection when using in-mem merge

This revision was automatically updated to reflect the committed changes. Closed by commit rHG44c2e80db985: rebase: fix dir/file conflict detection when using in-mem merge (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5359: tests: show that in-mem rebase does not find path dir/file conflicts

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe204d9a27528: tests: show that in-mem rebase does not find path dir/file conflicts (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5361: rebase: fix path auditing to audit path relative to repo root

yuja added a comment. > Before this patch, when rebasing a file called "foo/bar", we would > check e.g. if "/foo" (i.e. rooted at the file system root) was a > symlink. That's clearly not what we meant to do. I haven't added a > test case because I don't know to test it.

Re: D5361: rebase: fix path auditing to audit path relative to repo root

> Before this patch, when rebasing a file called "foo/bar", we would > check e.g. if "/foo" (i.e. rooted at the file system root) was a > symlink. That's clearly not what we meant to do. I haven't added a > test case because I don't know to test it. This probably fixes the issue5818.

Re: [PATCH 1 of 3] extdiff: register the configuration generated commands with a help category

On Tue, 04 Dec 2018 00:21:08 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1543888788 18000 > # Mon Dec 03 20:59:48 2018 -0500 > # Node ID faaf565508106fb08151ee169b9aa4b937374cc1 > # Parent bda0cb4839fb8618118e5dc7ab4b6742992eabd4 > extdiff: register

Re: [PATCH 2 of 3] tests: stabilize for recent wcache changes

On Tue, 04 Dec 2018 00:21:09 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1543900572 18000 > # Tue Dec 04 00:16:12 2018 -0500 > # Node ID d79558fe55840e43de7eb1b3b05c46b35293d72d > # Parent faaf565508106fb08151ee169b9aa4b937374cc1 > tests: stabilize for

Re: [PATCH] extdiff: avoid double backslashes in the displayed tool path on Windows

On Mon, 03 Dec 2018 17:44:37 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1543859322 18000 > # Mon Dec 03 12:48:42 2018 -0500 > # Node ID c39b92bd16598a3b7ca81f9ae0b768b452a88899 > # Parent 3984409e144bcfd6a3325aa2ef5b9432a0a9a038 > extdiff: avoid

Re: [PATCH] contrib: add a helper script that help to build interesting repositories

On Mon, 03 Dec 2018 09:51:41 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1543378018 -3600 > # Wed Nov 28 05:06:58 2018 +0100 > # Node ID 3374ca3b09624245f50f8e7ca556451198ac9b26 > # Parent 0800d9e6e216b2ca59f05788b288685b8d7b2d93 > # EXP-Topic

Re: [PATCH 4 of 4] mmapindex: set default to 1MB

On Sun, 02 Dec 2018 17:17:43 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1542949784 -3600 > # Fri Nov 23 06:09:44 2018 +0100 > # Node ID 9708243274585f9544c70925eb0b0fa0ec7aba4f > # Parent 0fff68dfbe48d87dce8b8736c0347ed5aa79030e > # EXP-Topic mmap > #