av6 added inline comments.
INLINE COMMENTS
> test-obsmarker-template.t:2511
>| @ 471597cad322
> - |/ Obsfate: pruned;
> + |/ Obsfate: rewritten as 2:617adc3a144c by test (at 1970-01-01 00:00
> +);
>o ea207398892e
The new output looks somewhat more correct, but not
# HG changeset patch
# User Yuya Nishihara
# Date 1545536360 -32400
# Sun Dec 23 12:39:20 2018 +0900
# Node ID d7abe8f0de4640541bb5717be36e21176733fa40
# Parent ce0bc2952e2a4061b0961efe11cf7af064c8ea8f
transaction: do not overwrite atomic-temp files on error
Even though the original files
# HG changeset patch
# User Matt Harbison
# Date 1543374607 18000
# Tue Nov 27 22:10:07 2018 -0500
# Node ID f1c5ed4697f3cd8ecd3103faec187ac4cf383ebe
# Parent ee3bcab67caeddaab6cdb4a2c06ed72308304f2c
lfs: convert to using exthelper to wrap functions
I'm not 100% sure that
# HG changeset patch
# User Matt Harbison
# Date 1545545120 18000
# Sun Dec 23 01:05:20 2018 -0500
# Node ID 75e78ec0d24d0f356e33dd047181b61ec35ffb4b
# Parent f1c5ed4697f3cd8ecd3103faec187ac4cf383ebe
exthelper: correct a documentation typo
diff --git a/mercurial/exthelper.py
# HG changeset patch
# User Matt Harbison
# Date 1543631995 18000
# Fri Nov 30 21:39:55 2018 -0500
# Node ID ee3bcab67caeddaab6cdb4a2c06ed72308304f2c
# Parent 532b67da901af08c2d467f1fb175b6073ffb8762
tests: convert a test extension to use exthelper
This provides test coverage to
# HG changeset patch
# User Matt Harbison
# Date 1545536664 18000
# Sat Dec 22 22:44:24 2018 -0500
# Node ID 532b67da901af08c2d467f1fb175b6073ffb8762
# Parent 9c6e437729b7da29d5ee3d3b680a7810314b9d93
exthelper: drop fileset/revset/template support for now
Yuya raised concerns about
# HG changeset patch
# User Matt Harbison
# Date 1545530784 18000
# Sat Dec 22 21:06:24 2018 -0500
# Node ID ffab2010329f111c2237ebbb64be650a1b0301d8
# Parent e9c606fef203621755d75b0434574a8a60ffd0ff
extensions: import the exthelper class from evolve 980565468003 (API)
This should help
# HG changeset patch
# User Matt Harbison
# Date 1545535596 18000
# Sat Dec 22 22:26:36 2018 -0500
# Node ID 9c6e437729b7da29d5ee3d3b680a7810314b9d93
# Parent ffab2010329f111c2237ebbb64be650a1b0301d8
exthelper: simplify configitem registration
diff --git a/mercurial/exthelper.py
On Sat, 22 Dec 2018 20:55:11 -0500, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1545431772 18000
> # Fri Dec 21 17:36:12 2018 -0500
> # Node ID e9c606fef203621755d75b0434574a8a60ffd0ff
> # Parent 54c3b4bd01f24039fd8bc18d48d11c0f1ba7c633
> phabricator:
yuja added a comment.
> @yuja I'm not sure by what you consider exactly to be internals here. If
that's the `[5]` and [6]`, maybe a `parents(revision)` method on the index
would be better ? The obvious drawback would be to write more C code.
>
> Given that my ultimate goal here is
> @yuja I'm not sure by what you consider exactly to be internals here. If
> that's the `[5]` and [6]`, maybe a `parents(revision)` method on the index
> would be better ? The obvious drawback would be to write more C code.
>
> Given that my ultimate goal here is to delegate the whole
yuja added a comment.
> + $ find main/d* -type f
> + main/d1/f
> + main/d3/g
> + main/d3/f
> + main/d5/f
> + main/d7/f
Inserted `| sort` to stabilize the output.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5276
To: martinvonz,
> + $ find main/d* -type f
> + main/d1/f
> + main/d3/g
> + main/d3/f
> + main/d5/f
> + main/d7/f
Inserted `| sort` to stabilize the output.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
yuja added a comment.
Queued, thanks.
> +def copytoworkingcopy(repo, tr):
> +if tr:
> +def write(file):
> +spec = repo.svfs.read(FILENAME)
> +file.write(spec)
> +file.close()
> +tr.addfilegenerator('narrowspec',
Queued, thanks.
> +def copytoworkingcopy(repo, tr):
> +if tr:
> +def write(file):
> +spec = repo.svfs.read(FILENAME)
> +file.write(spec)
> +file.close()
> +tr.addfilegenerator('narrowspec', (DIRSTATE_FILENAME,), write,
> +
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGce0bc2952e2a: narrow: detect if narrowspec was changed in a
different share (authored by martinvonz, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D5278?vs=12945=12960#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7db1619af061: tests: add test for narrow+share (authored by
martinvonz, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D5276?vs=12939=12959#toc
REPOSITORY
rHG Mercurial
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1e8d9f472ea1: narrow: keep narrowspec backup in store
(authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5470?vs=12934=12958
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG92fde28860bb: tests: update narrowspec when narrowspec, not
dirstate, is accessed (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
# HG changeset patch
# User Matt Harbison
# Date 1545431772 18000
# Fri Dec 21 17:36:12 2018 -0500
# Node ID e9c606fef203621755d75b0434574a8a60ffd0ff
# Parent 54c3b4bd01f24039fd8bc18d48d11c0f1ba7c633
phabricator: properly encode boolean types in the request body
I tripped over this playing
khanchi97 added a comment.
Please take a look at tests changes, as I accepted these changes using
--interactive flag thinking it as a expected change.
I think I can't add tests which will reflect the expected bahivour for this
issue here in mercurial, so I will send a test patch in evolve.
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
While traversing the obsolescence graph to find the successors sets
of csets:
In its 4th case (read comments of obsutil.successorssets to see
all 4
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
In evolve, stackaliases (s#) are also used in some command outputs,
where s# replaces the revision no. in that output.
By default it is set to true, as s#
gracinet added inline comments.
INLINE COMMENTS
> kevincox wrote in ancestors.rs:98
> It should be fine with tbe GIL. RefCell is basically a single-thread lock. In
> this case it should be fine to have no renterance.
Yes, I'll remove these comments, same with the ones for RW lock, it's pretty
kevincox accepted this revision.
kevincox added inline comments.
INLINE COMMENTS
> ancestors.rs:108
> +Err(e) => {
> +return Err(GraphError::new(py, format!("{:?}", e)));
> +}
.map_err(|e| GraphError::new(py, format!("{:?}", e)))
Or even
gracinet added a comment.
@yuja actually my first version of `CoreIterator` (and later `CoreLazy`) used
the `hg::AncestorsIterator` spelling, but actually I believe we might end up
after a while not exporting everything at the top of the `hg` crate, leaving us
either to `use hg::ancestors`,
gracinet updated this revision to Diff 12954.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5440?vs=12951=12954
REVISION DETAIL
https://phab.mercurial-scm.org/D5440
AFFECTED FILES
rust/hg-core/src/ancestors.rs
rust/hg-core/src/lib.rs
gracinet updated this revision to Diff 12951.
gracinet marked 4 inline comments as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5440?vs=12877=12951
REVISION DETAIL
https://phab.mercurial-scm.org/D5440
AFFECTED FILES
gracinet updated this revision to Diff 12953.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5439?vs=12950=12953
REVISION DETAIL
https://phab.mercurial-scm.org/D5439
AFFECTED FILES
rust/hg-cpython/src/ancestors.rs
tests/test-rust-ancestor.py
gracinet updated this revision to Diff 12949.
gracinet edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5438?vs=12875=12949
REVISION DETAIL
https://phab.mercurial-scm.org/D5438
AFFECTED FILES
mercurial/cext/revlog.c
gracinet updated this revision to Diff 12952.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5441?vs=12878=12952
REVISION DETAIL
https://phab.mercurial-scm.org/D5441
AFFECTED FILES
rust/hg-cpython/src/ancestors.rs
tests/test-rust-ancestor.py
gracinet updated this revision to Diff 12950.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5439?vs=12876=12950
REVISION DETAIL
https://phab.mercurial-scm.org/D5439
AFFECTED FILES
rust/hg-cpython/src/ancestors.rs
rust/hg-cpython/src/lib.rs
gracinet added a comment.
@yuja, yes a `Graph` not implementing `Clone` is already a good thing, as it
avoids to implement `Clone` in `hg-direct-ffi` prematurely. I think the whole
`hg::LazyAncestors` can end up being useful from core Rust code, too, that's
why I prefer that to a
gracinet added a comment.
@yuja I'm not sure by what you consider exactly to be internals here. If
that's the `[5]` and [6]`, maybe a `parents(revision)` method on the index
would be better ? The obvious drawback would be to write more C code.
Given that my ultimate goal here is to
I think it was just D5472 that conflicted, so it might work now that that's
queued. This patch should go last of my pending patches. If it's still not
working, I'll try to fix it when I'm back in a week or two.
On Fri, Dec 21, 2018, 23:21 yuja (Yuya Nishihara) <
phabrica...@mercurial-scm.org
35 matches
Mail list logo
