D5508: narrow: extract repo property for store narrowmatcher

2019-01-15 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd2d716cc0700: narrow: extract repo property for store narrowmatcher (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5508?v

D5556: narrow: include journal.narrowspec in transaction journal

2019-01-15 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0f2b8d51bfdf: narrow: include journal.narrowspec in transaction journal (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D55

D5505: narrow: include working copy narrowspec in transaction journal

2019-01-15 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3b35ebdb9f8c: narrow: include working copy narrowspec in transaction journal (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D5531: progress: deprecate ui.progress()

2019-01-15 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG44914de4e915: progress: deprecate ui.progress() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5531?vs=13095&id=13235 RE

D5504: narrow: make dirstateguard back up and restore working copy narrowspec instead

2019-01-15 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb74481038438: narrow: make dirstateguard back up and restore working copy narrowspec instead (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.

D5531: progress: deprecate ui.progress()

2019-01-15 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D5531#82608, @martinvonz wrote: > Btw, I've sent a patch for evolve: https://bitbucket.org/octobus/evolve-devel/commits/3e07c1eea61d2fe6bc80d75d0062d34e53b40577. Other extension authors should be able to copy that. goodjob

D5508: narrow: extract repo property for store narrowmatcher

2019-01-15 Thread pulkit (Pulkit Goyal)
pulkit accepted this revision. pulkit added inline comments. INLINE COMMENTS > localrepo.py:1227 > @storecache(narrowspec.FILENAME) > +def _storenarrowmatch(self): > +if repository.NARROW_REQUIREMENT not in self.requirements: In future, we can add a boolean `store` argument to `

Re: [PATCH] formatting: apply clang-format using the format-source extension

2019-01-15 Thread Boris FELD
On 14/01/2019 15:57, Augie Fackler wrote: > >> On Jan 14, 2019, at 05:49, Boris Feld wrote: >> >> # HG changeset patch >> # User Boris Feld >> # Date 1547462137 -3600 >> # Mon Jan 14 11:35:37 2019 +0100 >> # Node ID 1b6f196b7e094278f9956a479e10e02cd1108a12 >> # Parent 8d0d695fc7910665452b81

D5531: progress: deprecate ui.progress()

2019-01-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. Btw, I've sent a patch for evolve: https://bitbucket.org/octobus/evolve-devel/commits/3e07c1eea61d2fe6bc80d75d0062d34e53b40577. Other extension authors should be able to copy that. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5531

D5596: copies: get working copy parents from wctx, not dirstate, to make in-mem work

2019-01-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, `run-tests.py test-rebase-conflicts.t --extra-config-opt rebase.experimental.inmemory=1` would have some lines that say "searching for copi

D5595: copies: pass contexts into _findlimit()

2019-01-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Just a little refactoring to make the next patch simpler. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5595 AFFECTED FILES me

D5495: revset: add "branch" positional arguments to the merge revset

2019-01-15 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In https://phab.mercurial-scm.org/D5495#82416, @angel.ezquerra wrote: > I've sent an updated set of patches, following your recommendations. There are 2 patches now, since each includes its own tests. This means that the 3rd patch on the original patch set is

D5493: match: support rooted globs in hgignore

2019-01-15 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron added a comment. Sorry, it took me a while to come back to this. I renamed the syntax to rootglob. I haven't handled your other remark, however I noticed that globs in .gitignore can be rooted [1]. I had looked for a precedent for syntax for rooting a glob last week

D5594: copies: consider nullrev a common ancestor

2019-01-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I've seen many bugs in the git codebase that were caused by it not having a null revision and being forced to treat root commits differently. Mercurial has a

D5593: copies: use node.nullrev instead of literal -1

2019-01-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5593 AFFECTED FILES mercurial/copies.py CHANGE DETAILS diff --git a/mercurial/copies.py b/mercuria

D5592: copies: use node.wdirrev instead of inventing another constant for it

2019-01-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5592 AFFECTED FILES mercurial/copies.py CHANGE DETAILS diff --git a/mercurial/copies.py b/mercuria

D5493: match: support rooted globs in hgignore

2019-01-15 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron updated this revision to Diff 13229. valentin.gatienbaron edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5493?vs=13011&id=13229 REVISION DETAIL https://phab.mercurial-scm.org/D5493 AFFECTED FILES

D5496: revset: add "samebranch" keyword argument to the merge revset

2019-01-15 Thread angel.ezquerra (Angel Ezquerra)
angel.ezquerra added a comment. In https://phab.mercurial-scm.org/D5496#82394, @yuja wrote: > > -@predicate('merge(withbranch)', safe=True) > > +@predicate('merge(withbranch, samebranch=True)', safe=True) > > `[, samebranch]` or [, samebranch=False]`. I guess that means:

D5591: context: use scmutil.matchfiles instead of matchmod.match(exact=True)

2019-01-15 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb129837190f7: context: use scmutil.matchfiles instead of matchmod.match(exact=True) (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-s

D5532: context: schedule file prefetch before comparing for cleanliness

2019-01-15 Thread spectral (Kyle Lippincott)
spectral added a comment. In https://phab.mercurial-scm.org/D5532#82319, @yuja wrote: > > +scmutil.prefetchfiles( > > +self.repo(), [self.p1().rev()], > > +matchmod.match('', '', patterns=self._cache.keys(), exact=True)) > > Perhaps `scmutil.match

D5591: context: use scmutil.matchfiles instead of matchmod.match(exact=True)

2019-01-15 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5591 AFFECTED FILES mercurial/context.py CHANGE DETAILS diff --git a/mercurial/context.py b/mercuria

mercurial@41223: new changeset

2019-01-15 Thread Mercurial Commits
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/32ef47b3c91c changeset: 41223:32ef47b3c91c bookmark:@ tag: tip user:Augie Fackler date:Mon Jan 14 22:19:43 2019 -0500 summary: histedit: fix call to _getgoal() by adding a byteskwargs() wrapper

[PATCH FOLLOW-UP] revset: transparently forward _intlist argument in all case

2019-01-15 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1547580257 -3600 # Tue Jan 15 20:24:17 2019 +0100 # Node ID 7c8a8c0ea0c4cd1c1cbd0fb96342a45e9437d939 # Parent 32ef47b3c91c2913ab13cabf9efcdde3ef137987 # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH] discovery: improve some dealing with nullrev

2019-01-15 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1547465758 -3600 # Mon Jan 14 12:35:58 2019 +0100 # Node ID b2b1b1f3a579d1d2ff880a2783e87fce72beee4e # Parent 32ef47b3c91c2913ab13cabf9efcdde3ef137987 # EXP-Topic discovery.revset # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 7 of 7] revsetbenchmark: add more example for roots usages

2019-01-15 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1547486362 -3600 # Mon Jan 14 18:19:22 2019 +0100 # Node ID 01b9cd2cb7c6e41567fec956905b623d097a1af1 # Parent 8b13377cb4cb8789429693653091772029d54b15 # EXP-Topic revset.predicates # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 6 of 7] dagop: minor python optimization to `headrevs`

2019-01-15 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1547482521 -3600 # Mon Jan 14 17:15:21 2019 +0100 # Node ID 8b13377cb4cb8789429693653091772029d54b15 # Parent 39a2761dc425aaa14c00b69bce5a4c68a780ff50 # EXP-Topic revset.predicates # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 5 of 7] revset: use changelog's `headrevs` method to compute heads

2019-01-15 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1547482251 -3600 # Mon Jan 14 17:10:51 2019 +0100 # Node ID 39a2761dc425aaa14c00b69bce5a4c68a780ff50 # Parent c9906eb8d45f2e80157ca441c1ad01987d8e198a # EXP-Topic revset.predicates # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 3 of 7] revset: inline parents computation to reuse the input argument

2019-01-15 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1547481235 -3600 # Mon Jan 14 16:53:55 2019 +0100 # Node ID da8305b14fd8d61f7943c0f53480cfbb2358880d # Parent 0c8eb4ed3b0f0294f2cb2d328ffce70847489be9 # EXP-Topic revset.predicates # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 2 of 7] revsetbenchmarks: add various examples around the 'heads()' revset

2019-01-15 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1547414651 -3600 # Sun Jan 13 22:24:11 2019 +0100 # Node ID 0c8eb4ed3b0f0294f2cb2d328ffce70847489be9 # Parent d028a9425f028b02f5cff34683c472a14ff8d8d7 # EXP-Topic revset.predicates # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 4 of 7] revlog: accept a revs argument in `headrevs`

2019-01-15 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1547481960 -3600 # Mon Jan 14 17:06:00 2019 +0100 # Node ID c9906eb8d45f2e80157ca441c1ad01987d8e198a # Parent da8305b14fd8d61f7943c0f53480cfbb2358880d # EXP-Topic revset.predicates # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 1 of 7] revsetbenchmarks: support revset starting with a "-"

2019-01-15 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1547478077 -3600 # Mon Jan 14 16:01:17 2019 +0100 # Node ID d028a9425f028b02f5cff34683c472a14ff8d8d7 # Parent 32ef47b3c91c2913ab13cabf9efcdde3ef137987 # EXP-Topic revset.predicates # Available At https://bitbucket.org/octobus/mercurial-devel/ #

D5590: watchman: ignore some of watchman errors

2019-01-15 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. This series is non-urgent and it's fine if not included in the RC. I would like to gather feedback from fsmonitor experts on it but phabricator doesn't allow to set a `RFC` flag REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5590 T

D5590: watchman: ignore some of watchman errors

2019-01-15 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Don't display 'illegal_fstypes' errors. In environments with network filesystems, the error messages are quickly pilling up and polluting outputs. REPOSITORY

D5589: watchman: add the possibility to set the exact watchman binary location

2019-01-15 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is necessary to make rolling releases of new watchman versions across users. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercuri

D5588: watchman: disable fsmonitor when running non-interactively

2019-01-15 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One of the risks with activating fsmonitor globally is resource exhaustion (like inotify watches on Linux). When launching background-jobs, it's often bet

D5587: watchman: detect nested mercurial repositories and abort

2019-01-15 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Disable fsmonitor on nested mercurial repositories. Only depth one repositories are detected at the moment. REPOSITORY rHG Mercurial REVISION DETAIL http

D5586: watchman: add verbose config knob

2019-01-15 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This new config knob allows to silent watchman log and warning messages when watchman is unavailable. REPOSITORY rHG Mercurial REVISION DETAIL

D5585: histedit: fix call to _getgoal() by adding a byteskwargs() wrapper

2019-01-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG32ef47b3c91c: histedit: fix call to _getgoal() by adding a byteskwargs() wrapper (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.o

[PATCH] revset: support ranges in #generations relation

2019-01-15 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1547564229 -28800 # Tue Jan 15 22:57:09 2019 +0800 # Node ID c5157bffb822af4d48922d03440c013cd1253789 # Parent 8aca89a694d4bd7d25877b3652fb83e187ea1802 revset: support ranges in #generations relation diff --git a/mercurial/revset.py b/mercu

mercurial@41222: 7 new changesets

2019-01-15 Thread Mercurial Commits
7 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/5cc5a5561c3f changeset: 41216:5cc5a5561c3f user:Boris Feld date:Thu Jan 10 15:57:13 2019 +0100 summary: revset: remove a rare usage of "%d" for a non-revision item https://www.mercurial-scm.org/repo/hg

Re: Auto-formatting code with black - object now if you have a strong opinion

2019-01-15 Thread Yuya Nishihara
On Tue, 27 Nov 2018 15:42:21 -0800, Gregory Szorc wrote: > I also have some issues with black's formatting. I dislike black's use of > double quotes for strings (maybe a holdover from my knowledge of shell, > Perl, and PHP, where different quotes matter). The black isn't so black. There's -S/--ski

Re: [PATCH 2 of 2 V2] extdiff: add --mode option

2019-01-15 Thread Yuya Nishihara
On Sun, 13 Jan 2019 22:05:53 -0800, Ludovic Chabant wrote: > > I was just speaking about the current implementation (without your patch.) > > Maybe I should say .gui flag isn't checked because the current extdiff never > > spawns more than one processes at a time. > > Yeah, and I meant that I don'

D5585: histedit: fix call to _getgoal() by adding a byteskwargs() wrapper

2019-01-15 Thread durin42 (Augie Fackler)
durin42 added a comment. Yes just a py3 fix. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5585 To: durin42, #hg-reviewers Cc: martinvonz, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm

Re: [PATCH 7 of 7 V3] revset: introduce an API that avoids `formatspec` input serialization

2019-01-15 Thread Yuya Nishihara
On Mon, 14 Jan 2019 15:27:23 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1546605681 -3600 > # Fri Jan 04 13:41:21 2019 +0100 > # Node ID 466ba919947b7ced476c3669ac444f0b74ade8f0 > # Parent 1def212ed730ce024963fd41f2d341f584521bbf > # EXP-Topic revs-efficiency

Re: [PATCH 1 of 7 V3] revset: remove a rare usage of "%d" for a non-revision item

2019-01-15 Thread Yuya Nishihara
On Mon, 14 Jan 2019 15:27:17 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1547132233 -3600 > # Thu Jan 10 15:57:13 2019 +0100 > # Node ID 15458ddc966d002a781d0be59cf2fa961790aa4c > # Parent c339a01acd9a5fda3ea9ed15b4342a0d08af5f96 > # EXP-Topic revs-efficiency

D5550: rust-cpython: bindings for MissingAncestors

2019-01-15 Thread kevincox (Kevin Cox)
kevincox added inline comments. INLINE COMMENTS > gracinet wrote in ancestors.rs:170 > Got this one in the wrong direction (sorry about that!) : in this case, this > is a conversion from Rust, so we de have proper `size_hint()` > Still, I'll keep in mind the question for the other direction (in