[PATCH] revset: add default error messages to getintrange()

2019-02-05 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1549432950 -28800 # Wed Feb 06 14:02:30 2019 +0800 # Node ID e87cf73bbbffd69efa77b93fa4190d8e0987f339 # Parent a5493a251ad3a724b0a7a1bff21248c39611c6de revset: add default error messages to getintrange() Looks like it's the default values

D5800: config: introduce a new value for ui.relative-paths getting old behavior

2019-02-05 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. Maybe a py3 thing? $ py -3 run-tests.py --local test-http.t running 1 tests using 1 parallel processes --- c:/Users/Matt/hg/tests/test-http.t +++ c:/Users/Matt/hg/tests/test-http.t.err @@ -1,58 +1,262 @@ #require serve $

D5800: config: introduce a new value for ui.relative-paths getting old behavior

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz marked an inline comment as done. martinvonz added inline comments. INLINE COMMENTS > mharbison72 wrote in scmutil.py:741 > 2 too many quotes here are causing stacktraces. Fixed in the hg-committed repo. What kind of stacktraces? I'm curious why I didn't see them. REPOSITORY rHG

D5800: config: introduce a new value for ui.relative-paths getting old behavior

2019-02-05 Thread mharbison72 (Matt Harbison)
mharbison72 added inline comments. INLINE COMMENTS > scmutil.py:741 > +of what ui.relative-paths is set to. > +" > +if forcerelativevalue is not None: 2 too many quotes here are causing stacktraces. REPOSITORY rHG Mercurial REVISION DETAIL

[PATCH 6 of 6] py3: ensure the HTTP password manager returns strings, not bytes

2019-02-05 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1549404160 18000 # Tue Feb 05 17:02:40 2019 -0500 # Node ID c0d3c5f3c5ebd2db2a73b68d20c90df741831cb9 # Parent 766e1b887a85c352e10381e30f3caaae320483e2 py3: ensure the HTTP password manager returns strings, not bytes The digest handler calls

[PATCH 5 of 6] tests: enable HTTP digest testing

2019-02-05 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1549403239 18000 # Tue Feb 05 16:47:19 2019 -0500 # Node ID 766e1b887a85c352e10381e30f3caaae320483e2 # Parent 1a4bd7696b7e12673ddc46733babd15151f00e05 tests: enable HTTP digest testing I suppose we could spin the client side extension off to

[PATCH 4 of 6] wsgiheaders: make sure __repr__() returns a string

2019-02-05 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1549401374 18000 # Tue Feb 05 16:16:14 2019 -0500 # Node ID 1a4bd7696b7e12673ddc46733babd15151f00e05 # Parent 576aec428b05a88584505b9c4af541e273e1014a wsgiheaders: make sure __repr__() returns a string When printing `req.headers` on the

[PATCH 3 of 6] tests: add code to handle HTTP digests on the server side

2019-02-05 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1549391559 18000 # Tue Feb 05 13:32:39 2019 -0500 # Node ID 576aec428b05a88584505b9c4af541e273e1014a # Parent 4bad819762856a2a6b5c9faeb52a15fa63b1ca9e tests: add code to handle HTTP digests on the server side It's not hooked up yet. Mostly

[PATCH 2 of 6] run-tests: allow spaces in the --view tool

2019-02-05 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1549391448 18000 # Tue Feb 05 13:30:48 2019 -0500 # Node ID 4bad819762856a2a6b5c9faeb52a15fa63b1ca9e # Parent e68578660449146a4b77089e8419542a61a3dc1c run-tests: allow spaces in the --view tool Most tools on Windows are in Program Files, and

[PATCH 1 of 6] tests: extract the http server authentication extension to a single module

2019-02-05 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1549377443 18000 # Tue Feb 05 09:37:23 2019 -0500 # Node ID e68578660449146a4b77089e8419542a61a3dc1c # Parent 13f7a6a4f0dba217789055f6dc240d41be8dd65b tests: extract the http server authentication extension to a single module We had 4

Re: [PATCH STABLE] subrepo: avoid false unsafe path detection on Windows

2019-02-05 Thread Matt Harbison
On Tue, 05 Feb 2019 21:04:00 -0500, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1549417854 18000 # Tue Feb 05 20:50:54 2019 -0500 # Branch stable # Node ID 0e18c6ec895542394c0ad18c380bf3bbd4ba4d9b # Parent 8b2892d5a9f2c06c998c977015a9ad3e3a3c9b5f subrepo:

D5867: largefiles: use wrappedfunction() for match() override in overridecopy()

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This reduced the time that the override is in place, but I that it's correct this way (only for the duration of the orig() call). REPOSITORY rHG Mercurial

D5866: largefiles: use wrappedfunction() for util.copyfile() override

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5866 AFFECTED FILES hgext/largefiles/overrides.py CHANGE DETAILS diff --git

D5865: largefiles: use wrappedfunction() for matchandpats() override in overridelog()

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5865 AFFECTED FILES hgext/largefiles/overrides.py CHANGE DETAILS diff --git

mercurial@41564: 8 new changesets

2019-02-05 Thread Mercurial Commits
8 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/3a01ce246ece changeset: 41557:3a01ce246ece user:Kyle Lippincott date:Mon Jan 28 18:05:05 2019 -0800 summary: commit: ignore diff whitespace settings when doing `commit -i` (issue5839)

D5800: config: introduce a new value for ui.relative-paths getting old behavior

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc56d80871eac: config: introduce a new value for ui.relative-paths getting old behavior (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5802: status: if ui.relative-paths=no, don't use relative paths even with patterns

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG31ece2290403: status: if ui.relative-paths=no, dont use relative paths even with patterns (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5801: files: respect ui.relative-paths

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGce0a4ed25ebc: files: respect ui.relative-paths (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5801?vs=13812=13837

D5864: py3: use pycompat.bytestr() on extra values because it can be int

2019-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb436059c1cca: py3: use pycompat.bytestr() on extra values because it can be int (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5863: py3: add some b'' prefixes in hgext/convert/monotone.py

2019-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG83d62df28ab6: py3: add some b prefixes in hgext/convert/monotone.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5862: py3: use '%d' for integers instead of '%s'

2019-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9b4a142a2035: py3: use %d for integers instead of %s (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5862?vs=13829=13833

D5861: py3: add 1 new passing test found by buildbot

2019-02-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf9ad1b65d3c3: py3: add 1 new passing test found by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5813: revset: add expect to check the size of a set

2019-02-05 Thread yuja (Yuya Nishihara)
yuja added a comment. > > You can try out some combinations of `expect(5:0) & 1:10` and > > `10:1 & expect(0:5)`. > > I got into many errors while using this. I might be not understanding this correctly. Could you please elaborate? Can you share your failed attempt?

Re: D5813: revset: add expect to check the size of a set

2019-02-05 Thread Yuya Nishihara
> > You can try out some combinations of `expect(5:0) & 1:10` and > > `10:1 & expect(0:5)`. > > I got into many errors while using this. I might be not understanding this > correctly. Could you please elaborate? Can you share your failed attempt? Maybe you can get how revset works by

D5417: rust: translated random test of missingancestors

2019-02-05 Thread yuja (Yuya Nishihara)
yuja added a comment. > @yuja we don't need a seed to reproduce: failed examples contain all the information (that's a difference with the Python version) Yes, but isn't it handy if we can run the same test with some debugging aids? I didn't carefully look through the original

Re: D5417: rust: translated random test of missingancestors

2019-02-05 Thread Yuya Nishihara
> @yuja we don't need a seed to reproduce: failed examples contain all the > information (that's a difference with the Python version) Yes, but isn't it handy if we can run the same test with some debugging aids? I didn't carefully look through the original patch, so maybe I miss the point.

Re: Google Summer of Code 2019.

2019-02-05 Thread Sushil Khanchi
Hi, As I was Google Summer of Code student last year I know how much important it is for a student to have a mentor who will review the patches or provide pointer to the right person for a particular topic. I would love to work with a student and happy to see a new contributor in mercurial

D5862: py3: use '%d' for integers instead of '%s'

2019-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think this is the last of these occurences because I have got the test passing on python3 in a later patch. REPOSITORY rHG Mercurial REVISION DETAIL

D5864: py3: use pycompat.bytestr() on extra values because it can be int

2019-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One such example is {'close': 1} which marks a branch as closed. This makes test-convert-mtn.t pass on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL

D5863: py3: add some b'' prefixes in hgext/convert/monotone.py

2019-02-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5863 AFFECTED FILES

D5849: merge: don't unnecessarily calculate absolute path

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1f2714052d7e: merge: dont unnecessarily calculate absolute path (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5853: revert: migrate to scmutil.backuppath()

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > cmdutil.py:3017-3018 > +bakname = scmutil.backuppath(ui, repo, abs) > ui.note(_('saving current version of %s as > %s\n') % > (rel, bakname)) >

D5848: merge: don't unnecessarily calculate backup path

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGef2295651351: merge: dont unnecessarily calculate backup path (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5858: resolve: migrate to scmutil.backuppath()

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5858 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git a/mercurial/commands.py

D5860: scmutil: delete now-unused origpath()

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D5860#85771, @pulkit wrote: > This should be marked as API IIUC, right? Yes, good point, I'll do that. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5860 To: martinvonz, #hg-reviewers

D5860: scmutil: delete now-unused origpath()

2019-02-05 Thread pulkit (Pulkit Goyal)
pulkit added a comment. This should be marked as API IIUC, right? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5860 To: martinvonz, #hg-reviewers Cc: pulkit, mercurial-devel ___ Mercurial-devel mailing list

D5816: global: make some docstrings raw strings

2019-02-05 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D5816#85618, @pulkit wrote: > Should we add `# skip-blame` to this and rest of the series as they are just adding of r'' prefixes? I'm not sure. If there are `\` in the string, adding the `r''` can change the value of

D5860: scmutil: delete now-unused origpath()

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It has been replaced by backuppath(). REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5860 AFFECTED FILES mercurial/scmutil.py

D5859: subrepo: migrate to scmutil.backuppath()

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5859 AFFECTED FILES mercurial/subrepo.py CHANGE DETAILS diff --git a/mercurial/subrepo.py

D5855: mq: migrate to scmutil.backuppath()

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5855 AFFECTED FILES hgext/mq.py CHANGE DETAILS diff --git a/hgext/mq.py b/hgext/mq.py ---

D5857: merge: migrate to scmutil.backuppath()

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5857 AFFECTED FILES mercurial/merge.py CHANGE DETAILS diff --git a/mercurial/merge.py

D5853: revert: migrate to scmutil.backuppath()

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5853 AFFECTED FILES mercurial/cmdutil.py CHANGE DETAILS diff --git a/mercurial/cmdutil.py

D5851: scmutil: introduce a new backuppath() to replace origpath()

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Unlike most functions in our codebase, origpath() takes a path that is relative to cwd. This commit introduces a replacement for origpath(). The new function

D5850: tests: demonstrate broken unshelve when backing up untracked file

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5850 AFFECTED FILES tests/test-shelve2.t CHANGE DETAILS diff --git a/tests/test-shelve2.t

D5800: config: introduce a new value for ui.relative-paths getting old behavior

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13811. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5800?vs=13732=13811 REVISION DETAIL https://phab.mercurial-scm.org/D5800 AFFECTED FILES mercurial/commands.py mercurial/configitems.py

D5802: status: if ui.relative-paths=no, don't use relative paths even with patterns

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13813. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5802?vs=13734=13813 REVISION DETAIL https://phab.mercurial-scm.org/D5802 AFFECTED FILES mercurial/commands.py tests/test-status.t CHANGE DETAILS diff

D5801: files: respect ui.relative-paths

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13812. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5801?vs=13733=13812 REVISION DETAIL https://phab.mercurial-scm.org/D5801 AFFECTED FILES mercurial/cmdutil.py tests/test-locate.t CHANGE DETAILS diff

D5849: merge: don't unnecessarily calculate absolute path

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D5849#85665, @pulkit wrote: > > I think this also makes the code clearer (and prepares for the next > > patch). > > I don't see a next patch. Oops, true. I'll rephase to be more vague :) REPOSITORY rHG

D5849: merge: don't unnecessarily calculate absolute path

2019-02-05 Thread pulkit (Pulkit Goyal)
pulkit accepted this revision. pulkit added a comment. > I think this also makes the code clearer (and prepares for the next > patch). I don't see a next patch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5849 To: martinvonz, #hg-reviewers, pulkit

D5813: revset: add expect to check the size of a set

2019-02-05 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added a comment. > First, I think the word `expect` is too general. Perhaps, this should be called > `expectsize()` or `expectlen()`. I can make it `expectsize()`. > It's also unclear what's the difference between `size` and `min`/`max`. > Instead of these

D5849: merge: don't unnecessarily calculate absolute path

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think this also makes the code clearer (and prepares for the next patch). REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5849

D5848: merge: don't unnecessarily calculate backup path

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5848 AFFECTED FILES mercurial/merge.py CHANGE DETAILS diff --git a/mercurial/merge.py

D5635: branchmap: make branchcache responsible for reading

2019-02-05 Thread mjpieters (Martijn Pieters)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbf7fb97aecf1: branchmap: make branchcache responsible for reading (authored by mjpieters, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5637: branchmap: add some clarifications and clean up flow

2019-02-05 Thread mjpieters (Martijn Pieters)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc795c462b1d6: branchmap: add some clarifications and clean up flow (authored by mjpieters, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5636: branchmap: updating triggers a write

2019-02-05 Thread mjpieters (Martijn Pieters)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGeb7ce452e0fb: branchmap: updating triggers a write (authored by mjpieters, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5636?vs=13331=13807

D5800: config: introduce a new value for ui.relative-paths getting old behavior

2019-02-05 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D5800#85624, @yuja wrote: > > So do we prefer `legacyrelativevalue` then? Or `legacywasrelative`? Or `legacyrelative`? (I think the last one is least clear.) > > `legacyrelativevalue` sounds good to me. Okay, I

Re: Google Summer of Code 2019.

2019-02-05 Thread Sangeet Kumar Mishra
Hey Pulkit, Thanks for the detailed write-up. I can help with mentoring if required. On Tue, Feb 5, 2019 at 9:23 PM Pulkit Goyal <7895pul...@gmail.com> wrote: > Hey everyone, > > I hope you're doing well. > > We missed the initial deadline for application to PSF for Google Summer of > Code.

Google Summer of Code 2019.

2019-02-05 Thread Pulkit Goyal
Hey everyone, I hope you're doing well. We missed the initial deadline for application to PSF for Google Summer of Code. Don't be scared, things are fine. Once google announces the list of organizations, PSF can accept more sub-orgs. Google will announce list of orgs on 26th Feb. So let's get

D5817: attr: make some docstrings raw strings

2019-02-05 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa5493a251ad3: attr: make some docstrings raw strings (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5817?vs=13744=13805

D5417: rust: translated random test of missingancestors

2019-02-05 Thread gracinet (Georges Racinet)
gracinet added a comment. @yuja we don't need a seed to reproduce: failed examples contain all the information (that's a difference with the Python version) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5417 To: gracinet, #hg-reviewers Cc: yuja, durin42,

Re: [PATCH 3 of 3 V3] revset: leverage getintrange() helper in relation-subscript operation (API)

2019-02-05 Thread Augie Fackler
queued, thanks > On Feb 1, 2019, at 08:35, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1548563857 -32400 > # Sun Jan 27 13:37:37 2019 +0900 > # Node ID 84a273ff0d5254604d1f9d05d2dbdcebaadb5006 > # Parent 28b6a15f5bb2fcfa809532e27cf9008aa4f93d0d >

D5417: rust: translated random test of missingancestors

2019-02-05 Thread yuja (Yuya Nishihara)
yuja added a comment. > This test is useful for me, because it's the only one that really tests the corectness of MissingAncestor, and it's not a bench either. > I agree it feels out of place in with the unit tests, so my proposal is to make an integration test out of it. or

Re: D5417: rust: translated random test of missingancestors

2019-02-05 Thread Yuya Nishihara
> This test is useful for me, because it's the only one that really tests the > corectness of MissingAncestor, and it's not a bench either. > I agree it feels out of place in with the unit tests, so my proposal is to > make an integration test out of it. or examples/ to build a dev-only

mercurial@41556: 24 new changesets

2019-02-05 Thread Mercurial Commits
24 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/0f64091cc851 changeset: 41533:0f64091cc851 user:Gregory Szorc date:Mon Feb 04 09:07:00 2019 -0800 summary: global: make some docstrings raw strings

D5834: commit/revert: if interactive, look elsewhere for whitespace settings (BC)

2019-02-05 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG66399f2e92aa: commit: if interactive, look elsewhere for whitespace settings (BC) (authored by spectral, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5834?vs=13761=13804#toc

D5832: config: extract diff-related coreconfigitem()s to a helper method

2019-02-05 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG901ebc81ffb3: config: extract diff-related coreconfigitem()s to a helper method (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5833: diff: when looking for diff configs, support a configurable prefix

2019-02-05 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG78b270a55dc6: diff: when looking for diff configs, support a configurable prefix (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5800: config: introduce a new value for ui.relative-paths getting old behavior

2019-02-05 Thread yuja (Yuya Nishihara)
yuja added a comment. > So do we prefer `legacyrelativevalue` then? Or `legacywasrelative`? Or `legacyrelative`? (I think the last one is least clear.) `legacyrelativevalue` sounds good to me. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5800 To:

Re: D5800: config: introduce a new value for ui.relative-paths getting old behavior

2019-02-05 Thread Yuya Nishihara
> So do we prefer `legacyrelativevalue` then? Or `legacywasrelative`? Or > `legacyrelative`? (I think the last one is least clear.) `legacyrelativevalue` sounds good to me. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D5834: commit/revert: if interactive, look elsewhere for whitespace settings (BC)

2019-02-05 Thread yuja (Yuya Nishihara)
yuja added a comment. Updated the tests added at https://phab.mercurial-scm.org/rHGd1d3094b54f96ae806303d98b69cf7fa32fa2486 and queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5834 To: spectral, #hg-reviewers Cc: yuja, mercurial-devel

Re: D5834: commit/revert: if interactive, look elsewhere for whitespace settings (BC)

2019-02-05 Thread Yuya Nishihara
Updated the tests added at d1d3094b54f9 and queued, thanks. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839)

2019-02-05 Thread yuja (Yuya Nishihara)
yuja added a comment. > > I agree with that we would never set the `commands.commit.interactive.{...}` > > in hgrc, but the feature itself is useful if you have to work on unclean > > codebase unlike in Google. For example, I sometimes need to commit changes > > ignoring

Re: D5744: commit: ignore diff whitespace settings when doing `commit -i` (issue5839)

2019-02-05 Thread Yuya Nishihara
> > I agree with that we would never set the > `commands.commit.interactive.{...}` > > in hgrc, but the feature itself is useful if you have to work on unclean > > codebase unlike in Google. For example, I sometimes need to commit > changes > > ignoring unrelated whitespace cleanups

mercurial@41532: 3 new changesets

2019-02-05 Thread Mercurial Commits
3 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/4dd07bf84608 changeset: 41530:4dd07bf84608 user:Augie Fackler date:Mon Feb 04 17:06:22 2019 -0500 summary: tests: fix test-match.py on Python3 https://www.mercurial-scm.org/repo/hg/rev/14983ac4a764

D5816: global: make some docstrings raw strings

2019-02-05 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Should we add `# skip-blame` to this and rest of the series as they are just adding of r'' prefixes? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5816 To: indygreg, martinvonz, #hg-reviewers Cc: pulkit, mercurial-devel