D5296: store: don't read the whole fncache in memory

2019-02-25 Thread yuja (Yuya Nishihara)
yuja added a comment. (resend without the "On ... wrote:" line) > Seeing the performance benefit it brings on our repo, I want to try other ways we can do this. Do we like having a conditional which checks the size of fncache and choose one of the approaches depending on how large it

Re: D5296: store: don't read the whole fncache in memory

2019-02-25 Thread Yuya Nishihara
(resend without the "On ... wrote:" line) > Seeing the performance benefit it brings on our repo, I want to try other > ways we can do this. Do we like having a conditional which checks the size of > fncache and choose one of the approaches depending on how large it is? > > If

Re: [PATCH 1 of 8 "STABLE] test: update test-sparse-revlog.t output

2019-02-25 Thread Gregory Szorc
I queued parts 1-3 for stable. Then I merged stable into @ and queued 4-8 on default (because I don't think 4-8 are appropriate for stable since they change test runner functionality). FWIW I greatly appreciate the change to generate the file if it is missing. On Sun, Feb 24, 2019 at 3:07 PM

D5296: store: don't read the whole fncache in memory

2019-02-25 Thread indygreg (Gregory Szorc)
indygreg added a comment. I suspect https://phab.mercurial-scm.org/rHG9fca5b056c0a2f673aefa64f7ec7488bd9188d9d made things faster because the code before was using 1 I/O operation for every entry. I would also not be surprised if CPython from that era did something very inefficient with

Re: [PATCH 1 of 2 RESENT] strip: introduce a soft strip option

2019-02-25 Thread Gregory Szorc
I have queued this series! I think there's room to work on the terminology and the user-facing bits. But this feature is experimental and this all can be worked on later. I think the most important user-facing issue is differentiating "archived" changesets in `hg log` output. In the test added

[PATCH] tests: add more wildcards to test-extdiff.t

2019-02-25 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1551147016 18000 # Mon Feb 25 21:10:16 2019 -0500 # Node ID 6ec63ae7b61f0bf5e14c208667c484a4f589c991 # Parent 68bbcc70e27476fbfa3cc6aada1a99ce39c1306b tests: add more wildcards to test-extdiff.t This test has been flakey recently on Windows,

mercurial@41792: 25 new changesets

2019-02-25 Thread Mercurial Commits
25 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/041d829575ed changeset: 41768:041d829575ed user:Martin von Zweigbergk date:Sun Mar 25 21:32:16 2018 -0700 summary: context: add specialized way of getting copy source file only

D6025: remotefilelog: fix format str, blobsize isn't always a #, can be "(missing)"

2019-02-25 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6025 AFFECTED FILES hgext/remotefilelog/debugcommands.py CHANGE DETAILS diff --git

D6023: branchcache: move loading of branch names and nodes into it's own function

2019-02-25 Thread yuja (Yuya Nishihara)
yuja added a comment. > if not bcache.validfor(repo): > # invalidate the cache > raise ValueError(r'tip differs') > > - cl = repo.changelog > - for line in lineiter: > - line = line.rstrip('\n') > - if not line: > - continue > - node, state, label =

Re: D6023: branchcache: move loading of branch names and nodes into it's own function

2019-02-25 Thread Yuya Nishihara
> if not bcache.validfor(repo): > # invalidate the cache > raise ValueError(r'tip differs') > -cl = repo.changelog > -for line in lineiter: > -line = line.rstrip('\n') > -if not line: > -

D6024: remotefilelog: do not specify an explicit version for repack

2019-02-25 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6024 AFFECTED FILES hgext/remotefilelog/repack.py CHANGE DETAILS diff --git

[Bug 6092] New: Information of current selected commit is not proper

2019-02-25 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6092 Bug ID: 6092 Summary: Information of current selected commit is not proper Product: Mercurial Version: 4.9 Hardware: PC OS: Linux Status: UNCONFIRMED

D5963: copies: handle a case when both merging csets are not descendant of merge base

2019-02-25 Thread khanchi97 (Sushil khanchi)
khanchi97 updated this revision to Diff 14241. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5963?vs=14092=14241 REVISION DETAIL https://phab.mercurial-scm.org/D5963 AFFECTED FILES mercurial/copies.py tests/test-copies.t CHANGE DETAILS diff

D5962: copies: add test that makes both the merging csets dirty and fails

2019-02-25 Thread khanchi97 (Sushil khanchi)
khanchi97 updated this revision to Diff 14240. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5962?vs=14091=14240 REVISION DETAIL https://phab.mercurial-scm.org/D5962 AFFECTED FILES tests/test-copies.t CHANGE DETAILS diff --git

D5961: copies: add test that makes both the merging csets dirty and run w/o error

2019-02-25 Thread khanchi97 (Sushil khanchi)
khanchi97 updated this revision to Diff 14239. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5961?vs=14090=14239 REVISION DETAIL https://phab.mercurial-scm.org/D5961 AFFECTED FILES tests/test-copies.t CHANGE DETAILS diff --git

D6023: branchcache: move loading of branch names and nodes into it's own function

2019-02-25 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG68bbcc70e274: branchcache: move loading of branch names and nodes into its own function (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6023: branchcache: move loading of branch names and nodes into it's own function

2019-02-25 Thread lothiraldan (Boris Feld)
lothiraldan accepted this revision. lothiraldan added a comment. LGTM, queued thanks REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6023 To: pulkit, #hg-reviewers, lothiraldan Cc: lothiraldan, mercurial-devel ___

D5962: copies: add test that makes both the merging csets dirty and fails

2019-02-25 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > test-copytrace-heuristics.t:931-980 > + $ hg graft -r 6 --base c9241b0f2d5b --hidden > + grafting 6:99802e4f1e46 "added willconflict and d" (tip) > + ** unknown exception encountered, please report by visiting > + **

D5961: copies: add test that makes both the merging csets dirty and run w/o error

2019-02-25 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > test-copytrace-heuristics.t:724-728 > + $ cat >> $HGRCPATH << EOF > + > [experimental] > + > evolution.createmarkers=True > + > evolution.allowunstable=True > + > EOF Since this does not seem to set `experimental.copytrace = heuristics`

D5296: store: don't read the whole fncache in memory

2019-02-25 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Ping! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5296 To: pulkit, #hg-reviewers Cc: yuja, mjpieters, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D5997: mq: disable qrecord during histedit (issue5981)

2019-02-25 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added a comment. Thanks for queuing @pulkit. @yuja thanks for the review. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5997 To: navaneeth.suresh, #hg-reviewers, pulkit Cc: yuja, mercurial-devel ___

D5985: bundle2: don't send "shared" requirement when cloning from a share

2019-02-25 Thread mplamann (Mitchell Plamann)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2d835c42ab41: bundle2: dont send shared requirement when cloning from a share (authored by mplamann, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5984: tests: demonstrate failure when cloning from a share via bundle2

2019-02-25 Thread mplamann (Mitchell Plamann)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa62ad1be1671: tests: demonstrate failure when cloning from a share via bundle2 (authored by mplamann, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5997: mq: disable qrecord during histedit (issue5981)

2019-02-25 Thread navaneeth.suresh (Navaneeth Suresh)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4d21ebc4cb47: mq: disable qrecord during histedit (issue5981) (authored by navaneeth.suresh, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6023: branchcache: move loading of branch names and nodes into it's own function

2019-02-25 Thread pulkit (Pulkit Goyal)
pulkit added a comment. I am trying to make branchcache make lazy load and only validate nodes if required. This will speed up operations and loading of branchcache. Right now loading of branchcache validates all the nodes which is not required until the branch which has that node is

D6023: branchcache: move loading of branch names and nodes into it's own function

2019-02-25 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will help me in implementing lazy loading of the branchcache in upcoming patches. REPOSITORY rHG Mercurial REVISION DETAIL

[PATCH FOLLOW-UP] test: follow-up on 1c4d6ab2ecb8, stabilize test-remotefilelog-bgprefetch.t

2019-02-25 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1551081749 -3600 # lun. févr. 25 09:02:29 2019 +0100 # Node ID f611bf911c863d35aced20dfb2546725c911a722 # Parent 1c1c4ef8b72e39f5ed1c62dc4e31e02e9e08b652 # EXP-Topic stabilize-test-remotefilelog-bgprefetch.t # Available At