D6115: unamend: added match as argument for scmutil.movedirstate

martinvonz added a comment. In https://phab.mercurial-scm.org/D6115#89208, @taapas1128 wrote: > Earlier it didn't but now it can I suppose it should after the modification. The `@command` decorator defines what arguments that command accepts. In this case, it's an empty list (on

D6115: unamend: added match as argument for scmutil.movedirstate

taapas1128 added a comment. Earlier it didn't but now it can I suppose it should after the modification. Is there supposed to be any other way to verify it ?(the tests pass successfully) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6115 To: taapas1128,

D6115: unamend: added match as argument for scmutil.movedirstate

martinvonz added a comment. Does `hg unamend` accept patterns as arguments? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6115 To: taapas1128, #hg-reviewers Cc: martinvonz, mercurial-devel ___ Mercurial-devel mailing

D6115: unamend: added match as argument for scmutil.movedirstate

taapas1128 marked an inline comment as done. taapas1128 added a comment. I have added '*pats' as argument for unamend() , won't it serve as an optimisation now ? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6115 To: taapas1128, #hg-reviewers Cc: martinvonz,

D6115: unamend: added match as argument for scmutil.movedirstate

martinvonz added a comment. Could you choose the "Abandon Revision" action on this patch so it's clear that it's not meant to be queued? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6115 To: taapas1128, #hg-reviewers Cc: martinvonz, mercurial-devel

D6125: revert: option to choose what to keep, not what to discard

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I know the you (the reader) are probably tired of discussing how `hg revert -i -r .` should behave and so am I. And I know I'm one of the people who argued

D6124: patch: include newline at EOF in help text for interactive patch

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The lack of a newline means that some "editors" that are useful in tests, such as `echo "+new line" >> "$1"` don't work. It's obviously easy to work around

D6115: unamend: added match as argument for scmutil.movedirstate

taapas1128 marked an inline comment as done. taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in uncommit.py:184 > I don't think `hg unamend` accepts path arguments, so this matcher will > always match everything, right? sorry missed that went through the code of

D6115: unamend: added match as argument for scmutil.movedirstate

taapas1128 updated this revision to Diff 14478. taapas1128 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6115?vs=14476=14478 REVISION DETAIL https://phab.mercurial-scm.org/D6115 AFFECTED FILES hgext/uncommit.py

D6005: uncommit: added interactive mode -i(issue6062)

taapas1128 added a comment. I suppose no .. because in the very initial patch I combined `hg uncommit` with `hg commit -i`(as was stated in the bug description(https://bz.mercurial-scm.org/show_bug.cgi?id=6062)) . But later on I was asked to import it from `evolve` . The basic functionality

D6005: uncommit: added interactive mode -i(issue6062)

martinvonz added a comment. Can you update the commit message to explain how this works? I think I saw somewhere else that it first uncommits everything and then does an interactive amend. Is that correct? Also, I just tried to use this feature and it failed (depending on how many

D6122: tests: add a file listing all the flaky tests

lothiraldan added a comment. In https://phab.mercurial-scm.org/D6122#89169, @av6 wrote: > Another way to do this could be to introduce another special keyword, similar to "slow", so that tests that are known flaky can `#require flaky` or even mark a specific block with `#if flaky`.

D6123: Experimental features: Add condition to for float number (issue6099)

akshjain.jain74 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6123 AFFECTED FILES hgext/histedit.py mercurial/similar.py

D6115: unamend: added match as argument for scmutil.movedirstate

martinvonz added inline comments. INLINE COMMENTS > uncommit.py:184 > curctx = repo['.'] > - > +match = scmutil.match(curctx, opts) > rewriteutil.precheck(repo, [curctx.rev()], 'unamend') I don't think `hg unamend` accepts path arguments, so this matcher will always

D6115: unamend: added match as argument for scmutil.movedirstate

taapas1128 updated this revision to Diff 14476. taapas1128 retitled this revision from "unamend: added match as argument for _firdirstate() in unamend()" to "unamend: added match as argument for scmutil.movedirstate". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6122: tests: add a file listing all the flaky tests

av6 added a comment. Another way to do this could be to introduce another special keyword, similar to "slow", so that tests that are known flaky can `#require flaky` or even mark a specific block with `#if flaky`. Obviously fixing ​test-remotefilelog-bgprefetch.t is a better idea

D6122: tests: add a file listing all the flaky tests

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This file can be used by CI instances to skip tests known to be flaky and focus on tests with no false negatives. REPOSITORY rHG Mercurial REVISION DETAIL