spectral updated this revision to Diff 14491.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6131?vs=14490=14491
REVISION DETAIL
https://phab.mercurial-scm.org/D6131
AFFECTED FILES
mercurial/crecord.py
CHANGE DETAILS
diff --git
martinvonz added inline comments.
INLINE COMMENTS
> crecord.py:537-538
> try:
> -import pdb
> -pdb.set_trace()
> curses.wrapper(chunkselector.main)
I assume this patch was based on some local commit that we don't have in core
(and don't want in core :)). Can you
spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Failure to do this can cause screen corruption like:
[X] filename.cc
I believe this might only happen in some terminals, and maybe only
spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is the normal use of Ctrl-L, so I think this is going to be what most
people expect it to do. We're keeping the adjustment of what line we're
scrolled
to
spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6129
AFFECTED FILES
mercurial/crecord.py
CHANGE DETAILS
diff --git a/mercurial/crecord.py
akshjain.jain74 updated this revision to Diff 14487.
akshjain.jain74 retitled this revision from "ZeroDivisionError: Add condition
to avoid Zerodivisonerror due to float number (issue6099)" to "similar: add
condition to avoid Zerodivisonerror in function _score() (issue6099)".
REPOSITORY
rHG
akshjain.jain74 created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6128
AFFECTED FILES
hgext/histedit.py
hgext/pager.py
khanchi97 added inline comments.
INLINE COMMENTS
> test-split.t:734
>
> -#if no-windows
> +#if windows
> +TODO: Fix this on Windows. See issue 2020 and 5883
I moved the part when on windows (#if windows) at the top because I found it
easy to include nested conditions then.
REPOSITORY
rHG
khanchi97 updated this revision to Diff 14485.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6058?vs=14323=14485
REVISION DETAIL
https://phab.mercurial-scm.org/D6058
AFFECTED FILES
mercurial/patch.py
tests/test-split.t
CHANGE DETAILS
diff --git
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This avoids unnecessarily touching the working copy when splitting the
parent of the working copy. That also makes the test-removeemptydirs.t
case invalid,
indygreg added a comment.
While there may be a need for an explicit `--branch` argument, should we
start by having `hg phabsend` automatically pick up the branch from the
changeset? i.e. wouldn't we want branch selection to be automatic?
REPOSITORY
rHG Mercurial
REVISION DETAIL
akshjain.jain74 added a comment.
actually i am not getting what can be the proper topic for this :(
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6123
To: akshjain.jain74, durin42, #hg-reviewers
Cc: av6, pulkit, mercurial-devel
akshjain.jain74 added a comment.
sorry for that , but can you tell me in what condition this function will
return none value?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6123
To: akshjain.jain74, durin42, #hg-reviewers
Cc: av6, pulkit, mercurial-devel
On 2/19/19 4:46 PM, Augie Fackler wrote:
On Fri, Feb 15, 2019 at 02:39:44PM -0500, Valentin Gatien-Baron wrote:
Hello,
I wrote a fraction of hg status in rust, just the minimum needed to
compare current revision and working copy with few of the flags and
config settings supported. As you can
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The only valid API since
https://phab.mercurial-scm.org/rHG265e91da56fd4e6a9b765caec2c2cfee434de20e
(dirstate: drop deprecated
methods (API), 2018-02-02) is
av6 added a comment.
Okay, let's go over #1 in
https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist
once more. If you want to know what a good "topic" is, look at what other
people do. How patches that get accepted generally look. How bug-fixing commits
are worded.
akshjain.jain74 updated this revision to Diff 14482.
akshjain.jain74 retitled this revision from "Experimental features: Add
condition to for float number (issue6099)" to "ZeroDivisionError: Add condition
to avoid Zerodivisonerror due to float number (issue6099)".
REPOSITORY
rHG Mercurial
martinvonz added subscribers: spectral, ryanmce.
martinvonz added a comment.
In https://phab.mercurial-scm.org/D6005#89211, @pulkit wrote:
> In https://phab.mercurial-scm.org/D6005#89182, @martinvonz wrote:
>
> > Can you update the commit message to explain how this works? I think I
akshjain.jain74 added a comment.
Sorry for the various mistake
I will correct everything in an hour thanks
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6123
To: akshjain.jain74, durin42, #hg-reviewers
Cc: av6, pulkit, mercurial-devel
av6 added inline comments.
INLINE COMMENTS
> similar.py:67
> +if lengths > 0:
> return equal * 2.0 / lengths
>
This returns None in some cases, and code that uses `_score()` and `score()`
tries to compare it to an integer. In Python3 `None > 1` raises TypeError.
REPOSITORY
rHG
av6 added a comment.
I find it troubling that we now have contributors that don't follow #1 in
https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist.
Potentially #4 too (as Pulkit commented).
Seriously, the title is terrible at describing what this patch fixes and
akshjain.jain74 added a comment.
Oh sorry ,my bad I think that is by mistake I will correct it now
Ithink while committing I added that file by mistake
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6123
To: akshjain.jain74, durin42, #hg-reviewers
Cc:
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7e95ade0f369: chunkselector: fix typos in instructions when
user reviews patch (authored by spectral, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit added inline comments.
INLINE COMMENTS
> histedit.py:1127
> else:
> -index += 1
> +index -= 1
> changeaction(state, pos, KEY_LIST[index % len(KEY_LIST)])
Is this change required for this patch?
REPOSITORY
rHG Mercurial
REVISION DETAIL
pulkit added a comment.
In https://phab.mercurial-scm.org/D6005#89182, @martinvonz wrote:
> Can you update the commit message to explain how this works? I think I saw
somewhere else that it first uncommits everything and then does an interactive
amend. Is that correct?
Yes, this
25 matches
Mail list logo
