Re: [PATCH evolve-ext] uncommit: abort if an explicitly given file cannot be uncommitted (BC)

2019-04-09 Thread Martin von Zweigbergk via Mercurial-devel
On Tue, Apr 9, 2019, 18:31 Matt Harbison wrote: > On Tue, 09 Apr 2019 20:26:21 -0400, Martin von Zweigbergk > wrote: > > > On Tue, Apr 9, 2019 at 7:44 AM Pierre-Yves David < > > pierre-yves.da...@ens-lyon.org> wrote: > > > >> PAtch looks good overall, but has compatibility issue with older > >>

Re: [PATCH evolve-ext] uncommit: abort if an explicitly given file cannot be uncommitted (BC)

2019-04-09 Thread Matt Harbison
On Tue, 09 Apr 2019 20:26:21 -0400, Martin von Zweigbergk wrote: On Tue, Apr 9, 2019 at 7:44 AM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: PAtch looks good overall, but has compatibility issue with older version. Can you have a look at my comment below? On 4/3/19 4:45 AM,

Re: [PATCH evolve-ext] uncommit: abort if an explicitly given file cannot be uncommitted (BC)

2019-04-09 Thread Martin von Zweigbergk via Mercurial-devel
On Tue, Apr 9, 2019 at 7:44 AM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > PAtch looks good overall, but has compatibility issue with older > version. Can you have a look at my comment below? > > On 4/3/19 4:45 AM, Matt Harbison wrote: > > # HG changeset patch > > # User Matt

[PATCH] cext: cast s# arguments of Py_BuildValue() to Py_ssize_t

2019-04-09 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1554814777 -32400 # Tue Apr 09 21:59:37 2019 +0900 # Node ID 1792bd9807b6ff434df207e33b94d2ea32555b3e # Parent 864f9f63d3ed371ab3d283911790d4f990926499 cext: cast s# arguments of Py_BuildValue() to Py_ssize_t The doc doesn't state that "s#"

D6221: py3: add b'' prefixes to new doctests in match.py

2019-04-09 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame as just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6221 AFFECTED FILES mercurial/match.py CHANGE

D6220: py3: add one new passing test found by buildbot

2019-04-09 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6220 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist

D6196: cext: make revlog.c PY_SSIZE_T_CLEAN

2019-04-09 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In https://phab.mercurial-scm.org/D6196#90521, @yuja wrote: > > 4 org.python.python 0x0001000eb761 va_build_value + 737 > > 5 org.python.python 0x0001000eb837 _Py_BuildValue_SizeT + 167 > > Maybe we

D5628: diffstat: make --git work properly on renames (issue6025)

2019-04-09 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added inline comments. INLINE COMMENTS > pulkit wrote in patch.py:2811 > This is unfortunately not working with hglib. hglib seems to be splitting > data on '>' or only reading data after that. > > @yuja do you have any idea what can cause that? @pulkit Can you add a possible

Re: [PATCH evolve-ext] uncommit: abort if an explicitly given file cannot be uncommitted (BC)

2019-04-09 Thread Pierre-Yves David
PAtch looks good overall, but has compatibility issue with older version. Can you have a look at my comment below? On 4/3/19 4:45 AM, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1554259321 14400 # Tue Apr 02 22:42:01 2019 -0400 # Node ID

Re: Idea: hg merge --close

2019-04-09 Thread Pierre-Yves David
On 4/8/19 8:25 PM, Augie Fackler wrote: On Sun, Apr 07, 2019 at 02:02:07PM +0200, Pierre-Yves David wrote: On 4/7/19 12:52 PM, Joerg Sonnenberger wrote: Hello all, one thing we discussed during the mini sprint is the issue of dealing with merged vs active vs inactive branches. At the

D6196: cext: make revlog.c PY_SSIZE_T_CLEAN

2019-04-09 Thread yuja (Yuya Nishihara)
yuja added a comment. > 4 org.python.python 0x0001000eb761 va_build_value + 737 > 5 org.python.python 0x0001000eb837 _Py_BuildValue_SizeT + 167 Maybe we shouldn't trust the Python doc too much, which says 's#' of

Re: D6196: cext: make revlog.c PY_SSIZE_T_CLEAN

2019-04-09 Thread Yuya Nishihara
> 4 org.python.python 0x0001000eb761 > va_build_value + 737 > 5 org.python.python 0x0001000eb837 > _Py_BuildValue_SizeT + 167 Maybe we shouldn't trust the Python doc too much, which says 's#' of Py_BuildValue() takes an int.

[PATCH 1 of 2 "V3] compression: introduce an official `zstd-revlog` requirement

2019-04-09 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1553707623 -3600 # Wed Mar 27 18:27:03 2019 +0100 # Node ID 8ce788576265eb8b84cb697ea2e09b2246fb7b81 # Parent 456c37433c433ee59d321315da24eb944e495f08 # EXP-Topic zstd-revlog # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 2 of 2 "V3] upgrade: support upgrade to/from zstd storage (issue6088)

2019-04-09 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1549032662 -3600 # Fri Feb 01 15:51:02 2019 +0100 # Node ID 7a0f7be070d77f454ce8d205aa85ba3308919157 # Parent 8ce788576265eb8b84cb697ea2e09b2246fb7b81 # EXP-Topic zstd-revlog # Available At https://bitbucket.org/octobus/mercurial-devel/ #

Re: [PATCH 7 of 8 "] compression: introduce an official `zstd-revlog` requirement

2019-04-09 Thread Pierre-Yves David
On 4/2/19 8:28 PM, Gregory Szorc wrote: On Tue, Apr 2, 2019 at 6:57 AM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 4/2/19 9:52 AM, Josef 'Jeff' Sipek wrote: > On Sun, Mar 31, 2019 at 17:36:23 +0200, Pierre-Yves David wrote: >> # HG changeset patch