D6263: Typos

2019-04-17 Thread joerg.sonnenberger (Joerg Sonnenberger)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG644eaffab9db: setdiscovery: fix a few typos (authored by joerg.sonnenberger, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D6263?vs=14800&id=14836#toc REPOSITORY rHG Mercuri

D6267: incoming: detect if server send partial replies

2019-04-17 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger updated this revision to Diff 14835. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6267?vs=14808&id=14835 REVISION DETAIL https://phab.mercurial-scm.org/D6267 AFFECTED FILES mercurial/bundlerepo.py tests/test-pull-bundle.t CHANG

D6233: rust-discovery: implementing and exposing stats()

2019-04-17 Thread yuja (Yuya Nishihara)
yuja added a comment. Can't apply by `:D6233`. Can you rebase? % hg pimp :D6233 applying patch from stdin patching file mercurial/setdiscovery.py Hunk #1 succeeded at 167 with fuzz 2 (offset 5 lines). Hunk #2 FAILED at 343 1 out of 2 hunks FAILED -- saving rejects to

D6249: copies: delete debug message about search limit

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG380f59da7aea: copies: delete debug message about search limit (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6249?vs=1482

Re: D6233: rust-discovery: implementing and exposing stats()

2019-04-17 Thread Yuya Nishihara
Can't apply by `:D6233`. Can you rebase? ``` % hg pimp :D6233 applying patch from stdin patching file mercurial/setdiscovery.py Hunk #1 succeeded at 167 with fuzz 2 (offset 5 lines). Hunk #2 FAILED at 343 1 out of 2 hunks FAILED -- saving rejects to file mercurial/setdiscovery.py.rej abort: patch

Re: [PATCH] chistedit: use context manager to set verbose ui

2019-04-17 Thread Yuya Nishihara
On Tue, 16 Apr 2019 13:13:45 -0400, Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1555434741 14400 > # Tue Apr 16 13:12:21 2019 -0400 > # Node ID f64bbdc70aaa1ca8c504c2d909f6012927a27cb8 > # Parent a362b0b95e42c8f7d46d7e3a0eb4cc531fa5f2d6 > c

D6250: copies: delete debug message about changes since common ancestor

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG43c2a13b56eb: copies: delete debug message about changes since common ancestor (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.

D6251: copies: delete debug message about "unmatched files new in both"

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1e266bd9f25b: copies: delete debug message about "unmatched files new in both" (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.

D6246: copies: fix up "fullcopy" with missing entries from "copy"

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG96bd75e67a94: copies: fix up "fullcopy" with missing entries from "copy" (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6

D6248: copies: move early return for "no copies" case a little earlier

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG85f5934016f9: copies: move early return for "no copies" case a little earlier (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.o

D6245: merge: remove workaround for issue5020

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbeec7fc6adec: merge: remove workaround for issue5020 (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6245?vs=14773&id=1482

D6247: copies: fix up "fullcopy" with missing entries from "diverge"

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG22c9ffdf8ef6: copies: fix up "fullcopy" with missing entries from "diverge" (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D6244: copies: don't include copies that are not in source in directory move

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG31abb9d713af: copies: don't include copies that are not in source in directory move (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial

D6242: tests: add test for issue5343 (grafting with copies)

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7815cf0ea88b: tests: add test for issue5343 (grafting with copies) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6242?vs

Re: [PATCH 4 of 4 V3] verify: also check full manifest validity during verify runs

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019 at 8:25 AM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1551881213 -3600 > # Wed Mar 06 15:06:53 2019 +0100 > # Node ID 15d38aadce0e1a4cc526e9bbbc42a158c263df53 > # Parent 9bec7491e9b4cabdfa4d264e5

Re: [PATCH 1 of 2 V2] peer: introduce a limitedarguments attributes

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019 at 2:38 PM Martin von Zweigbergk wrote: > > > On Wed, Apr 17, 2019 at 2:33 PM Joerg Sonnenberger wrote: > >> On Wed, Apr 17, 2019 at 11:33:45AM -0700, Martin von Zweigbergk via >> Mercurial-devel wrote: >> > Question 3: Does httppostargs switch GET requests to POST requests?

D6263: Typos

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. I haven't run tests on this, but I'm guessing one of the `test-check*` tests will tell you that your subject line ("Typos") does not follow our style guide (you could change it to something like "setdiscovery: fix a few typos"). REPOSITORY rHG Mercurial REVISIO

D6249: copies: delete debug message about search limit

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14823. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6249?vs=14777&id=14823 REVISION DETAIL https://phab.mercurial-scm.org/D6249 AFFECTED FILES mercurial/copies.py tests/test-copy-move-merge.t tests/test-d

D6250: copies: delete debug message about changes since common ancestor

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14824. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6250?vs=14778&id=14824 REVISION DETAIL https://phab.mercurial-scm.org/D6250 AFFECTED FILES mercurial/copies.py tests/test-graft.t tests/test-rebase-conf

D6251: copies: delete debug message about "unmatched files new in both"

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14825. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6251?vs=14779&id=14825 REVISION DETAIL https://phab.mercurial-scm.org/D6251 AFFECTED FILES mercurial/copies.py tests/test-graft.t tests/test-rename-merg

D6246: copies: fix up "fullcopy" with missing entries from "copy"

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14820. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6246?vs=14774&id=14820 REVISION DETAIL https://phab.mercurial-scm.org/D6246 AFFECTED FILES mercurial/copies.py tests/test-graft.t tests/test-rename-merg

D6248: copies: move early return for "no copies" case a little earlier

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14822. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6248?vs=14776&id=14822 REVISION DETAIL https://phab.mercurial-scm.org/D6248 AFFECTED FILES mercurial/copies.py CHANGE DETAILS diff --git a/mercurial/copie

D6244: copies: don't include copies that are not in source in directory move

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14819. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6244?vs=14772&id=14819 REVISION DETAIL https://phab.mercurial-scm.org/D6244 AFFECTED FILES mercurial/copies.py tests/test-merge-criss-cross.t CHANGE DETA

D6247: copies: fix up "fullcopy" with missing entries from "diverge"

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14821. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6247?vs=14775&id=14821 REVISION DETAIL https://phab.mercurial-scm.org/D6247 AFFECTED FILES mercurial/copies.py CHANGE DETAILS diff --git a/mercurial/copie

D6252: tests: make merge conflicts explicit in `hg annotate` tests

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7116fc614cfc: tests: make merge conflicts explicit in `hg annotate` tests (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

D6243: tests: split out separate test for issue5020

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf2fe7cf4ebb6: tests: split out separate test for issue5020 (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6243?vs=14771&i

D6254: tests: avoid a rename/delete conflict when updating in test-narrow-update.t

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG351cbda889db: tests: avoid a rename/delete conflict when updating in test-narrow-update.t (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mer

D6253: tests: delete unused function in test-rename-merge2.t

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG344066b54a7b: tests: delete unused function in test-rename-merge2.t (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6253?v

D6264: narrow: make warning about possibly dirty files respect ui.relative-paths

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG770f5f586ae5: narrow: make warning about possibly dirty files respect ui.relative-paths (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercu

D6255: copies: calculate mergecopies() based on pathcopies()

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D6255#91146, @martinvonz wrote: > In https://phab.mercurial-scm.org/D6255#91019, @martinvonz wrote: > > > In https://phab.mercurial-scm.org/D6255#91015, @marmoute wrote: > > > > > > > > > > > Since this seems the v

D6255: copies: calculate mergecopies() based on pathcopies()

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14809. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6255?vs=14804&id=14809 REVISION DETAIL https://phab.mercurial-scm.org/D6255 AFFECTED FILES mercurial/copies.py tests/test-annotate.t tests/test-copies.t

D6269: copies: ignore heuristics copytracing when using changeset-centric algos

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6269 AFFECTED FILES mercurial/copies.py CHANGE DETAILS diff --git a/mercurial/copies.py b/mercuria

D6256: copies: inline _computenonoverlap() in mergecopies()

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14810. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6256?vs=14805&id=14810 REVISION DETAIL https://phab.mercurial-scm.org/D6256 AFFECTED FILES hgext/remotefilelog/__init__.py mercurial/copies.py tests/tes

D6268: copies: move check for experimental.copytrace== earlier

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm going to ignore experimental.copytrace when changeset-centric algorithms are required. This little refactoring makes that easier to add. REPOSITORY rHG

D6266: copies: replace .items() by .values() where appropriate

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14811. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6266?vs=14806&id=14811 REVISION DETAIL https://phab.mercurial-scm.org/D6266 AFFECTED FILES mercurial/copies.py CHANGE DETAILS diff --git a/mercurial/copie

D6267: incoming: detect if server send partial replies

2019-04-17 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. +1 for feature. Needs some minor work to get review. INLINE COMMENTS > bundlerepo.py:639 > > +if rheads and any(x not in localrepo for x in rheads): > +u

Re: [PATCH 2 of 4] verify: introduce a notion of "level"

2019-04-17 Thread Gregory Szorc
On Wed, Apr 17, 2019 at 7:54 AM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 4/17/19 3:15 PM, Gregory Szorc wrote: > > > > > >> On Apr 17, 2019, at 01:38, Pierre-Yves David < > pierre-yves.da...@ens-lyon.org> wrote: > >> > >> # HG changeset patch > >> # User Pierre-Yves Davi

Re: [PATCH 1 of 2 V2] peer: introduce a limitedarguments attributes

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019 at 2:33 PM Joerg Sonnenberger wrote: > On Wed, Apr 17, 2019 at 11:33:45AM -0700, Martin von Zweigbergk via > Mercurial-devel wrote: > > Question 3: Does httppostargs switch GET requests to POST requests? > > > > I believe the answer is "no". > > See makev1commandrest in httpp

D6267: incoming: detect if server send partial replies

2019-04-17 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY incoming is not using the normal exchange logic and therefore doesn't know how to tell with pullbundles. Fixing that is involved and it is currently n

Re: [PATCH 1 of 2 V2] peer: introduce a limitedarguments attributes

2019-04-17 Thread Joerg Sonnenberger
On Wed, Apr 17, 2019 at 11:33:45AM -0700, Martin von Zweigbergk via Mercurial-devel wrote: > Question 3: Does httppostargs switch GET requests to POST requests? > > I believe the answer is "no". See makev1commandrest in httppeer.py line 137ff. The answer is "yes, if they exist". Joerg _

D6265: narrow: also warn when not deleting untracked or ignored files

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14807. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6265?vs=14803&id=14807 REVISION DETAIL https://phab.mercurial-scm.org/D6265 AFFECTED FILES mercurial/narrowspec.py tests/test-narrow-share.t CHANGE DETAI

D6265: narrow: also warn when not deleting untracked or ignored files

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > rdamazio wrote in narrowspec.py:310 > Just do a loop for each one? You probably also don't need them to be sets. I did it that way at first. Then I changed it because I figured it might be a harder to read if dirty, untracked, and ignored file

D6255: copies: calculate mergecopies() based on pathcopies()

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14804. martinvonz edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6255?vs=14783&id=14804 REVISION DETAIL https://phab.mercurial-scm.org/D6255 AFFECTED FILES mercurial/copies.

D6256: copies: inline _computenonoverlap() in mergecopies()

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14805. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6256?vs=14785&id=14805 REVISION DETAIL https://phab.mercurial-scm.org/D6256 AFFECTED FILES hgext/remotefilelog/__init__.py mercurial/copies.py tests/tes

D6266: copies: replace .items() by .values() where appropriate

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As pointed out by Pierre-Yves. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6266 AFFECTED FILES mercurial/copies.py CHANGE D

D6254: tests: avoid a rename/delete conflict when updating in test-narrow-update.t

2019-04-17 Thread marmoute (Pierre-Yves David)
marmoute accepted this revision. marmoute added a comment. This one seems simple and sensible. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6254 To: martinvonz, durin42, #hg-reviewers, marmoute Cc: marmoute, mercurial-devel

D6253: tests: delete unused function in test-rename-merge2.t

2019-04-17 Thread marmoute (Pierre-Yves David)
marmoute added a comment. That one seems simple and sensible too. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6253 To: martinvonz, #hg-reviewers Cc: marmoute, mercurial-devel ___ Mercurial-devel mailing list Mercuri

D6252: tests: make merge conflicts explicit in `hg annotate` tests

2019-04-17 Thread marmoute (Pierre-Yves David)
marmoute accepted this revision. marmoute added a comment. This one seems simple and sensible. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6252 To: martinvonz, #hg-reviewers, marmoute Cc: marmoute, mercurial-devel _

D6265: narrow: also warn when not deleting untracked or ignored files

2019-04-17 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio added inline comments. INLINE COMMENTS > narrowspec.py:310 > +for f in sorted(trackeddirty + status.unknown + status.ignored): > +if f in unknownset: > +repo.ui.status(_('not deleting unknown file %s\n') % uipathfn(f)) Just do a loop for each one? You probably al

D6255: copies: calculate mergecopies() based on pathcopies()

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D6255#91019, @martinvonz wrote: > In https://phab.mercurial-scm.org/D6255#91015, @marmoute wrote: > > > > > > The rest somehow didn't make it here, so I'll copy from the email (i.e. the below is from Pierre-Yves, not

mercurial@42149: 4 new changesets (4 on stable)

2019-04-17 Thread Mercurial Commits
4 new changesets (4 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/4a8d9ed86475 changeset: 42146:4a8d9ed86475 branch: stable tag: 5.0rc0 parent: 41984:d1c33b2442a7 parent: 42143:29569f2db929 user:Augie Fackler date:Wed Apr 17 13:41:18 2

D6258: packaging: coerce paths to strings

2019-04-17 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D6258#91056, @indygreg wrote: > In https://phab.mercurial-scm.org/D6258#91055, @durin42 wrote: > > > Argh. This change appears to be wrong (!) so I'm going to drop it. > > > Eh? I don't see anything wrong with this. Casti

Re: [PATCH 1 of 2 V2] peer: introduce a limitedarguments attributes

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019 at 10:41 AM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 4/17/19 7:17 PM, Martin von Zweigbergk wrote: > > > > > > On Wed, Apr 17, 2019 at 10:07 AM Pierre-Yves David > > mailto:pierre-yves.da...@ens-lyon.org>> > > > wrote: > > > > # HG changeset patc

Re: [PATCH 2 of 4 V2] verify: introduce a notion of "level"

2019-04-17 Thread Pierre-Yves David
On 4/17/19 8:04 PM, Martin von Zweigbergk wrote: On Wed, Apr 17, 2019 at 6:27 AM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 4/17/19 3:18 PM, Martin von Zweigbergk wrote: > > > On Wed, Apr 17, 2019, 03:49 Pierre-Yves David > mailto:pierre-

mercurial@42145: 2 new changesets

2019-04-17 Thread Mercurial Commits
2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/013de80bf90e changeset: 42144:013de80bf90e user:Pierre-Yves David date:Wed Apr 17 00:37:00 2019 +0200 summary: recover: add a --[no-]verify flag https://www.mercurial-scm.org/repo/hg/rev/607a0de9bae3 c

Re: [PATCH 2 of 4 V2] verify: introduce a notion of "level"

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019 at 6:27 AM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 4/17/19 3:18 PM, Martin von Zweigbergk wrote: > > > > > > On Wed, Apr 17, 2019, 03:49 Pierre-Yves David > > mailto:pierre-yves.da...@ens-lyon.org>> > > > wrote: > > > > # HG changeset patch > >

D6265: narrow: also warn when not deleting untracked or ignored files

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6265 AFFECTED FILES mercurial/narrowspec.py tests/test-narrow-sh

D6264: narrow: make warning about dirty possibly files respect ui.relative-paths

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6264 AFFECTED FILES mercurial/narrowspec.py CHANGE DETAILS diff --git a/mercurial/narrowspec.py b/

Re: [PATCH 1 of 2 V2] peer: introduce a limitedarguments attributes

2019-04-17 Thread Pierre-Yves David
On 4/17/19 7:17 PM, Martin von Zweigbergk wrote: On Wed, Apr 17, 2019 at 10:07 AM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: # HG changeset patch # User Pierre-Yves David mailto:pierre-yves.da...@octobus.net>> # Date 116590 -7200 #      Wed Apr 17

Re: [PATCH 2 of 2] setdiscovery: stop limiting the number of local head we initially send

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Tue, Apr 16, 2019 at 8:59 PM Martin von Zweigbergk wrote: > > > On Tue, Apr 16, 2019 at 11:41 AM Pierre-Yves David < > pierre-yves.da...@ens-lyon.org> wrote: > >> # HG changeset patch >> # User Pierre-Yves David >> # Date 1555428398 -7200 >> # Tue Apr 16 17:26:38 2019 +0200 >> # Node ID

D2647: setdiscovery: make progress on each connected group each roundtrip

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 14801. martinvonz retitled this revision from "setdiscovery: include all local heads in second "known" request (issue5809)" to "setdiscovery: make progress on each connected group each roundtrip". martinvonz edited the summary of this revision. REPOSITORY

Re: [PATCH 1 of 2 V2] peer: introduce a limitedarguments attributes

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019 at 10:07 AM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 116590 -7200 > # Wed Apr 17 17:56:30 2019 +0200 > # Node ID 6882a0101d389e27d697bf2e9717de176f273309 > # Parent 607a0de9bae31df526da75b6

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

2019-04-17 Thread idlsoft (Sandu Turcan)
idlsoft added a comment. If ACL is enabled, processing this part is mandatory, yes. On clone, or pull the user doesn't specify includes, so reading this part is the only way the client can get them. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6218 To: pulk

[PATCH 2 of 2 V2] setdiscovery: stop limiting the number of local head we initially send

2019-04-17 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1555428398 -7200 # Tue Apr 16 17:26:38 2019 +0200 # Node ID db6c319c208491e0cc1705b5f09ae7cc50719842 # Parent 6882a0101d389e27d697bf2e9717de176f273309 # EXP-Topic discovery-speedup # Available At https://bitbucket.org/octobus/mercurial-dev

[PATCH 1 of 2 V2] peer: introduce a limitedarguments attributes

2019-04-17 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 116590 -7200 # Wed Apr 17 17:56:30 2019 +0200 # Node ID 6882a0101d389e27d697bf2e9717de176f273309 # Parent 607a0de9bae31df526da75b68ab2853787d8c31e # EXP-Topic discovery-speedup # Available At https://bitbucket.org/octobus/mercurial-dev

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D6218#91121, @idlsoft wrote: > Because the current client ignores the data completely, the only way to force it to fail I think is to change the name of the part. > This would make things cleaner probably, but I'll deal with

Re: [PATCH 1 of 2] debugdiscovery: include the number of heads in all sets

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Tue, Apr 16, 2019 at 11:44 AM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1555422620 -7200 > # Tue Apr 16 15:50:20 2019 +0200 > # Node ID 017778a4463a8e6ecb4b17cacf46a3ab27bdb239 > # Parent 967c098eed3398d991cbd7f0

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

2019-04-17 Thread idlsoft (Sandu Turcan)
idlsoft added a comment. Because the current client ignores the data completely, the only way to force it to fail I think is to change the name of the part. This would make things cleaner probably, but I'll deal with whatever solution you guys settle on. REPOSITORY rHG Mercurial REVISIO

[Bug 6120] New: Experimental graphstyle doesn't allow UTF-8 characters

2019-04-17 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6120 Bug ID: 6120 Summary: Experimental graphstyle doesn't allow UTF-8 characters Product: Mercurial Version: 4.9 Hardware: Macintosh OS: Mac OS Status: UNCONFIRMED

Re: [PATCH 2 of 2] setdiscovery: stop limiting the number of local head we initially send

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019 at 8:27 AM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > On 4/17/19 5:21 PM, Martin von Zweigbergk wrote: > > > > > > On Wed, Apr 17, 2019 at 3:36 AM Pierre-Yves David > > mailto:pierre-yves.da...@ens-lyon.org>> > > > wrote: > > > > On 4/17/19 5:59 AM, Marti

Re: [PATCH 2 of 2] setdiscovery: stop limiting the number of local head we initially send

2019-04-17 Thread Pierre-Yves David
On 4/17/19 5:21 PM, Martin von Zweigbergk wrote: On Wed, Apr 17, 2019 at 3:36 AM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 4/17/19 5:59 AM, Martin von Zweigbergk wrote: > > > On Tue, Apr 16, 2019 at 11:41 AM Pierre-Yves David > mailto:pierre

[PATCH 3 of 4 V3] verify: introduce an experimental --full flag

2019-04-17 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1555456269 -7200 # Wed Apr 17 01:11:09 2019 +0200 # Node ID 9bec7491e9b4cabdfa4d264e5213b1f416ec2607 # Parent 55bd98999c25b10e220477fd4cc446a7c9c1f8ca # EXP-Topic verify # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 1 of 4 V3] recover: add a --[no-]verify flag

2019-04-17 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1555454220 -7200 # Wed Apr 17 00:37:00 2019 +0200 # Node ID f233cb63bc077267d8571378350d9563cbabcf3d # Parent eebf78724d94649de84f921ff5bd39cbc0f48cb6 # EXP-Topic verify # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 2 of 4 V3] verify: introduce a notion of "level"

2019-04-17 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1555456341 -7200 # Wed Apr 17 01:12:21 2019 +0200 # Node ID 55bd98999c25b10e220477fd4cc446a7c9c1f8ca # Parent f233cb63bc077267d8571378350d9563cbabcf3d # EXP-Topic verify # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 4 of 4 V3] verify: also check full manifest validity during verify runs

2019-04-17 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1551881213 -3600 # Wed Mar 06 15:06:53 2019 +0100 # Node ID 15d38aadce0e1a4cc526e9bbbc42a158c263df53 # Parent 9bec7491e9b4cabdfa4d264e5213b1f416ec2607 # EXP-Topic verify # Available At https://bitbucket.org/octobus/mercurial-devel/ #

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

2019-04-17 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D6218#91119, @martinvonz wrote: > In https://phab.mercurial-scm.org/D6218#91058, @indygreg wrote: > > > This patch is backwards incompatible over the wire protocol. > > > > The problem is a new client will blindly send part

Re: [PATCH 2 of 2] setdiscovery: stop limiting the number of local head we initially send

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019 at 3:36 AM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 4/17/19 5:59 AM, Martin von Zweigbergk wrote: > > > > > > On Tue, Apr 16, 2019 at 11:41 AM Pierre-Yves David > > mailto:pierre-yves.da...@ens-lyon.org>> > > > wrote: > > > > # HG changeset patch

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D6218#91058, @indygreg wrote: > This patch is backwards incompatible over the wire protocol. > > The problem is a new client will blindly send part data to an old server expecting part parameters. The old server won't read

[PATCH V4] repoview: introduce a `experimental.extra-filter-revs` config

2019-04-17 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1554565579 -7200 # Sat Apr 06 17:46:19 2019 +0200 # Node ID a6885b6d14025a68c1b65128050384f3849ff688 # Parent eebf78724d94649de84f921ff5bd39cbc0f48cb6 # EXP-Topic repoview # Available At https://bitbucket.org/octobus/mercurial-devel/ #

Re: [PATCH 4 of 4] verify: also check full manifest validity during verify runs

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019, 06:52 Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 4/17/19 3:49 PM, Martin von Zweigbergk wrote: > > > > > > On Wed, Apr 17, 2019, 06:47 Pierre-Yves David > > mailto:pierre-yves.da...@ens-lyon.org>> > > > wrote: > > > > > > > > On 4/17/19 3:06 PM, M

Re: [PATCH] repoview: introduce a `experimental.extra-filter-revs` config

2019-04-17 Thread Pierre-Yves David
On 4/17/19 2:08 PM, Gregory Szorc wrote: On Apr 17, 2019, at 13:34, Pierre-Yves David wrote: On 4/17/19 1:22 PM, Gregory Szorc wrote: diff --git a/tests/test-server-view.t b/tests/test-server-view.t --- a/tests/test-server-view.t +++ b/tests/test-server-view.t @@ -34,5

Re: [PATCH] repoview: introduce a `experimental.extra-filter-revs` config

2019-04-17 Thread Pierre-Yves David
On 4/17/19 2:08 PM, Gregory Szorc wrote: On Apr 17, 2019, at 13:34, Pierre-Yves David wrote: On 4/17/19 1:22 PM, Gregory Szorc wrote: On Tue, Apr 16, 2019 at 4:54 PM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: # HG changeset patch # User Pierre-Yves David m

Re: [PATCH 2 of 4] verify: introduce a notion of "level"

2019-04-17 Thread Pierre-Yves David
On 4/17/19 3:15 PM, Gregory Szorc wrote: On Apr 17, 2019, at 01:38, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1555456341 -7200 # Wed Apr 17 01:12:21 2019 +0200 # Node ID 55bd98999c25b10e220477fd4cc446a7c9c1f8ca # Parent f233cb63bc077267d857137835

Re: [PATCH 4 of 4] verify: also check full manifest validity during verify runs

2019-04-17 Thread Pierre-Yves David
On 4/17/19 3:49 PM, Martin von Zweigbergk wrote: On Wed, Apr 17, 2019, 06:47 Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 4/17/19 3:06 PM, Martin von Zweigbergk wrote: > > > On Wed, Apr 17, 2019, 03:34 Pierre-Yves David > mailto:pierre-yves

Re: [PATCH 4 of 4] verify: also check full manifest validity during verify runs

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019, 06:47 Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 4/17/19 3:06 PM, Martin von Zweigbergk wrote: > > > > > > On Wed, Apr 17, 2019, 03:34 Pierre-Yves David > > mailto:pierre-yves.da...@ens-lyon.org>> > > > wrote: > > > > On 4/17/19 4:59 AM, Martin vo

Re: [PATCH 2 of 4 V2] verify: introduce a notion of "level"

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019, 06:27 Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 4/17/19 3:18 PM, Martin von Zweigbergk wrote: > > > > > > On Wed, Apr 17, 2019, 03:49 Pierre-Yves David > > mailto:pierre-yves.da...@ens-lyon.org>> > > > wrote: > > > > # HG changeset patch > >

Re: [PATCH 2 of 3 V2] repoview: introduce a `experimental.extra-filter-revs` config

2019-04-17 Thread Pierre-Yves David
On 4/17/19 3:44 PM, Martin von Zweigbergk wrote: On Wed, Apr 17, 2019, 06:42 Martin von Zweigbergk > wrote: On Tue, Apr 16, 2019, 11:52 Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: # HG changeset patch # User Pierr

Re: [PATCH 4 of 4] verify: also check full manifest validity during verify runs

2019-04-17 Thread Pierre-Yves David
On 4/17/19 3:06 PM, Martin von Zweigbergk wrote: On Wed, Apr 17, 2019, 03:34 Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 4/17/19 4:59 AM, Martin von Zweigbergk wrote: > > > On Tue, Apr 16, 2019, 16:46 Pierre-Yves David > mailto:pierre-yves.d

Re: [PATCH 2 of 3 V2] repoview: introduce a `experimental.extra-filter-revs` config

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019, 06:42 Martin von Zweigbergk wrote: > > > On Tue, Apr 16, 2019, 11:52 Pierre-Yves David < > pierre-yves.da...@ens-lyon.org> wrote: > >> # HG changeset patch >> # User Pierre-Yves David >> # Date 1554565579 -7200 >> # Sat Apr 06 17:46:19 2019 +0200 >> # Node ID 898753ab5

Re: [PATCH 2 of 3 V2] repoview: introduce a `experimental.extra-filter-revs` config

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Tue, Apr 16, 2019, 11:52 Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1554565579 -7200 > # Sat Apr 06 17:46:19 2019 +0200 > # Node ID 898753ab5830bed2a7e16639a746376fa447577f > # Parent 56e2557a9401a3b3c60956b86860c

Re: [PATCH 2 of 4] verify: introduce a notion of "level"

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
Heh, that's very much related to my comment on the V2 of this patch. Pierre-Yves, have you considered sending patches via Phabricator? That keeps comments on various versions of a patch together in one place. On Wed, Apr 17, 2019, 06:18 Gregory Szorc wrote: > > > > On Apr 17, 2019, at 01:38, Pi

D6259: [POC] revset: on-disk cache for children queries

2019-04-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. Perhaps we'd want this to not be specifically for revsets? We could also write to it when we write to the changelog to keep it up to date. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6259 To: joerg.sonnenberger, #hg-reviewers Cc:

Re: [PATCH 2 of 4 V2] verify: introduce a notion of "level"

2019-04-17 Thread Pierre-Yves David
On 4/17/19 3:18 PM, Martin von Zweigbergk wrote: On Wed, Apr 17, 2019, 03:49 Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: # HG changeset patch # User Pierre-Yves David mailto:pierre-yves.da...@octobus.net>> # Date 1555456341 -7200 #      Wed Apr 17 01:1

Re: [PATCH 2 of 4 V2] verify: introduce a notion of "level"

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019, 03:49 Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1555456341 -7200 > # Wed Apr 17 01:12:21 2019 +0200 > # Node ID 55bd98999c25b10e220477fd4cc446a7c9c1f8ca > # Parent f233cb63bc077267d8571378350d9

Re: [PATCH 2 of 4] verify: introduce a notion of "level"

2019-04-17 Thread Gregory Szorc
> On Apr 17, 2019, at 01:38, Pierre-Yves David > wrote: > > # HG changeset patch > # User Pierre-Yves David > # Date 1555456341 -7200 > # Wed Apr 17 01:12:21 2019 +0200 > # Node ID 55bd98999c25b10e220477fd4cc446a7c9c1f8ca > # Parent f233cb63bc077267d8571378350d9563cbabcf3d > # EXP-Topic

Re: [PATCH 4 of 4] verify: also check full manifest validity during verify runs

2019-04-17 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Apr 17, 2019, 03:34 Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 4/17/19 4:59 AM, Martin von Zweigbergk wrote: > > > > > > On Tue, Apr 16, 2019, 16:46 Pierre-Yves David > > mailto:pierre-yves.da...@ens-lyon.org>> > > > wrote: > > > > # HG changeset patch > >

D6231: rust-discovery: starting core implementation

2019-04-17 Thread kevincox (Kevin Cox)
kevincox added a comment. In https://phab.mercurial-scm.org/D6231#91102, @gracinet wrote: > I believe to have addressed your immediate concerns. > > I played with splitting in different `struct`s for the various stages of the process. It is indeed cleaner and clearer Rust code. >

D6260: rust-discovery: takefullsample() core implementation

2019-04-17 Thread kevincox (Kevin Cox)
kevincox accepted this revision. kevincox added inline comments. INLINE COMMENTS > discovery.rs:108 > +cur: usize, > +} > + You might also consider an enum enum Parents { Zero, One(Revision), Two(Revision, Revision), } This also makes the iterator implementation a little cl

D6259: [POC] revset: on-disk cache for children queries

2019-04-17 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger added a comment. For the NetBSD repository, a trivial test with the new cache: time hg log -r '1000~-400' -T {node} > /dev/null real0m1.898s time hg log -r '1000~-400' -T {node} > /dev/null real0m0.170s time hg log -r '1000~-1' -T {node}

D6263: Typos

2019-04-17 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6263 AFFECTED FILES mercurial/setdiscovery.py CHANGE DETAILS diff --git a/mercurial/setdis

  1   2   >