D6557: relnotes: added description about statemod._statecheck

2019-06-27 Thread taapas1128 (Taapas Agrawal)
taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in next:65-66 > I'll drop the last sentence in flight since D6583 > has landed. thanks! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6557/new/

D6557: relnotes: added description about statemod._statecheck

2019-06-27 Thread taapas1128 (Taapas Agrawal)
Closed by commit rHGdf5f674050b7: relnotes: added description about statemod._statecheck (authored by taapas1128). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D6557?vs=15690=15691#toc REPOSITORY rHG

D6557: relnotes: added description about statemod._statecheck

2019-06-27 Thread martinvonz (Martin von Zweigbergk)
This revision is now accepted and ready to land. martinvonz added inline comments. martinvonz accepted this revision. INLINE COMMENTS > next:65-66 > + independently a state for a new operation can be registered using > + `addunfinished()` in `state` module. The description of data needed > +

D6557: relnotes: added description about statemod._statecheck

2019-06-27 Thread taapas1128 (Taapas Agrawal)
taapas1128 updated this revision to Diff 15690. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6557?vs=15620=15690 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6557/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6557 AFFECTED

D6583: statecheck: shifted defaults to addunfinished()

2019-06-27 Thread taapas1128 (Taapas Agrawal)
Closed by commit rHGfaec09d89435: statecheck: shifted defaults to addunfinished() (authored by taapas1128). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6551: statecheck: added support for cmdutil.afterresolvedstates

2019-06-27 Thread taapas1128 (Taapas Agrawal)
taapas1128 added inline comments. INLINE COMMENTS > taapas1128 wrote in state.py:135 > sure. resolved in D6583 REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6551/new/ REVISION DETAIL

D6583: statecheck: shifted defaults to addunfinished()

2019-06-27 Thread taapas1128 (Taapas Agrawal)
taapas1128 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This shifts the definitions and defaults of `_statecheck()` class to `addunfinished()` registration method. REPOSITORY rHG Mercurial REVISION DETAIL

mercurial@42533: 11 new changesets

2019-06-27 Thread Mercurial Commits
11 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/49998d5ba66a changeset: 42523:49998d5ba66a user:Rodrigo Damazio Bovendorp date:Tue Jun 25 19:28:41 2019 -0700 summary: pycompat: make fewer assumptions about sys.executable

[Bug 6165] New: Mercurial 5.0.1 does not have Windows wheels

2019-06-27 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6165 Bug ID: 6165 Summary: Mercurial 5.0.1 does not have Windows wheels Product: Mercurial Version: 5.0 Hardware: PC OS: Linux Status: UNCONFIRMED Severity:

D6551: statecheck: added support for cmdutil.afterresolvedstates

2019-06-27 Thread taapas1128 (Taapas Agrawal)
taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in state.py:135 > Oh, it still won't be consistent... Can you send a follow-up to reorder these > assignments to be consistent? sure. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6547: shelve: removed redundant merge detection method

2019-06-27 Thread taapas1128 (Taapas Agrawal)
taapas1128 updated this revision to Diff 15687. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6547?vs=15642=15687 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6547/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6547 AFFECTED

D6557: relnotes: added description about statemod._statecheck

2019-06-27 Thread taapas1128 (Taapas Agrawal)
taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in next:63-69 > The "private" (underscore-prefixed) members should not be mentioned here. > Extension developers should not be accessing them, so they don't need to know > about them. What they need to know is that if they

D6582: abort: added support for histedit

2019-06-27 Thread taapas1128 (Taapas Agrawal)
taapas1128 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds the support for histedit in `hg abort` plan. `_aborthistedit()` has been modified for independent calls.

D6557: relnotes: added description about statemod._statecheck

2019-06-27 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > next:63-69 > + has been added to `state.py` and is form of class called `_statecheck`. > + To register a new state for an operation you need to add a `_statecheck` > + object with necessary information to `_unfinishedstates` list. > +

D6551: statecheck: added support for cmdutil.afterresolvedstates

2019-06-27 Thread taapas1128 (Taapas Agrawal)
Closed by commit rHG0231032729c4: statecheck: added support for cmdutil.afterresolvedstates (authored by taapas1128). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6551: statecheck: added support for cmdutil.afterresolvedstates

2019-06-27 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > martinvonz wrote in state.py:135 > I'll move this up two lines in flight so it's consistent with the order above Oh, it still won't be consistent... Can you send a follow-up to reorder these assignments to be consistent? REPOSITORY rHG

D6551: statecheck: added support for cmdutil.afterresolvedstates

2019-06-27 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > state.py:135 > self._reportonly = reportonly > +self._continueflag = continueflag > I'll move this up two lines in flight so it's consistent with the order above REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6484: states: moved cmdutil.unfinishedstates to state.py

2019-06-27 Thread taapas1128 (Taapas Agrawal)
Closed by commit rHG5f2f6912c9e6: states: moved cmdutil.unfinishedstates to state.py (authored by taapas1128). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6484?vs=15638=15681

D6503: statecheck: added support for STATES

2019-06-27 Thread taapas1128 (Taapas Agrawal)
Closed by commit rHG12243f15d53e: statecheck: added support for STATES (authored by taapas1128). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15641=15684 CHANGES SINCE

D6501: state: created new class statecheck to handle unfinishedstates

2019-06-27 Thread taapas1128 (Taapas Agrawal)
Closed by commit rHGdc3fdd1b5af4: state: created new class statecheck to handle unfinishedstates (authored by taapas1128). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6502: state: moved cmdutil.STATES and utilities to state.py

2019-06-27 Thread taapas1128 (Taapas Agrawal)
Closed by commit rHG5bddd2244814: state: moved cmdutil.STATES and utilities to state.py (authored by taapas1128). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6502?vs=15640=15683

D6393: rust-dirstate: add "dirs" Rust implementation

2019-06-27 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > Alphare wrote in dirs_multiset.rs:43 > Unless I'm missing something, this would render the `if` statement useless. Maybe Kevin meant something like this? if skip_state == None | skip_state == Some(state) { multiset.add_path(filename);

D6575: pycompat: make fewer assumptions about sys.executable

2019-06-27 Thread rdamazio (Rodrigo Damazio Bovendorp)
Closed by commit rHG49998d5ba66a: pycompat: make fewer assumptions about sys.executable (authored by rdamazio). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6575?vs=15663=15675

D6570: rebase: fix in-memory rebasing of copy of empty file

2019-06-27 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHGe079e001d536: rebase: fix in-memory rebasing of copy of empty file (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6570?vs=15653=15680

D6577: py3: make catapult usable from the test runner in py3

2019-06-27 Thread rdamazio (Rodrigo Damazio Bovendorp)
Closed by commit rHG9913fffd744b: py3: make catapult usable from the test runner in py3 (authored by rdamazio). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6577?vs=15662=15677

D6569: tests: demonstrate broken in-memory rebase of copy to empty file

2019-06-27 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHG4a6826868625: tests: demonstrate broken in-memory rebase of copy to empty file (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6574: zsh: enable completion support for chg as well

2019-06-27 Thread spectral (Kyle Lippincott)
Closed by commit rHG0c0e54bcea9b: zsh: enable completion support for chg as well (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6574?vs=15657=15678 CHANGES

D6576: py3: use integer division for the value passed to xrange

2019-06-27 Thread rdamazio (Rodrigo Damazio Bovendorp)
Closed by commit rHGf3fa10a5877d: py3: use integer division for the value passed to xrange (authored by rdamazio). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6576?vs=15659=15676

mercurial@42522: 3 new changesets

2019-06-27 Thread Mercurial Commits
3 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/898b36f74f75 changeset: 42520:898b36f74f75 user:Martin von Zweigbergk date:Wed Jun 26 05:20:02 2019 -0700 summary: copies: document how 'copies' dict instances are reused

D6581: update: fix spurious unclean status bug shown by previous commit

2019-06-27 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHGd29db0a0c4eb: update: fix spurious unclean status bug shown by previous commit (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6580: tests: show bug in update introduced in 87a34c767384

2019-06-27 Thread valentin.gatienbaron (Valentin Gatien-Baron)
Closed by commit rHG64a873ca7135: tests: show bug in update introduced in 87a34c767384 (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6581: update: fix spurious unclean status bug shown by previous commit

2019-06-27 Thread martinvonz (Martin von Zweigbergk)
This revision is now accepted and ready to land. martinvonz added a comment. martinvonz accepted this revision. Thanks for fixing this quickly! The fix looks very straight-forward too. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6581/new/ REVISION

Re: [PATCH evolve-ext] py3: broad pass for python3 compatibility

2019-06-27 Thread Ludovic Chabant
> We definitely want this patch, but we equally want a way to test (not > just locally) that it keeps working. Maybe we can better coordinate the > efforts in #hg-evolve. Will do, thanks! ___ Mercurial-devel mailing list

D6395: rust-dirstate: call new "dirs" rust implementation from Python

2019-06-27 Thread Raphaël Gomès
Alphare updated this revision to Diff 15672. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6395?vs=15509=15672 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6395/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6395 AFFECTED FILES

D6393: rust-dirstate: add "dirs" Rust implementation

2019-06-27 Thread Raphaël Gomès
Alphare added a comment. In D6393#95768 , @kevincox wrote: > Sorry. I was busy. In general don't worry about blocking on me, I can't promise any sort of reasonable response time. Worst case I can review the changes after submission and changes

D6393: rust-dirstate: add "dirs" Rust implementation

2019-06-27 Thread Raphaël Gomès
Alphare marked an inline comment as done. Alphare updated this revision to Diff 15670. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6393?vs=15508=15670 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6393/new/ REVISION DETAIL

D6394: rust-dirstate: add "dirs" rust-cpython binding

2019-06-27 Thread Raphaël Gomès
Alphare updated this revision to Diff 15671. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6394?vs=15342=15671 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6394/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6394 AFFECTED FILES

D6581: update: fix spurious unclean status bug shown by previous commit

2019-06-27 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The crux of the problem is: - the dirstate is corrupted (the sizes/dates are assigned to the wrong files) - because when worker.worker is used

D6580: tests: show bug in update introduced in 87a34c767384

2019-06-27 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As reported by Martin at https://phab.mercurial-scm.org/D6475. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6580

Re: [PATCH evolve-ext] py3: broad pass for python3 compatibility

2019-06-27 Thread Anton Shestakov
On Wed, 26 Jun 2019 15:55:50 -0700 "Ludovic Chabant" wrote: > Should I re-create the patch on the latest evolve stable now? Or will someone > else do it? > I'm asking because py3 support is blocking a few things for sourcehut. > Thanks! Personally, I thought you all would discuss py3 efforts

D6475: merge: fix race that could cause wrong size in dirstate

2019-06-27 Thread valentin.gatienbaron (Valentin Gatien-Baron)
valentin.gatienbaron added a comment. In D6475#95879 , @martinvonz wrote: > In D6475#95878 , @martinvonz wrote: > >> Try this: >> `hg co -C 4.9; hg debugrebuilddirstate; hg co 5.0; hg st` >>