Improving file name encoding support on Windows

2019-08-06 Thread Manuel Jacob
Recently I sent a mail to the Mercurial (user mailing list) to ask how to have filename encoding interoperability between Linux and Windows. It seems like this is currently not easily achievable. I’ve seen the Windows UTF-8 plan in the Wiki, but it doesn’t seem to be implemented, so I

D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

2019-08-06 Thread spectral (Kyle Lippincott)
spectral added a comment. In D6710#98322 , @marmoute wrote: > Forcing this write seems like a good idea. Having it in its own > changeset seems like a good idea (and please add a comment about forcing > the write). I've split the

D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve

2019-08-06 Thread navaneeth.suresh (Navaneeth Suresh)
Closed by commit rHG6957f7b93e03: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve (authored by navaneeth.suresh). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D6708?vs=16146=16147#toc

D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve

2019-08-06 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Applied the following diff in flight which was result of test output changes. --- /home/pulkit/repo/paccess/tests/test-shelve.t +++ /home/pulkit/repo/paccess/tests/test-shelve.t @@ -1365,19 +1365,19 @@ #if stripbased $ hg log -r 3:: -G

D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve

2019-08-06 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16146. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6708?vs=16141=16146 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6708/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6708

D6699: tests: add test for unshelve --interactive --keep

2019-08-06 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16145. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6699?vs=16131=16145 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6699/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6699

D6712: config: fix defaultvalue template keyword

2019-08-06 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16144. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6712?vs=16118=16144 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6712/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6712

D6694: unshelve: delete shelvedstate after a successful unshelve --continue

2019-08-06 Thread navaneeth.suresh (Navaneeth Suresh)
Closed by commit rHG073cfff9aaef: unshelve: delete shelvedstate after a successful unshelve --continue (authored by navaneeth.suresh). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D6634: rust-dirstate: call rust dirstatemap from Python

2019-08-06 Thread Raphaël Gomès
Alphare added a comment. Alphare added a subscriber: reviewers. @reviewers I am leaving for a vacation on the 9h and I won't be able to answer your questions or work on those patches before the 20th. This series has been idle for a long time, I didn't want it to be forgotten about.

D6694: unshelve: delete shelvedstate after a successful unshelve --continue

2019-08-06 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16142. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6694?vs=16133=16142 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6694/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6694

D6694: unshelve: delete shelvedstate after a successful unshelve --continue

2019-08-06 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added inline comments. INLINE COMMENTS > pulkit wrote in test-shelve.t:1430 > the above sentence is confusing and maybe incorrect too. okay, maybe i should remove it. doing that right away. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve

2019-08-06 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added inline comments. INLINE COMMENTS > pulkit wrote in shelve.py:1008 > IIUC, we don't need `_forgetunknownfiles()` too in this if statement. Can you > add some related tests and see if we need this as a followup? sure, will investigate on that. REPOSITORY rHG Mercurial

D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve

2019-08-06 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16141. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6708?vs=16112=16141 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6708/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6708

D6694: unshelve: delete shelvedstate after a successful unshelve --continue

2019-08-06 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > test-shelve.t:1430 > +-- now, --continue should abort as the last unshelve was successful even > +-- though it was partially done. it can be completed without --continue. > + $ hg unshelve --continue the above sentence is confusing and maybe

D6686: unshelve: handle stripping changesets on interactive mode

2019-08-06 Thread navaneeth.suresh (Navaneeth Suresh)
Closed by commit rHG4814d993fe21: unshelve: handle stripping changesets on interactive mode (authored by navaneeth.suresh). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve

2019-08-06 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Sorry for not noticing this before, but this patch needs tests. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6708/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6708 To: navaneeth.suresh, #hg-reviewers, pulkit Cc:

mercurial@42701: 18 new changesets (2 on stable)

2019-08-06 Thread Mercurial Commits
18 new changesets (2 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/9e0f1c80cddb changeset: 42684:9e0f1c80cddb branch: stable parent: 42682:e0cf09bc35ef user:Gregory Szorc date:Sat Aug 03 12:13:51 2019 -0700 summary: automation: push changes

[PATCH 1 of 3] copies: extract an explicit `computechangesetcopie` method from context

2019-08-06 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1565054260 -7200 # Tue Aug 06 03:17:40 2019 +0200 # Node ID fc8e461200c7262246ebd610100bcf9a75ded461 # Parent f95b59ffc307c4549d9640a81d750a99bd75f423 # EXP-Topic extrameta # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 3 of 3] copies: extract an explicit `computechangesetfilesremoved` method from context

2019-08-06 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1560343372 -3600 # Wed Jun 12 13:42:52 2019 +0100 # Node ID 961d24dfe801ac0c5ad5737d98d553075cef4089 # Parent f6b2517c3651915610cee753ff8351e90078685d # EXP-Topic extrameta # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 2 of 3] copies: extract an explicit `computechangesetfilesadded` method from context

2019-08-06 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1560343342 -3600 # Wed Jun 12 13:42:22 2019 +0100 # Node ID f6b2517c3651915610cee753ff8351e90078685d # Parent fc8e461200c7262246ebd610100bcf9a75ded461 # EXP-Topic extrameta # Available At https://bitbucket.org/octobus/mercurial-devel/ #

Re: [PATCH 1 of 2] byteify-strings: add space in special comments to silence flake8 error

2019-08-06 Thread Pulkit Goyal
On Tue, Aug 6, 2019 at 3:59 PM Raphaël Gomès wrote: > > # HG changeset patch > # User Raphaël Gomès > # Date 1565095770 -7200 > # Tue Aug 06 14:49:30 2019 +0200 > # Node ID a6acc71d557b3606a048dd95f26e0b6988682a9c > # Parent 2c32f0d1ae622cdbe10c92a763f6fbec711d7668 > # EXP-Topic

[Bug 6183] New: hg import fails to ignore '\ ' line due to Windows line endings

2019-08-06 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6183 Bug ID: 6183 Summary: hg import fails to ignore '\ ' line due to Windows line endings Product: Mercurial Version: unspecified Hardware: PC OS: Windows

D6694: unshelve: delete shelvedstate after a successful unshelve --continue

2019-08-06 Thread pulkit (Pulkit Goyal)
pulkit added a comment. This fails to apply on tip of default. Can you rebase and resend? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6694/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6694 To: navaneeth.suresh, #hg-reviewers, durin42,

D6707: revset: drop argument when it's None

2019-08-06 Thread av6 (Anton Shestakov)
Closed by commit rHG911e25dc9d8c: revset: drop argument when its None (authored by av6). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6707?vs=16107=16139 CHANGES SINCE LAST

D6714: automation: update packages in requirements files

2019-08-06 Thread indygreg (Gregory Szorc)
Closed by commit rHG3495edddc78d: automation: update packages in requirements files (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6714?vs=16123=16135

D6716: automation: increase root volume size on Linux

2019-08-06 Thread indygreg (Gregory Szorc)
Closed by commit rHG3e3fb15bfeea: automation: increase root volume size on Linux (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6716?vs=16125=16137 CHANGES

D6706: stack: remove unnecessary reverse() predicate

2019-08-06 Thread av6 (Anton Shestakov)
Closed by commit rHG77c52ce50e6a: stack: remove unnecessary reverse() predicate (authored by av6). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6706?vs=16106=16138 CHANGES SINCE

D6715: automation: install Rust in Linux environment

2019-08-06 Thread indygreg (Gregory Szorc)
Closed by commit rHG89ba81771fc9: automation: install Rust in Linux environment (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6715?vs=16124=16136 CHANGES

D6713: automation: install latest Python versions

2019-08-06 Thread indygreg (Gregory Szorc)
Closed by commit rHG6f7262fe671c: automation: install latest Python versions (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6713?vs=16122=16134 CHANGES

Re: [PATCH 1 of 3] copies: extract an explicit `computechangesetcopie` method from context

2019-08-06 Thread Yuya Nishihara
On Tue, 6 Aug 2019 14:38:23 +0200, Pierre-Yves David wrote: > > > On 8/6/19 2:25 PM, Yuya Nishihara wrote: > > On Tue, 06 Aug 2019 11:50:38 +0200, Pierre-Yves David wrote: > >> # HG changeset patch > >> # User Pierre-Yves David > >> # Date 1565054260 -7200 > >> # Tue Aug 06 03:17:40 2019

[PATCH 2 of 2] byteify-strings: add --version argument

2019-08-06 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1565096065 -7200 # Tue Aug 06 14:54:25 2019 +0200 # Node ID fcfc777aef1bf534878f3318cb826f5d6ef7ed33 # Parent a6acc71d557b3606a048dd95f26e0b6988682a9c # EXP-Topic byteify-strings byteify-strings: add --version argument This is indispensable

[PATCH 1 of 2] byteify-strings: add space in special comments to silence flake8 error

2019-08-06 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1565095770 -7200 # Tue Aug 06 14:49:30 2019 +0200 # Node ID a6acc71d557b3606a048dd95f26e0b6988682a9c # Parent 2c32f0d1ae622cdbe10c92a763f6fbec711d7668 # EXP-Topic byteify-strings byteify-strings: add space in special comments to silence

Re: [PATCH 1 of 3] copies: extract an explicit `computechangesetcopie` method from context

2019-08-06 Thread Pierre-Yves David
On 8/6/19 2:25 PM, Yuya Nishihara wrote: On Tue, 06 Aug 2019 11:50:38 +0200, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1565054260 -7200 # Tue Aug 06 03:17:40 2019 +0200 # Node ID fc8e461200c7262246ebd610100bcf9a75ded461 # Parent

Re: [PATCH 1 of 3] copies: extract an explicit `computechangesetcopie` method from context

2019-08-06 Thread Yuya Nishihara
On Tue, 06 Aug 2019 11:50:38 +0200, Pierre-Yves David wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1565054260 -7200 > # Tue Aug 06 03:17:40 2019 +0200 > # Node ID fc8e461200c7262246ebd610100bcf9a75ded461 > # Parent f95b59ffc307c4549d9640a81d750a99bd75f423 > # EXP-Topic

D6694: unshelve: delete shelvedstate after a successful unshelve --continue

2019-08-06 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh marked an inline comment as done. navaneeth.suresh updated this revision to Diff 16133. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6694?vs=16109=16133 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6694/new/ REVISION

D6705: relnotes: copy "next" to "5.1" and clear "next"

2019-08-06 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHGcba59b338976: relnotes: copy next to 5.1 and clear next (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6705?vs=16105=16132 CHANGES

D6694: unshelve: delete shelvedstate after a successful unshelve --continue

2019-08-06 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > test-shelve.t:1436 > + $ hg shelve --list > + default-01 (1s ago)changes to: add A to bars > + default (1s ago)changes to: add B to foo These timing needs to be globbed. REPOSITORY rHG Mercurial CHANGES SINCE LAST

D6686: unshelve: handle stripping changesets on interactive mode

2019-08-06 Thread pulkit (Pulkit Goyal)
pulkit added a comment. I am not sure why, but `test-shelve.t` fails for me with some hash changes. Can you have a look? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6686/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6686 To:

D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve

2019-08-06 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > shelve.py:1008 > if not ispartialunshelve: > _forgetunknownfiles(repo, shelvectx, addedbefore) > unshelvecleanup(ui, repo, basename, opts) IIUC, we don't need `_forgetunknownfiles()` too in this if statement. Can

D6699: tests: add test for unshelve --interactive --keep

2019-08-06 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > test-shelve.t:1476 > + > + $ hg shelve --list > + default (1s ago)changes to: add B to foo Can you show what the new shelve contains? Also add a test when there is partial unshelving going. REPOSITORY rHG Mercurial CHANGES

Re: D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

2019-08-06 Thread Pierre-Yves David
Forcing this write seems like a good idea. Having it in its own changeset seems like a good idea (and please add a comment about forcing the write). On 8/6/19 3:12 AM, spectral (Kyle Lippincott) wrote: spectral added inline comments. INLINE COMMENTS marmoute wrote in localrepo.py:2224 Why

Re: [PATCH 6 of 8] upgrade: add an argument to control manifest upgrade

2019-08-06 Thread Pierre-Yves David
On 8/6/19 4:44 AM, Gregory Szorc wrote: On Mon, Aug 5, 2019 at 10:04 AM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: # HG changeset patch # User Pierre-Yves David mailto:pierre-yves.da...@octobus.net>> # Date 1564439752 -7200 #      Tue Jul 30 00:35:52

Re: [PATCH 4 of 8] upgrade: introduce a _copyrevlog method

2019-08-06 Thread Pierre-Yves David
On 8/6/19 4:33 AM, Gregory Szorc wrote: On Mon, Aug 5, 2019 at 9:55 AM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: # HG changeset patch # User Pierre-Yves David mailto:pierre-yves.da...@octobus.net>> # Date 1564509524 -7200 #      Tue Jul 30 19:58:44

[PATCH 1 of 3] copies: extract an explicit `computechangesetcopie` method from context

2019-08-06 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1565054260 -7200 # Tue Aug 06 03:17:40 2019 +0200 # Node ID fc8e461200c7262246ebd610100bcf9a75ded461 # Parent f95b59ffc307c4549d9640a81d750a99bd75f423 # EXP-Topic extrameta # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 3 of 3] copies: extract an explicit `computechangesetfilesremoved` method from context

2019-08-06 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1560343372 -3600 # Wed Jun 12 13:42:52 2019 +0100 # Node ID 8e554943127cd8daf0fe6561fb3c2e1930d8c8e1 # Parent 8e63367b5e07024527f1afbd3585f9af651c2d64 # EXP-Topic extrameta # Available At https://bitbucket.org/octobus/mercurial-devel/ #