Re: [PATCH 01 of 10] revlog: split a `_revisiondata` method to file `revision` job

On Wed, Aug 7, 2019 at 2:44 PM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1565190888 -7200 > # Wed Aug 07 17:14:48 2019 +0200 > # Node ID 3b49bb04851ea501f005e7a58403fee3b1c52958 > # Parent

[PATCH 6 of 9] flagutil: introduce a flagprocessorsmixin class

# HG changeset patch # User Pierre-Yves David # Date 1565219568 -7200 # Thu Aug 08 01:12:48 2019 +0200 # Node ID 466943d2fed3602e08ac9117afef1c727bcb98a5 # Parent 82e7f9d4d0bac574e4aa1b8f81e81ac1df3f6ddc # EXP-Topic flag-processors # Available At

[PATCH 9 of 9] flagutil: use it in simplestorerepo

# HG changeset patch # User Pierre-Yves David # Date 1565223018 -7200 # Thu Aug 08 02:10:18 2019 +0200 # Node ID 8bf3a649c932784a12ea49aeda0f3991980e8777 # Parent 9ee2ada7f37ba42787408c03074206cf0bb828de # EXP-Topic flag-processors # Available At

[PATCH 7 of 9] flagutil: use the new mixin use in remotefilelog

# HG changeset patch # User Pierre-Yves David # Date 1565219856 -7200 # Thu Aug 08 01:17:36 2019 +0200 # Node ID 2e87598264f883b252a39664f2e2618e9de13e42 # Parent 466943d2fed3602e08ac9117afef1c727bcb98a5 # EXP-Topic flag-processors # Available At

[PATCH 8 of 9] flagutil: make the error class used by the mixin configurable

# HG changeset patch # User Pierre-Yves David # Date 1565219744 -7200 # Thu Aug 08 01:15:44 2019 +0200 # Node ID 9ee2ada7f37ba42787408c03074206cf0bb828de # Parent 2e87598264f883b252a39664f2e2618e9de13e42 # EXP-Topic flag-processors # Available At

[PATCH 4 of 9] flagutil: move insertflagprocessor to the new module (API)

# HG changeset patch # User Pierre-Yves David # Date 1565220337 -7200 # Thu Aug 08 01:25:37 2019 +0200 # Node ID c446e19887223d1e7299ea6123b408564f3832d9 # Parent c084756962a2c842af5dc0e23cc67234e4fb1d59 # EXP-Topic flag-processors # Available At

[PATCH 3 of 9] flagutil: move REVIDX_KNOWN_FLAGS source of truth in flagutil (API)

# HG changeset patch # User Pierre-Yves David # Date 1565220514 -7200 # Thu Aug 08 01:28:34 2019 +0200 # Node ID c084756962a2c842af5dc0e23cc67234e4fb1d59 # Parent 6e9396b0817a0e161ff340eab6aeb9c220b1d4df # EXP-Topic flag-processors # Available At

[PATCH 2 of 9] flagutil: move the `flagprocessors` mapping in the new module

# HG changeset patch # User Pierre-Yves David # Date 1565219088 -7200 # Thu Aug 08 01:04:48 2019 +0200 # Node ID 6e9396b0817a0e161ff340eab6aeb9c220b1d4df # Parent 536a1081efbe3cf9ae150af69ab10c6152e8197d # EXP-Topic flag-processors # Available At

[PATCH 5 of 9] flagutil: move addflagprocessor to the new module (API)

# HG changeset patch # User Pierre-Yves David # Date 1565222383 -7200 # Thu Aug 08 01:59:43 2019 +0200 # Node ID 82e7f9d4d0bac574e4aa1b8f81e81ac1df3f6ddc # Parent c446e19887223d1e7299ea6123b408564f3832d9 # EXP-Topic flag-processors # Available At

[PATCH 1 of 9] flagutil: create a `mercurial.revlogutils.flagutil` module

# HG changeset patch # User Pierre-Yves David # Date 1565218981 -7200 # Thu Aug 08 01:03:01 2019 +0200 # Node ID 536a1081efbe3cf9ae150af69ab10c6152e8197d # Parent 11498aa91c036c6d70f7ac5ee5af2664a84a1130 # EXP-Topic flag-processors # Available At

D6712: config: remove pycompat.bytestr() for defaultvalue

yuja added a comment. > The `pycompat.bytestr()` was there for py3 compatibility, Not really for the "value" variable which may be unprintable object, but I think it's okay to assume defaultvalues are None/bool/int/float/bytes type. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

Re: D6712: config: fix defaultvalue template keyword (patch 1 of 2)

> The `pycompat.bytestr()` was there for py3 compatibility, Not really for the "value" variable which may be unprintable object, but I think it's okay to assume defaultvalues are None/bool/int/float/bytes type. ___ Mercurial-devel mailing list

Re: [PATCH 3 of 3 V3] copies: extract an explicit `computechangesetfilesremoved` method from context

On Wed, 07 Aug 2019 15:46:50 +0200, Pierre-Yves David wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1560343372 -3600 > # Wed Jun 12 13:42:52 2019 +0100 > # Node ID 49740823dab3e2673ece70974080a274f2b8cf94 > # Parent 791b66f0c3e2f67dd7cb093cf58d662f63e4273f > # EXP-Topic

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

This revision now requires changes to proceed. pulkit added a comment. pulkit requested changes to this revision. The test still fails. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6697/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6697

D6717: mypy: add a mypy.ini config file

pulkit added a comment. I am +1 on this. If I don't hear any objection on it until next week, I will queue it. Thanks for doing this work! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6717/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6717

D6699: tests: add test for unshelve --interactive --keep

pulkit added a comment. You are already working on improving things with `--keep` and `--interactive`, so let's have this patch as a part of that patch. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6699/new/ REVISION DETAIL

D6659: graft: split graft code into seperate functions

pulkit added inline comments. INLINE COMMENTS > cmdutil.py:3431 > +"""logic to execute graft once revs are generated""" > +graftstate = statemod.cmdstate(repo, 'graftstate') > +for pos, ctx in enumerate(repo.set("%ld", revs)): let's initialize `graftstate` only where we need it. >

D6678: continue: added support for histedit

pulkit added inline comments. INLINE COMMENTS > histedit.py:1842 > > +def hgcontinuehistedit(ui, repo): > +state = histeditstate(repo) I see that we can have a unified function, `resumehistedit(..)` which can be called from `_histedit()` too. REPOSITORY rHG Mercurial CHANGES SINCE

D6689: continue: added support for transplant

pulkit added inline comments. INLINE COMMENTS > transplant.py:743 > +tp = transplanter(ui, repo, opts) > +tp.resume(repo, repo, opts) > +return I don't see `transplanter` modifying opts. So we can directly pass empty dict in both of the above function. >

[PATCH 08 of 10] rawdata: implement the method for `remotefilelog` too

# HG changeset patch # User Pierre-Yves David # Date 1565203912 -7200 # Wed Aug 07 20:51:52 2019 +0200 # Node ID cfad2ef930798575f52a6a20313b0b57a5b16e1f # Parent 614e6f874408568cda406299e714b0d711e970be # EXP-Topic rawdata # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 10 of 10] rawdata: register the method for `ifiledata`

# HG changeset patch # User Pierre-Yves David # Date 1565208169 -7200 # Wed Aug 07 22:02:49 2019 +0200 # Node ID 798e48124c8f0297f0eeab0277c58f38f88b9284 # Parent 9c998f6ff099877a0e53722a1c35a8e059cb17ee # EXP-Topic rawdata # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 07 of 10] rawdata: implement `rawdata` for `simplestore` too

# HG changeset patch # User Pierre-Yves David # Date 1565203685 -7200 # Wed Aug 07 20:48:05 2019 +0200 # Node ID 614e6f874408568cda406299e714b0d711e970be # Parent 61aefd21e509dac932964c332744f42e7d619546 # EXP-Topic rawdata # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 09 of 10] rawdata: implement the method for `unionrepo` too

# HG changeset patch # User Pierre-Yves David # Date 1565205468 -7200 # Wed Aug 07 21:17:48 2019 +0200 # Node ID 9c998f6ff099877a0e53722a1c35a8e059cb17ee # Parent cfad2ef930798575f52a6a20313b0b57a5b16e1f # EXP-Topic rawdata # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 06 of 10] rawdata: forward `rawdata` call on `manifestlog`

# HG changeset patch # User Pierre-Yves David # Date 1565208484 -7200 # Wed Aug 07 22:08:04 2019 +0200 # Node ID 61aefd21e509dac932964c332744f42e7d619546 # Parent 07298d6c4c98ee1f59ab1aa563226e8d1f91dbcf # EXP-Topic rawdata # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 03 of 10] rawdata: forward the method call on `filelog` object

# HG changeset patch # User Pierre-Yves David # Date 1565207960 -7200 # Wed Aug 07 21:59:20 2019 +0200 # Node ID 948b50c3f67ae6a7812823ead71760ef88647f7e # Parent fe5517914e9f519855d5f8c0ef89098e039d68c6 # EXP-Topic rawdata # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 05 of 10] rawdata: implement `rawdata` for `sqlitestore` too

# HG changeset patch # User Pierre-Yves David # Date 1565208112 -7200 # Wed Aug 07 22:01:52 2019 +0200 # Node ID 07298d6c4c98ee1f59ab1aa563226e8d1f91dbcf # Parent b358cc7a35d219848f1366c29610eb46beb91225 # EXP-Topic rawdata # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 02 of 10] rawdata: introduce a `rawdata` method on revlog

# HG changeset patch # User Pierre-Yves David # Date 1565207669 -7200 # Wed Aug 07 21:54:29 2019 +0200 # Node ID fe5517914e9f519855d5f8c0ef89098e039d68c6 # Parent 3b49bb04851ea501f005e7a58403fee3b1c52958 # EXP-Topic rawdata # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 04 of 10] rawdata: add the method to bundlerevlog

# HG changeset patch # User Pierre-Yves David # Date 1565208057 -7200 # Wed Aug 07 22:00:57 2019 +0200 # Node ID b358cc7a35d219848f1366c29610eb46beb91225 # Parent 948b50c3f67ae6a7812823ead71760ef88647f7e # EXP-Topic rawdata # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 01 of 10] revlog: split a `_revisiondata` method to file `revision` job

# HG changeset patch # User Pierre-Yves David # Date 1565190888 -7200 # Wed Aug 07 17:14:48 2019 +0200 # Node ID 3b49bb04851ea501f005e7a58403fee3b1c52958 # Parent 4710384df490f426ba53055537b16030dc61d957 # EXP-Topic rawdata # Available At https://bitbucket.org/octobus/mercurial-devel/ #

D6712: config: remove pycompat.bytestr() for defaultvalue

Closed by commit rHG049b2ac3252e: config: remove pycompat.bytestr() for defaultvalue (authored by navaneeth.suresh). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6720: config: fix fm.data() handling of defaultvalue

Closed by commit rHG60789444acd6: config: fix fm.data() handling of defaultvalue (authored by navaneeth.suresh). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6720?vs=16150=16152

D6696: abort: added support for transplant

pulkit added inline comments. INLINE COMMENTS > transplant.py:779 > +tp = transplanter(ui, repo, {}) > +tp.abort(ui, repo) > +return `return tp.abort(..)` instead. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6696/new/

D6695: transplant: added support for --abort flag

pulkit added inline comments. INLINE COMMENTS > transplant.py:416 > > +def clear(self): > +"""clear the state file if it exists""" We already have `self.unlog` doing the same here. > transplant.py:421 > + > +def abort(self, ui ,repo): > +"""logic to abort an

D6712: config: remove pycompat.bytestr() for defaultvalue

navaneeth.suresh added a comment. In D6712#98424 , @pulkit wrote: > The `pycompat.bytestr()` was there for py3 compatibility, however removing it should be fine in this case. Can you make sure `test-config.t` passes with this patch on Python

D6720: config: fix fm.data() handling of defaultvalue

navaneeth.suresh updated this revision to Diff 16150. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6720?vs=16149=16150 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6720/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6720

D6720: config: fix fm.data() handling of defaultvalue

pulkit added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in commands.py:1884 > I did this but, couldn't see a difference in the test output. ah, I guess the output is sorted. Anyway, the suggested one is a correct way to do this, because otherwise we are writing name to fm two

D6720: config: fix fm.data() handling of defaultvalue

navaneeth.suresh added inline comments. INLINE COMMENTS > pulkit wrote in commands.py:1884 > A better fix will be to move `fm.data(name=entryname)` inside the if, i.e. > where it was before https://phab.mercurial-scm.org/D6704. > > And add `fm.data(defaultvalue=...)` below the if-else which

[PATCH 2 of 3 V2] upgrade: add an argument to control changelog upgrade

# HG changeset patch # User Pierre-Yves David # Date 1564500316 -7200 # Tue Jul 30 17:25:16 2019 +0200 # Node ID acf1937e39ba1db0ab81a14bc0c0082c93df838b # Parent 8a77cda93b1a7252482a4ca4e420b76936c9ae27 # EXP-Topic upgrade-select # Available At

[PATCH 1 of 3 V2] upgrade: add an argument to control manifest upgrade

# HG changeset patch # User Pierre-Yves David # Date 1564439752 -7200 # Tue Jul 30 00:35:52 2019 +0200 # Node ID 8a77cda93b1a7252482a4ca4e420b76936c9ae27 # Parent 0812d9fb63fe1f417a1bdec3bc292dd953a5fc62 # EXP-Topic upgrade-select # Available At

[PATCH 3 of 3 V2] upgrade: make sure we reclone all revlogs when updating to some format

# HG changeset patch # User Pierre-Yves David # Date 1565018724 -7200 # Mon Aug 05 17:25:24 2019 +0200 # Node ID e585aec755459c4169c2db87b8ffbd523be19f87 # Parent acf1937e39ba1db0ab81a14bc0c0082c93df838b # EXP-Topic upgrade-select # Available At

D6712: config: fix defaultvalue template keyword (patch 1 of 2)

pulkit added a comment. This patch needs a better description. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6712/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6712 To: navaneeth.suresh, #hg-reviewers Cc: pulkit, durin42, marmoute,

D6720: config: fix defaultvalue template keyword (patch 2 of 2)

pulkit added a comment. This patch also needs a better description, something like: `config: fix fm.data() handling of defaultvalue`. INLINE COMMENTS > commands.py:1884 > fm.condwrite(ui.debugflag, 'source', '%s: ', source) > +fm.data(name=entryname,

D6709: config: add --registered flag to show all known configs

This revision now requires changes to proceed. marmoute added inline comments. marmoute requested changes to this revision. INLINE COMMENTS > pulkit wrote in test-config.t:228 > In cases when the default value and the value of config set are different, > let's do something like ` (default=)`

D6712: config: fix defaultvalue template keyword (patch 1 of 2)

pulkit added a comment. The `pycompat.bytestr()` was there for py3 compatibility, however removing it should be fine in this case. Can you make sure `test-config.t` passes with this patch on Python 3? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6709: config: add --registered flag to show all known configs

pulkit added inline comments. INLINE COMMENTS > ui.py:821 > > +def walkallconfig(self, untrusted=False): > +"""walk through all known config options in the registrar""" Since, we renamed the flag which was good idea, let's rename the function too. Also, this should better return

D6720: config: fix defaultvalue template keyword (patch 2 of 2)

navaneeth.suresh created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a follow-up patch to rHG51a2e3102db2 . This moves `fm.data()` out

[PATCH 2 of 3 V3] copies: extract an explicit `computechangesetfilesadded` method from context

# HG changeset patch # User Pierre-Yves David # Date 1560343342 -3600 # Wed Jun 12 13:42:22 2019 +0100 # Node ID 791b66f0c3e2f67dd7cb093cf58d662f63e4273f # Parent fc8e461200c7262246ebd610100bcf9a75ded461 # EXP-Topic extrameta # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 3 of 3 V3] copies: extract an explicit `computechangesetfilesremoved` method from context

# HG changeset patch # User Pierre-Yves David # Date 1560343372 -3600 # Wed Jun 12 13:42:52 2019 +0100 # Node ID 49740823dab3e2673ece70974080a274f2b8cf94 # Parent 791b66f0c3e2f67dd7cb093cf58d662f63e4273f # EXP-Topic extrameta # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 1 of 3 V3] copies: extract an explicit `computechangesetcopie` method from context

# HG changeset patch # User Pierre-Yves David # Date 1565054260 -7200 # Tue Aug 06 03:17:40 2019 +0200 # Node ID fc8e461200c7262246ebd610100bcf9a75ded461 # Parent f95b59ffc307c4549d9640a81d750a99bd75f423 # EXP-Topic extrameta # Available At https://bitbucket.org/octobus/mercurial-devel/ #

D6712: config: fix defaultvalue template keyword (patch 1 of 2)

navaneeth.suresh retitled this revision from "config: fix defaultvalue template keyword" to "config: fix defaultvalue template keyword (patch 1 of 2)". navaneeth.suresh edited the summary of this revision. navaneeth.suresh updated this revision to Diff 16148. REPOSITORY rHG Mercurial CHANGES

Re: Improving file name encoding support on Windows

On Wed, 07 Aug 2019 04:14:54 +0200, Manuel Jacob wrote: > Unix-derived systems use bytes as the native type for file names. > > Windows uses Unicode (this mostly means "UTF-16") as the native type for > file names. Windows provides a subset of the filesystem API accepting > bytes (for some

Re: [PATCH 1 of 3 V2] copies: extract an explicit `computechangesetcopie` method from context

On Wed, 07 Aug 2019 11:24:25 +0200, Pierre-Yves David wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1565054260 -7200 > # Tue Aug 06 03:17:40 2019 +0200 > # Node ID fc8e461200c7262246ebd610100bcf9a75ded461 > # Parent f95b59ffc307c4549d9640a81d750a99bd75f423 > # EXP-Topic

D6712: config: fix defaultvalue template keyword

durin42 added a comment. durin42 resigned from this revision. I agree with marmoute on all points. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6712/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6712 To: navaneeth.suresh, #hg-reviewers Cc:

Re: Hosting Mercurial Sprint 5.2

Hey everyone, Good news, Jane Street is happy to host us for the sprint in New York. We plan to decide on a date in 7-10 days as that will give enough time for people to book their travel. If you haven't filled your preferences yet and want to attend the sprint, it will be a nice time to do so

[PATCH 1 of 3 V2] copies: extract an explicit `computechangesetcopie` method from context

# HG changeset patch # User Pierre-Yves David # Date 1565054260 -7200 # Tue Aug 06 03:17:40 2019 +0200 # Node ID fc8e461200c7262246ebd610100bcf9a75ded461 # Parent f95b59ffc307c4549d9640a81d750a99bd75f423 # EXP-Topic extrameta # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 2 of 3 V2] copies: extract an explicit `computechangesetfilesadded` method from context

# HG changeset patch # User Pierre-Yves David # Date 1560343342 -3600 # Wed Jun 12 13:42:22 2019 +0100 # Node ID f6b2517c3651915610cee753ff8351e90078685d # Parent fc8e461200c7262246ebd610100bcf9a75ded461 # EXP-Topic extrameta # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 3 of 3 V2] copies: extract an explicit `computechangesetfilesremoved` method from context

# HG changeset patch # User Pierre-Yves David # Date 1560343372 -3600 # Wed Jun 12 13:42:52 2019 +0100 # Node ID 961d24dfe801ac0c5ad5737d98d553075cef4089 # Parent f6b2517c3651915610cee753ff8351e90078685d # EXP-Topic extrameta # Available At https://bitbucket.org/octobus/mercurial-devel/ #

D6712: config: fix defaultvalue template keyword

marmoute added a comment. For some reasons, my previous comment seems to have never made it to phabricator: You description says the changesets does three things. So it should be three different changesets. Can you split them ? I don't understand why we are adding a warning here.