D6863: py3: byte-prefix sanitisation regexes in phabricator.py

Closed by commit rHG04c6de38734d: py3: byte-prefix sanitisation regexes in phabricator.py (authored by Kwan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6870: tests: recognize DNS timeouts as well

joerg.sonnenberger created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6870 AFFECTED FILES tests/test-clonebundles.t CHANGE DETAILS diff --git

D6869: py3: pass a bytestring into querydrev instead of a string that'll TypeError

Closed by commit rHG6fb281f39c25: py3: pass a bytestring into querydrev instead of a string thatll TypeError (authored by Kwan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D6868: py3: add test demonstrating TypeError when phabsending skips unchanged commits

rEmail\":\"test\"},\"1990\":{\"id\":\"1990\",\"revisionID\":\"1253\",\"dateCreated\":\"1559939219\",\"dateModified\":\"1559939221\",\"sourceControlBaseRevision\":null,\"sourceControlPath\"

D6869: py3: pass a bytestring into querydrev instead of a string that'll TypeError

Kwan created this revision. Kwan added a comment. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. For stable REVISION SUMMARY This was a regression I introduced in c19d259fd6ad

D6868: py3: add test demonstrating TypeError when phabsending skips unchanged commits

25eb9799c9961b5465d4e6e40\"],\"time\":0}}},\"authorName\":\"test\",\"authorEmail\":\"test\"},\"1990\":{\"id\":\"1990\",\"revisionID\":\"1253\",\"dateCreated\":\"1559939219\",\"dateModified\":\&q

D6867: transaction: detect an attempt to truncate-to-extend on playback, raise error

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY On some networked filesystems, writes can have delayed finalization/confirmation and write races can occur such that a remote modification will "win" and

D6866: osutil: tolerate Py_GetArgcArgv not being set up properly

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6866 AFFECTED FILES mercurial/cext/osutil.c CHANGE DETAILS diff --git a/mercurial/cext/osutil.c

D6865: osutil: allow disabling setprocname via a define passed to the compiler

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In some situations, we run a custom python launcher that appears to not set up Py_GetArgcArgv correctly. We then proceed to promptly crash when we attempt to

D6864: py3: don't double-convert "opts" to bytes

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The "opts" are already converted to bytes at the beginning of the function. Doing it twice results in a crash, which makes test-uncommit.t fail. The extra

mercurial@42948: 9 new changesets

9 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/c04e0836f039 changeset: 42940:c04e0836f039 user:David Demelier date:Tue Sep 17 10:47:31 2019 + summary: archive: add XZ support if built with Python 3

D6863: py3: byte-prefix sanitisation regexes in phabricator.py

Kwan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY So it doesn't die with "TypeError: cannot use a string pattern on a bytes-like object". REPOSITORY rHG Mercurial REVISION DETAIL

D6848: narrow: add option for automatically removing unused includes

Closed by commit rHG40f78072fda9: narrow: add option for automatically removing unused includes (authored by martinvonz). martinvonz marked an inline comment as done. This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6862: tests: clean up built binaries after running test-fuzz-targets.t

Closed by commit rHG39cab871e880: tests: clean up built binaries after running test-fuzz-targets.t (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6861: fastannotate: remove support for flock() locking

Closed by commit rHG0152a907f714: fastannotate: remove support for flock() locking (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6861?vs=16567=16572 CHANGES

D6860: remotefilelog: remove dead code for using flock() for locking

Closed by commit rHG5316f9ff3e48: remotefilelog: remove dead code for using flock() for locking (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC)

Closed by commit rHGc2676b5a9f59: narrow: dont hexify paths and double-hexify known nodes on wire (BC) (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6862: tests: clean up built binaries after running test-fuzz-targets.t

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Most users won't notice a change here because they won't have the fuzzer infra, but by good fortune my workstation has the required bits and keeps leaving the

D6861: fastannotate: remove support for flock() locking

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We've seen enough weirdness in CI with flock for remotefilelog that I'm now of the opinion we should just stop using flock() everywhere until someone has a

D6860: remotefilelog: remove dead code for using flock() for locking

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6860 AFFECTED FILES hgext/remotefilelog/extutil.py CHANGE DETAILS diff --git

D6844: remotefilelog: replace repack lock to solve race condition

Closed by commit rHG5fadf6103790: remotefilelog: replace repack lock to solve race condition (authored by lothiraldan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6848: narrow: add option for automatically removing unused includes

martinvonz added inline comments. martinvonz marked an inline comment as done. INLINE COMMENTS > pulkit wrote in narrowcommands.py:369 > sorry, but `currently visible commits` sounds like not correct as this can be > used in case of non-ellipses repository also. Good point. I've updated this a

D6848: narrow: add option for automatically removing unused includes

martinvonz updated this revision to Diff 16564. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6848?vs=16563=16564 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6848/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6848 AFFECTED

D6848: narrow: add option for automatically removing unused includes

pulkit added inline comments. INLINE COMMENTS > narrowcommands.py:369 > +If --auto-remove-includes is specified, then those includes that don't > match > +any files modified by currently visible commits will be added to the set > of > +explicitly specified includes to remove.

D6814: revlog: add a `sidedata` parameters to addrevision

This revision now requires changes to proceed. durin42 added inline comments. durin42 requested changes to this revision. INLINE COMMENTS > remotefilelog.py:132 > def addrevision(self, text, transaction, linknode, p1, p2, > cachedelta=None, > -node=None,

Re: [PATCH 2 of 2] perf: add a --stats argument to perfhelper-pathcopies

queued these, thanks > On Sep 17, 2019, at 12:48, Pierre-Yves David > wrote: > > # HG changeset patch > # User Pierre-Yves David > # Date 1568738190 -7200 > # Tue Sep 17 18:36:30 2019 +0200 > # Node ID 4b7259822c49347ad30219a89d3e791730438e75 > # Parent

D6848: narrow: add option for automatically removing unused includes

martinvonz edited the summary of this revision. martinvonz marked 2 inline comments as done. martinvonz updated this revision to Diff 16563. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6848?vs=16536=16563 CHANGES SINCE LAST ACTION

D6848: narrow: add option for automatically removing unused includes

martinvonz added inline comments. INLINE COMMENTS > pulkit wrote in narrowcommands.py:331 > Following pattern of other flags, `auto-removeinclude(s)` seems better. I was also wondering about that. Maybe those should be changed instead? I'm not sure, but I think we're slowly transitioning

D6848: narrow: add option for automatically removing unused includes

pulkit added inline comments. INLINE COMMENTS > narrowcommands.py:331 > ('', 'removeinclude', [], _('old paths to no longer include')), > + ('', 'auto-remove-includes', False, > + _('automatically choose unused includes to remove (EXPERIMENTAL)')), Following pattern of other

D6848: narrow: add option for automatically removing unused includes

martinvonz added inline comments. INLINE COMMENTS > pulkit wrote in narrowcommands.py:332 > Can you add some help text below on how these unused includes are calculated? Even though it's marked EXPERIMENTAL? Or maybe I should do that and just drop the EXPERIMENTAL since the whole feature

D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC)

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. In D6851#100690 , @idlsoft wrote: >>> Just `tracked --add-include`. A workaround to simplify the upgrade would be to change

D6848: narrow: add option for automatically removing unused includes

pulkit added inline comments. INLINE COMMENTS > narrowcommands.py:332 > + ('', 'auto-remove-includes', False, > + _('automatically choose unused includes to remove (EXPERIMENTAL)')), > ('', 'addexclude', [], _('new paths to exclude')), Can you add some help text below on how

Re: [PATCH] archive: add XZ support if built with Python 3

On Tue, Sep 17, 2019 at 7:16 AM Augie Fackler wrote: > > > > On Sep 17, 2019, at 06:48, David Demelier wrote: > > > > # HG changeset patch > > # User David Demelier > > # Date 1568717251 0 > > # Tue Sep 17 10:47:31 2019 + > > # Node ID c0398aef7f0977b5f076b15638762773dde7d5b6 > > #

[PATCH 1 of 2] perf: add a --stats argument to perfhelper-mergecopies

# HG changeset patch # User Pierre-Yves David # Date 1568706570 -7200 # Tue Sep 17 09:49:30 2019 +0200 # Node ID b4757cd4ef21160461bb0c6901719d3cd2ffd3f8 # Parent 181ee2118a96c4b52bbd6d7b5a47e87f2e1d77e9 # EXP-Topic copy-perf # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 2 of 2] perf: add a --stats argument to perfhelper-pathcopies

# HG changeset patch # User Pierre-Yves David # Date 1568738190 -7200 # Tue Sep 17 18:36:30 2019 +0200 # Node ID 4b7259822c49347ad30219a89d3e791730438e75 # Parent b4757cd4ef21160461bb0c6901719d3cd2ffd3f8 # EXP-Topic copy-perf # Available At https://bitbucket.org/octobus/mercurial-devel/ #

mercurial@42939: 8 new changesets

8 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/e4803231f538 changeset: 42932:e4803231f538 user:Matt Harbison date:Sat Sep 14 15:13:16 2019 -0400 summary: amend: add option to update to the current user

Re: [PATCH] archive: add XZ support if built with Python 3

> On Sep 17, 2019, at 06:48, David Demelier wrote: > > # HG changeset patch > # User David Demelier > # Date 1568717251 0 > # Tue Sep 17 10:47:31 2019 + > # Node ID c0398aef7f0977b5f076b15638762773dde7d5b6 > # Parent 181ee2118a96c4b52bbd6d7b5a47e87f2e1d77e9 > archive: add XZ support

D6709: config: add --registered flag to show all known configs

pulkit added a comment. In D6709#100698 , @av6 wrote: > And to make the review process easier, I propose doing this in 3 or 4 patches: > > - adding `--registered`: will simply show all registered options in key=value format > - adding

[PATCH] archive: add XZ support if built with Python 3

# HG changeset patch # User David Demelier # Date 1568717251 0 # Tue Sep 17 10:47:31 2019 + # Node ID c0398aef7f0977b5f076b15638762773dde7d5b6 # Parent 181ee2118a96c4b52bbd6d7b5a47e87f2e1d77e9 archive: add XZ support if built with Python 3 diff -r 181ee2118a96 -r c0398aef7f09

D6709: config: add --registered flag to show all known configs

marmoute added a comment. In D6709#100698 , @av6 wrote: > In D6709#100618 , @marmoute wrote: > >> In D6709#99199 , @av6 wrote: >> >>> I'm strongly

D6859: rust-cpython: mark PySharedState as Sync so &'PySharedState can be Send (RFC)

Alphare added a comment. It is indeed `Sync` because the `py_class!` macro forces us to have a reference to the GIL at the type level to access the data attributes, but I would also like to be extra sure and have someone else confirm it. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6709: config: add --registered flag to show all known configs

av6 added a comment. In D6709#100618 , @marmoute wrote: > In D6709#99199 , @av6 wrote: > >> I'm strongly -1 on adding qualifiers straight to the keys. The primary usage scenario here is scripts