D7408: extensions: hide two confusing import statements from pytype

dlax added a comment. In D7408#109565 , @indygreg wrote: > Where does `hgext.__index__` come from?! This is generated by setup.py, apparently only when building with py2exe. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://

Re: Line buffering not supported in binary mode on Python 3

On Sat, Nov 16, 2019 at 4:26 PM Manuel Jacob wrote: > Python 3’s IO implementation doesn’t support line buffering in binary > mode. On Python 3.8, this results in a RuntimeWarning, breaking > test-ssh-proto.t. Here are the tracebacks for the two occurences of the > warning: > >Traceback (mos

mercurial@43677: new changeset (1 on stable)

New changeset (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/0f82b29f7494 changeset: 43677:0f82b29f7494 branch: stable tag: tip parent: 43668:53607fd3ec6c user:Kim Alvefur date:Wed Nov 13 22:40:32 2019 +0100 summary: zeroconf: fix tra

D7199: lock: fix race in lock-breaking code

valentin.gatienbaron added a comment. Thanks for the review. Did something go wrong in a rebase? I'm confused as to why there's two `self.vfs.unlink` calls in the diff displayed by phabricator. I have read the paper you mention, and I have seen repositories get corrupted for these kinds

D7199: lock: fix race in lock-breaking code

Closed by commit rHG355a6ef12ba9: lock: fix race in lock-breaking code (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D7199?vs=17496&id=18232#toc REPOSITORY rHG Mercurial CH

D7198: lock: refactor in preparation for next commit

Closed by commit rHGcd822413b9aa: lock: refactor in preparation for next commit (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7198?vs=17495&id=18

D7199: lock: fix race in lock-breaking code

This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. Thank you for tracking down this issue and for the detailed commit message! I agree there is a race between 2 processes creating the lock and that we need to verify the created lock

D7198: lock: refactor in preparation for next commit

This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. This looks like a non-behavior-changing refactor. Thanks also for the switch to a context manager, which is more robust. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://

D7407: debugcommands: add assertions to convince pytype peer is not None

Closed by commit rHG23ad4f0c1578: debugcommands: add assertions to convince pytype peer is not None (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7407?vs=1815

D7385: debugcommands: suppress import errors for pytype

Closed by commit rHGa9b14ef701d1: debugcommands: suppress import errors for pytype (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7385?vs=18157&id=18226 CHANG

D7410: extensions: suppress a pytype failure due to a typeshed bug

Closed by commit rHGda5ccc591cff: extensions: suppress a pytype failure due to a typeshed bug (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7410?vs=18159&id=1

D7409: dispatch: add some assertions to give pytype a helping hand

Closed by commit rHGac8fd215a776: dispatch: add some assertions to give pytype a helping hand (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7409?vs=18102&id=1

D7381: cmdutil: add a pytype annotation to help out some callsites

Closed by commit rHGa58d2361b231: cmdutil: add a pytype annotation to help out some callsites (authored by durin42). durin42 marked an inline comment as done. This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://

D7408: extensions: hide two confusing import statements from pytype

Closed by commit rHG1ea33dff7841: extensions: hide two confusing import statements from pytype (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7408?vs=18101&id=

D7429: py3: use '%d' for formatting a revnum in `hg co --date` code

Closed by commit rHG0c25e3404e23: py3: use '%d' for formatting a revnum in `hg co --date` code (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7429?vs=18155&

D7383: state: add a pytype annotation

Closed by commit rHG127d46468a45: state: add a pytype annotation (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7383?vs=18070&id=18225 CHANGES SINCE LAST ACTI

D7382: logcmdutil: add a type annotation

Closed by commit rHGc9301ac73b95: logcmdutil: add a type annotation (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7382?vs=18098&id=18224 CHANGES SINCE LAST A

D7374: hghave: add a check for the `xz` compression utility

Closed by commit rHG21e05aabef8c: hghave: add a check for the `xz` compression utility (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7374?vs=18055&id=1822

D7454: py3: send bytes from Rust-created warning patterns

Closed by commit rHGdc4e74d0ef96: py3: send bytes from Rust-created warning patterns (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7454?vs=18210&id=18220 CHA

D7453: py3: pass bytes to `configint` and `configbool`

Closed by commit rHG794426e96970: py3: pass bytes to `configint` and `configbool` (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7453?vs=18209&id=18219 CHANGE

D7296: pycompat: kludge around pytype being confused by __new__

indygreg added a comment. @durin42 I just queued most of the remaining patches in this series. This one still needs your attention, it appears. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7296/new/ REVISION DETAIL https://phab.mercurial-scm.org/D

D7408: extensions: hide two confusing import statements from pytype

This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. Where does `hgext.__index__` come from?! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7408/new/ REVISION DETAIL https://phab.mercurial-scm.o

D7374: hghave: add a check for the `xz` compression utility

This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. Regarding nested conditionals, you could do something like `#if py3 xz`. But then we wouldn't have test coverage of Mercurial itself generating lzma, which is built in to Python 3. So t

mercurial@43676: 8 new changesets

8 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/8273680059b2 changeset: 43669:8273680059b2 parent: 43665:f37da59a36d9 user:Martin von Zweigbergk date:Thu Nov 14 17:30:52 2019 -0800 summary: help: remove references to default.d/ from user-facing

Re: [PATCH 3 of 3] hgweb: add diffs to the json changeset template

queued, thanks > On Nov 15, 2019, at 16:02, Jordi Gutiérrez Hermoso wrote: > > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1573851536 18000 > # Fri Nov 15 15:58:56 2019 -0500 > # Node ID df8d762ab0683fb2fe337952b906e2944f89aaa2 > # Parent 6a9122d3cd3639ddacb8768c573ea9e

mercurial@43668: new changeset (1 on stable)

New changeset (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/53607fd3ec6c changeset: 43668:53607fd3ec6c branch: stable tag: tip user:Manuel Jacob date:Sun Nov 17 19:55:01 2019 +0100 summary: cffi: fix build on Python 3 -- Repository URL:

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz added a comment. In D7144#109543 , @marmoute wrote: > I am working on a non-experimental series that get things more contained in repo/changectx to robustness. It also contains tests making sure we do not regress. I think we could

D7144: status: use unfiltered repo if we're getting status of working copy

marmoute added a comment. I am working on a non-experimental series that get things more contained in repo/changectx to robustness. It also contains tests making sure we do not regress. I think we could so something really robust, efficient and transparent, but having this and that filtered

D7432: templates: make {indent("", " ")} be empty

Closed by commit rHGfa246ada356b: templates: make {indent("", " ")} be empty (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7432?vs=18208&id=18218 CHANGES

D7447: tests: verify that Python scripts are blackened

Closed by commit rHG2d8d4e08c493: tests: verify that Python scripts are blackened (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7447?vs=18198&id=18215 CHANG

D7446: black: blacken scripts

Closed by commit rHG47ef023d0165: black: blacken scripts (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7446?vs=18197&id=18214 CHANGES SINCE LAST ACTION htt

D7431: tests: document behavior of indent() with empty first line

Closed by commit rHG0fd9e7a1cf36: tests: document behavior of indent() with empty first line (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7431?vs=18164&id

D7448: tests: check for Windows line endings

Closed by commit rHGf0b33e5f0cf4: tests: check for Windows line endings (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7448?vs=18199&id=18216 CHANGES SINCE L

D7428: tags: don't check for clean files when checking for dirty working copy

Closed by commit rHGf7d7f9d23a7a: tags: don't check for clean files when checking for dirty working copy (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7428

D7445: doc: don't use mutable default arguments

Closed by commit rHG15cccbacd5ce: doc: don't use mutable default arguments (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7445?vs=18196&id=18213 CHANGES SINC

D7427: branchmap: make "closed" a set from beginning instead of converting from list

Closed by commit rHG5cdc3c1292f6: branchmap: make "closed" a set from beginning instead of converting from list (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D7453: py3: pass bytes to `configint` and `configbool`

Alphare created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Both functions require bytes, even in Python 3. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7453 AFFECTED FILES

D7454: py3: send bytes from Rust-created warning patterns

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Python code expects bytes in both Python 2 and Python 3, so we should send bytes. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

Re: [PATCH stable] cffi: fix build on Python 3

On Sun, 17 Nov 2019 19:57:08 +0100, Manuel Jacob wrote: > # HG changeset patch > # User Manuel Jacob > # Date 1574016901 -3600 > # Sun Nov 17 19:55:01 2019 +0100 > # Branch stable > # Node ID ef297356c8605f036417f7b839c87ba8f9ffad07 > # Parent 856cce0c255cc6ffbe164764cc152e3011c59fd7 > cffi:

D7439: dirstate: include explicit matches in match.traversedir calls

Alphare added inline comments. Alphare accepted this revision. INLINE COMMENTS > martinvonz wrote in dirstate.py:942 > It's on line 916 in this file. Indeed. Don't know what happened. Thanks REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7439/new/ REVIS

D7439: dirstate: include explicit matches in match.traversedir calls

martinvonz added inline comments. martinvonz marked an inline comment as done. INLINE COMMENTS > Alphare wrote in dirstate.py:942 > Where is `matchtdir` defined? I don't see it on any of the patches in the > stack. It's on line 916 in this file. REPOSITORY rHG Mercurial CHANGES SINCE LAST A

D7439: dirstate: include explicit matches in match.traversedir calls

Alphare added inline comments. INLINE COMMENTS > dirstate.py:942 > results, work, dirsnotfound = self._walkexplicit(match, subrepos) > +if matchtdir: > +for d in work: Where is `matchtdir` defined? I don't see it on any of the patches in the stack. REPOSITORY rHG