D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix

2019-11-22 Thread yuja (Yuya Nishihara)
yuja added a comment. Many unhandled results: warning: unused `std::result::Result` that must be used --> hg-core/src/dirstate/dirs_multiset.rs:42:21 | 42 | multiset.add_path(filename); |

Re: D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix

2019-11-22 Thread Yuya Nishihara
Many unhandled results: ``` warning: unused `std::result::Result` that must be used --> hg-core/src/dirstate/dirs_multiset.rs:42:21 | 42 | multiset.add_path(filename); | | = note: #[warn(unused_must_use)] on by

D7510: windows: suppress pytype warnings for Windows imports and functions

2019-11-22 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. I'm not sure if there are plans to vendor *.pyi files. Maybe that could be used to backfill platform specific modules instead of doing this. But for now is seems better to get the error count and blacklist length reduced. REPOSITORY rHG Mercurial CHANGES

D7512: exchange: guard against method invocation on `b2caps=None` args

2019-11-22 Thread mharbison72 (Matt Harbison)
mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I couldn't figure out how these are called, but the value is pretty obviously set at least for the cases that have tests. REPOSITORY rHG Mercurial

D7511: exchange: eliminate some bytes.format() calls

2019-11-22 Thread mharbison72 (Matt Harbison)
mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7511 AFFECTED FILES mercurial/exchange.py CHANGE DETAILS diff --git a/mercurial/exchange.py

D7510: windows: suppress pytype warnings for Windows imports and functions

2019-11-22 Thread mharbison72 (Matt Harbison)
mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This should allow the modules to not be excluded, and not generate complaints on non Windows platforms. REPOSITORY rHG Mercurial REVISION DETAIL

mercurial@43736: new changeset

2019-11-22 Thread Mercurial Commits
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/640bae94f2f3 changeset: 43736:640bae94f2f3 bookmark:@ tag: tip user:Augie Fackler date:Thu Nov 21 23:35:29 2019 -0500 summary: cleanup: update references to /help/ that should now be

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In D7506#110288 , @mharbison72 wrote: > I'm not sure why, but this version seems to also show obsolete revisions. I've got a bunch of `x` and `*` nodes in hg-committed right now. I didn't see that before,

D7481: localrepo: recognize trivial "null" queries in `anyrev`

2019-11-22 Thread marmoute (Pierre-Yves David)
Closed by commit rHGc0e04f07a2d4: localrepo: recognize trivial null queries in `anyrev` (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7481?vs=18288=18333

D7480: localrepo: also fastpath `nullrev` in __getitem__

2019-11-22 Thread marmoute (Pierre-Yves David)
Closed by commit rHG099e96103085: localrepo: also fastpath `nullrev` in __getitem__ (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7480?vs=18287=18332

D7482: repoview: add a test that access actual changeset data of `null`

2019-11-22 Thread marmoute (Pierre-Yves David)
Closed by commit rHGf612a044a5ab: repoview: add a test that access actual changeset data of `null` (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7477: util: add an optional `prefix` argument to debugstacktrace

2019-11-22 Thread marmoute (Pierre-Yves David)
Closed by commit rHG6301ea7a26b6: util: add an optional `prefix` argument to debugstacktrace (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7479: repoview: add a test to track operation not supposed to trigger filtering

2019-11-22 Thread marmoute (Pierre-Yves David)
Closed by commit rHGa7a4b3b28c52: repoview: add a test to track operation not supposed to trigger filtering (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7478: repoview: display stack trace along side the debug message

2019-11-22 Thread marmoute (Pierre-Yves David)
Closed by commit rHGb9e4226ff1db: repoview: display stack trace along side the debug message (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7475: localrepo: extract handling of some special value in __getitem__

2019-11-22 Thread marmoute (Pierre-Yves David)
Closed by commit rHG8e2df30694de: localrepo: extract handling of some special value in __getitem__ (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7474: localrepo: extract handling of some special value in __getitem__

2019-11-22 Thread marmoute (Pierre-Yves David)
Closed by commit rHGb7d0aa525435: localrepo: extract handling of some special value in __getitem__ (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7476: repoview: add a 'devel.debug.repo-filter' option

2019-11-22 Thread marmoute (Pierre-Yves David)
Closed by commit rHG0ddd97e45cc6: repoview: add a devel.debug.repo-filter option (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7476?vs=18283=18328 CHANGES

D7473: localrepo: add some basic comment for block in __getitem__

2019-11-22 Thread marmoute (Pierre-Yves David)
Closed by commit rHG7d6465eda585: localrepo: add some basic comment for block in __getitem__ (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7483: changectx: add a "maybe filtered" filtered attribute

2019-11-22 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > context.py:503 > +repo = self._repo.unfiltered() > +return repo.changelog.changelogrevision(self.rev()) > Before I accept more of this series, I'd like others to think about the potential alternative solution of passing in

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. I'm not sure why, but this version seems to also show obsolete revisions. I've got a bunch of `x` and `*` nodes in hg-committed right now. I didn't see that before, although that was on a different clone that I don't have access to now. REPOSITORY rHG

[Bug 6228] New: "/help" link for config _command_ goes to help for config _topic_

2019-11-22 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6228 Bug ID: 6228 Summary: "/help" link for config _command_ goes to help for config _topic_ Product: Mercurial Version: 5.2 Hardware: PC URL:

D7500: repoview: add a test for changelog filtering trigger for `hg annotate`

2019-11-22 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D7500#110252 , @marmoute wrote: > Yes we could. Please do if you don't mind. Thanks. > (right now, the test are introduced right before the series of change fixing it (or right after the last chngeset

D7509: windows: further build fixes for the WiX installer

2019-11-22 Thread durin42 (Augie Fackler)
Closed by commit rHGe8373b215a67: windows: further build fixes for the WiX installer (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7509: windows: further build fixes for the WiX installer

2019-11-22 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With these fixes in place, the .msi actually builds for me again. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7509 AFFECTED

D7508: relnotes: add note about changes to match.{explicit, reverse}dir

2019-11-22 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 18322. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7508?vs=18319=18322 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7508/new/ REVISION DETAIL

D7295: pytype: add a (very slow) test that executes pytype

2019-11-22 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In D7295#107482 , @indygreg wrote: > Since type checking is slow (but there are state files we can reuse to speed things up), we'll need to figure out how to make this work in CI. But I have no doubt we can

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In D7506#110249 , @dlax wrote: > In D7506#110225 , @mharbison72 wrote: > >> I'm also interested in coloring the status value, but I can tinker with that after it's

D7500: repoview: add a test for changelog filtering trigger for `hg annotate`

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute added a comment. Yes we could. (right now, the test are introduced right before the series of change fixing it (or right after the last chngeset in that series) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7500/new/ REVISION DETAIL

D7507: phabricator: add a "phabstatus" template keyword

2019-11-22 Thread dlax (Denis Laxalde)
dlax updated this revision to Diff 18321. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7507?vs=18316=18321 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7507/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7507

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread dlax (Denis Laxalde)
dlax updated this revision to Diff 18320. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7506?vs=18315=18320 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7506/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7506

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread dlax (Denis Laxalde)
dlax added a comment. dlax planned changes to this revision. In D7506#110225 , @mharbison72 wrote: > I like it. Thanks! > Any idea why the changeset isn't colored, unlike `hg show stack`? It might also be a little more readable if

D7508: relnotes: add note about changes to match.{explicit, reverse}dir

2019-11-22 Thread dlax (Denis Laxalde)
dlax added inline comments. INLINE COMMENTS > next:22 > + also called when only `explicitdir` used to be called. That may > + mean that you can simple remove the use of `explicitdir` if you > + were already using `traversedir`. simple -> simply? REPOSITORY rHG Mercurial CHANGES SINCE

D7500: repoview: add a test for changelog filtering trigger for `hg annotate`

2019-11-22 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. Could we just add all these tests from the beginning? It seems they would look almost the same if added early in the series, just with some extra "getting filtered repo" lines (or whatever they say). If the tests were added earlier, it would be clearer which

D7508: relnotes: add note about changes to match.{explicit, reverse}dir

2019-11-22 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7508 AFFECTED FILES relnotes/next CHANGE DETAILS diff --git a/relnotes/next

mercurial@43735: 11 new changesets (1 on stable)

2019-11-22 Thread Mercurial Commits
11 new changesets (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/71dbd6f6fcb8 changeset: 43725:71dbd6f6fcb8 parent: 43718:d155bf11cf22 user:Denis Laxalde date:Thu Nov 21 09:25:50 2019 +0100 summary: import: add a --secret option

D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > Alphare wrote in lib.rs:117 > This patch is a minimal effort to stick to the C and Python implementations > until a decision is reached. Should we decide to keep this code, I would be > for having the path included in the error. This seems

D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix

2019-11-22 Thread Raphaël Gomès
Alphare added inline comments. INLINE COMMENTS > marmoute wrote in lib.rs:117 > Should we also have the path included in that error ? This patch is a minimal effort to stick to the C and Python implementations until a decision is reached. Should we decide to keep this code, I would be for

D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix

2019-11-22 Thread Raphaël Gomès
Closed by commit rHG20a3bf5e71d6: rust-dirs: address failing tests for `dirs` impl with a temporary fix (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7472: cleanup: update references to /help/ that should now be /helptext/

2019-11-22 Thread durin42 (Augie Fackler)
Closed by commit rHG640bae94f2f3: cleanup: update references to /help/ that should now be /helptext/ (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. I like it. Any idea why the changeset isn't colored, unlike `hg show stack`? It might also be a little more readable if the URI and status line were tabbed in, but maybe colored cset hashes would make that unnecessary? I'm also interested in coloring

D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > lib.rs:117 > +} > +} > } Should we also have the path included in that error ? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7503/new/ REVISION DETAIL

D7507: phabricator: add a "phabstatus" template keyword

2019-11-22 Thread dlax (Denis Laxalde)
dlax updated this revision to Diff 18316. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7507?vs=18314=18316 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7507/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7507

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread dlax (Denis Laxalde)
dlax updated this revision to Diff 18315. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7506?vs=18313=18315 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7506/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7506

D7507: phabricator: add a "phabstatus" template keyword

2019-11-22 Thread dlax (Denis Laxalde)
dlax created this revision. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We add a "phabstatus" template keyword, returning an object with "url" and "status" keys. This is quite similar to "phabreview" template keyword, but it

D7506: phabricator: add a "phabstatus" show view

2019-11-22 Thread dlax (Denis Laxalde)
dlax created this revision. Herald added subscribers: mercurial-devel, Kwan, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We add a "phabstatus" show view (called as "hg show phabstatus") which renders a dag with underway revisions associated with a differential

D7505: logcmdutil: call _exthook() in changesettemplater

2019-11-22 Thread dlax (Denis Laxalde)
dlax created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Class changesetprinter has an _exthook() method that is called in _show() before the patch is displayed. Call the method as well in changesettemplater._show().

D7504: py3: replace %s by %r on binary format string when needed

2019-11-22 Thread matclab (Mathieu Clabaut)
matclab added a comment. matclab abandoned this revision. INLINE COMMENTS > dlax wrote in localrepo.py:1571 > The first `%s` was correct I think because `changeid` can be a bytes. > > For the second one, if `%r` is the way to go (I'm not sure), maybe we can > drop `pycompat.sysstr()`? I'm

mercurial@43724: 3 new changesets (3 on stable)

2019-11-22 Thread Mercurial Commits
3 new changesets (3 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/aff3f6e407a1 changeset: 43722:aff3f6e407a1 branch: stable user:Martin von Zweigbergk date:Wed Nov 20 08:11:21 2019 -0800 summary: py3: wrap a __func__ in sysbytes() before logging as

D7504: py3: replace %s by %r on binary format string when needed

2019-11-22 Thread dlax (Denis Laxalde)
This revision now requires changes to proceed. dlax added a comment. dlax requested changes to this revision. nit: the actual PEP is pep-0461 (https://www.python.org/dev/peps/pep-0461/) INLINE COMMENTS > localrepo.py:1571 > +b"unsupported changeid '%r' of type %r" >

Re: [PATCH STABLE V2] singlehead: making config item a bool again

2019-11-22 Thread Yuya Nishihara
On Thu, 21 Nov 2019 14:43:15 +0100, Georges Racinet wrote: > # HG changeset patch > # User Georges Racinet > # Date 1574273222 -3600 > # Wed Nov 20 19:07:02 2019 +0100 > # Branch stable > # Node ID 0509d93280bfd9df473ad4ee5b00d0d1d1e8e291 > # Parent ca3dca416f8d5863ca6f5a4a6a6bb835dcd5feeb

D7504: py3: replace %s by %r on binary format string when needed

2019-11-22 Thread matclab (Mathieu Clabaut)
matclab created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For some error, mercurial displays the type of a variable. However the formatting string used was "%s" which is not compatible with `type` and lead to an

D7051: phabricator: remove tests and all recordings

2019-11-22 Thread dlax (Denis Laxalde)
dlax added a comment. > The next commit is going to change the format of conduit API requests so none of the VCR recordings will match and all the tests will fail. @Kwan, it seems to me that there is no longer any recording data nor actual test from this changeset. Did you plan to add

D7503: rust-dirs: address failing tests for `dirs` impl with a temporary fix

2019-11-22 Thread Raphaël Gomès
Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY https://phab.mercurial-scm.org/D7252 (5d40317d42b7083b49467502549e25f144888cb3

D7501: changectx: use unfiltered changelog to walk ancestors in annotate

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since we are only walking ancestors, it is safe to use an unfiltered repository. (Because if the original rev is not filtered, none of its ancestors will be).

D7502: changectx: mark parent of changesets as non filtered

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If a node is not filtered, its parents cannot be filtered. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7502 AFFECTED FILES

D7492: localrepo: also fastpath access to working copy parents when possible

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If the filter level garantee that the workig copy parents will be visible, we allow fast path access to them. With this change multiple commands can now run

D7498: localrepo: also fast past the parents of working copies parents

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are a descent odds that their will be needed too. So we also cache and fastpath them. REPOSITORY rHG Mercurial REVISION DETAIL

D7500: repoview: add a test for changelog filtering trigger for `hg annotate`

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7500 AFFECTED FILES tests/test-repo-filters-tiptoe.t CHANGE DETAILS diff --git

D7495: localrepo: recognize trivial request for '.'

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Same logic as for `null`, this is a command request and skipping the revset logic can avoid triggering the changelog filtering logic. REPOSITORY rHG

D7499: repoview: test triggering of filter computation for `hg export`

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This already skips changelog filtering. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7499 AFFECTED FILES

D7497: repoview: add a test for filtering computation for `hg diff --change`

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY That one still trigger the filtering. We will fix this in later changesets. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7497

D7494: localrepo: fastpath access to "."

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY "." is just an aliast for `p1(wdir()`, let us handle it that way. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7494 AFFECTED

D7496: repoview: add a test for filtering computation for `hg diff`

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The recent works means it is -already- not triggering filtering computation :-) REPOSITORY rHG Mercurial REVISION DETAIL

D7491: changectx: mark the parents of the working copy as non filtered

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If we successfully accessed the working copy, its parents are not filtered. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7491

D7493: repoview: test changelog filtering triggered by a lookup to '.'

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a commonly used value, we should deal with it properly. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7493 AFFECTED FILES

D7488: localrepo: introduce a `_quick_access_changeid` property

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Having faster access to `null` is cute… but limited. We want to speedup access to more useful revision, like `.`. We start with turning the fast path for

D7490: repoview: add an explicit set of all filter that show the wc parents

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The `visible` set will always show the working copy parents. We record this in a specific set. This will allow to fast path some access. REPOSITORY rHG

D7487: changectx: use unfiltered changelog to access parents of unfiltered revs

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If a revision is not filtered, we know that its parents are not either. So we can take a shortcut. This shortcut avoid the computation of all filtered revs in

D7486: locarepo: also fastpath `nullid` lookup in __getitem__

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We already use that fastpath for `"null"` and `nullrev`, using it for `nullid` is similar. REPOSITORY rHG Mercurial REVISION DETAIL

D7489: repoview: add test for filtering computation when running `hg status`

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7489 AFFECTED FILES tests/test-repo-filters-tiptoe.t CHANGE DETAILS diff --git

D7484: localrepo: mark nullrev has never filtered

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY All repository have a null, and it cannot be filtered. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7484 AFFECTED FILES

D7481: localrepo: recognize trivial "null" queries in `anyrev`

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Bypassing the revset logic for trivial "null" queries means we can avoid to trigger the filtering logic in some cases. REPOSITORY rHG Mercurial

D7483: changectx: add a "maybe filtered" filtered attribute

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are changeset that we know not to be filtered (eg: `null`). In this case, we could access some information without triggering changelog filtering. We add

D7485: repoview: test filtered computation on `hg status --change` call

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One more case to test for. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7485 AFFECTED FILES tests/test-repo-filters-tiptoe.t

D7480: localrepo: also fastpath `nullrev` in __getitem__

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As explained earlier, nullrev will exist in all repository, we do not need any special checking. REPOSITORY rHG Mercurial REVISION DETAIL

D7482: repoview: add a test that access actual changeset data of `null`

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Ideally, we would not trigger filtering here. However some work needs to happens first. REPOSITORY rHG Mercurial REVISION DETAIL

D7477: util: add an optional `prefix` argument to debugstacktrace

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is useful when using it in a specific context. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7477 AFFECTED FILES

D7479: repoview: add a test to track operation not supposed to trigger filtering

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This test will be useful to confirm we removed filtering trigger and to prevent it to come back without us noticing. REPOSITORY rHG Mercurial

D7475: localrepo: extract handling of some special value in __getitem__

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The value "tip" should always be accessible, otherwise there is some problematic bug in the lower level. So we can access this outside of the general

D7478: repoview: display stack trace along side the debug message

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When a filter computation is triggered, If --traceback is provided, we will display a traceback in addition to the debug message. REPOSITORY rHG Mercurial

D7476: repoview: add a 'devel.debug.repo-filter' option

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If set, there will be debug message when a filter computation is triggered. This is going to be useful to remove various filtering trigger and to test they

D7474: localrepo: extract handling of some special value in __getitem__

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The value "null" will always be present in a repository. So this lookup should always succeed and do not need to be in the general try/catch. REPOSITORY rHG

D7473: localrepo: add some basic comment for block in __getitem__

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are different early processing before getting to the core of the function. We highlight that fact. REPOSITORY rHG Mercurial REVISION DETAIL

D7252: dirs: reject consecutive slashes in paths

2019-11-22 Thread marmoute (Pierre-Yves David)
marmoute added a comment. In practice, this means the tests consistently fails when testing with Rust. Can we either have a quick fix of the Rust code or a temporary backout of this (until we Rust code is fixed)? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION