Re: D9573: branchmap: update rev-branch-cache automatically [POC]

2020-12-13 Thread Joerg Sonnenberger
On Sun, Dec 13, 2020 at 06:50:45PM +, joerg.sonnenberger (Joerg Sonnenberger) wrote: > REVISION SUMMARY > Introduce an optional callback in changelog.add and provide it in > localrepo to update the revbranchcache for all new changes. Ignore the > now redundant bundle part.

D9573: branchmap: update rev-branch-cache automatically [POC]

2020-12-13 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Introduce an optional callback in changelog.add and provide it in localrepo to update the revbranchcache for all new changes. Ignore the now

D9572: revlog: support none compression

2020-12-12 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY revlog files had uncompressed revlog entries support since forever, but it wasn't selectable or exposed explicitly. It is occassionally useful for

D9546: cext: match format string for 32bit long platforms

2020-12-08 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9546 AFFECTED FILES mercurial/cext/revlog.c CHANGE DETAILS diff --git

D9445: sidedata: send the correct revision data for wireproto v2

2020-12-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger added a comment. I don't think they are. The main motivation for pushing this one is to ensure that later changes to result in more sidedata doesn't create spurious failures with wireproto v2. As discussed on IRC around the sprint, it is dead at this point, but I'd still

D9532: transaction: windows workaround for missing line iteration support

2020-12-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The mixedfilemodewrapper doesn't support line iteration, so just read the whole file in one go. REPOSITORY rHG Mercurial BRANCH default

D9525: singlehead: introduce option to restrict to public changes

2020-12-05 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The new experimental.single-head-per-branch:public-changes-only option restricts the single-head-per-branch filter to public changesets. This is

Re: [support]: changing author of a commit when rewriting history

2020-12-03 Thread Joerg Sonnenberger
On Fri, Dec 04, 2020 at 01:31:52AM +0100, Antonio Muci wrote: > That would be useful for the tip, thanks. > > I have to to rewrite a commit that is not the last one, like commit 1 in the > example. At least with changeset evolution enabled, you can just update to commit 1, amend it and then

Re: [support]: changing author of a commit when rewriting history

2020-12-03 Thread Joerg Sonnenberger
On Fri, Dec 04, 2020 at 01:10:38AM +0100, Antonio Muci via Mercurial-devel wrote: > I am struggling to find a way to change the author of a commit. hg amend -u ? Joerg ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D9481: relnotes: document better memory use for unbundle

2020-12-01 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9481 AFFECTED FILES relnotes/next CHANGE DETAILS diff --git

D9480: node: import symbols explicitly

2020-12-01 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: durin42. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY There is

D9465: [POC] node: replace nullid and friends with nodeconstants class

2020-11-30 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: durin42. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a reviewer: martinvonz. Herald added subscribers: mercurial-patches, Kwan. Herald added a reviewer:

D9450: cext: isolate hash size in the revlog handling in a single place

2020-11-28 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9450 AFFECTED FILES mercurial/cext/revlog.c CHANGE DETAILS diff --git

D9445: sidedata: send the correct revision data for wireproto v2

2020-11-28 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY When no sidedata is present, rawdata() and revision() are the same. But as soon as sidedata is present, the way it is currently stored will change

D9443: tests: simplify and extend pull-bundle test using debugbuilddag

2020-11-28 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9443 AFFECTED FILES tests/test-pull-bundle.t CHANGE DETAILS diff

D9283: bundle: optional multithreaded compression, ATM zstd-only

2020-11-08 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Compression type can be a huge chunk of "hg bundle", especially when using the higher compression levels. With level=22 and threads=7, the NetBSD

D9282: relnotes: drop 5.6 release entries from next

2020-11-08 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9282 AFFECTED FILES relnotes/next CHANGE DETAILS diff --git

D9275: transaction: drop per-file extra data support

2020-11-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY At the moment, transactions support an optional extra data argument for all files to be stored in addition to the

D9277: transaction: change list of journal entries into a dictionary

2020-11-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The transaction object used to keep a mapping table of path names to journal entries and a list of journal entries consisting of path and file

D9278: transaction: split new files into a separate set

2020-11-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Journal entries with size 0 are common as they represent new revlog files. Move them from the dictionary into a set as the former is more dense.

D9276: transaction: rename find to findoffset and drop backup file support

2020-11-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY transaction.find used to support access to both the regular file and backup file list. They have different

D9258: relnotes: mention improved memory use and underlaying API changes

2020-10-29 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9258 AFFECTED FILES relnotes/next CHANGE DETAILS diff --git

D9237: transaction: only keep file names in-memory for journal [WIP]

2020-10-21 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The offsets are normally only used during rollback and can be read back from disk in that case. The exception is

D9236: utils: helper function to print top memory allocation site

2020-10-21 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The memorytop function uses Python's tracemalloc module to show the source lines / backtraces with the largest remaining allocations. This allows

D9235: revlog: use LRU for the chain cache

2020-10-20 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY For a large repository, this reduces the number of filelog instances and associated data a lot. For a 1% speed

D9231: revlog: extend addgroup() with callback for duplicates

2020-10-20 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The addgroup() interface currently doesn't allow the caller to keep track of duplicated nodes except by looking at

D9233: phases: convert registernew users to use revision sets

2020-10-20 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9233 AFFECTED FILES hgext/convert/hg.py mercurial/changegroup.py

D9232: phases: allow registration and boundary advancement with revsion sets

2020-10-20 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The core internals either use revision sets already or can trivially use them. Use the new interface in cg1unpacker.apply to avoid materializing

Re: [PATCH 3 of 3] revlog: prevent recreating a tuple again and again for each rev

2020-10-11 Thread Joerg Sonnenberger
On Sun, Oct 11, 2020 at 11:32:34AM +0900, Yuya Nishihara wrote: > On Sat, 10 Oct 2020 14:17:24 +0530, Pulkit Goyal wrote: > > # HG changeset patch > > # User Pulkit Goyal <7895pul...@gmail.com> > > # Date 1602252446 -19800 > > # Fri Oct 09 19:37:26 2020 +0530 > > # Node ID

D9162: [WIP] revlog: store new index entries as binary

2020-10-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY For a pure unbundle of the current NetBSD test repository, this results in a 10% peak RSS reduction. Using the C revlog index, it shows 25% peak

D9161: unionrepo: don't insert index tuples with None as int field

2020-10-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9161 AFFECTED FILES mercurial/unionrepo.py CHANGE DETAILS diff --git

D9160: bundlerepo: don't insert index tuples with full nodes as linkrev

2020-10-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9160 AFFECTED FILES mercurial/bundlerepo.py CHANGE DETAILS diff --git

D9155: [WIP] revlog: don't cache parsed tuples in the C module

2020-10-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D9155 AFFECTED FILES mercurial/cext/revlog.c CHANGE DETAILS diff --git

D9154: revlog: pre-compute null revlog item for pure version

2020-10-05 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The dynamically created tuple shows up in memory profiles and the use of nullid prevents the normal constant building to work. REPOSITORY rHG

D9153: unbundle: free temporary objects after use

2020-10-05 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This reduces peak RSS for larger unbundle operations by ~30 Bytes per changeset on AMD64. REPOSITORY rHG Mercurial BRANCH stable REVISION

D9150: tests: skip doctests if not running from a hg repo

2020-10-05 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9150 AFFECTED FILES tests/test-doctest.py CHANGE DETAILS diff --git

D9072: phases: fix performance regression with Python 2.

2020-09-23 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Unlike Python 3, xrange doesn't support efficient "in" and uses a linear time scan instead. Expand the condition to handle it fast. REPOSITORY rHG

Re: The SHA1 replacement plan [Hash function part]

2020-08-05 Thread Joerg Sonnenberger
On Wed, Aug 05, 2020 at 03:24:48PM -0400, Augie Fackler wrote: > > > > On Jul 28, 2020, at 16:23, Joerg Sonnenberger wrote: > > > > On Tue, Jul 28, 2020 at 03:49:58PM -0400, Augie Fackler wrote: > >> > >> > >>> On Jul 28, 2020, at 15:29,

Re: [PATCH] who: remove OpenJDK

2020-07-31 Thread Joerg Sonnenberger
On Fri, Jul 31, 2020 at 06:30:57PM +0200, Antonio Muci via Mercurial-devel wrote: > What concerns me the most are two things: > > 1. scripta manent: when in some years people will google for "mercurial > performance" they will stumble upon JDK considerations, and take them > form granted. What

D8850: dirstate: restore original estimation and update comment

2020-07-30 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The former comment didn't reflect the content of the dirstate entries, the two nodes are a fixed header in the file and not per-entry. Split the

D8849: dirstate: revert change to Rust binding

2020-07-29 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8849 AFFECTED FILES mercurial/dirstate.py CHANGE DETAILS diff --git

Re: The SHA1 replacement plan

2020-07-28 Thread Joerg Sonnenberger
On Tue, Jul 28, 2020 at 03:55:55PM -0400, Josef 'Jeff' Sipek wrote: > On Tue, Jul 28, 2020 at 21:35:51 +0200, Joerg Sonnenberger wrote: > > On Tue, Jul 28, 2020 at 03:02:46PM -0400, Josef 'Jeff' Sipek wrote: > > > On Sun, Jul 26, 2020 at 18:26:51 +0200, Joerg

Re: The SHA1 replacement plan [Hash function part]

2020-07-28 Thread Joerg Sonnenberger
On Tue, Jul 28, 2020 at 03:49:58PM -0400, Augie Fackler wrote: > > > > On Jul 28, 2020, at 15:29, Joerg Sonnenberger wrote: > > > > On Tue, Jul 28, 2020 at 02:31:09PM -0400, Augie Fackler wrote: > >>> The second most widely supported hash function wo

Re: The SHA1 replacement plan [Tests, mercurial.nodes handling, compat]

2020-07-28 Thread Joerg Sonnenberger
On Tue, Jul 28, 2020 at 02:31:09PM -0400, Augie Fackler wrote: > > (2) How to deal with tests > > > > Pretty much every single test in the tree has to be adjusted. Some for > > the new repo flag, but almost all of them for the changed changeset ids > > in one form or another. I was looking at

Re: The SHA1 replacement plan

2020-07-28 Thread Joerg Sonnenberger
On Tue, Jul 28, 2020 at 03:02:46PM -0400, Josef 'Jeff' Sipek wrote: > On Sun, Jul 26, 2020 at 18:26:51 +0200, Joerg Sonnenberger wrote: > ... > > I've attached basic benchmark numbers below. The asm variant is using > > whatever my Threadripper supports in terms of low-lev

Re: The SHA1 replacement plan [Hash function part]

2020-07-28 Thread Joerg Sonnenberger
On Tue, Jul 28, 2020 at 02:31:09PM -0400, Augie Fackler wrote: > > The second most widely supported hash function would be BLAKE2s. > > I've been strongly favoring blake2b for years now. Why prefer s over b? Performance on 32bit platforms of blake2b is ...bad. blake2s works reasonable well on

Re: [PATCH] who: remove OpenJDK

2020-07-26 Thread Joerg Sonnenberger
On Sun, Jul 26, 2020 at 11:12:25AM -0400, Josef 'Jeff' Sipek wrote: > > > I'm guessing that they would have benefited from treemanifest. > > > > From my testing, treemanifests don't help at all. > > They seemed to help with the jdk repo. I'm guessing that jdk has a deeper > nested directories

The SHA1 replacement plan

2020-07-26 Thread Joerg Sonnenberger
Hello all, as you might have seen by various changesets in the recent past, I'm looking actively into the steps required to retire SHA1. The current goal is to focus on new repositories and/or a one-time conversion with the option of partial compatibility with old changeset ids as follow-up. At

Re: [PATCH] who: remove OpenJDK

2020-07-25 Thread Joerg Sonnenberger
On Sat, Jul 25, 2020 at 01:36:32PM -0400, Josef 'Jeff' Sipek wrote: > First off, the clone itself. I cloned it from the official upstream repos. > My internet connection is 150 Mbit/s, the storage is a 3-way ZFS mirror. I > used hg 4.9.1 (py27), and git 2.21.0. (I know, I need to update both.

D8815: dirstate: isolate node len dependency for the pure version

2020-07-24 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY When switching to a 256bit hash function, this still needs adjustment, but concentrates the change in one place. REPOSITORY rHG Mercurial BRANCH

D8801: obsstore: refactor v1 logic to fix 32 byte hash support

2020-07-23 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Refactor the v1 logic to determine the node parsing based on the flag. Move the predecessor out of the fixed part and handle it like the other

D8784: tags: adjust file node cache to have space for 32 bytes node ids

2020-07-21 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The .hgtags processing uses two different caches. The first cache is essentially a global version of all .hgtags files and a textual format without

D8783: storageutil: allow modern hash sizes for fileids

2020-07-21 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8783 AFFECTED FILES mercurial/utils/storageutil.py CHANGE DETAILS

D8782: tests: make flag parsing test more future safe

2020-07-21 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The revlog format contains a number of feature flags, e.g. if general deltas are active. When testing that unknown flags are rejected, use bits

D6259: [POC] revset: on-disk cache for children queries

2020-07-20 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger added a comment. Yes, it's still a POC. I wanted to make sure that it works in the modern world, but I am still considering the idea in the context of larger changes for transactional caches. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D8767: relnotes: extend

2020-07-18 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8767 AFFECTED FILES relnotes/next CHANGE DETAILS diff --git

D8766: manifest: kill one more instance of the old merge hash hack

2020-07-18 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8766 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git

Re: [PATCH 2 of 6] phases: fix error return with no exception from computephases()

2020-07-18 Thread Joerg Sonnenberger
On Sat, Jul 18, 2020 at 07:12:58PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1595063621 -32400 > # Sat Jul 18 18:13:41 2020 +0900 > # Node ID fb15ffcb12fae7e7c73dfbbc271874f0f3418193 > # Parent bf0637f0915c1365c58d37e55f511323af0dc706 > phases: fix

D8760: cext: remove unused variables

2020-07-16 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8760 AFFECTED FILES mercurial/cext/manifest.c mercurial/cext/revlog.c

D8759: status: match category text in the option description

2020-07-16 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The ! category in the main status help text is defined as "missing", so use the same text for the help text of --delete. REPOSITORY rHG Mercurial

D6259: revset: on-disk cache for children queries

2020-07-12 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger retitled this revision from "[POC] revset: on-disk cache for children queries" to "revset: on-disk cache for children queries". joerg.sonnenberger updated this revision to Diff 21871. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D8697: phases: sparsify phase lists

2020-07-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY When the internal and archived phase was added, allphase became a large, sparsely populated list. This dramatically increased the number of lookup

D8698: phases: sparsify phaseroots and phasesets

2020-07-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY As final step of dealing with the holes in the phase numbers, make phaseroots and phasesets both dictionaries indexed by the phase number. Further

D8696: phases: updatephases should not skip internal phase

2020-07-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Historically, updatephases used to skip the secret phase, but wasn't updated when archived and internal were added. REPOSITORY rHG Mercurial

D8695: phases: replace magic number by constant

2020-07-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8695 AFFECTED FILES mercurial/phases.py CHANGE DETAILS diff --git

D8694: phases: provide a test and accessor for non-public phase roots

2020-07-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This decouples users from the implementation details of the phasecache. Also document a historic artifact about the stored phaseroots. REPOSITORY

D8693: sidedata: test changes for incoming and local changes [POC]

2020-07-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Fixes wireproto v2 to not send the raw data with flags=0 REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D8684: manifest: use the same logic for handling flags in _parse as elsewhere

2020-07-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8684 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git

D8683: revlog: avoid hard-coded hash sizes

2020-07-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8683 AFFECTED FILES

D8679: manifest: tigher manifest parsing and flag use

2020-07-05 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY In the manifest line, flags are put directly after the hash, so the parser has been guessing the presence of flags based on the length of the hash.

D8676: tests: allow timing difference in output

2020-07-02 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8676 AFFECTED FILES tests/test-wireproto-exchangev2-shallow.t CHANGE

D8675: ui: fix Python 2.7 support for ui.timestamp-output

2020-07-02 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8675 AFFECTED FILES mercurial/ui.py CHANGE DETAILS diff --git

D8672: tests: ignore possible diagnostics from gpg 2.2

2020-06-30 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8672 AFFECTED FILES tests/test-gpg.t CHANGE DETAILS diff --git

D8670: repoview: use the phasecache directly to determine mutable revisions

2020-06-27 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This speeds up no-change updates from 1.3s to 0.85s for my NetBSD test repository. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D8654: phases: make phase list dense or dictionaries [PoC]

2020-06-23 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY When the internal and archived phase was added, allphases became sparse populated. This dramatically increased the number of lookup operations for

D8651: share: provide a more useful text for hg help

2020-06-23 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D8651 AFFECTED FILES hgext/share.py CHANGE DETAILS diff --git

D8645: clonebundles: optional memory-requirement attribution

2020-06-21 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The new REQUIREDRAM option allows a client to skip bundles it isn't expected to handle well, e.g. without swapping. This allows a fallback path to

D8644: util: provide a helper function to estimate RAM size

2020-06-21 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY For POSIX systems, it uses sysconf. For Windows, it uses the win32 API directly. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D8641: phases: improve performance of _retractboundary

2020-06-18 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The old version repeatedly converts nodes to revisions, which is a moderately expensive operation. Mapping all new changes once to revisions and

D8640: ui: add option to timestamp status and diagnostic messages

2020-06-18 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D8640 AFFECTED FILES mercurial/configitems.py mercurial/ui.py

Re: [PATCH] py3: make ui.write() call fout.flush() per line if fout is a tty or pager

2020-06-08 Thread Joerg Sonnenberger
On Mon, Jun 08, 2020 at 09:11:48PM +0900, Yuya Nishihara wrote: > On Sun, 7 Jun 2020 22:09:58 +0200, Joerg Sonnenberger wrote: > > On Sun, Jun 07, 2020 at 08:55:03PM +0900, Yuya Nishihara wrote: > > > With my testing, inserting flush() automatically showed a better result >

Re: [PATCH] py3: make ui.write() call fout.flush() per line if fout is a tty or pager

2020-06-07 Thread Joerg Sonnenberger
On Sun, Jun 07, 2020 at 08:55:03PM +0900, Yuya Nishihara wrote: > With my testing, inserting flush() automatically showed a better result than > using unbuffered io, so this patch implements (b). Since ui._isatty() call > isn't cheap, the result is cached. I also made ui.write() not scan the >

Re: [PATCH 10 of 15] sslutil: assert that the Python we run on supports TLS 1.1 and TLS 1.2

2020-05-30 Thread Joerg Sonnenberger
On Sat, May 30, 2020 at 07:52:22AM +0200, Manuel Jacob wrote: > sslutil: assert that the Python we run on supports TLS 1.1 and TLS 1.2 Given that many systems want to phase out TLS 1.1, it seems questionable to enforce this. Joerg ___ Mercurial-devel

D8575: hooklib: fix detection of successors for changeset_obsoleted

2020-05-21 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Provide a hook for obsutil.getobsolete to be used with either a transaction or the changes item of the transaction, since hooks only have access to

D8574: hooks: teach reject_new_heads about phase transitions

2020-05-21 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D8574 AFFECTED FILES hgext/hooklib/reject_new_heads.py

D8522: fastexport: adjust output to be more canonical

2020-05-12 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY For time zones, git doesn't consider +0 and -0 the same timezone, so use the former canonically. Add a test case to ensure that non-UTC offsets are

D8505: tests: fix timer scaling in wait-on-file

2020-05-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY When using the default test timeouts, wait-on-file would not wait for $n seconds, but $n/100 seconds. This resulted in easy timeouts on even

D8501: tests: increase internal timeouts

2020-05-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The default limit is not enough time for non-rust test cases on a Threadripper when using SMT, so bump the limit to 1/3 of the default timeout to

D8500: tests: use regular POSIX shell

2020-05-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY wait-on-file requires one POSIX extension (sleep with non-integral argument), but it doesn't require any bash extensions, so just require a normal

D8490: hooks: provide access to transaction changes for hooks

2020-04-30 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. joerg.sonnenberger added a comment. This is part of a change discussed on IRC to make hooks more useful, e.g. providing better access to which changesets have been

D8487: fastexport: downgrade message about already exported changesets to debug

2020-04-27 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The old warning level is just too noisy for incremental processing. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D8486: fastexport: adjust output to be more canonical

2020-04-27 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The real name part of the committer name is normally not quoted, so don't enforce that. Prefer UTC+0 to UTC-0, git doesn't normalize it. REPOSITORY

D8481: pullbundles: use unfiltered repo for head/base matching

2020-04-24 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The unfiltered view works even when changeset transistion from draft to hidden phase. The normal visibility is already ensured by discovery as

D8480: bundle2: make obsolescence parts optional

2020-04-24 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It is useful to ship obsolescence markers as part of clonebundles or pullbundles, but they shouldn't stop a non-evolution client from working.

D8397: tests: deal with "ls" vs "ls -A" difference on 2BSD derived systems

2020-04-16 Thread joerg.sonnenberger (Joerg Sonnenberger)
Closed by commit rHG5c2a4f37eace: tests: deal with ls vs ls -A difference on 2BSD derived systems (authored by joerg.sonnenberger). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D8395: tests: skip CVS tests for root

2020-04-16 Thread joerg.sonnenberger (Joerg Sonnenberger)
Closed by commit rHGe5e5ee2b60e4: tests: skip CVS tests for root (authored by joerg.sonnenberger). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D8396: tests: skip non-readable check for root

2020-04-16 Thread joerg.sonnenberger (Joerg Sonnenberger)
Closed by commit rHG28aacddf3af0: tests: skip non-readable check for root (authored by joerg.sonnenberger). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D8398: fastexport: fix diagnostics

2020-04-13 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger added a comment. Think about any attempt to localize the error message. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8398/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8398 To: joerg.sonnenberger, #hg-reviewers, pulkit

D8398: fastexport: fix diagnostics

2020-04-13 Thread joerg.sonnenberger (Joerg Sonnenberger)
Closed by commit rHG4c806a5fe254: fastexport: fix diagnostics (authored by joerg.sonnenberger). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D8398?vs=21033=21040#toc REPOSITORY rHG Mercurial CHANGES SINCE

D8398: fastexport: fix diagnostics

2020-04-10 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8398 AFFECTED FILES hgext/fastexport.py tests/test-fastexport.t CHANGE

<    1   2   3   4   5   >