D11349: dirstate: drop the deprecated `merge` method

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The method was deprecated in 5.9. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11349 AFFECTED FILES

D11348: dirstate: drop the deprecated `remove` method

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The method was deprecated in 5.9. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11348 AFFECTED FILES

D11347: dirstate: drop the deprecated `add` method

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The method was deprecated in 5.9. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11347 AFFECTED FILES

D11346: dirstate: drop the deprecated `otherparent` method

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The method was deprecated in 5.9. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11346 AFFECTED FILES

D11345: dirstate: drop the deprecated `normallookup` method

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The method was deprecated in 5.9. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11345 AFFECTED FILES

D11344: dirstate: drop the deprecated `normal` method

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The method was deprecated in 5.9. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11344 AFFECTED FILES

D11343: dirstate: also wrap the new method in `dirstatenonnormalcheck`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The goal of this is to make sure we set the data right, so we need to make sure it run after the new method, that we actually call, in addition to the old

D11342: ci: only run the phabricator step if the previous on succeeded

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It seems like f6879956a386 regressed the intended behavior. REPOSITORY rHG

D11340: clone: properly create target directories during local clone (issue6581)

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The store encoding was mudding the water. This lead to local clone crashing for file with long filename as their destination directory needed to be encoded.

D11339: clone: add a file demonstrating issue6581 in test-clone-stream.t

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is quite noisy so we adds it in its own changeset. Fixes for the issue are coming in the next patch. REPOSITORY rHG Mercurial BRANCH stable

D11338: clone: verify the local clone in test-clone-stream.t

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will help detecting corruption. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11338 AFFECTED FILES

D11337: clone: automatically glob stream clone output in test

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Touching `test-clone-stream.t` is very painful otherwise. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11337

D11336: clone: fix a comment in test-clone-stream.t

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11336 AFFECTED FILES tests/test-clone-stream.t CHANGE DETAILS diff --git

D11330: dirstate-item: add dedicated "legacy" constructor for `addfile` case

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This way the internal details of how a DirstateItem is encoded is encapsulated within the DirstateItem. This will finally give use some latitude to change the

D11332: dirstatemap: also discard item from sets

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This seems more consistent to do that. I don't think any test was actually barking about it, but the code feels a bit more robust now. REPOSITORY rHG

D11331: dirstatemap: drop unused internal constant definition

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All that logic now moved within the DirstateItem itself, so we can finally drop this implementation details from the "higher" level. REPOSITORY rHG

D11329: dirstatemap: use the default code to handle "merged" case

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This simplify the conditionnal a bit since most of it is handled by the common code. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11328: dirstatemap: use the default code to handle "added" case

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This one is very easy too. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11328 AFFECTED FILES

D11327: dirstatemap: use the default code to handle "removed" case

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This one is very easy. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11327 AFFECTED FILES

D11326: dirstatemap: use the default code to handle "clean-p2" case

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This simplify the conditionnal a bit since most of it is handled by the common code. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11325: dirstatemap: use the default code to handle "p2-tracked" case

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We juste have to do minor value adjustement and the default code will do the rest. This kind of change highglight that "clean_p2" is probably not the right

D11324: dirstatemap: use the default code to handle "possibly_dirty" case

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This case is quite simple too REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11324 AFFECTED FILES

D11323: dirstatemap: use the default code to handle normal entry

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This case is quite simple. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11323 AFFECTED FILES

D11315: dirstatemap: replace `removefile` by an explicit `entry.set_untracked()`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All the other caller goes through `reset_state`, so we can safely have an explicit method on `DirstateItem` object. This means that all the logic to preserve

D11320: dirstate-item: feed more information to `__init__`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Instead of processing the "rich" value at the `dirstatemap` level, we can now directly pass them to the DirstateItem object. This will make the object free to

D11322: dirstatemap: conclude `reset_state` with logic using the new __init__

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Now the DirstateItem can deal with most of the logic related to its initialization, our goal is to migrate the function to a more "unified" way were minimal

D11321: dirstatemap: temporarily return early in `reset_state`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We are about to migrate `addfile` to the new `DirstateItem__init__` and having these early return will the new series of patches to be clearer. REPOSITORY

D11319: rust-dirstatemap: temporarily use `from_v1_data` in `addfile`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We are about to change the `__init__` for `DirstateItem`. To make the transition easier, we move existing caller to `DirstateItem.from_v1_data`. The Rust

D11318: dirstatemap: temporarily use `from_v1_data` in `addfile`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We are about to change the `__init__` for `DirstateItem`. To make the transition easier, we move existing caller to `DirstateItem.from_v1_data`. REPOSITORY

D11317: dirstate-item: fix the declaration of the Cext `from_v1_meth`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This method is apparently not called from anywhere since the declaration was garbage. We will start calling it in the next changeset. REPOSITORY rHG

D11316: dirstate-item: fix Cext declaration of dm_nonnormal and dm_otherparent

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY These are property, not method. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11316 AFFECTED FILES

D11314: dirstate: forward `remove` call to newer `API`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The `_remove` method was only called in the deprecated `remove` function. We merge the two and express it in terms of call to new API methods. REPOSITORY

D11313: dirstate: directly call the dirstatemap in `set_untracked`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This function is only called in two places: the deprecated "remove" method and in the new `set_untracked` method. So we simply inline the appropriate

D11312: resources: narrow the try:except clause to minimum

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Otherwise this mind hides other import or attribute errors. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11312

D11310: template: FileNotFoundError is actually a built in exception

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY However it is python3 only. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11310 AFFECTED FILES

D11311: resources: stop important a non existent FileNotFoundError

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The error was hidden by the wide try/except REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11311 AFFECTED FILES

D11309: check-code: drop the camelcase checks

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Fro about 2 years we have been using CamelCase is class names. That rules gets in the way of assigning class or exception in compatibility layers. I think

D11305: pyoxidizer: skip for ZeroConf related test for now

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY These test are failing for obscure reason. They are fairly minor and Since they are the only thing between us and enabling pyoxidizer testing in the CI by

D11306: pyoxidizer: always run the associated CI jobs

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Now that all tests are passing, we can enable this by default. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11304: pyoxidizer: disable the test for disabled & broken extensions help

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The test is a bit fragile and the feature is significantly broken for 3rd party extension already. So we disable that section with a comment about why and

D11302: pyoxidizer: re-install PYTHONPATH behavior

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Hooks and extensions can rely on PYTHONPATH value. Yet the pyoxidized binary ignore the variable. So we manually reinstall the behavior to fix various tests

D11301: windows: add pytest-vcr to the dependencies

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will lead to pyoxidizer including it in its binary. This fix test-phabricator.t REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11300: pyoxidizer: wrap the pyoxidizer script on multiple line

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is clearer and will help with future edition of the script. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11299: pyoxidized: silence the fuzzywuzzy warning about python-Levenshtein

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I don't think we need the fast implementation for the test so lets ignore it for now. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11298: pyoxidized: install fuzzywuzzy too

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is necessary for some of the release note tooling. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11298

D11297: pyoxidized: adapt output of test-install.t

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The python lib and template directories are in different location that requires a different patterns. REPOSITORY rHG Mercurial BRANCH stable REVISION

D11296: pyoxidized: disable part of `test-install.t` related to pip and virtualenv

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This part are testing manual installation of Mercurial, this is not relevant for the pyoxidizer variant. REPOSITORY rHG Mercurial BRANCH stable REVISION

D11295: pyoxidized: adapt output of test-bad-extension.t

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The file path in the traceback become module name. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11295

D11293: pyoxidized: adapt output of `test-phases.t`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We are getting one less line. I am not sure why, but it seems fairly minor. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11294: pyoxidized: adapt output of test-flagprocessor.t

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The file path in the traceback become module name. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11294

D11292: pyoxidized: add a copy of the `doc` directory in the right location

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This get the hacky setup closer to how an actual install is setup. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11291: pyoxidized: add a copy of the `contrib` directory in the right location

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This get the hacky setup closer to how an actual install is setup. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11290: pyoxidized: add a copy of the `defaultrc` file in the right location

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This get the hacky setup closer to how an actual install is setup. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11286: pyoxidized: add a dedicated target in the tests

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We will need to setup more items to make the "quick" version work on stable, having a dedicated operation will allow to contains change to that operation.

D11288: template: handle missing resource in `_readmapfile`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This should fix tests/test-template-map.t REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11288 AFFECTED FILES

D11289: pyoxidized: add a copy of the `helptext` directory in the right location

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This get the hacky setup closer to how an actual install is setup. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11287: pyoxidized: add a copy of the `templates` directory in the right location

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This should fix multiple tests. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11287 AFFECTED FILES Makefile

D11285: test-extension: adapt output to pyoxidizer

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The traceback use module name instead of filename. The rest of the test is still on fire for various other reasons. However that specific output mismatch

D11283: pyoxidized: add a `pyoxidizer` hghave keyword for line matching

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Some output line can be affected by pyoxidizer, for example the source file path are replaced by the module name. We introduce a new condition keyword to cope

D11284: pyoxidized: adapt test-devel-warnings.t

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11284 AFFECTED FILES tests/test-devel-warnings.t CHANGE DETAILS diff --git

D11282: templater: swap `\` with `/` in more location

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is similar to the previous changeset, but apply that logic to _readmapfile. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11281: templater: swap `\` with `/` to allow the resource logic to kicks in

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Without this change our wrapper to the resource logic will fails to details the nesting and try to pass `directory/file` entry to the resource module, leading

D11278: ci: run --pyoxidized tests on Windows

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY They still have numerous failure, but at least we can start fixing them now. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11277: run-tests: introduce a --pyoxidized option

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This options make it possible to use the pyoxidizer version to run the tests. This is a first basic version that is windows only. The test needs a working

D11276: ci: add a "all" template to easily control "when" test run

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY When debugging some job (usually windows one) it is handy to have a way to pass all other jobs to manual execution. We add a "root" template to control

D11271: issue6528: add a config option to control the fixing on the fly

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will allow people who know to be safe to avoid any performance overhead (and other potential issue). REPOSITORY rHG Mercurial BRANCH stable

D11270: issue6528: also filter delta on the fly when applying a changegroup

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This ensure that corrupted clone does not spread corruption to "fixed" version. This might come at a performance cost, we will had a config option to

D11269: filelog: open the writing context a bit earlier in `addgroup`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is a small change made ahead of the next patch for clarification. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11268: issue6528: implement _is_revision_affected_fast using callback

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The delta comming from a bundle/stream does not exists in the revlog yet, so we will need other way to retrieve the same information. To prepare for this

D11267: issue6528: implement _is_revision_affected using callback

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The delta comming from a bundle/stream does not exists in the revlog yet, so we will need other way to retrieve the same information. To prepare for this

D11266: test-pager: properly mark a line as optional

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY An extra space was missing (unlike the other lines above) REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11266

D11261: ci: backed out changeset 2fb4bd5f773f

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Now that test-censor.t is working on Windows, we can re-enable it. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11260: vfs: always use / as file separator (issue6546)

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Various part of vfs already enforce `/` usage and using `\` confuse the encoded vfs. So we simply use `/` all the time. REPOSITORY rHG Mercurial BRANCH

D11259: subrepo: compare normalised vfs path

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Otherwise the realpath call can turn `/` into `\` on windows confusing the check. (We probably needs this in more location) REPOSITORY rHG Mercurial

D11253: test: disable test-subrepo-git.t in python2 + chg

nt process as most CI run end up +# wasting abotu 1h until that one fails. +# +# Pierre-Yves David, Augie Fackler and Raphaël Gomès all agreed to disable this +# case in that specific case until we figure this out (or we drop python2 o:-) ) + +#if no-py3 chg + $ echo 'skipped: this test get stuck

D11251: test-nointerrupt: make "sure" the handler "might" trigger (issue6558)

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We are sure that the signal got sent in the right time frame, however, we still have race, so either the code is actually buggy or we need some security to

D11249: check-module-imports: ignore non-stdlib module installed by distribution

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. pulkit accepted this revision. This revision is now accepted and ready to land. Alphare accepted this revision. REVISION SUMMARY Previously, the check script would detect breezy

D11250: testing: make sure write_file is "atomic"

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. marmoute added a comment. Alphare accepted this revision. This revision is now accepted and ready to land. This does not seems to be all of the issue we have with nointerrupt.t

D11228: tests: make test-serve works on system that allow user to bind low port

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It is possible to encounter linux system configured in a way that allow port < 1024 to be bound by any users. So we update a test to focus more on the actual

D11227: run-tests: use a small timeout for chg instance

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY There is case where the test runner fails to clean up the temporary files in that case, spawned chg instance can stay around for 1 hours. Getting them to

D11226: run-tests: do not inherit file descriptor when running a command

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is one of the difference between python2 and python3 and could have been a reason why test hang with python2 + chg. This does not seems to help the

D11225: dummyssh: make sure we don't inherit files descriptor to the children

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is one of the difference between python2 and python3 and could have been a reason why test hang with python2 + chg. This does not seems to help the

D11224: dirstate: use `add` in the deprecation message about `add`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The previous message was talking about `remove`. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11224 AFFECTED

D11220: store: document the decoding discrepancy in store.py

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will help future people that might be looking into this. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11219: clone: add a file with special character while testing uncompressed

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will make sure we currently do not have any actual impact from issue6548. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D11218: clone: test local clone in `test-clone-uncompressed.t` too

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not an uncompressed test but needs to be tested in the same kind of constraints regarding special file name. REPOSITORY rHG Mercurial BRANCH

D11216: test-transaction-safety: relax some of the synchronisation schedule

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We can have `internal` and `external` runs at the same time, so we unlock `external` a bit sooner. REPOSITORY rHG Mercurial BRANCH stable REVISION

D11215: test-transaction-safety: document the test schedule

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This helps reader to understand how the test work and actually helped me to detect a missing synchronisation step. REPOSITORY rHG Mercurial BRANCH stable

D11214: help: indicate how to run downgrade a repository using persistent nodemap

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We have a couple of report of people needing this. I am not fan of pointing people to a debug command, but we don't have much better to offer right now

D11213: help: use the correct spelling for `slow-path` in persistent nodemap help

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11213 AFFECTED FILES mercurial/helptext/config.txt CHANGE DETAILS diff --git

D11205: test: remove `sleep` usage in `test-nointerrupt.t` (issue6271)

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We move from sleep based synchronisation to file creation based synchronisation. Sleeps is the path to the dark side. Sleeps leads to flakiness.

Re: Subject: 5.9 freeze, Windows, regression-fixes and Python 2 drop

On 7/19/21 8:44 PM, Pierre-Yves David wrote: I poked at a fix and I have something that will only requires minor adjustment, I should have a patch tomorrow morning. Here it is https://phab.mercurial-scm.org/D11201 -- Pierre-Yves David

D11201: walk: no longer ignore revlogs of files starting with `undo.` (issue6542)

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Changeset 0b569c75d180 introduced new code in store.walk to filter out undo

D11202: upgrade: avoid a traceback in case of unrecognized revlog

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Without this, in case of revlog name not matching any know pattern we would get a traceback. Raising a clear error seems simpler. REPOSITORY rHG Mercurial

Re: Subject: 5.9 freeze, Windows, regression-fixes and Python 2 drop

On 7/19/21 7:23 PM, Pulkit Goyal wrote: The freeze idea sounds good to me since we haven't really spent much time fixing the remaining issues related to py3 support and other long-standing bugs. On Mon, Jul 19, 2021 at 12:02 PM Pierre-Yves David wrote: There is a silly, but critical issue

D11198: mq: replace `add` call with newer API

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11198 AFFECTED FILES hgext/mq.py CHANGE DETAILS diff --git a/hgext/mq.py

D11193: mq: replace `drop` call with newer API

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11193 AFFECTED FILES hgext/mq.py CHANGE DETAILS diff --git a/hgext/mq.py

D11199: dirstate: deprecate the `add` method

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All users have been migrated. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11199 AFFECTED FILES

D11200: relnotes: document the change in the dirstate API

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11200 AFFECTED FILES relnotes/next CHANGE DETAILS diff --git a/relnotes/next

D11196: largefile: use `update_file` instead of `add` in `mergerecordupdates`

marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11196 AFFECTED FILES

<    1   2   3   4   5   6   7   8   9   10   >