D11197: largefile: use `updatefile` instead of `add` in `synclfdirstate`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11197 AFFECTED FILES

D11195: dirstate: deprecate the `drop` method

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All users have been migrated. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11195 AFFECTED FILES

D11188: amend: use `update_file` instead of `drop`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11188 AFFECTED FILES

D11192: largefile: use `update_file` instead of `drop` during `rollback`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11192 AFFECTED FILES

D11194: narrow: stop using `drop` in the `updateworkingcopy`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Let us use the new API instead. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11194 AFFECTED FILES

D11187: context: use `update_file` instead of `drop` in `markcommitted`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11187 AFFECTED FILES

D11191: largefile: use `update_file` instead of `drop` in `synclfdirstate`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11191 AFFECTED FILES

D11190: sparse: use `update_file` instead of `drop`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11190 AFFECTED FILES

D11189: sparse: use `update_file` instead of `drop` in `refreshwdir`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11189 AFFECTED FILES

D11185: mq: drop the use of `dirstate.merged

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Since mq does not work on merge, we do not need this. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11185

D11186: dirstate: deprecate the `merge` method in all cases

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All code have been migrated to the new APIs. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11186 AFFECTED

D11184: dirstate: deprecate the `otherparent` method in all cases

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All code have been migrated to the new APIs. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11184 AFFECTED

D11183: dirstate: deprecate the `normallookup` method in all cases

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All code have been migrated to the new APIs. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11183 AFFECTED

D11182: narrow: stop using `normallookup` during a test

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: durin42. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11182 AFFECTED FILES

D11175: mq: replace `normallookup` call with newer API

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This align MQ behavior with what what `scmutil.movedirstate` does. (it should probably use `scmutil.movedirstate` itself. REPOSITORY rHG Mercurial BRANCH

D11180: test: use the internal `_normallookup` in `test-rebuildstate.t`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is a low level test doing low level manipulation. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11180

D11181: narrow: use `update_file` instead of `normallookup` after update

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11181 AFFECTED FILES

D11174: revert: use `set_possibly_dirty` instead of `normal_lookup`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11174 AFFECTED FILES

D11179: sparse: use `update_file` instead of `normallookup` in refreshwdir

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11179 AFFECTED FILES

D11178: keywork: use `update_file_p1` instead of `normallookup`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11178 AFFECTED FILES

D11172: record: use `update_file` instead of `normallookup`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We are cheating a bit to enforce we are in a pending change context. This will have to be cleaned up later. The end goal is reached, we are now using the

D11177: fix: use `set_possibly_dirty` instead of `normallookup`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11177 AFFECTED FILES

D11176: eol: use `set_possibly_dirty` instead of `normallookup`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11176 AFFECTED FILES

D11170: amend: use `update_file` instead of `normallookup`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11170 AFFECTED FILES

D11173: dirstate: enforce `possibly_dirty` in `set_tracked`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY There is some usecase (like `hg revert`) that requires more agressive `possibly_dirty` setting. So we take a safe path and enforce it in one of the main

D11171: copy: use `update_file` instead of `normallookup` in `dirstatecopy`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11171 AFFECTED FILES

D11169: mergestate: use `update_file` to handle `for ACTION_EXEC`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11169 AFFECTED FILES

D11168: mergestate: use `update_file` to handle `for ACTION_ADD_MODIFIED`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11168 AFFECTED FILES

D11167: largefile: use `update_file` for `synclfdirstate` "m" case

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11167 AFFECTED FILES

D11166: largefile: use `update_file` for `synclfdirstate` "n" case

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11166 AFFECTED FILES

D11163: largefile: use `set_possibly_dirty` instead of `normallookup`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11163 AFFECTED FILES hgext/largefiles/overrides.py CHANGE DETAILS diff --git

D11165: largefile: replace the `normallookup` call when creating a new lfdirstate

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11165 AFFECTED FILES

D11162: dirstate: add a `set_possibly_dirty` method

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This method will be able to replace some usage of `normallookup` in the future. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11164: largefile: use `update_file` instead of `normallookup` in `updatelfiles`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11164 AFFECTED FILES

D11158: largefile: use `update_file` instead of `normal` in `synclfdirstate`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. This was the last call to `normal` in largefile. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11156: largefile: use `set_clean` instead of `normal` in `lfdirstatestatus`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11156 AFFECTED FILES

D11160: test: use `set_traced` in `test-context`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is apparently the last user of the old API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11160 AFFECTED

D11159: mq: replace usage of `normal` with newer API

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11159 AFFECTED FILES hgext/mq.py CHANGE DETAILS diff --git a/hgext/mq.py

D11161: dirstate: deprecate the `normal` method in all cases

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All code have been migrated to the new APIs. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11161 AFFECTED

D11149: revert: use `set_clean` instead of `normal`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11149 AFFECTED FILES

D11157: largefile: use `set_clean` instead of `normal` in `repo.status`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11157 AFFECTED FILES

D11155: largefile: use `update_file` instead of `normal` in `updatelfiles`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11155 AFFECTED FILES

D11153: keywork: use `set_clean` instead of `normal`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11153 AFFECTED FILES

D11154: largefile: respect the `normal` signature

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The `parentfiledata` parameter was missing, we throw it away because I am not sure what to do with it in the largefile case. REPOSITORY rHG Mercurial BRANCH

D11152: sparse: use `update_file` instead of `normal` in `refreshwdir`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11152 AFFECTED FILES

D11151: sparse: use `update_file` instead of `normal` during `applyupdates`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. (more content end up "nonnormal", see previous commit) REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11148: context: use `update_file` instead of `normal` in `markcommitted`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11148 AFFECTED FILES

D11150: sparse: apply update with in a `parentchange` context

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We are changing the reference so we should be within such context manager. This seems make the actual dirstate content a bit flaky with content being

D11147: context: use new API instead of `normal` during fixup post status

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We use `set_clean` or `update_file` depending of if we are in the middle of an update or not. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11146: dirstate: introduce a `set_clean` method

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will provide a good alternative to `normal` call with a narrower semantic. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11145: largefile: use `update_file` instead of `normal`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11145 AFFECTED FILES

D11144: largefile: adjust the dirstate post update within a `parentchange` context

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is doing an update, so this seems more appropriate. No other change have been made, but the next changeset will :-) REPOSITORY rHG Mercurial BRANCH

D11139: mq: use `update_file_p1` instead of `remove` when adjusting dirstate

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the new API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11139 AFFECTED FILES hgext/mq.py CHANGE

D11143: dirstate: deprecate `dirstate.remove` in all cases

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This will make sure that code will use the newer, more semantic API sooner than later. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11134: dirstate-map: move most of `dirstate.update_file` logic in the dsmap

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY A new `reset_state` method is introduced to deal with most of that logic. This move things one layer lower, but the ultimate goal is to deal with most of this

D11140: largefile: use `update_file` instead of `remove` in `mergerecordupdates`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11140 AFFECTED FILES

D11142: largefile: use `update_file` instead of `remove` in `synclfdirstate`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the newer, more semantic API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11142 AFFECTED FILES

D11141: largefile: rearrange conditionnal in `synclfdirstate`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We can liquidate the special case early, so do we. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11141

D11135: dirstate: rename `update_file_reference` to `update_file_p1`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is a bit clearer on the intended usage of the function. (but still not great) REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11138: dirstate: properly update `_lastnormaltime` in `update_file_p1`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This was previously overlooked. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11138 AFFECTED FILES

D11137: dirstate: properly update `_lastnormaltime` in `update_file`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This was previously overlooked. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11137 AFFECTED FILES

D11136: dirstate: use `reset_state` in `update_file_p1`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Going through the same API is more consistent and allow us to push implementation lower down the call stack. REPOSITORY rHG Mercurial BRANCH default

D11133: dirstate: replace `update_parent_file_data` with simpler `update_parent` call

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This make the dirstate API simpler. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11133 AFFECTED FILES

D11132: dirstate: factor out the part retrieve "filedata" out of `normal`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We will need them elsewhere. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11132 AFFECTED FILES

D11131: dirstate-map: factor out the change to _dirs and _alldirs on removing

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This logic is complicated enough to deserves its own function. So it now does. This will make it easier to reuse that logic in later changeset. REPOSITORY

D11130: dirstate-map: factor out the change to _dirs and _alldirs on dropping

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This logic is complicated enough to deserves its own function. So it now does. This will make it easier to reuse that logic in later changeset. REPOSITORY

D11128: dirstate: replace a dead conditional branch with an assert in `update_file`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is a case we never meet, so lets trim it away to simplify the code before more changes. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11129: dirstate-map: factor out the change to _dirs and _alldirs on adding

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This logic is complicated enough to deserves its own function. So it now does. This will make it easier to reuse that logic in later changeset. REPOSITORY

D11126: dirstate: drop a duplicated assert

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This very case is checked in 3 line above that one. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11126

D11127: dirstate-map: do not use `size` to gate copy dropping during remove_file

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This get us close to moving the block right above withing the DirstateItem object. Doing so will help us getting rid of magic constant at the dirstatemap

D11124: dirstate-item: introduce a `dm_otherparent` property

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY See inline documentation for details. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11124 AFFECTED FILES

D11125: dirstate: drop duplicated check

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is covered by the `@requires_parents_change` decorator that this function use. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11123: dirstate-item: introduce a `dm_nonnormal` property

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY See inline documentation for details. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11123 AFFECTED FILES

D11122: dirstate: add a `set_possibly_dirty` in `fakedirstatewritetime`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11122 AFFECTED FILES tests/fakedirstatewritetime.py CHANGE DETAILS diff --git

D11119: dirstate-item: add a `set_possibly_dirty` method

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY See inline documentation for details. The pushes the AMBIGUOUS_TIME implementation further down the line within the DirstateItem only. When this cleanup

D11121: dirstatemap: use `set_possibly_dirty` in `clearambiguoustimes`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY lets put this new method to use REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11121 AFFECTED FILES

D11120: dirstate-item: use `set_possibly_dirty` in `pure.pack_dirstate`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Lets make use of the new function. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11120 AFFECTED FILES

D11118: dirstate-item: add a `from_v1_data` constructor

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This class method is dedicated to building a DirstateItem from the data available in the "dirstate-v1" format. Since that format is frozen, this constructor

D11117: dirstate-item: use an explicit __init__ function instead of the attrs one

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY For now, this is not doing anything special, however we plan to make it different in the future. So we start simple. REPOSITORY rHG Mercurial BRANCH

D11116: dirstate: deprecated `drop` outside of `update/merge`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All core users have been migrated. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D6 AFFECTED FILES

D11115: dirstate: deprecated `remove` outside of `update/merge`

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All core users have been migrated. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D5 AFFECTED FILES

D11114: dirstate: deprecate the `add` method outside of update/merge context

2021-07-19 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY All core users have been updated. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D4 AFFECTED FILES

Re: Subject: 5.9 freeze, Windows, regression-fixes and Python 2 drop

2021-07-19 Thread Pierre-Yves David
://www.mercurial-scm.org/mailman/listinfo/mercurial-devel -- Pierre-Yves David ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D11111: largefile: use `set_untracked` in the override of copy/rename

2021-07-18 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the new shiny API REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D1 AFFECTED FILES

D11113: largefiles: replace use of synclfdirstate with drop

2021-07-18 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Replace calling a complex function with a simple dedicated one REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D11110: largefile: use `set_untracked` in the `forget` override

2021-07-18 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the new shinny API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D0 AFFECTED FILES

D11112: largefile: use `parentchange` markcommitted

2021-07-18 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D2 AFFECTED FILES hgext/largefiles/lfutil.py CHANGE DETAILS diff --git

D11109: largefile: directly use set_untracked() for removing files

2021-07-18 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is new shiny API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11109 AFFECTED FILES

D11108: largefile: use `parentchange` during rollback

2021-07-18 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY rollback is updating parent without touching the working copy. It should wrapped in a `parentchange` context. REPOSITORY rHG Mercurial BRANCH default

D11106: largefile: use `set_tracker` in the `hg copy` overwrite

2021-07-18 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the new shiny API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11106 AFFECTED FILES

D11107: largefile: consider `updatelfiles` as a `parentchange`

2021-07-18 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is not strictly a `parentchange`, however this is still some internal dirstate adjustment as "similar" enough that it seems find to do so. REPOSITORY

D11105: largefile: use parentchange during mergerecordupdates

2021-07-18 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This match what core is doing around recordupdates. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11105

D11104: largefile: use `set_tracker` in the `hg add` overwrite

2021-07-18 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the new shiny API. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11104 AFFECTED FILES

D11103: largefile: synchronise the dirstate within a `parentchange` context

2021-07-18 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Semantically these changes are made to adjust the dirstate after a commit, so it should be in a `parentchange` context. REPOSITORY rHG Mercurial BRANCH

D11100: windows: enforce the module policy to be c for test

2021-07-16 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the same as what we do with the linux test. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11100

D11087: sigpipe-remote: simply delegate pipe forwarding to subprocess we can kill

2021-07-11 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Instead of using sophisticated logics with thread a non blocking pipes, we simply spawn two new process in charge of reading the pipe and sending the result

D11086: sigpipe-remote: verify the script is IO are unbuffered

2021-07-11 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We don't want to get stuck anywhere by buffers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11086 AFFECTED

D11085: sigpipe-remote: check environment variable sooner

2021-07-11 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Lets make sure we have everything before doing anything. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11085

D11084: test-sigpipe: run the hook using `sh`

2021-07-11 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This make the hook properly run on Windows. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D11084 AFFECTED

D11081: run-test: rework the redirection script for python on windows

2021-07-11 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This should get use something something overall simpler and clearer. Especially, we now have a `python.exe` script (even if by default Windows has

<    1   2   3   4   5   6   7   8   9   10   >