D6848: narrow: add option for automatically removing unused includes

pulkit added inline comments. INLINE COMMENTS > narrowcommands.py:369 > +If --auto-remove-includes is specified, then those includes that don't > match > +any files modified by currently visible commits will be added to the set > of > +explicitly specified includes to remove. sorry

D6848: narrow: add option for automatically removing unused includes

pulkit added inline comments. INLINE COMMENTS > narrowcommands.py:331 > ('', 'removeinclude', [], _('old paths to no longer include')), > + ('', 'auto-remove-includes', False, > + _('automatically choose unused includes to remove (EXPERIMENTAL)')), Following pattern of other flags

D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC)

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. In D6851#100690 , @idlsoft wrote: >>> Just `tracked --add-include`. A workaround to simplify the upgrade would be to change `wireprototypes.

D6848: narrow: add option for automatically removing unused includes

pulkit added inline comments. INLINE COMMENTS > narrowcommands.py:332 > + ('', 'auto-remove-includes', False, > + _('automatically choose unused includes to remove (EXPERIMENTAL)')), > ('', 'addexclude', [], _('new paths to exclude')), Can you add some help text below on how these

D6709: config: add --registered flag to show all known configs

pulkit added a comment. In D6709#100698 , @av6 wrote: > And to make the review process easier, I propose doing this in 3 or 4 patches: > > - adding `--registered`: will simply show all registered options in key=value format > - adding de

D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC)

pulkit added a comment. In D6851#100667 , @martinvonz wrote: > In D6851#100666 , @idlsoft wrote: > >>> @idlsoft and their company does use narrow extension. @idlsoft can you upgrade server and

Re: [PATCH] rust-cpython: add sanity check to PySharedState::decrease_leak_count()

On Sun, Sep 15, 2019 at 7:33 PM Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1568555012 -32400 > # Sun Sep 15 22:43:32 2019 +0900 > # Node ID 071b35e3f7cde53cbf411a536091153741dc4a37 > # Parent 34ed651ba7e4a4b7f0ee79c5a5442b5eed27bbad > rust-cpython: add s

D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC)

pulkit added a comment. pulkit added subscribers: idlsoft, pulkit. > This is clearly a breaking change, but the feature is experimental and > we're not aware of anyone running a server using this command yet. @idlsoft and their company does use narrow extension. @idlsoft can you upgrade

D6857: uncommit: enable support for adding a note

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. > Should these note options (including on amend) be marked advanced to keep the > help text clutter level down? Maybe, I don't have strong opinion here on any of the options. REPOSIT

D6776: bookmarks: validate changes on push (issue6193) (BC)

pulkit added a comment. I agree with @valentin.gatienbaron that `--force` is quite generic :(. It may create new heads on the server even if I don't want to. INLINE COMMENTS > bundle2.py:2149 > +hint= > +_("run 'hg pull', resolve conflicts, an

D4664: mergecommit: add a new extension to merge in-memory and create a commit

pulkit added a comment. In D4664#100404 , @durin42 wrote: > Neat. I assume you normally check these out later? For now yes. The plan was to make `hg cat` support cat-ing maultiple files preventing to checkout. REPOSITORY rHG Mercurial

D6738: unshelve: add --unresolved flag to unshelve mergestate with unresolved files

pulkit added inline comments. INLINE COMMENTS > pulkit wrote in shelve.py:754 > Then we are somehow parsing or building the records in not correct way. Did you manage to find why that error comes up? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6738/ne

D6736: shelve: add method for storing mergestate in changeset extras

pulkit added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in shelve.py:416 > i feel like the current approach is more simpler and easy to understand. It will be nice to use only way to encode mergestates at all the places. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION htt

D6828: uncommit: add options to update to the current user or current date

pulkit added a comment. In D6828#100190 , @mharbison72 wrote: > In D6828#100139 , @pulkit wrote: > >> I guess `--interactive` is the only flag left which is extra in evolve version, right? >

D6828: uncommit: add options to update to the current user or current date

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. I guess `--interactive` is the only flag left which is extra in evolve version, right? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6828/new/ REV

D6825: contrib: start building a library for simple hooks

pulkit added a comment. Thanks a lot for putting efforts here. I am +1 on this. I haven't looked at the code though, will try to review if no one else beats me to it. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6825/new/ REVISION DETAIL https://p

D6757: bdiff-torture: fix pyflakes warning reporting undefined name 'inst'

Closed by commit rHG3316e59b0105: bdiff-torture: fix pyflakes warning reporting undefined name 'inst' (authored by pulkit). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6757?vs=162

Re: [PATCH] rust: apply more formatting fixes

On Sat, Aug 31, 2019 at 9:07 AM Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1567228358 -32400 > # Sat Aug 31 14:12:38 2019 +0900 > # Node ID 72263c4cadfe715c76c35f6966e35e8dd3934e96 > # Parent a3c2ffcd266f33608ac1694ed7daece0bd85d52b > rust: apply more fo

D6741: interfaces: create a new folder for interfaces and move repository.py in it

Closed by commit rHG268662aac075: interfaces: create a new folder for interfaces and move repository.py in it (authored by pulkit). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D674

D6742: interfaceutil: move to interfaces/

Closed by commit rHG2c4f656c8e9f: interfaceutil: move to interfaces/ (authored by pulkit). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6742?vs=16260&id=16311 CHANGES SINCE LAST A

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

pulkit added a comment. Queued the patches for stable, many thanks! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6731/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6731 To: navaneeth.suresh, #hg-reviewers, pulkit Cc: pulkit, mercurial-devel

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

This revision is now accepted and ready to land. pulkit added inline comments. pulkit accepted this revision. INLINE COMMENTS > test-bookmarks-pushpull.t:1347 > Pushing the bookmark "foo" now fails as it contains a secret changeset > #if b2-pushkey >$ hg push -r foo removing the casing in

D6738: unshelve: add --unresolved flag to unshelve mergestate with unresolved files

pulkit added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in shelve.py:754 > i had tried to support it earlier. but, it throws the following error. i > think it's okay to use the latest format only since, we haven't stored any > mergestate using the previous format. the repo won't

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

pulkit added a comment. Looks like you forgot to update tests. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6731/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6731 To: navaneeth.suresh, #hg-reviewers Cc: pulkit, mercurial-devel

D6757: bdiff-torture: fix pyflakes warning reporting undefined name 'inst'

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Looks like I got a latest version of pyflakes somehow or it's running on py3 and it spotted this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercu

Re: [PATCH 11 of 11] rust-dirstate: remove test case for DirsMultiset::new(Manifest, Some)

On Sat, Aug 17, 2019 at 3:49 PM Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1566034135 -32400 > # Sat Aug 17 18:28:55 2019 +0900 > # Node ID 24f0204173d07b53cdd34b75122b46cd74df3756 > # Parent c0660c41e5b27173f73b8c88da1728b69425aeba > rust-dirstate: remo

D6718: repository: suppress typing errors on functions without arguments

pulkit added a comment. I tried to queue but `test-check-code.t` and `test-check-commit.t` fails. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6718/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6718 To: indygreg, #hg-reviewers, durin42 Cc:

D6746: perf: don't pass experimental argument in config for older Mercurial versions

pulkit added a comment. Folded https://www.mercurial-scm.org/repo/hg-committed/rev/9f2189b6bf2a. This can be closed now. Thanks for the quick fix. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6746/new/ REVISION DETAIL https://phab.mercurial-scm.or

D6746: perf: don't pass experimental argument in config for older Mercurial versions

pulkit added a comment. In D6746#99035 , @martinvonz wrote: > When this patch is ready, could we fold this into `a11fd395e83f`? I have `extensions.perf=contrib/perf.py` in my config and it's pretty annoying to have any commit in the broken ran

D6741: interfaces: create a new folder for interfaces and move repository.py in it

pulkit added a comment. In D6741#98947 , @martinvonz wrote: >> I was trying to understand current interfaces and write new ones and I realized >> we need to improve how current interfaces are organised. > > And what was the reason we need

D6748: hgit: define invalidatecaches for gitstore()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6748 AFFECTED FILES hgext/git/__init__.py CHANGE DETAILS diff --git a/hgext/git/__init__.py b/hgext/gi

D6747: hgit: fix some pyflakes and check-code warning

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I mostly added absolute_import and fixed warnings related to undefined name. This should get folded in the main hgit RFC patch. There are still more failures b

D6746: perf: don't pass experimental argument in config for older Mercurial versions

pulkit added inline comments. INLINE COMMENTS > perf.py:270 > pass > +except TypeError: > +configitem(b'perf', b'presleep', Can you add the commit hash and hg version (5.2 in this case) as comment due to which the compatibility is need? REPOSITORY rHG Mercurial CHANGES SINCE LAST A

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

pulkit added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in exchange.py:1044 > I'm getting the following error with the code snippet that you've suggested: > > + Traceback (most recent call last): > +File "/tmp/hgtests.nS3TJv/install/bin/hg", line 43, in > + dispat

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

pulkit added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in exchange.py:1044 > updated to get rid of one return. if node is `None`, then hg will throw an > error there. If the node is None, then `if node and ` will be false and the second condition won't be executed. REPOSIT

D6735: update: added support for --abort flag(issue4404)

pulkit added a comment. Nice start! If I remember correctly, the mergestate stores the local version of the file. We can use that directly instead. INLINE COMMENTS > hg.py:992 > +for f in ms: > +ms.mark(f, mergemod.MERGE_RECORD_UNRESOLVED_PATH) > +ms.mark(f, mergemod.MERG

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

pulkit added a comment. Can you also add a test where we are pushing multiple heads/bookmarks and one of the bookmark is problematic? INLINE COMMENTS > exchange.py:1043 > +if ctx.phase() == phases.secret: > +raise error.Abort(_('bookmark %s points to a secret changeset') % b) > +

D6740: tests: add test to demonstrate issue6159

pulkit added inline comments. INLINE COMMENTS > test-bookmarks-pushpull.t:1344 > +Move the bookmark "foo" to point at a secret changeset > + $ hg commit -qAm_ > + $ hg phase -s -f `--config phases.new-commit=secret` can be used here instead to create a secret commit. > test-bookmarks-pushpul

D6738: unshelve: add --unresolved flag to unshelve mergestate with unresolved files

pulkit added inline comments. INLINE COMMENTS > shelve.py:754 > +ms = merge.mergestate.clean(repo) > +ms._writerecordsv2(_decodemergerecords(records)) > + we should write both the versions, `_writerecords()` should be used. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https:/

D6736: shelve: add method for storing mergestate in changeset extras

pulkit added inline comments. INLINE COMMENTS > shelve.py:416 > > +def _encodemergerecords(records): > +"""Encode mergestate records to store in changeset extras. What do you think about refactoring the code to write mergestate v2 on disk and use that encoding to achieve this? REPOSITORY

D6741: interfaces: create a new folder for interfaces and move repository.py in it

pulkit created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I was trying to understand current interfaces and write new

D6742: interfaceutil: move to interfaces/

pulkit created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we have a dedicated folder for interfaces, let's move interfaceutil there. REPOSITORY rHG Mercurial REVISION DETAIL

D6479: shelve: first prototype of storing/restoring unresolved changes

pulkit added a comment. In D6479#98757 , @navaneeth.suresh wrote: > In D6479#98737 , @durin42 wrote: > >> The only thing I'm curious about really is why we have extrastorage and usualstorge. Can w

D6735: update: added support for --abort flag(issue4404)

pulkit added inline comments. INLINE COMMENTS > test-merge-tools.t:2092 > + > +Test for 'hg update --abort' > + I suggest taking `update --abort` tests in a new file as we will need to extensively test that. > test-merge-tools.t:2129 > + merging file > + warning: conflicts while merging file

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

pulkit added a comment. In such cases, I like the idea of having fix as two patches, first which demonstrates the bug and the second which fixes the bug. What do you think? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6731/new/ REVISION DETAIL htt

D6728: config: add experimental argument to the config registrar

pulkit added inline comments. INLINE COMMENTS > perf.py:244 > default=mercurial.configitems.dynamicdefault, > +experimental=True, > ) This breaks `contrib/perf.py` with older versions of mercurial. Can you send a compatibility fix as followup? REPOSITORY rHG Mercurial

Re: [PATCH] py3: do not convert rust module/attribute names to bytes

On Sat, Aug 17, 2019 at 3:09 PM Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1566005104 -32400 > # Sat Aug 17 10:25:04 2019 +0900 > # Node ID 302e4706ab25b4d29d858f93ca2678a609e95570 > # Parent a3c360094c93509ee013ed7f4b7807c74b2d60a4 > py3: do not convert

Re: [PATCH] transplant: unnest --stop case

On Sat, Aug 17, 2019 at 3:06 PM Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1566024221 -32400 > # Sat Aug 17 15:43:41 2019 +0900 > # Node ID a3c360094c93509ee013ed7f4b7807c74b2d60a4 > # Parent 88d6a6f7e83716146fc725f20166509a520bc164 > transplant: unnest

Re: [PATCH hg-website] who: remove Python, OpenSolaris and add nginx

On Fri, Jul 26, 2019 at 3:40 PM David Demelier wrote: > > # HG changeset patch > # User David Demelier > # Date 1564144028 -7200 > # Fri Jul 26 14:27:08 2019 +0200 > # Node ID 1bf7e259ffb1b212152eb155803984b1ad9118a0 > # Parent e3a73084715ab55f78f1c75474a89bed5e485f63 > who: remove Python,

D6695: transplant: added support for --abort flag

pulkit added a comment. Let's rename this to `transplant --stop` instead. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6695/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6695 To: taapas1128, #hg-reviewers Cc: pulkit, mjpieters, mercurial-de

D6699: unshelve: abort on using --keep and --interactive together

This revision is now accepted and ready to land. pulkit added inline comments. pulkit accepted this revision. INLINE COMMENTS > shelve.py:970 > basename = shelved[0] > +if interactive and opts.get('keep'): > +raise error.Abort(_('--keep on --interactive is not yet supported')

D6709: config: add --registered flag to show all known configs

pulkit added a comment. In D6709#98716 , @marmoute wrote: > We will need more than just matching the categoie name to detect experimental/deprecated config. There are such option outside of the `experimental` section, and we still need to hide

D6724: unshelve: forget unknown files after a partial unshelve

This revision is now accepted and ready to land. pulkit added inline comments. pulkit accepted this revision. INLINE COMMENTS > shelve.py:1009 > if not ispartialunshelve: > -_forgetunknownfiles(repo, shelvectx, addedbefore) > unshelvecleanup(ui, repo, basename, o

D6722: fncache: make debugrebuildfncache not fail on broken fncache

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. Queued these for stable branch. Many thanks! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6722/new/ REVISION DETAIL https://phab.mercurial-scm.o

D6699: unshelve: abort on using --keep and --interactive together

pulkit added inline comments. INLINE COMMENTS > shelve.py:971 > +if interactive and opts.get('keep'): > +raise error.Abort(_('--keep on interactive is not yet supported')) > `--keep on --interactive ...` REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercuria

D6709: config: add --registered flag to show all known configs

pulkit added inline comments. INLINE COMMENTS > commands.py:1888 > fm.condwrite(ui.debugflag, 'source', '%s: ', source) > +fm.data(defaultvalue=defaultvalue) > if uniquesel: unrequired change I guess > marmoute wrote in test-config.t:228 > Displaying the default vs cur

D6709: config: add --registered flag to show all known configs

pulkit added a comment. In D6709#98493 , @marmoute wrote: > In D6709#98479 , @navaneeth.suresh wrote: > >> @pulkit I couldn't figure out why the devel-warnings are coming. It's being shown for the

D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

pulkit added a comment. Thanks @marmoute for the review. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6710/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6710 To: spectral, #hg-reviewers, marmoute, pulkit Cc: marmoute, mercurial-devel __

D6695: transplant: added support for --abort flag

pulkit added a comment. Sorry for missing this earlier, but what happens when we are transplanting mutliple revisions and we have conflicts in a revision after the first one? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6695/new/ REVISION DETAIL h

D6695: transplant: added support for --abort flag

pulkit added inline comments. INLINE COMMENTS > pulkit wrote in test-transplant.t:466 > A better candidate here will be to show `hg status -v` as that will show > whether there is an unfinished transplant or not. This one is not done. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION htt

D6689: continue: added support for transplant

pulkit added inline comments. INLINE COMMENTS > transplant.py:737 > > +def continuetransplant(ui, repo): > +"""logic to resume an interrupted transplant using let's name this function `continue` only as it's in transplant.py and a continue implies that we are continuing transplant. REPOS

D6695: transplant: added support for --abort flag

pulkit added inline comments. INLINE COMMENTS > transplant.py:417 > +"""logic to abort an interrupted transplant""" > +if repo.vfs.exists('transplant/journal'): > +startctx = repo['.'] `canresume` above can be used for doing this check. REPOSITORY rHG Mercurial CH

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

This revision now requires changes to proceed. pulkit added a comment. pulkit requested changes to this revision. The test still fails. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6697/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6697 To:

D6717: mypy: add a mypy.ini config file

pulkit added a comment. I am +1 on this. If I don't hear any objection on it until next week, I will queue it. Thanks for doing this work! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6717/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6717

D6699: tests: add test for unshelve --interactive --keep

pulkit added a comment. You are already working on improving things with `--keep` and `--interactive`, so let's have this patch as a part of that patch. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6699/new/ REVISION DETAIL https://phab.mercurial-

D6659: graft: split graft code into seperate functions

pulkit added inline comments. INLINE COMMENTS > cmdutil.py:3431 > +"""logic to execute graft once revs are generated""" > +graftstate = statemod.cmdstate(repo, 'graftstate') > +for pos, ctx in enumerate(repo.set("%ld", revs)): let's initialize `graftstate` only where we need it. > c

D6678: continue: added support for histedit

pulkit added inline comments. INLINE COMMENTS > histedit.py:1842 > > +def hgcontinuehistedit(ui, repo): > +state = histeditstate(repo) I see that we can have a unified function, `resumehistedit(..)` which can be called from `_histedit()` too. REPOSITORY rHG Mercurial CHANGES SINCE LAS

D6689: continue: added support for transplant

pulkit added inline comments. INLINE COMMENTS > transplant.py:743 > +tp = transplanter(ui, repo, opts) > +tp.resume(repo, repo, opts) > +return I don't see `transplanter` modifying opts. So we can directly pass empty dict in both of the above function. > transplant.py:7

D6696: abort: added support for transplant

pulkit added inline comments. INLINE COMMENTS > transplant.py:779 > +tp = transplanter(ui, repo, {}) > +tp.abort(ui, repo) > +return `return tp.abort(..)` instead. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6696/new/ REVISION

D6695: transplant: added support for --abort flag

pulkit added inline comments. INLINE COMMENTS > transplant.py:416 > > +def clear(self): > +"""clear the state file if it exists""" We already have `self.unlog` doing the same here. > transplant.py:421 > + > +def abort(self, ui ,repo): > +"""logic to abort an interrupte

D6720: config: fix fm.data() handling of defaultvalue

pulkit added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in commands.py:1884 > I did this but, couldn't see a difference in the test output. ah, I guess the output is sorted. Anyway, the suggested one is a correct way to do this, because otherwise we are writing name to fm two tim

D6712: config: fix defaultvalue template keyword (patch 1 of 2)

pulkit added a comment. This patch needs a better description. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6712/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6712 To: navaneeth.suresh, #hg-reviewers Cc: pulkit, durin42, marmoute, mercurial

D6720: config: fix defaultvalue template keyword (patch 2 of 2)

pulkit added a comment. This patch also needs a better description, something like: `config: fix fm.data() handling of defaultvalue`. INLINE COMMENTS > commands.py:1884 > fm.condwrite(ui.debugflag, 'source', '%s: ', source) > +fm.data(name=entryname, defaultvalue=defaultvalu

D6712: config: fix defaultvalue template keyword (patch 1 of 2)

pulkit added a comment. The `pycompat.bytestr()` was there for py3 compatibility, however removing it should be fine in this case. Can you make sure `test-config.t` passes with this patch on Python 3? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D671

D6709: config: add --registered flag to show all known configs

pulkit added inline comments. INLINE COMMENTS > ui.py:821 > > +def walkallconfig(self, untrusted=False): > +"""walk through all known config options in the registrar""" Since, we renamed the flag which was good idea, let's rename the function too. Also, this should better return `

Re: Hosting Mercurial Sprint 5.2

hange. Thanks and regards Pulkit On Wed, Jun 19, 2019 at 4:43 PM Pulkit Goyal <7895pul...@gmail.com> wrote: > > Hey everyone, > > I hope you're doing well. > > We are planning to have the next bi-yearly developer sprint 5.2 in sometime > in September or October. Since t

D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve

pulkit added a comment. Applied the following diff in flight which was result of test output changes. --- /home/pulkit/repo/paccess/tests/test-shelve.t +++ /home/pulkit/repo/paccess/tests/test-shelve.t @@ -1365,19 +1365,19 @@ #if stripbased $ hg log -r 3:: -G

D6694: unshelve: delete shelvedstate after a successful unshelve --continue

pulkit added inline comments. INLINE COMMENTS > test-shelve.t:1430 > +-- now, --continue should abort as the last unshelve was successful even > +-- though it was partially done. it can be completed without --continue. > + $ hg unshelve --continue the above sentence is confusing and maybe incor

D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve

pulkit added a comment. Sorry for not noticing this before, but this patch needs tests. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6708/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6708 To: navaneeth.suresh, #hg-reviewers, pulkit Cc: pul

Re: [PATCH 1 of 2] byteify-strings: add space in special comments to silence flake8 error

On Tue, Aug 6, 2019 at 3:59 PM Raphaël Gomès wrote: > > # HG changeset patch > # User Raphaël Gomès > # Date 1565095770 -7200 > # Tue Aug 06 14:49:30 2019 +0200 > # Node ID a6acc71d557b3606a048dd95f26e0b6988682a9c > # Parent 2c32f0d1ae622cdbe10c92a763f6fbec711d7668 > # EXP-Topic byteify-str

D6694: unshelve: delete shelvedstate after a successful unshelve --continue

pulkit added a comment. This fails to apply on tip of default. Can you rebase and resend? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6694/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6694 To: navaneeth.suresh, #hg-reviewers, durin42, pul

D6694: unshelve: delete shelvedstate after a successful unshelve --continue

pulkit added inline comments. INLINE COMMENTS > test-shelve.t:1436 > + $ hg shelve --list > + default-01 (1s ago)changes to: add A to bars > + default (1s ago)changes to: add B to foo These timing needs to be globbed. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6686: unshelve: handle stripping changesets on interactive mode

pulkit added a comment. I am not sure why, but `test-shelve.t` fails for me with some hash changes. Can you have a look? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6686/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6686 To: navaneeth.sur

D6708: unshelve: clear shelvedstate and _finishunshelve() on partial unshelve

pulkit added inline comments. INLINE COMMENTS > shelve.py:1008 > if not ispartialunshelve: > _forgetunknownfiles(repo, shelvectx, addedbefore) > unshelvecleanup(ui, repo, basename, opts) IIUC, we don't need `_forgetunknownfiles()` too in this if statement. Can

D6699: tests: add test for unshelve --interactive --keep

pulkit added inline comments. INLINE COMMENTS > test-shelve.t:1476 > + > + $ hg shelve --list > + default (1s ago)changes to: add B to foo Can you show what the new shelve contains? Also add a test when there is partial unshelving going. REPOSITORY rHG Mercurial CHANGES SINC

D6701: tests: sort imports in test-bookmarks-corner-case.t

Closed by commit rHGcfb774aae660: tests: sort imports in test-bookmarks-corner-case.t (authored by pulkit). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHAN

D6702: py3: add one more test to list of passing tests

Closed by commit rHG6d50a7ebf7e0: py3: add one more test to list of passing tests (authored by pulkit). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D6702: py3: add one more test to list of passing tests

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Found by buildbot. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6702 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS di

D6701: tests: sort imports in test-bookmarks-corner-case.t

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY test-check-module-imports.t breaks on py3 without this change. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6701 AFFECTED FILES t

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

pulkit added a comment. `test-commit-interactive.t` and some other tests fail for me with this, can you have a look? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6697/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6697 To: navaneeth.suresh,

Re: [PATCH STABLE] curses: do not setlocale() at import time (issue5261)

Seems like it was not queued, so I queued it. On Sat, Jul 27, 2019 at 2:17 AM Augie Fackler wrote: > > queued for stable, thanks > > > On Jul 25, 2019, at 8:42 AM, Yuya Nishihara wrote: > > > > # HG changeset patch > > # User Yuya Nishihara > > # Date 1564057709 -32400 > > # Thu Jul 25 21:

Re: [PATCH 1 of 2 STABLE] automation: allow exit code of 1 for `hg push`

On Mon, Jul 29, 2019 at 4:41 AM Gregory Szorc wrote: > > # HG changeset patch > # User Gregory Szorc > # Date 1564362968 25200 > # Sun Jul 28 18:16:08 2019 -0700 > # Branch stable > # Node ID 9905d2b89f8ca2f542cd79986a0daf4bd72766d1 > # Parent 7fae3b0bd893b75e0fb65ad3032b7532089e2341 > auto

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. > cmdutil: add allowunfinished to prevent checkunfinished() on docommit() s/docommit/dorecord/ in flight REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-s

D6686: unshelve: handle stripping changesets on interactive mode

pulkit added a comment. In D6686#97957 , @navaneeth.suresh wrote: > I just found that this change is not required while creating D6694 . We will be needing the nodes which we are removing for later in case

D6685: unshelve: changes how date is set on interactive mode

pulkit added a comment. > the remaining changes are shelved again for later. the shelve is updated with remaining changes. (mentioning update is important because we are not creating a new shelve, we are updating that shelve) > This patch modifies the date of remaining shelved c

D6683: unshelve: unify logic around creating an unshelve changeset

pulkit added inline comments. INLINE COMMENTS > shelve.py:812 > +Here, we return both the newnode which is created interactively and a > +bool to know whether the shelve is partly done or completely done. > """ How about: Handles creation of unshelve commit and updating the shelv

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

pulkit added inline comments. INLINE COMMENTS > cmdutil.py:274 > """ > -if not opts.get('interactive-unshelve'): > +if not (allowunfinished or opts.get('interactive-unshelve')): > checkunfinished(repo, commit=True) Why not get rid of `interactive-shelve` pas

D6684: unshelve: modify --continue on interactive unshelve

pulkit added a comment. Sorry for getting this and the parent patch split before, after the recent improvements, it looks like they should be folded into one. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6684/new/ REVISION DETAIL https://phab.merc

D6688: unshelve: make basename as a mandatory argument for unshelvecontinue()

pulkit added a comment. In D6688#97899 , @navaneeth.suresh wrote: > In D6688#97859 , @pulkit wrote: > >> Can you explain in commit description as why this is done? > > This patch will become ob

D6685: unshelve: changes how date is set on interactive mode

pulkit added inline comments. INLINE COMMENTS > shelve.py:831 > user=shelvectx.user(), > -date=shelvectx.date()) > +date=dateutil.makedate()) > m = scmutil.matchfiles(repo, repo[snode].files()) We can just skip passing

<    3   4   5   6   7   8   9   10   11   12   >