akshjain.jain74 updated this revision to Diff 14508.
akshjain.jain74 marked 2 inline comments as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6123?vs=14487&id=14508
REVISION DETAIL
https://phab.mercurial-scm.org/D6123
AFFECTED FILES
mercurial/
akshjain.jain74 added inline comments.
INLINE COMMENTS
> pulkit wrote in similar.py:68
> no need for this else. you can `return 0` without else.
yes actually 😅 i did'nt noticed that
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6123
To: akshjain.jain74, durin42
akshjain.jain74 added a comment.
thanks for the review
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6123
To: akshjain.jain74, durin42, #hg-reviewers
Cc: av6, pulkit, mercurial-devel
___
Mercurial-devel mailing list
M
akshjain.jain74 added a comment.
In https://phab.mercurial-scm.org/D6123#89410, @pulkit wrote:
> Can you try to add a test for this?
yes i can definitely try to add test for this
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6123
To: akshjain.jain7
akshjain.jain74 updated this revision to Diff 14487.
akshjain.jain74 retitled this revision from "ZeroDivisionError: Add condition
to avoid Zerodivisonerror due to float number (issue6099)" to "similar: add
condition to avoid Zerodivisonerror in function _score() (issue6099)".
REPOSITORY
rHG M
akshjain.jain74 created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6128
AFFECTED FILES
hgext/histedit.py
hgext/pager.py
merc
akshjain.jain74 added a comment.
actually i am not getting what can be the proper topic for this :(
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6123
To: akshjain.jain74, durin42, #hg-reviewers
Cc: av6, pulkit, mercurial-devel
akshjain.jain74 added a comment.
sorry for that , but can you tell me in what condition this function will
return none value?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6123
To: akshjain.jain74, durin42, #hg-reviewers
Cc: av6, pulkit, mercurial-devel
__
akshjain.jain74 updated this revision to Diff 14482.
akshjain.jain74 retitled this revision from "Experimental features: Add
condition to for float number (issue6099)" to "ZeroDivisionError: Add condition
to avoid Zerodivisonerror due to float number (issue6099)".
REPOSITORY
rHG Mercurial
CHA
akshjain.jain74 added a comment.
Sorry for the various mistake
I will correct everything in an hour thanks
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6123
To: akshjain.jain74, durin42, #hg-reviewers
Cc: av6, pulkit, mercurial-devel
___
akshjain.jain74 added a comment.
Oh sorry ,my bad I think that is by mistake I will correct it now
Ithink while committing I added that file by mistake
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6123
To: akshjain.jain74, durin42, #hg-reviewers
Cc: pulkit,
akshjain.jain74 created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6123
AFFECTED FILES
hgext/histedit.py
mercurial/similar.py
akshjain.jain74 added a comment.
In https://phab.mercurial-scm.org/D6026#88552, @pulkit wrote:
> I am not sure the new message is much helpful. As JordiGH and others
pointed out on IRC, it will definitely be helpful if we can show which
operation has the lock right now.
>
> Something
akshjain.jain74 added a comment.
okay @pulkit let me work upon your suggestion and
INLINE COMMENTS
> pulkit wrote in test-lock-badness.t:18
> still here are unrealted changes.
I accept these changes while running test, if i am not changing this then it
will cause test failing
REPOSITORY
akshjain.jain74 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6043
AFFECTED FILES
hg
hgext/pager.py
hgext/phabricator.py
mercurial/dispatch.py
mercur
akshjain.jain74 updated this revision to Diff 14291.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6026?vs=14279&id=14291
REVISION DETAIL
https://phab.mercurial-scm.org/D6026
AFFECTED FILES
hgext/journal.py
mercurial/lock.py
tests/test-check-pyfl
akshjain.jain74 marked an inline comment as done.
akshjain.jain74 added a comment.
@pulkit done changes as per your suggestion in lock file too but what did you
meant by storelock?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6026
To: akshjain.jain74, #hg-rev
akshjain.jain74 updated this revision to Diff 14279.
akshjain.jain74 marked 2 inline comments as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6026?vs=14277&id=14279
REVISION DETAIL
https://phab.mercurial-scm.org/D6026
AFFECTED FILES
hgext/jour
akshjain.jain74 updated this revision to Diff 14277.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6026?vs=14274&id=14277
REVISION DETAIL
https://phab.mercurial-scm.org/D6026
AFFECTED FILES
hgext/journal.py
tests/test-lock-badness.t
CHANGE DETAILS
akshjain.jain74 updated this revision to Diff 14274.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6026?vs=14273&id=14274
REVISION DETAIL
https://phab.mercurial-scm.org/D6026
AFFECTED FILES
hgext/journal.py
tests/test-lock-badness.t
CHANGE DETAILS
akshjain.jain74 updated this revision to Diff 14273.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6026?vs=14272&id=14273
REVISION DETAIL
https://phab.mercurial-scm.org/D6026
AFFECTED FILES
hgext/journal.py
tests/test-lock-badness.t
CHANGE DETAILS
akshjain.jain74 updated this revision to Diff 14272.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6026?vs=14271&id=14272
REVISION DETAIL
https://phab.mercurial-scm.org/D6026
AFFECTED FILES
hgext/journal.py
tests/test-lock-badness.t
CHANGE DETAILS
akshjain.jain74 updated this revision to Diff 14271.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6026?vs=14244&id=14271
REVISION DETAIL
https://phab.mercurial-scm.org/D6026
AFFECTED FILES
hgext/journal.py
tests/test-lock-badness.t
CHANGE DETAILS
akshjain.jain74 added a comment.
Ya I am sending that just trying to find out the file
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6026
To: akshjain.jain74, #hg-reviewers
Cc: pulkit, mercurial-devel
___
Mercurial-d
akshjain.jain74 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6026
AFFECTED FILES
tests/test-lock-badness.t
CHANGE DETAILS
diff --git a/tests/test-lock-bad
akshjain.jain74 added a comment.
okay , thanks @martinvonz
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5967
To: akshjain.jain74, durin42, #hg-reviewers, martinvonz
Cc: martinvonz, mercurial-devel
___
Mercurial-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGdf1f3ba56157: chistedit: improve proper username in
histedit curses interface (authored by akshjain.jain74, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-
akshjain.jain74 created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5967
AFFECTED FILES
hgext/histedit.py
CHANGE DETAILS
diff -
akshjain.jain74 added a comment.
okay
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5941
To: akshjain.jain74, #hg-reviewers, pulkit
Cc: pulkit, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercuria
akshjain.jain74 added a comment.
@pulkit like what else we required to improve the documentation for the issue
, in general what tweakdefault do for mercurial is already mention in the issue
🤔
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5941
To: akshjain.ja
akshjain.jain74 updated this revision to Diff 14079.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5941?vs=14050&id=14079
REVISION DETAIL
https://phab.mercurial-scm.org/D5941
AFFECTED FILES
mercurial/help/config.txt
CHANGE DETAILS
diff --git a/merc
akshjain.jain74 updated this revision to Diff 14078.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5743?vs=13571&id=14078
REVISION DETAIL
https://phab.mercurial-scm.org/D5743
AFFECTED FILES
mercurial/patch.py
tests/test-commit-interactive.t
tests
akshjain.jain74 updated this revision to Diff 14050.
akshjain.jain74 retitled this revision from "config.txt: Add better
documentation for ui.tweakdefault
(issue6000)" to "tweakdefault: Add better documentation for ui.tweakdefault
(issue6000)".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDAT
akshjain.jain74 updated this revision to Diff 14038.
akshjain.jain74 retitled this revision from "config.txt: Add better
documentation for ui.tweakdefault
(issue6000)" to "config.txt: Add better documentation for ui.tweakdefault
(issue6000)
***
config.txt: Add better documentation for ui.tweakdefa
akshjain.jain74 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5941
AFFECTED FILES
mercurial/help/config.txt
CHANGE DETAILS
diff --git a/mercurial/help/conf
35 matches
Mail list logo