D8079: manifest: remove `.new()` from the interface

Closed by commit rHGc86256bd4eb8: manifest: remove `.new()` from the interface (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D8083: archival: use walk() instead of matches() on manifest

Closed by commit rHG2d1b2ad3705b: archival: use walk() instead of matches() on manifest (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D8085: manifest: move matches method to be outside the interface

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In order to adequately smoke out any legacy consumers of the method, we rename it to _matches so it's clear that it's class-private. To my amazement, all

D8084: merge: use manifestdict.walk() instead of manifestdict.matches()

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As with other patches in this series, this avoids making a potentially-expensive copy of a manifest. REPOSITORY rHG Mercurial BRANCH default REVISION

D8082: manifest: rewrite filesnotin to not make superfluous manifest copies

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This also skips using diff() when all we care about is the filenames. I'm expecting the built in set logic to be plenty fast. For really large manifests with a

D8083: archival: use walk() instead of matches() on manifest

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY All we care about is the filepaths, so this avoids a pointless copy of the manifest that we only used to extract matching filenames. REPOSITORY rHG Mercurial

D8081: manifest: fix _very_ subtle bug with exact matchers passed to walk()

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Prior to this fix, manifestdict.walk() with an exact matcher would blindly list the files in the matcher, even if they weren't in the manifest. This was exposed

D8080: context: use manifest.walk() instead of manifest.match() to get file list

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The former doesn't create a whole extra manifest in order to produce the matching file list, which is all we actually cared about here. Sigh. REPOSITORY rHG

D8079: manifest: remove `.new()` from the interface

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Nothing used it. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8079 AFFECTED FILES

D8069: manifest: remove optional default= argument on flags(path)

Closed by commit rHGdbbae122f5e4: manifest: remove optional default= argument on flags(path) (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D8069: manifest: remove optional default= argument on flags(path)

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It had only one caller inside manifest.py, and treemanifest was actually incorrectly implemented. treemanifest is still missing the fastdelta() method from the

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 added a comment. I need to make some time to clean up the manifest implementation in this to land it, and then we'll need help improving it. It's not dead, just resting. :) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION

D7295: pytype: add a (very slow) test that executes pytype

durin42 added a comment. In D7295#118785 , @quark wrote: > Have `pyre` been considered? No, initially because I'd never heard of it, but now because I don't want to deal with ocaml. :) > It seems `pyre` only takes 10 seconds to check

D8030: uncopy: add support for unmarking committed copies

durin42 added a comment. durin42 accepted this revision as: durin42. In D8030#118489 , @martinvonz wrote: > In D8030#118480 , @durin42 wrote: > >> I'm conflicted on rolling the `uncopy &&

D7999: merge: make hg.merge() take a context instead of a node

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. Breaks `test-merge2.t` but otherwise seems like a good series. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7999/new/ REVISION DETAIL

D7974: merge: when rename was made on both sides, use ancestor as merge base

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. This one needs rebased. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7974/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7974

D8030: uncopy: add support for unmarking committed copies

durin42 added a comment. I'm conflicted on rolling the `uncopy && amend` action into the uncopy command like this. Could users not (without this patch) do `hg uncopy foo && hg amend`? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8030/new/ REVISION

D8029: uncopy: add new `hg uncopy` command

durin42 added a comment. In D8029#118464 , @martinvonz wrote: > In D8029#118463 , @marmoute wrote: > >> Coudl we use a flag for to `hg copy` for that ? something like `hg copy --forget` >

D7937: python-zstandard: blacken at 80 characters

durin42 added a comment. I'm -0 on auto-formatting third-party code at all, and that includes zstandard stuff. Why do we care if it's in the ignorelist? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7937/new/ REVISION DETAIL

D7932: [RFC]debugbackups: introduce command to interact with strip backups

durin42 added a comment. I'm +1 on having this functionality in core, FYI. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7932/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7932 To: pulkit, #hg-reviewers Cc: durin42, mercurial-devel

D7964: cext: change two more vars to Py_ssize_t in manifest.c

durin42 added a comment. Yes, I'll move this to stable. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7964/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7964 To: spectral, #hg-reviewers Cc: pulkit, durin42, martinvonz, mercurial-devel

D7788: rust-node: binary Node and conversion utilities

durin42 added a comment. Yes, I'd appreciate not adding any assumptions that nodes are 20 bytes. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7788/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7788 To: gracinet, #hg-reviewers, kevincox,

D7910: rust-re2: add wrapper for calling Re2 from Rust

durin42 added a comment. In D7910#116208 , @kevincox wrote: > Does mercurial currently use RE2? If not then can you explain why we don't just use the rust `regex` crate? We have support for using re2 iff the correct Python bindings are

D7812: examples: specify rustfmt nightly using a $() construct

Closed by commit rHG6e13b31f83b5: examples: specify rustfmt nightly using a $() construct (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7812?vs=19087=19210

D7813: revlog: run rustfmt nightly

Closed by commit rHG625691953552: revlog: run rustfmt nightly (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7813?vs=19088=19211 CHANGES SINCE LAST ACTION

D7849: core: migrate uses of hashlib.sha1 to hashutil.sha1

Closed by commit rHG4ebd162f4d8c: core: migrate uses of hashlib.sha1 to hashutil.sha1 (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7849?vs=19190=19200

D7851: hgext: replace references to hashlib.sha1 with hashutil.sha1

Closed by commit rHG006e7821704a: hgext: replace references to hashlib.sha1 with hashutil.sha1 (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7815: sha1dc: initial implementation of Python extension

Closed by commit rHGbde1cd4c99d9: sha1dc: initial implementation of Python extension (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7815?vs=19188=19198

D7850: sslutil: migrate to hashutil.sha1 instead of hashlib.sha1

Closed by commit rHGfde05ece875c: sslutil: migrate to hashutil.sha1 instead of hashlib.sha1 (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7850?vs=19191=19201

D7848: hashutil: new package for hashing-related features

Closed by commit rHG0803f803ba03: hashutil: new package for hashing-related features (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7848?vs=19189=19199

D7849: core: migrate uses of hashlib.sha1 to hashutil.sha1

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7849 AFFECTED FILES mercurial/chgserver.py mercurial/exchange.py mercurial/hg.py

D7850: sslutil: migrate to hashutil.sha1 instead of hashlib.sha1

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a straight-line replacement like the others, but I split it out since it's used in a network context and I'm not sure this is appropriate (we should

D7815: sha1dc: initial implementation of Python extension

durin42 marked an inline comment as done. durin42 updated this revision to Diff 19188. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7815?vs=19119=19188 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7815/new/ REVISION

D7848: hashutil: new package for hashing-related features

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Right now this just tries to use our sha1dc and if it's missing (eg a --pure build) we fall back to hashlib. I imagine in the future we'll want some other

D7815: sha1dc: initial implementation of Python extension

durin42 added a comment. durin42 marked 3 inline comments as done. Good call on tests, I had the return type of `hexdigest()` wrong. Please do let me know if you think of any missing cases here. INLINE COMMENTS > indygreg wrote in cext.c:68 > I'm not super keen on overloading

D7815: sha1dc: initial implementation of Python extension

durin42 edited the summary of this revision. durin42 retitled this revision from "sha1dc: initial implementation of Python extension (NOT READY)" to "sha1dc: initial implementation of Python extension". durin42 updated this revision to Diff 19119. REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7815: sha1dc: initial implementation of Python extension (NOT READY)

durin42 added inline comments. durin42 marked 4 inline comments as done. INLINE COMMENTS > spectral wrote in cext.c:24 > Nit: "clang-format on" (typo: s/oon/on/) Good catch! > spectral wrote in cext.c:104 > I think you need a {NULL} entry here, or else it's going to walk off the end > of this

D7815: sha1dc: initial implementation of Python extension (NOT READY)

durin42 updated this revision to Diff 19116. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7815?vs=19115=19116 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7815/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7815

D7815: sha1dc: initial implementation of Python extension (NOT READY)

durin42 edited the summary of this revision. durin42 updated this revision to Diff 19115. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7815?vs=19113=19115 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7815/new/ REVISION

D7815: sha1dc: initial implementation of Python extension (NOT READY)

durin42 updated this revision to Diff 19113. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7815?vs=19112=19113 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7815/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7815

D7815: sha1dc: initial implementation of Python extension (NOT READY)

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is not yet ready: there's some bug (probably a simple oversight) that causes it to segfault inside PyType_Ready() during import of the module.

D7617: fix: make example fix hgrc work in subdirs

durin42 added a comment. Now that D7570 is landed, this is obsolete, right? REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7617/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7617 To:

D7712: lfs: don't skip locally available blobs when verifying

This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision. Needs rebased. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7712/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7712 To:

D7576: hg-core: add configparser to library

durin42 added a comment. I'm a little lost on the state of this. It looks like we need to downgrade the required Rust version? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7576/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7576 To:

D7808: mmap: add a size argument to mmapread

durin42 added inline comments. INLINE COMMENTS > marmoute wrote in util.py:419-422 > passing 0 in `mmap.mmap(fd, 0, access=mmap.ACCESS_READ)` get you "all the > byte you can eat". That's is not 0 sized mmap. > > The `size` argument for `util.mmapread` is (after this patch). If size is > None

D7813: revlog: run rustfmt nightly

durin42 created this revision. Herald added subscribers: mercurial-devel, kevincox. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm a little nervous about folding this back (might be nightly rustfmt mismatches?) so I want someone to review this. REPOSITORY rHG Mercurial BRANCH

D7812: examples: specify rustfmt nightly using a $() construct

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is ugly, but it's how we have to configure rustfmt for now as we require nightly rustfmt. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D7733: hgext: initial version of fastexport extension

durin42 added a comment. durin42 accepted this revision as: durin42. I only did a light pass, but looks good to me. Any plans for a fast-export importer as well? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7733/new/ REVISION DETAIL

D7807: hgrc: introduce HGRCSKIPREPO to skip reading the hgrc's repository

durin42 added inline comments. durin42 added subscribers: krbullock, durin42. INLINE COMMENTS > scripting.txt:80 > + > +Note that these approaches can have unintended consequences, as the > +repository config files might define things like extensions that may Awkward. Maybe: Note that

D7683: examples: add an example configuration for go source files

Closed by commit rHGb78795c2a294: examples: add an example configuration for go source files (authored by durin42). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7683: examples: add an example configuration for go source files

durin42 updated this revision to Diff 18827. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7683?vs=18826=18827 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7683/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7683 AFFECTED FILES

D7683: examples: add an example configuration for go source files

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Tested by timeless. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7683 AFFECTED FILES contrib/examples/fix.hgrc CHANGE DETAILS

D7615: procutil: try and avoid angering CoreFoundation on macOS

Closed by commit rHGa89381e04c58: procutil: try and avoid angering CoreFoundation on macOS (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7615?vs=18755=18807

D7679: windows: if username(uid=None) is loaded, just use getpass

Closed by commit rHG1b26cb044097: windows: if username(uid=None) is loaded, just use getpass (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7679: windows: if username(uid=None) is loaded, just use getpass

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is at least consistent with what we do on other platforms in the base case. I don't know enough about Windows to fill in other cases that might exist here,

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 updated this revision to Diff 18757. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=18756=18757 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6734 AFFECTED FILES

D6734: git: RFC of a new extension to _directly_ operate on git repositories

durin42 edited the summary of this revision. durin42 updated this revision to Diff 18756. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6734?vs=17007=18756 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6734/new/ REVISION DETAIL

D7615: procutil: try and avoid angering CoreFoundation on macOS

durin42 updated this revision to Diff 18755. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7615?vs=18645=18755 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7615/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7615 AFFECTED FILES

D7615: procutil: try and avoid angering CoreFoundation on macOS

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We've seen failures like this: objc[57662]: +[__NSCFConstantString initialize] may have been in progress in another thread when fork() was called.

D7592: fuzz: add support for fuzzing under either Python 2 or 3

Closed by commit rHG8766728dbce6: fuzz: add support for fuzzing under either Python 2 or 3 (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7592?vs=18559=18630

D7575: hg-core: vendor Facebook's configparser crate

durin42 added inline comments. INLINE COMMENTS > Alphare wrote in c_api.rs:1 > Do we need bindings to C ? I don't see what the use-case is at this stage of > the Rust development. +1, I'm not sure what the use case for this would be in core. REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7522: rust-dirs: handle forgotten `Result`s

durin42 added a comment. durin42 resigned from this revision. This needs a rebase that I'm not sure I can accomplish correctly. Could you take a look? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7522/new/ REVISION DETAIL

D7570: match: resolve filesets against the passed `cwd`, not the current one

This revision is now accepted and ready to land. durin42 added a comment. durin42 accepted this revision. I'm happy with this, but didn't spend time figuring out if all concerns have been addressed (I'm mostly doing a fast triage path). REPOSITORY rHG Mercurial BRANCH default CHANGES

D7595: status: outputting structured unfinished-operation information

durin42 added inline comments. INLINE COMMENTS > rdamazio wrote in configitems.py:247 > I'm fine with removing the config option, but will let yuja reply first. > About being BC or not - it depends on how people are parsing the JSON output > :) If they're either turning off morestatus for

D7517: filemerge: byteify the open() mode

durin42 added a comment. I'm a little fuzzy on this: should I see some test failures? or...? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7517/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7517 To: mharbison72, #hg-reviewers Cc: durin42,

D7600: fuzz: add a seed corpus for the dirs fuzzer

Closed by commit rHGb7af8a02a304: fuzz: add a seed corpus for the dirs fuzzer (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7600?vs=18594=18608 CHANGES

D7599: fuzz: clean up production of seed corpora

Closed by commit rHGd74d78aa74e9: fuzz: clean up production of seed corpora (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7599?vs=18593=18607 CHANGES SINCE

D7600: fuzz: add a seed corpus for the dirs fuzzer

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I was hoping to trigger an asan violation under Python 3 that some internal tests at Google found, but for some reason that's beyond me I can't seem to manage.

D7599: fuzz: clean up production of seed corpora

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was getting out of hand. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7599 AFFECTED FILES

D7579: tests: add test for Rust formatting

durin42 added a comment. What are we depending on in the rustfmt settings that's nightly behavior? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7579/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7579 To: indygreg, #hg-reviewers, Alphare,

D7557: annotate: describe --skip as taking a revset

Closed by commit rHGa6483107a07a: annotate: describe --skip as taking a revset (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7557?vs=18495=18575 CHANGES

D7596: tests: replace [[]] bashism with portable [] invocation

Closed by commit rHG36444dddaeb4: tests: replace [[]] bashism with portable [] invocation (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7596?vs=18568=18579

D7596: tests: replace [[]] bashism with portable [] invocation

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In this case nothing fancy is required. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7596 AFFECTED FILES tests/test-amend.t

D7592: fuzz: add support for fuzzing under either Python 2 or 3

durin42 added a comment. Note: please review the embedded Python segments carefully, as it's a little fidgety to get right and verify I didn't do something Really Dumb. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7592/new/ REVISION DETAIL

D7592: fuzz: add support for fuzzing under either Python 2 or 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was more of a hairball than I hoped, but it appears to work. The hg-py3 branch of my oss-fuzz fork on github has the remaining changes to switch us to

D7584: procutil: add a option to not fully detach background process

This revision now requires changes to proceed. durin42 added inline comments. durin42 requested changes to this revision. INLINE COMMENTS > procutil.py:589 > + > +When `register_wait` is not None, the spawned process will not be > fully > +detached and the `record_wait` argument

D7585: remotefilelog: add a developer option to wait for background processes

durin42 added inline comments. INLINE COMMENTS > shallowrepo.py:237 > +if repo.ui.configbool(b'devel', b'remotefilelog.bg-wait'): > +kwargs['record_wait'] = repo.ui.atexit > + It took me some very careful reasoning to figure this out. Could you amend the log message

D7590: remotefilelog: remove the `ensurestart` usage

durin42 added a comment. This is wrong, because now remotefilelog will do ensurestart=True (the default) which is a significant performance hit for remotefilelog users. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7590/new/ REVISION DETAIL

D7590: remotefilelog: remove the `ensurestart` usage

durin42 added a comment. Wait, I just saw the chain. Thanks for weird emails phabricator! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7590/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7590 To: marmoute, #hg-reviewers Cc: durin42,

D7590: remotefilelog: remove the `ensurestart` usage

durin42 added a comment. This doesn't apply to stable. I also checked default, and it doesn't apply there either. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7590/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7590 To: marmoute,

D7564: fuzz: use a more standard approach to allow local builds of fuzzers

Closed by commit rHG28a91a581fd9: fuzz: use a more standard approach to allow local builds of fuzzers (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7567: fuzz: remove legacy setup for running fuzzers outside oss-fuzz

Closed by commit rHG7857bd9bb2b0: fuzz: remove legacy setup for running fuzzers outside oss-fuzz (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7568: fuzz: clean up some repetition on building parsers.so fuzzers

Closed by commit rHGceeff2d99cc9: fuzz: clean up some repetition on building parsers.so fuzzers (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7566: tests: finally fix up test-fuzz-targets.t

Closed by commit rHGece907920139: tests: finally fix up test-fuzz-targets.t (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7566?vs=18504=18517 CHANGES SINCE

D7565: fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize

Closed by commit rHG01ec70a80a7b: fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7560: fuzz: always define LLVMFuzzerInitialize() even if we don't need it

Closed by commit rHG0a56e5f26a52: fuzz: always define LLVMFuzzerInitialize() even if we dont need it (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7563: fuzz: use a variable to allow specifying python-config to use

Closed by commit rHG4445e2775066: fuzz: use a variable to allow specifying python-config to use (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7562: fuzz: suppress deprecated-register warnings in our compile

Closed by commit rHG28be1932f61f: fuzz: suppress deprecated-register warnings in our compile (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7561: fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE

Closed by commit rHG7cb99887bcc3: fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7561?vs=18499=18512

D7559: fuzz: remove debug prints from revlog_corpus.py

Closed by commit rHG98eb12eab5e5: fuzz: remove debug prints from revlog_corpus.py (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7559?vs=18497=18510 CHANGES

D7558: fuzz: fix an unused result on getcwd() in pyutil

Closed by commit rHGf6c0b0510b49: fuzz: fix an unused result on getcwd() in pyutil (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7558?vs=18496=18509 CHANGES

D7568: fuzz: clean up some repetition on building parsers.so fuzzers

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There was a lot of repetition here that I realized could be cleared out. I think there's some more work we could do here, but this is enough for now.

D7564: fuzz: use a more standard approach to allow local builds of fuzzers

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is taken from the (improved since we started fuzzing) guide on ideal integrations. Rather than have our own wonky targets for building outside the fuzzer

D7567: fuzz: remove legacy setup for running fuzzers outside oss-fuzz

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We don't need this anymore. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7567 AFFECTED FILES contrib/fuzz/Makefile

D7566: tests: finally fix up test-fuzz-targets.t

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's been failing on my workstation for a while, since I have a new enough LLVM that I had the fuzzer goo, but not so new that I actually had

D7565: fuzz: make standalone_fuzz_target_runner call LLVMFuzzerInitialize

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise some of our fuzzers crash when they try and use Python. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7565 AFFECTED

D7560: fuzz: always define LLVMFuzzerInitialize() even if we don't need it

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will make it easier to test our fuzzers outside oss-fuzz. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7560 AFFECTED FILES

D7563: fuzz: use a variable to allow specifying python-config to use

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Eventually we should probably default this to just `python-config` and have the oss-fuzz build.sh script specify the sanpy python-config, but for now this lets

D7562: fuzz: suppress deprecated-register warnings in our compile

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These come from the Python.h headers still using the `register` keyword and our use of C++17. I think this will go away when we're using Python 3 for our

D7561: fuzz: follow modern guidelines and use LIB_FUZZING_ENGINE

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will make our lives easier in an upcoming change, but it's also how we're supposed to set things up anyway. REPOSITORY rHG Mercurial REVISION DETAIL

<    1   2   3   4   5   6   7   8   9   10   >