D11280: fix: reduce number of tool executions

hooper created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY By grouping together (path, ctx) pairs according to the inputs they would provide to fixer tools, we can deduplicate executions of fixer tools to significantly

D11279: fix: add test to demonstrate how many times tools are executed

hooper created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The current implementation wastes a lot of effort invoking fixer tools more than once on the same file name+content. It is good to track changes in this

D8287: fix: add a -s option to format a revision and its descendants

hooper added a comment. D8283 :D8288 all looks good to me. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8287/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8287

D7570: match: resolve filesets against the passed `cwd`, not the current one

hooper added inline comments. INLINE COMMENTS > martinvonz wrote in test-fix.t:1336-1342 > > `.::` doesn't include fixing wdir() > > Yes, that's how revsets work (as you noted) > > > `.` isn't updated unless `-w` is specified > > Yes, because otherwise the working directory would appear to

D7086: fix: remove a never-true check for unset pattern in Fixer.affects()

hooper added a comment. Looks good. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7086/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7086 To: martinvonz, #hg-reviewers Cc: hooper, mercurial-devel

D6975: fix: add :enabled sub-config for fixer tools

Closed by commit rHG808a57a08470: fix: add :enabled sub-config for fixer tools (authored by hooper). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D6975: fix: add :enabled sub-config for fixer tools

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This allows distributing opt-in fixer tool configurations in .hgrc files. This may be useful for adding default configs in core, or for orgranizations that want

D6726: fix: correctly parse the :metadata subconfig

Closed by commit rHGd82e9f7e7440: fix: correctly parse the :metadata subconfig (authored by hooper). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D6723: fix: allow tools to use :linerange, but also run if a file is unchanged

Closed by commit rHG69b37b7227f2: fix: allow tools to use :linerange, but also run if a file is unchanged (authored by hooper). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D6727: fix: pass line ranges as value instead of callback

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The callback no longer takes any arguments from the inner function, so we might as well call it sooner and pass the value instead. Note the value still needs to

D6726: fix: correctly parse the :metadata subconfig

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's being handled as a string instead of a bool, though the thruthiness of the string makes the feature still essentially work. Added a regression test.

D6723: fix: allow tools to use :linerange, but also run if a file is unchanged

hooper updated this revision to Diff 16181. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6723?vs=16178=16181 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6723/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6723 AFFECTED FILES

D6723: fix: allow tools to use :linerange, but also run if a file is unchanged

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The definition of "unchanged" here is subtle, because pure deletion diff hunks are ignored. That means this is different from using the --whole flag. This change

D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy

Closed by commit rHG74b4cd091e0d: fix: run fixer tools in the repo root as cwd so they can use the working copy (authored by hooper). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D6698: fix: add some new test cases

Closed by commit rHG4b04244f2d5f: fix: add some new test cases (authored by hooper). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6698?vs=16082=16094 CHANGES SINCE LAST ACTION

D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy

hooper added a comment. In D6440#97422 , @durin42 wrote: > I still think we should fix the cwd for fixers, but it seems Martin and I agree that repo-root is more consistent. Would you be willing to reroll with repo-root instead of cwd?

D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy

hooper updated this revision to Diff 16083. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6440?vs=15244=16083 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6440/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6440 AFFECTED FILES

D6698: fix: add some new test cases

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These cover a couple of behaviors we were testing at Google that weren't covered here before. REPOSITORY rHG Mercurial REVISION DETAIL

D6693: fix: ignore fixer tool configurations that are missing patterns

Closed by commit rHG2987d015aba4: fix: ignore fixer tool configurations that are missing patterns (authored by hooper). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR TO

D6692: fix: add a test case around the effect of cwd on pattern matching

Closed by commit rHG22c4bd7d1cbf: fix: add a test case around the effect of cwd on pattern matching (authored by hooper). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6691: fix: remove support for :fileset sub-config in favor of :pattern

Closed by commit rHG9ed63cd0026c: fix: remove support for :fileset sub-config in favor of :pattern (authored by hooper). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6693: fix: ignore fixer tool configurations that are missing patterns

hooper added inline comments. INLINE COMMENTS > martinvonz wrote in fix.py:738-739 > Is this change needed given the change above? It makes this function more robust. It might be called by someone who actually tries to use a Fixer with no pattern. > martinvonz wrote in test-fix.t:1280 > nit:

D6693: fix: ignore fixer tool configurations that are missing patterns

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is to prevent a crash under the same circumstances. This is also to avoid data loss due to accidental application of a fixer tool to all files, if the

D6692: fix: add a test case around the effect of cwd on pattern matching

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was not covered by previous tests. It is related to a regression encountered at Google due to misconfiguration of [fix]. REPOSITORY rHG Mercurial REVISION

D6691: fix: remove support for :fileset sub-config in favor of :pattern

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6691 AFFECTED FILES hgext/fix.py tests/test-fix.t CHANGE DETAILS diff --git a/tests/test-fix.t

D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy

hooper added inline comments. INLINE COMMENTS > durin42 wrote in fix.py:106 > I wonder if it'd be more generally useful to run the fixer in the repo root > than the same `pwd` as the command invocation. WDYT? It depends on whether we want to make it easier for tools that want to examine the

D6439: test: add missing 'cd ..' to test case

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb02f3aa2fab5: test: add missing cd .. to test case (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6439?vs=15243=15245

D6440: fix: let fixer tools inherit hg's cwd so they can look at the working copy

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This lets fixer tools do things like find configuration files, with the caveat that they'll only see the version of that file in the working copy, regardless of

D6439: test: add missing 'cd ..' to test case

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6439 AFFECTED FILES tests/test-fix.t CHANGE DETAILS diff --git a/tests/test-fix.t b/tests/test-fix.t

D6414: narrow: consider empty commits to be "inside the narrow spec" for templates

This revision was automatically updated to reflect the committed changes. Closed by commit rHG45c18f7345c1: narrow: consider empty commits to be inside the narrow spec for templates (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6414: narrow: consider empty commits to be "inside the narrow spec" for templates

hooper created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It doesn't seem useful to exclude them, or harmful to include them. Users writing log

D6313: remotefilelog: add missing argument to hg.verify wrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rHGbed4c308fc56: remotefilelog: add missing argument to hg.verify wrapper (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6313: remotefilelog: add missing argument to hg.verify wrapper

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6313 AFFECTED FILES hgext/remotefilelog/__init__.py CHANGE DETAILS diff --git

D6167: fix: allow fixer tools to return metadata in addition to the file content

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0da689a60163: fix: allow fixer tools to return metadata in addition to the file content (authored by hooper, committed by ). CHANGED PRIOR TO COMMIT

D6167: fix: allow fixer tools to return metadata in addition to the file content

hooper added inline comments. INLINE COMMENTS > martinvonz wrote in fix.py:559-570 > Would the thing that processes this metadata usually not care to aggregate > per fixer? If they did, it seems they would now have to look for a > `fixer-applied='my-fixer'` entry and then take the metadata

D6167: fix: allow fixer tools to return metadata in addition to the file content

hooper updated this revision to Diff 14901. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6167?vs=14581=14901 REVISION DETAIL https://phab.mercurial-scm.org/D6167 AFFECTED FILES hgext/fix.py tests/test-fix-metadata.t tests/test-fix.t CHANGE

D6165: fix: allow fixing untracked files when given as arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7f6b375a8903: fix: allow fixing untracked files when given as arguments (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6166: fix: make the order of the work queue deterministic

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8f427f7c1f71: fix: make the order of the work queue deterministic (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5516: fix: add some arguments to facilitate extensions

hooper abandoned this revision. hooper added a comment. See https://phab.mercurial-scm.org/D6167 for a newer approach. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5516 To: hooper, #hg-reviewers Cc: durin42, mercurial-devel

D6167: fix: allow fixer tools to return metadata in addition to the file content

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With this change, fixer tools can be configured to output a JSON object that will be parsed and passed to hooks that can be used to print summaries of what code

D6165: fix: allow fixing untracked files when given as arguments

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's more useful to fix the file than to silently avoid it when the user does this: hg fix --working-dir untracked-file We will still do nothing to

D6166: fix: make the order of the work queue deterministic

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes any output generated during the parallel phase of execution stable if parallelism is disabled. This helps write tests like that in the future.

D5516: fix: add some arguments to facilitate extensions

hooper added a comment. In https://phab.mercurial-scm.org/D5516#81841, @durin42 wrote: > In https://phab.mercurial-scm.org/D5516#81683, @hooper wrote: > > > In https://phab.mercurial-scm.org/D5516#81679, @durin42 wrote: > > > > > I'm -0 on this: what's special about this

D5517: tests: use more portable flags in test-fix.t

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd8f5c615e811: tests: use more portable flags in test-fix.t (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5517: tests: use more portable flags in test-fix.t

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `head --lines N` is known to not exist on OSX. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5517 AFFECTED FILES hgext/fix.py

D5516: fix: add some arguments to facilitate extensions

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For example, these additions allow wrapping `hg fix` to do things like: - Telling fixer tools what commit a file belongs to - Cleaning up temporary files

D5428: absorb: don't prompt to apply changes when there are none to apply

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa08e12149bcb: absorb: dont prompt to apply changes when there are none to apply (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5428: absorb: don't prompt to apply changes when there are none to apply

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5428 AFFECTED FILES hgext/absorb.py tests/test-absorb.t CHANGE DETAILS diff --git

D5245: fix: add extra field to fixed revisions to avoid creating obsolescence cycles

This revision was automatically updated to reflect the committed changes. Closed by commit rHGad71c792a8d8: fix: add extra field to fixed revisions to avoid creating obsolescence cycles (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5244: cleanup: use revision numbers instead of hashes in test output

This revision was automatically updated to reflect the committed changes. Closed by commit rHG19e1c26213f1: cleanup: use revision numbers instead of hashes in test output (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5245: fix: add extra field to fixed revisions to avoid creating obsolescence cycles

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The extra field prevents sequential invocations of fix from producing the same hash twice. Previously, this could cause problems because it would create an

D5244: cleanup: use revision numbers instead of hashes in test output

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This allows changes to the hashes produced by fix to not needlessly modify this area of the test. REPOSITORY rHG Mercurial REVISION DETAIL

D5237: fix: add suboption for configuring execution order of tools

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb9557567cc3f: fix: add suboption for configuring execution order of tools (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5237: fix: add suboption for configuring execution order of tools

hooper updated this revision to Diff 12473. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5237?vs=12461=12473 REVISION DETAIL https://phab.mercurial-scm.org/D5237 AFFECTED FILES hgext/fix.py tests/test-fix.t CHANGE DETAILS diff --git

D5237: fix: add suboption for configuring execution order of tools

hooper updated this revision to Diff 12461. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5237?vs=12460=12461 REVISION DETAIL https://phab.mercurial-scm.org/D5237 AFFECTED FILES hgext/fix.py tests/test-fix.t CHANGE DETAILS diff --git

D5237: fix: add suboption for configuring execution order of tools

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This could be accomplished by using wrapper scripts, but that would diminish the usefulness of the incremental formatting logic. Configuring execution order

D5226: fix: rename :fileset subconfig to :pattern

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2ecf5c24d0cd: fix: rename :fileset subconfig to :pattern (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5226?vs=12437=12446

D5200: fix: add a config to abort when a fixer tool fails

This revision was automatically updated to reflect the committed changes. Closed by commit rHG93bab80993f4: fix: add a config to abort when a fixer tool fails (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5226: fix: rename :fileset subconfig to :pattern

hooper updated this revision to Diff 12437. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5226?vs=12436=12437 REVISION DETAIL https://phab.mercurial-scm.org/D5226 AFFECTED FILES hgext/fix.py tests/test-fix-clang-format.t

D5226: fix: rename :fileset subconfig to :pattern

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This name was always inaccurate, since the config accepts any pattern. Hopefully so few people use this right now that it won't matter, but there will now be a

D5200: fix: add a config to abort when a fixer tool fails

hooper added a comment. In https://phab.mercurial-scm.org/D5200#77865, @yuja wrote: > Looks good, but test-check-config.t failed probably because the doc couldn't > be found by the checker. Looks like it's picky about whitespace. REPOSITORY rHG Mercurial REVISION DETAIL

D5200: fix: add a config to abort when a fixer tool fails

hooper updated this revision to Diff 12435. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5200?vs=12355=12435 REVISION DETAIL https://phab.mercurial-scm.org/D5200 AFFECTED FILES hgext/fix.py tests/test-fix.t CHANGE DETAILS diff --git

D5103: beautifygraph: don't substitute anything for 'X' in rendered graphs

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc2a0bc6412db: beautifygraph: dont substitute anything for X in rendered graphs (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5102: beautifygraph: add configs for customizing the characters

hooper added a comment. I'll elaborate a bit. I think the idea of using unicode to make the graph good looking is flawed. There are no characters that properly serve common cases like this: o | \ o That's part of why there was some disagreement in early discussion

D5102: beautifygraph: add configs for customizing the characters

hooper updated this revision to Diff 12138. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5102?vs=12130=12138 REVISION DETAIL https://phab.mercurial-scm.org/D5102 AFFECTED FILES hgext/beautifygraph.py tests/test-glog-beautifygraph.t CHANGE

D5102: beautifygraph: add configs for customizing the characters

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I figure we should keep this out of graphmod.py and templatekw.py for now. Moving the extension functionality out of hgext is a separate issue. Calling

D5103: beautifygraph: don't substitute anything for 'X' in rendered graphs

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It looks like we never actually render graphs this way, although there's an example in a comment next to the code that prevents it from being needed (see

D4158: fix: determine fixer tool failure by exit code instead of stderr

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa009589cd32a: fix: determine fixer tool failure by exit code instead of stderr (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4158: fix: determine fixer tool failure by exit code instead of stderr

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This seems like the more natural thing, and it probably should have been this way to beign with. It is more flexible because it allows tools to emit diagnostic

D4146: fix: correctly set wdirwritten given that the dict item is deleted

This revision was automatically updated to reflect the committed changes. Closed by commit rHG35bc4b6e132d: fix: correctly set wdirwritten given that the dict item is deleted (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4145: fix: pull out flag definitions to make them re-usable from extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb0c591950e51: fix: pull out flag definitions to make them re-usable from extensions (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4146: fix: correctly set wdirwritten given that the dict item is deleted

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4146 AFFECTED FILES hgext/fix.py CHANGE DETAILS diff --git a/hgext/fix.py b/hgext/fix.py ---

D4145: fix: pull out flag definitions to make them re-usable from extensions

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes it cleaner to implement fix-related commands with additional functionality while sharing some flags with the core implementation. REPOSITORY rHG

D4100: fix: compute changed lines lazily to make whole-file fixer tools faster

This revision was automatically updated to reflect the committed changes. Closed by commit rHG257c9846b532: fix: compute changed lines lazily to make whole-file fixer tools faster (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4100: fix: compute changed lines lazily to make whole-file fixer tools faster

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4100 AFFECTED FILES hgext/fix.py CHANGE DETAILS diff --git a/hgext/fix.py b/hgext/fix.py ---

D4048: fix: add a monkey-patchable point after all new revisions have been committed

hooper added inline comments. INLINE COMMENTS > pulkit wrote in fix.py:197 > If the output is not Google specific, we can have that here also under `hg > fix -v` or a config option. Unfortunately, some of it is, though that might just mean we should template it. I think there's also some

D4048: fix: add a monkey-patchable point after all new revisions have been committed

This revision was automatically updated to reflect the committed changes. Closed by commit rHG64535d43c103: fix: add a monkey-patchable point after all new revisions have been committed (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4048: fix: add a monkey-patchable point after all new revisions have been committed

hooper updated this revision to Diff 9769. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4048?vs=9768=9769 REVISION DETAIL https://phab.mercurial-scm.org/D4048 AFFECTED FILES hgext/fix.py CHANGE DETAILS diff --git a/hgext/fix.py b/hgext/fix.py ---

D4048: fix: add a monkey-patchable point after all new revisions have been committed

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4048 AFFECTED FILES hgext/fix.py CHANGE DETAILS diff --git a/hgext/fix.py b/hgext/fix.py ---

D3960: worker: use one pipe per posix worker and select() in parent process

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9e6afe7fca31: worker: use one pipe per posix worker and select() in parent process (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3960: worker: use one pipe per posix worker and select() in parent process

hooper added a comment. Do you want to move the selector import stuff to pycompat? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3960 To: hooper, #hg-reviewers Cc: yuja, mercurial-devel ___ Mercurial-devel mailing

D3960: worker: use one pipe per posix worker and select() in parent process

hooper updated this revision to Diff 9626. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3960?vs=9618=9626 REVISION DETAIL https://phab.mercurial-scm.org/D3960 AFFECTED FILES mercurial/worker.py CHANGE DETAILS diff --git a/mercurial/worker.py

D3960: worker: use one pipe per posix worker and select() in parent process

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This allows us to pass results larger than PIPE_BUF through the pipes without interleaving them. This is necessary now because "hg fix" sends file contents as

D3949: shelve: improve help text for --patch and --stat

This revision was automatically updated to reflect the committed changes. Closed by commit rHGabcf500d527c: shelve: improve help text for --patch and --stat (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3950: shelve: pick the most recent shelve if none specified for --patch/--stat

This revision was automatically updated to reflect the committed changes. Closed by commit rHG905b66681004: shelve: pick the most recent shelve if none specified for --patch/--stat (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3949: shelve: improve help text for --patch and --stat

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's not currently obvious why "hg shelve -p" fails, since -p doesn't take an argument. REPOSITORY rHG Mercurial REVISION DETAIL

D3897: tests: prevent conflict markers in test case from triggering warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rHG02850baddadd: tests: prevent conflict markers in test case from triggering warnings (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3897: tests: prevent conflict markers in test case from triggering warnings

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Broadly, having lines that begin with several '<' tends to trigger tools that try to warn you about unresolved conflicts. It will save some headaches to tweak

D3894: fix: add test case that shows why --whole with --base is useful

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf068495a1c28: fix: add test case that shows why --whole with --base is useful (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3894: fix: add test case that shows why --whole with --base is useful

hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3894 AFFECTED FILES hgext/fix.py tests/test-fix.t CHANGE DETAILS diff --git a/tests/test-fix.t

D3848: fix: add progress bar for number of file revisions processed

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc8961e9b2f5e: fix: add progress bar for number of file revisions processed (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3845: worker: support more return types in posix worker

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8c38d2948217: worker: support more return types in posix worker (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3846: fix: use a worker pool to parallelize running tools

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5ffe2041d427: fix: use a worker pool to parallelize running tools (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3847: fix: disallow 'hg fix --base --whole'

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3a2c57dfea60: fix: disallow hg fix --base rev --whole (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3847?vs=9366=9431

D3847: fix: disallow 'hg fix --base --whole'

hooper added a comment. Let's not commit this one if possible. I have another patch with a test case that shows the combination is useful. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3847 To: hooper, #hg-reviewers, durin42 Cc: mercurial-devel

D3845: worker: support more return types in posix worker

hooper added a comment. Yuya, it had passed tests for me with cbor, so is that a portability issue? One of the benefits of pickle/marshal is that we don't lose information, like when tuples become lists. That would be an insidious problem for callers. Also, in case it wasn't

D3845: worker: support more return types in posix worker

hooper updated this revision to Diff 9418. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3845?vs=9401=9418 REVISION DETAIL https://phab.mercurial-scm.org/D3845 AFFECTED FILES mercurial/worker.py CHANGE DETAILS diff --git a/mercurial/worker.py

D3845: worker: support more return types in posix worker

hooper updated this revision to Diff 9401. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3845?vs=9364=9401 REVISION DETAIL https://phab.mercurial-scm.org/D3845 AFFECTED FILES mercurial/worker.py CHANGE DETAILS diff --git a/mercurial/worker.py

D3861: scmutil: fix __enter__ in progress context manager

hooper updated this revision to Diff 9402. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3861?vs=9380=9402 REVISION DETAIL https://phab.mercurial-scm.org/D3861 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git a/mercurial/scmutil.py

D3861: scmutil: fix __enter__ in progress context manager

This revision was automatically updated to reflect the committed changes. Closed by commit rHG077301ac69dc: scmutil: fix __enter__ in progress context manager (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

  1   2   >