D12245: tests: unconditionalize some imports

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Now that we require Python 3 we can simplify these imports. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12245

D12243: tests: simplify Windows and PYTHON3 conditionals

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY PYTHON3 is always True. So this flow can be reduced. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12243 AFFEC

D12242: tests: delete some not PYTHON3 blocks

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY These can never be used anymore. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12242 AFFECTED FILES tests/ru

D12241: tests: unconditionalize _bytes2sys()

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY As part of requiring Python 3. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12241 AFFECTED FILES tests/run-

D12239: tests: always encode session

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12239 AFFECTED FILES tests/run-tests.py CHANGE DETAILS diff --git a/tests/run-te

D12238: tests: unconditionalize bchr

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We could probably just do bytes([x]) everywhere. But this eliminates use of PYTHON3. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://ph

D12240: tests: remove Python 3 conditionalizing from variables

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12240 AFFECTED FILES tests/run-tests.py CHANGE DETAILS diff --git a/tests/run-te

D12237: tests: unconditionalize _unified_diff

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Now that we're Python 3 only we can make this logic simpler. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D1223

D12236: tests: collapse elif PYTHON3 block

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY PYTHON3 is always True now so this logic should be identical as to before. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial

D12235: tests: collapse some more trivial if PYTHON3 blocks

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This doesn't account for all of the references to PYTHON3. But it accounts for the ones that are more trivial and don't entail logical changes. REPOSITORY

D12234: tests: require Python 3.5+ in run-tests.py

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We change the version check logic to hard fail if running on <= 3.5.0. The branch for <3.5 has been deleted. And the >=3.5 branch block has been dedented. RE

D12218: black: blacken with 22.1.0

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY black 22.1.0 is the first non-beta release of black. I think it makes sense for us to adopt this version of black. This commit blackens the repo with versi

D12232: cext: remove PY23()

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Since we always run on Python 3 now, we no longer need this macro to support Python 2. We refactor all users to just use the 2nd argument. REPOSITORY rHG M

D12233: cext: remove inline rewriting of argv

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This only worked on Python 2. And since we dropped support for Python 2, we can drop support for this functionality. REPOSITORY rHG Mercurial BRANCH defau

D12231: cext: unconditionalize PySlice_GetIndicesEx()

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We only support Python 3 now. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12231 AFFECTED FILES mercurial/c

D12229: cext: use PyLong symbols

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We no longer support Python 2. So we can unconditionally use the Python 3 symbol names. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https:/

D12230: cext: unconditionalize PYLONG_VALUE()

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We only support Python 3 now. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12230 AFFECTED FILES mercurial/c

D12228: cext: use PyLong symbols

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We no longer need to support Python 2. So use the Python 3 symbol names directly. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.

D12221: cext: remove Python 2 module initializer functions

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We no longer need these since we dropped support for Python 2. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12

D12227: cext: remove Python 2 support

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We still alias the Python 2 symbols. This will be cleaned up in a separate commit. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab

D12226: cext: remove Python 2 file handling code

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12226 AFFECTED FILES mercurial/cext/osutil.c CHANGE DETAILS diff --git a/mercuri

D12225: cext: remove Python 2 variant of listdir_slot()

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12225 AFFECTED FILES mercurial/cext/osutil.c CHANGE DETAILS diff --git a/mercuri

D12224: cext: remove some conditional preprocessor defines

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We may want to inline these defines. But for now, getting rid of the Python 2 support is a step forward. REPOSITORY rHG Mercurial BRANCH default REVISION

D12223: cext: unconditionally use PyLong_FromLong()

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We no longer support Python 2. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D12223 AFFECTED FILES mercurial/

D12222: cext: drop preprocessor PyInt aliases

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Now that we dropped support for Python 2 we can use the Python 3 native functions. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab

D12220: tests: require black 22.1.0

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We recently reformatted the repo with black 22.1.0. Since black 22.1.0 is the first non-beta release of black and black is committed to keeping the style stab

D12219: automation: upgrade black to 22.1.0

2022-03-01 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We just reformatted the repo with black 22.1.0. Let's install this version of black in the Linux automation. REPOSITORY rHG Mercurial BRANCH default REVI

D12203: scmutil: revert c7e675848027 / scmutil: obsrevs is already a frozenset

2022-02-19 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The reverted change breaks nearly every command for me when I'm using obsolescence. Specifically, I get `TypeError: unhashable type: 'set'` on the changed lin

D12132: automation: use gp3 volume type

2022-02-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is a newer volume type. It offers a better baseline of performance by default and is ~10% cheaper. It doesn't offer burst credits. But its performance is

D12131: automation: use m6i instances

2022-02-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This instance type is much, much faster than t3 and can perform tasks much quicker. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://pha

D11776: automation: support Python 3.10 on Windows

2021-11-23 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Python 3.10 is out and we should support it. This commit teaches the automation code to install and support building for Python 3.10. REPOSITORY rHG Mercuria

D11775: contrib: update Windows environment to Python 3.9.9

2021-11-23 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Let's keep the environment modern. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D11775 AFFECTED FILES contrib

D11763: cext: define S_IFLNK on Python 2.7 and Windows

2021-11-15 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Before this change, building on Python 2.7 on Windows fails due to S_IFLNK being undefined. This regression was introduced by a32a96079e2d

D11359: pyoxidizer: add arch to PyOxidizer MSIs

2021-08-26 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is the proper filename pattern. This filename format wasn't properly implemented when PyOxidizer took over Python 3 MSI generation in 603efb3845ba

D11357: contrib: install PyOxidizer 0.17.0

2021-08-26 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This pulls in some changes we want to improve Windows MSI installers. This will need separate enhancements to the pyoxidizer.bzl. But those will be handled

D11358: pyoxidizer: pass arch to WiXInstaller()

2021-08-26 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We just upgraded Windows automation to PyOxidizer 0.17.0. This version of PyOxidizer changed the behavior of WiX installers so installer architecture defaulte

D11356: packaging: reference proper output directory

2021-08-26 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY 9438e9b7321a changed the name of the PyOxidizer target, which changed the name of

D11355: packaging: pass extra_pyoxidizer_vars only to pyoxidizer

2021-08-26 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Before, we would attempt to call a function (build_installer_py2exe) that didn't accept this keyword argument. This was preventing the building of py2exe inst

D10691: contrib: install Visual Studio 2019 tools instead of 2017

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We might as well keep modern. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10691 AFFECTED FILES contrib/ins

D10690: automation: create Python 3.5 variant of requirements.txt

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The automation environment is refusing to build with the previous file because some dependencies won't install on Python 3.5. I couldn't find an easy way t

D10689: pyoxidizer: use Python 3.9 (BC)

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Newer versions of PyOxidizer use Python 3.9 by default. We previously pinned the version to 3.8 to facilitate porting to a new PyOxidizer version and diffing

D10683: pyoxidizer: support producing MSI installers

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Newer versions of PyOxidizer have support for building WiX MSI installers "natively." Essentially, you can script the definition of your WiX installer via Sta

D10688: packaging: use PyOxidizer for producing WiX MSI installer

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We recently taught our in-tree PyOxidizer configuration file to produce MSI installers with WiX using PyOxidizer's built-in support for doing so. This co

D10687: packaging: extract invocation of pyoxidizer to own function

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I'll be refactoring how the WiX installer creation calls into pyoxidizer and will need a lower level function for facilitating that. The new `run_pyoxidi

D10686: packaging: rename run_pyoxidizer()

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I'm going to split this function up in a future commit and I'll want the name "run_pyoxidizer()" for a lower-level function for invoking `pyoxidizer`. REPOSI

D10684: pyoxidizer: support code signing

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Newer versions of PyOxidizer feature built-in support for code signing. You simply declare a code signer in the Starlark configuration file, activate it for a

D10685: packaging: move documentation HTML building to own function

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is part of some light refactoring to enable us to use PyOxidizer for WiX MSI installer generation. REPOSITORY rHG Mercurial BRANCH default REVISION

D10682: pyoxidizer: use allocator_backend instead of raw_allocator

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The name of this attribute changed in PyOxidizer 0.11. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10682 AFF

D10681: pyoxidizer: simplify targets

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The split targets existed to enable the use of a non-default distribution flavor on Windows. Modern versions of PyOxidizer use the "standalone_dynamic" distri

D10680: contrib: install PyOxidizer 0.15.0

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY PyOxidizer now provides MSI installers. So we install that way. This significantly reduces the time to bootstrap a Windows environment, as building PyOxidizer

D10679: pyoxidizer: pin Python to 3.8

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Newer versions of PyOxidizer use version 3.9 by default. As part of upgrading PyOxidizer, we want to pin the version at 3.8 so we can compare differences more

D10678: pyoxidizer: remove some boilerplate in file

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This isn't used for anything and can safely be removed. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10678 AF

D10677: contrib: upgrade Rust in Windows automation

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I'm not sure why we don't install the minimum required Rust version here like we do for Linux. Whatever: that's unrelated to wanting to stay modern. REPOSITO

D10676: contrib: update Python versions in Windows automation

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Let's keep our Python versions modern. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10676 AFFECTED FILES co

D10675: automation: update rust in Linux environment

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Our minimum supported Rust is 1.41.1 per rust/README.rst. We also bump the modern Rust version to latest stable to stay current. REPOSITORY rHG Mercurial BR

D10674: automation: install latest Python versions in Linux environment

2021-05-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Let's keep our Linux environment up to date. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D10674 AFFECTED FILE

D9858: contrib: update PyOxidizer to 0.10.3

2021-01-24 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is necessary to work around a bug that caused build failures on current stable with 0.9.0. This patch was used to build the 5.7rc0 Windows installers. R

D9281: cext: add .pyi files for C extensions

2020-11-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I'm unsure if all the annotations are completely accurate. But having these helps type checkers reason about our C extensions. REPOSITORY rHG Mercurial BRAN

D9280: revlog: pass sidedata argument to flagutil.processflagswrite()

2020-11-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Bug found through pytype. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D9280 AFFECTED FILES mercurial/revlog

D9279: pure: guard against empty blocks

2020-11-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY If blocks is empty, we append `None` to the returned list, which is incorrect. This subtle issue was caught by pytype, which correctly identified the ret

D9274: internals: start to document how .hg/ works

2020-11-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This commit adds internals documentation that starts to document the files and semantics of the .hg/ directory. A lot of this functionality is currently on

D7258: makefile: use Python 3 by default (BC)

2020-11-06 Thread indygreg (Gregory Szorc)
Closed by commit rHGc2837640aeb0: makefile: use Python 3 by default (BC) (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7258?vs=23421&id=23422 CHANGES SINCE

D7258: makefile: use Python 3 by default (BC)

2020-11-06 Thread indygreg (Gregory Szorc)
Herald added a subscriber: mercurial-patches. indygreg edited the summary of this revision. indygreg retitled this revision from "makefile: use Python 3 by default outside of Windows (BC)" to "makefile: use Python 3 by default (BC)". indygreg updated this revision to Diff 23421. REPOSITORY rHG

D9228: pyoxidizer: update to PyOxidizer 0.9

2020-10-18 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We were previously using a Git commit from a few days before the 0.8 release. This commit upgrades us to the just-released 0.9 release. This required some

D9188: automation: upgrade packages in Linux environment

2020-10-09 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY It's been a while since we've ran `pip-compile -U`. Let's do that. When I ran this command, black was upgraded and newer versions of black complains about

D9189: automation: support running against Python 3.9

2020-10-09 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We just added CPython 3.9.0 to the automation environment. Let's support actions targeting it. One side-effect of this change is that we'll produce Windows

D9187: packaging: upgrade packages in Windows environment

2020-10-09 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY I ran `pip-compile -U` to update all packages to latest versions. I did this so the Windows environment is more modern. dulwich 0.20 dropped support for Py

D9186: contrib: install Python 3.9.0

2020-10-09 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We update the Windows and Linux environments to install CPython 3.9.0, which was released a few days ago. REPOSITORY rHG Mercurial BRANCH default REVISIO

D9185: contrib: stop installing Python 3.5 and 3.6 in Windows environment

2020-10-09 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We're only publishing Python 3.7+ wheels and other builds on Windows. Python 3.5 and 3.6 are not supported on this platform. Let's stop installing them in the

D9148: pyoxidizer: produce working Python 3 Windows installers (issue6366)

2020-10-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY While we've had code to produce Python 3 Windows installers with PyOxidizer, we haven't been advertising them on the web site due to a bug in making TLS conne

D9147: packaging: normalize - to _ in WiX Id values

2020-10-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY - is not a valid identifier character in WiX Ids. So let's normalize accordingly. I discovered this issue after a subsequent change which introduces a

D9146: contrib: install Rust 1.46.0

2020-10-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Let's use the latest/greatest version of Rust in the automation environment. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercu

D9145: contrib: install latest versions of Python

2020-10-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Let's keep our build environment modern. We upgrade 3.5-3.8 on Linux. Just 3.7 and 3.8 on Windows because we don't use <3.7 on Windows. REPOSITORY rHG M

D7221: hghave: fix bytes/string issue on Python 3

2020-08-08 Thread indygreg (Gregory Szorc)
indygreg added a comment. A similar patch already landed. I'm going to commandeer and close. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7221/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7221 To: durin42, #hg-reviewers, pulkit Cc: indygre

D8838: clonebundles: document REQUIREDRAM key

2020-07-26 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is a follow-up to 72feaeb510b3 , which introduced the feature. The key should

D7944: localrepo: handle ValueError during repository opening

2020-06-09 Thread indygreg (Gregory Szorc)
Closed by commit rHG9e5b4dbe8ff2: localrepo: handle ValueError during repository opening (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Revision". REPOSITORY rHG Mercuria

D8456: rust: remove duplicate import

2020-05-30 Thread indygreg (Gregory Szorc)
indygreg added a comment. Well, I attempted to rewrite `@`. But somehow the empty changeset got published before that push completed. So it is forever part of history now :/ REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8456/new/ REVISION DETAIL ht

D8456: rust: remove duplicate import

2020-05-30 Thread indygreg (Gregory Szorc)
indygreg added a comment. It looks like `hg phabread | hg import -` produced an empty changeset, which I accidentally pushed. I have since rewritten `@` on `hg-committed` to remove the empty changeset. This differential revision should be reopened (which I cannot do since I don't own it). R

D8456: rust: remove duplicate import

2020-05-30 Thread indygreg (Gregory Szorc)
Herald added a subscriber: mercurial-patches. This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. This patch currently fails to apply. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8456/

D8484: automation: support building Python 3 MSI installers

2020-04-24 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This is very similar to what we just did for Inno. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D8484 AFFECTED

D8483: automation: support building Python 3 Inno installers

2020-04-24 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The core packaging code now supports building Python 3 installers using PyOxidizer. Let's teach the automation code to invoke it so that we produce both Pytho

D8482: automation: add extra arguments when building Inno

2020-04-24 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY These were being fed into the template expansion but not being used. This meant --version was not getting set when it should have been. REPOSITORY rHG Merc

D8479: packaging: add -python2 to Windows installer filenames

2020-04-23 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We just taught the Windows installers to produce Python 3 variants built with PyOxidizer. Our plan is to publish both Python 2 and Python 3 versions of the

D8478: automation: support building Windows wheels for Python 3.7 and 3.8

2020-04-23 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The time has come to support Python 3 on Windows. Let's teach our automation code to produce Windows wheels for Python 3.7 and 3.8. We could theoretic

D8473: packaging: support building Inno installer with PyOxidizer

2020-04-21 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We want to start distributing Mercurial on Python 3 on Windows. PyOxidizer will be our vehicle for achieving that. This commit implements basic support for

D8477: packaging: support building WiX installers with PyOxidizer

2020-04-21 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We initially implemented PyOxidizer support for Inno installers. That did most of the heavy work of integrating PyOxidizer into the packaging system. Implemen

D8475: packaging: integrate signing into run_wix_packaging()

2020-04-21 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Previously, signing was implemented via a separate function which called build_installer() and then called signing functionality. In this model, in order

D8476: packaging: move version derivation to run_wix_packaging()

2020-04-21 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY With the previous commit moving signing inline, we no longer need to compute the version string in build_installer() and can instead move this logic to run_wi

D8474: packaging: isolate invocation of WiX to own function

2020-04-21 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Like we did for Inno, we want to split out the building of Mercurial from invoking the packaging tool so that we can introduce an alternate build mechanism.

D8469: setup: use sysstr() on process output

2020-04-21 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Otherwise we get a str-bytes mismatch on Python 3 if an error occurs. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm

D8470: packaging: add docutils as dependency

2020-04-21 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The previous commit revealed that attempting to run `python setup.py build_doc` from the packaging virtualenv failed due to missing docutils package. We didn'

D8472: packaging: split Inno installer building from Mercurial building

2020-04-21 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We want to make the logic for producing the installer agnostic about how Mercurial is built to allow for alternate build methods (like PyOxidizer). REPOSITOR

D8468: contrib: install PyOxidizer in Linux and Windows environments

2020-04-21 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY For Linux, this was trivial. For Windows, we need to teach the powershell script to install Rust as well. This was also pretty straightforward. REPOSITORY

D8471: packaging: remove pyoxidizer.bzl from packaging directory

2020-04-21 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We have another version in rust/hgcli that is more modern and is already associated with our Rust CLI project. REPOSITORY rHG Mercurial BRANCH stable REV

D8466: contrib: update to latest Python 2.7, 3.7, and 3.8

2020-04-21 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY We would ideally update the 3.5 and 3.6 versions as well. But Python didn't generate exe installers for newer versions for some reason. REPOSITORY rHG Mercur

D8467: automation: install latest Python versions in Linux

2020-04-21 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Staying up to date. Keeping parity with the Windows environment. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D8

D8465: automation: always use latest Windows AMI

2020-04-21 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY The old AMI isn't available any more. We seem to run into this problem every few months. Amazon (or Microsoft) appears to be removing the old AMIs when the

D8353: debugcommands: create new debugantivirusrunning command

2020-04-01 Thread indygreg (Gregory Szorc)
indygreg added a comment. I do not understand what the intended side-effect of running this command is supposed to be. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8353/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8353 To: durin42, #hg-re

D8344: extensions: refactor function for obtaining disabled extension help

2020-04-01 Thread indygreg (Gregory Szorc)
Closed by commit rHG843418dc0b1b: extensions: refactor function for obtaining disabled extension help (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY r

D8342: tests: prevent printing \r to stdout

2020-04-01 Thread indygreg (Gregory Szorc)
Closed by commit rHG47e6ec977555: tests: prevent printing \r to stdout (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAS

<    1   2   3   4   5   6   7   8   9   10   >