D7007: py3: manually import pycompat.setattr where it is needed

2019-10-07 Thread indygreg (Gregory Szorc)
Closed by commit rHG66f2cc210a29: py3: manually import pycompat.setattr where it is needed (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7008: py3: stop injecting pycompat.hasattr into modules

2019-10-07 Thread indygreg (Gregory Szorc)
Closed by commit rHG0d612db7047c: py3: stop injecting pycompat.hasattr into modules (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7006: py3: stop implicitly importing unicode

2019-10-07 Thread indygreg (Gregory Szorc)
Closed by commit rHGbbcbb82e3589: py3: stop implicitly importing unicode (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7006?vs=16921=16929 CHANGES SINCE

D7004: import-checker: allow symbol imports from mercurial.pycompat

2019-10-06 Thread indygreg (Gregory Szorc)
Closed by commit rHGc2e284cee333: import-checker: allow symbol imports from mercurial.pycompat (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7011: py3: stop normalizing .encode()/.decode() arguments to unicode

2019-10-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we don't byte transform string literals, we no longer need this transform. While we're here, we also drop some superfluous u'' prefix in existing

D7009: py3: manually import getattr where it is needed

2019-10-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The march continues. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7009 AFFECTED FILES

D7005: py3: manually import pycompat.open into files that need it

2019-10-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We want to eliminate the source transformer. Currently it inserts a `from

D7010: py3: manually import pycompat.delattr where it is needed

2019-10-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY And with this change, we no longer need the auto-inserted import statement in the source transformer, so it has been removed! REPOSITORY rHG Mercurial

D7007: py3: manually import pycompat.setattr where it is needed

2019-10-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Continuing to eliminate the implicit import of symbols in the Python 3 source transformer so we can eliminate it. REPOSITORY rHG Mercurial REVISION DETAIL

D7008: py3: stop injecting pycompat.hasattr into modules

2019-10-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I only found a single user of this pattern, probably because we use util.hasattr everywhere. REPOSITORY rHG Mercurial REVISION DETAIL

D7006: py3: stop implicitly importing unicode

2019-10-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We should be pycompat.unicode everywhere. It turns out we were doing this everywhere except for one place in templatefilters! REPOSITORY rHG Mercurial

D7004: import-checker: allow symbol imports from mercurial.pycompat

2019-10-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Currently, the source transformer inserts `from mercurial.pycompat import delattr, getattr, hasattr, setattr, open, unicode` to the top of every file. As part

D2010: check-commit: allow foo_bar naming in functions

2019-10-06 Thread indygreg (Gregory Szorc)
indygreg added a comment. We just took a hand poll of this at the 4.9 sprint and all but one person supported allowing underscores in names. The objection was on the grounds of "I don't want us to mass rename things." But we aren't going to do that. REPOSITORY rHG Mercurial CHANGES SINCE

D7002: contrib: add a fork of black (as "grey") that includes my changes

2019-10-06 Thread indygreg (Gregory Szorc)
This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. Works with the custom installed black version. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7002/new/ REVISION DETAIL

D7002: contrib: add a fork of black (as "grey") that includes my changes

2019-10-06 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. $ pip3.7 install --upgrade black $ python3.7 contrib/grey.py Traceback (most recent call last): File "contrib/grey.py", line 54, in from _version

D6994: ui: define (write|status|warn|note)noi18n aliases

2019-10-06 Thread indygreg (Gregory Szorc)
Closed by commit rHG5209fc94b982: ui: define (write|status|warn|note)noi18n aliases (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6994?vs=16886=16906

D6991: hg: remove HGUNICODEPEDANTRY and RTUNICODEPEDANTRY

2019-10-06 Thread indygreg (Gregory Szorc)
Closed by commit rHG5c9c71cde1c9: hg: remove HGUNICODEPEDANTRY and RTUNICODEPEDANTRY (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6991?vs=16862=16895

D6964: tests: conditionalize output for Python 3

2019-10-06 Thread indygreg (Gregory Szorc)
Closed by commit rHG9cc55b743713: tests: conditionalize output for Python 3 (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6964?vs=16804=16896 CHANGES SINCE

D6965: convert: use pycompat.fsencode()

2019-10-06 Thread indygreg (Gregory Szorc)
Closed by commit rHG058c2468b2f5: convert: use pycompat.fsencode() (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6965?vs=16805=16894 CHANGES SINCE LAST

D6986: tests: make tarball output conditional on Python version

2019-10-06 Thread indygreg (Gregory Szorc)
Closed by commit rHG830eacef67f8: tests: make tarball output conditional on Python version (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6986?vs=16855=16893

D6988: tests: conditionalize test-run-tests.t for Python 3.8

2019-10-06 Thread indygreg (Gregory Szorc)
Closed by commit rHG1d60a7825dcb: tests: conditionalize test-run-tests.t for Python 3.8 (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6988?vs=16857=16892

D6992: hgweb: use importlib.reload() if available

2019-10-06 Thread indygreg (Gregory Szorc)
Closed by commit rHGe554cfd93975: hgweb: use importlib.reload() if available (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6992?vs=16864=16891 CHANGES

D6990: tests: allow xrange warning from perf.py

2019-10-06 Thread indygreg (Gregory Szorc)
Closed by commit rHG094d0f4a8edd: tests: allow xrange warning from perf.py (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6990?vs=16863=16890 CHANGES SINCE

D6974: examples: include a sample of how to use black with fix

2019-10-06 Thread indygreg (Gregory Szorc)
This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. I'll add the fsmonitor exclusion in flight. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6974/new/ REVISION DETAIL

D6939: sidedata: apply basic but tight security around exchange

2019-10-06 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > bundle2.py:2343 > +if 'exp-sidedata-flag' in repo.requirements: > +part.addparam('sidedata', '1') > Shouldn't this by `exp-sidedata`? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6989: push: support config option to require revs be specified when running push

2019-10-05 Thread indygreg (Gregory Szorc)
indygreg added a comment. Question: should this checking be performed in `exchange.push` or at the command layer? (I'm not sure of the answer.) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6989/new/ REVISION DETAIL

D6843: ui: option to preserve the progress bar

2019-10-05 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. I think this is a useful feature. I've wanted this in automated environment so the last state from the progress bar is preserved, for example. But I agree with Augie that

D6922: ci: implement a "try server"

2019-10-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 16854. CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6922?vs=16853=16854 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6922/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6922 AFFECTED FILES contrib/ci/README.rst

D6971: formatting: blacken the codebase

2019-10-05 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > durin42 wrote in __init__.py:1 > I'm not sold, honestly: we've already substantially diverged from upstream on > this, so I think we should just act like we own it for now. We need to take some upstream Python 3 changes soon. Can we defer this

D6972: formatting: byteify all mercurial/ and hgext/ string literals

2019-10-05 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. This still needs to not modify `mercurial/__init__.py`. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6972/new/ REVISION DETAIL

D6922: ci: implement a "try server"

2019-10-05 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 16853. CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6922?vs=16717=16853 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6922/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6922 AFFECTED FILES contrib/ci/README.rst

D6983: automation: add a command to submit to a Try server

2019-10-05 Thread indygreg (Gregory Szorc)
Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-devel. Closed by commit rHGc5c502bd1f70: automation: add a command to submit to a Try server (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted

D6982: automation: improve documentation for credentials management

2019-10-05 Thread indygreg (Gregory Szorc)
Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-devel. Closed by commit rHGf71b3c561b93: automation: improve documentation for credentials management (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not

D6980: automation: upgrade various packages

2019-10-05 Thread indygreg (Gregory Szorc)
Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-devel. Closed by commit rHGeddae0ed485d: automation: upgrade various packages (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it

D6981: automation: switch to us-west-2 by default

2019-10-05 Thread indygreg (Gregory Szorc)
Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-devel. Closed by commit rHGb8df6a470bbb: automation: switch to us-west-2 by default (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it

D6342: style: run a patched black on a subset of mercurial

2019-10-05 Thread indygreg (Gregory Szorc)
This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. I'm going to split this on land so `pyproject.toml` appears in its own changeset. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6342/new/

D6974: examples: include a sample of how to use black with fix

2019-10-05 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. This needs `hgext/fsmonitor/pywatchman` added to the list. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6974/new/ REVISION DETAIL

D6973: mangler: stop rewriting string constants to be bytes literals

2019-10-05 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. This is good. But it will need rebased once `b""` are removed. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6973/new/ REVISION

D6972: formatting: byteify all mercurial/ and hgext/ string literals

2019-10-05 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. Please add `# skip-blame` to the commit message. INLINE COMMENTS > __init__.py:1 > # Copyright 2014-present Facebook, Inc. > # All rights reserved. Files in this directory

D6971: formatting: blacken the codebase

2019-10-05 Thread indygreg (Gregory Szorc)
indygreg added a comment. Please also add `# skip-blame` to the commit message. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6971/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6971 To: durin42, indygreg, martinvonz, #hg-reviewers Cc:

D6971: formatting: blacken the codebase

2019-10-05 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added inline comments. indygreg requested changes to this revision. INLINE COMMENTS > __init__.py:1 > # Copyright 2014-present Facebook, Inc. > # All rights reserved. This is 3rd party code and shouldn't be formatted. REPOSITORY rHG

D6342: style: run a patched black on a subset of mercurial

2019-10-05 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. Please add `# skip-blame` to the commit message. And split the addition of `pyproject.toml` into its own commit so we have annotate info. REPOSITORY rHG Mercurial CHANGES

D6958: hg: move hg script to be a template that gets filled in via make

2019-10-04 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. Changes are coming. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6958/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6958

D6923: setup: build extensions in parallel by default

2019-10-03 Thread indygreg (Gregory Szorc)
Closed by commit rHGf9d35f01b8b3: setup: build extensions in parallel by default (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6890: sidedata: add a function to read sidedata from revlog raw text

2019-10-03 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > sidedata.py:42 > +SIDEDATA_HEADER = struct.Struct('>H') > +SIDEDATA_ENTRY = struct.Struct('>HL20s') > + Python 3 will require a `r''` because of source transformation. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6927: ci: report cost to run each job

2019-09-30 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 16724. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6927?vs=16721=16724 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6927/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6927 AFFECTED FILES

D6929: ci: add comment about block duration pricing

2019-09-30 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We can make things even cheaper if we remove the block duration from the spot request. I added a TODO to track this. REPOSITORY rHG Mercurial REVISION DETAIL

D6906: ci: implement a new CI system for Mercurial

2019-09-30 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 16716. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6906?vs=16697=16716 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6906/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6906 AFFECTED FILES

D6922: ci: implement a "try server"

2019-09-30 Thread indygreg (Gregory Szorc)
indygreg edited the summary of this revision. indygreg updated this revision to Diff 16717. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6922?vs=16696=16717 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6922/new/ REVISION DETAIL

D6928: ci: fetch explicit attributes

2019-09-30 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we store the launch configuration in the job record and this launch configuration can be several KB large, we need to be careful about the data that

D6927: ci: report cost to run each job

2019-09-30 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The spot instance request contains details on the cost to run the instance. Let's record the hourly cost to run an instance in DynamoDB so we can use it to

D6925: ci: track spot instance state, randomly assign availability zone

2019-09-30 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous implementation of spot instance requests was too naive. I observed the CI system making spot instance requests that were expiring due to

D6924: ci: store job start parameters in DynamoDB

2019-09-30 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes it vastly easier to retry or retrigger a job, since the instance launch state will be stored in the database instead of in an ad-hoc SQS message.

D6923: setup: build extensions in parallel by default

2019-09-30 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The build_ext distutils command in Python 3.5+ has a "parallel" option that controls whether to build extensions in parallel. It is disabled by default (None)

D6917: automation: support and use Debian Buster by default

2019-09-30 Thread indygreg (Gregory Szorc)
Closed by commit rHGd1d919f679f7: automation: support and use Debian Buster by default (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6912: automation: remove Ubuntu 18.10

2019-09-30 Thread indygreg (Gregory Szorc)
Closed by commit rHG3aa227feffbe: automation: remove Ubuntu 18.10 (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAST

D6921: tests: use silenttestrunner in test-simplemerge.py

2019-09-30 Thread indygreg (Gregory Szorc)
Closed by commit rHGd75142ef054a: tests: use silenttestrunner in test-simplemerge.py (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6921?vs=16694=16703

D6918: tests: suppress output from write()

2019-09-30 Thread indygreg (Gregory Szorc)
Closed by commit rHGf1dffb37f27c: tests: suppress output from write() (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6918?vs=16691=16700 CHANGES SINCE LAST

D6920: contrib: use pycompat.xrange in bdiff-torture.py

2019-09-30 Thread indygreg (Gregory Szorc)
Closed by commit rHGe05c141511dd: contrib: use pycompat.xrange in bdiff-torture.py (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6920?vs=16693=16702

D6919: interfaces: use triple quotes for Attribute value

2019-09-30 Thread indygreg (Gregory Szorc)
Closed by commit rHG5f8b6617e962: interfaces: use triple quotes for Attribute value (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6919?vs=16692=16701

D6909: tests: look for additional pip warning variant

2019-09-30 Thread indygreg (Gregory Szorc)
Closed by commit rHGd6f34ceb08db: tests: look for additional pip warning variant (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6909?vs=16681=16699 CHANGES

D6908: tests: use test harness `hg` in test-hghave.t

2019-09-30 Thread indygreg (Gregory Szorc)
Closed by commit rHG7eac24de491d: tests: use test harness `hg` in test-hghave.t (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6908?vs=16680=16698 CHANGES

D6906: ci: implement a new CI system for Mercurial

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 16697. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6906?vs=16695=16697 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6906/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6906 AFFECTED FILES

D6922: ci: implement a "try server"

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg added a comment. indygreg planned changes to this revision. This is less polished than the commit implementing the CI system. And it exposes some cracks in the design of the CI system (such as a missing abstraction for controlling what to run). But it does work. I still need to

D6922: ci: implement a "try server"

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit implements a new CI component which allows privileged users to upload Mercurial bundles and have automation run against them. The functionality is

D6906: ci: implement a new CI system for Mercurial

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 16695. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6906?vs=16682=16695 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6906/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6906 AFFECTED FILES

D6921: tests: use silenttestrunner in test-simplemerge.py

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The time monkeypatching doesn't appear to work reliably in Python 3, possibly due to unittest using a different time function. This makes the test intermittent

D6920: contrib: use pycompat.xrange in bdiff-torture.py

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For Python 3 compatibility. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6920 AFFECTED FILES contrib/bdiff-torture.py CHANGE

D6919: interfaces: use triple quotes for Attribute value

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise the source transformer converts it to bytes and test-check-interfaces.py complains on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL

D6918: tests: suppress output from write()

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise it is printed and the test fails with tons of output on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6918

D6906: ci: implement a new CI system for Mercurial

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 16682. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6906?vs=16678=16682 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6906/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6906 AFFECTED FILES

D6917: automation: support and use Debian Buster by default

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY While Debian Buster (Debian 10) was released in July, the AWS AMIs were not published until mid September. This commit teaches the automation system to

D6916: automation: use latest AMIs

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This cuts down on the overhead to create a new AMI, as we don't have to install as many package upgrades. REPOSITORY rHG Mercurial REVISION DETAIL

D6915: automation: increase size of Linux AMI build volume

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I ran out of space attempting to build a few AMIs. Let's give the environment an extra 2 GB to utilize. REPOSITORY rHG Mercurial REVISION DETAIL

D6912: automation: remove Ubuntu 18.10

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It reached end of life on July 18, 2019. I don't think we should care about supporting it. REPOSITORY rHG Mercurial REVISION DETAIL

D6913: automation: upgrade packages in Linux environment

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Let's stay modern. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6913 AFFECTED FILES contrib/automation/hgautomation/linux.py

D6914: automation: install awscli and python3-boto3 packages

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This provides the `aws` command-line utility as well as a Python library for interacting with AWS. It is useful to have these packages installed in AMIs so you

D6911: automation: always install docker-ce

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Docker has published packages for Ubuntu Disco and we no longer need this one-off. REPOSITORY rHG Mercurial REVISION DETAIL

D6910: automation: use LSB_RELEASE instead of DEBIAN_VERSION

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This should be more robust since I believe the minor version can change mid release. REPOSITORY rHG Mercurial REVISION DETAIL

D6909: tests: look for additional pip warning variant

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The wording has been tweaked in new versions of pip. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6909 AFFECTED FILES

D6908: tests: use test harness `hg` in test-hghave.t

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This prevents the sub test harness from rebuilding Mercurial. It shaves ~30s from the test wall time on my machine. REPOSITORY rHG Mercurial REVISION DETAIL

D6907: synthrepo: use pycompat.xrange

2019-09-29 Thread indygreg (Gregory Szorc)
Closed by commit rHGc07812bdd568: synthrepo: use pycompat.xrange (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6907?vs=16676=16679 CHANGES SINCE LAST

D6906: ci: implement a new CI system for Mercurial

2019-09-29 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 16678. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6906?vs=16677=16678 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6906/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6906 AFFECTED FILES

D6906: ci: implement a new CI system for Mercurial

2019-09-28 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 16677. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6906?vs=16675=16677 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6906/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6906 AFFECTED FILES

D6907: synthrepo: use pycompat.xrange

2019-09-28 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This silences some test-check-pyflakes.t warnings on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6907 AFFECTED FILES

D6906: ci: implement a new CI system for Mercurial

2019-09-28 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY tl;dr a new CI system built on top of AWS using mostly serverless technology is implemented. It can be seen at https://ci.hg.gregoryszorc.com/ Mercurial's

D6858: zstandard: vendor python-zstandard 0.12

2019-09-16 Thread indygreg (Gregory Szorc)
Closed by commit rHG69de49c4e39c: zstandard: vendor python-zstandard 0.12 (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6858?vs=16552=16560 CHANGES SINCE

D6858: zstandard: vendor python-zstandard 0.11

2019-09-15 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The upstream source distribution from PyPI was extracted. Unwanted files were removed. The clang-format ignore list was updated to reflect the new

D6786: automation: implement "publish-windows-artifacts" command

2019-09-09 Thread indygreg (Gregory Szorc)
Closed by commit rHG92593d72e10b: automation: implement publish-windows-artifacts command (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6786?vs=16389=16458

D6785: automation: upgrade to latest packages in requirements.txt

2019-09-09 Thread indygreg (Gregory Szorc)
Closed by commit rHG6bf88befa027: automation: upgrade to latest packages in requirements.txt (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6825: contrib: start building a library for simple hooks

2019-09-07 Thread indygreg (Gregory Szorc)
indygreg added a comment. I think we should go a step further and have some built-in hooks in Mercurial itself, like we do extensions. A good first implementation would be to define those hooks somewhere where they can be imported, add tests like they are standalone hooks. As a follow-up

D6808: revlog: introduce a `sidedata` method

2019-09-07 Thread indygreg (Gregory Szorc)
indygreg added a comment. I think I see where you are going with this and it seems potentially very useful. I do wish the flag processors code could have been refactored without involving `sidedata`, as I would have taken the patches later in this series to remove the temporary `mixin`

D6814: revlog: add a `sidedata` parameters to addrevision

2019-09-07 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > remotefilelog.py:133 > def addrevision(self, text, transaction, linknode, p1, p2, > cachedelta=None, > -node=None, flags=revlog.REVIDX_DEFAULT_FLAGS): > +node=None, flags=revlog.REVIDX_DEFAULT_FLAGS,

D6807: flagprocessors: small code update to clarify parameters

2019-09-07 Thread indygreg (Gregory Szorc)
This revision is now accepted and ready to land. indygreg added inline comments. indygreg accepted this revision. INLINE COMMENTS > flagutil.py:163 > return text, True > -if not operation in ('read', 'write'): > +if not operation in ('read', 'write', 'raw'): >

D6800: flagprocessors: introduce specialized functions

2019-09-07 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > flagutil.py:151 > + > +Returns a 2-tuple of ``(text, validatehash)`` where ``text`` is the > +processed text and ``validatehash`` is a bool indicating whether the Please follow-up with a fix for the docstring to reflect that this

D6800: flagprocessors: introduce specialized functions

2019-09-07 Thread indygreg (Gregory Szorc)
This revision is now accepted and ready to land. indygreg added inline comments. indygreg accepted this revision. INLINE COMMENTS > flagutil.py:98 > +return self._processflagsread(text, flags) > +else: # write operation > +return self._processflagswrite(text,

D6796: flagutil: introduce a flagprocessorsmixin class

2019-09-07 Thread indygreg (Gregory Szorc)
indygreg added a comment. I'm going to attempt to look at this series... REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6796/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6796 To: marmoute, yuja, durin42, indygreg, #hg-reviewers Cc:

D6788: hgweb: fix websub regex flag syntax on Python 3

2019-09-07 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. Nice catch! INLINE COMMENTS > webutil.py:794 > if flagin: > -for flag in flagin.upper(): > +for flag in flagin.upper().decode('ascii'): >

D6786: automation: implement "publish-windows-artifacts" command

2019-09-05 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The new command and associated functionality can be used to automate the publishing of Windows release artifacts. It supports uploading wheels to PyPI (using

D6785: automation: upgrade to latest packages in requirements.txt

2019-09-05 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Let's stay modern. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6785 AFFECTED FILES contrib/automation/requirements.txt

<    2   3   4   5   6   7   8   9   10   11   >