D6906: ci: implement a new CI system for Mercurial

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY tl;dr a new CI system built on top of AWS using mostly serverless technology is implemented. It can be seen at https://ci.hg.gregoryszorc.com/ Mercurial's

D6858: zstandard: vendor python-zstandard 0.12

Closed by commit rHG69de49c4e39c: zstandard: vendor python-zstandard 0.12 (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6858?vs=16552&id=16560 CHANGES SINCE

D6858: zstandard: vendor python-zstandard 0.11

indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The upstream source distribution from PyPI was extracted. Unwanted files were removed. The clang-format ignore list was updated to reflect the new

D6825: contrib: start building a library for simple hooks

indygreg added a comment. In D6825#100146 , @durin42 wrote: > I like where this is going, but I wonder if these specific hooks can be written without being in-process Python hooks. Reason being that Python hooks use the unstable internals of h

D6786: automation: implement "publish-windows-artifacts" command

Closed by commit rHG92593d72e10b: automation: implement "publish-windows-artifacts" command (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6786?vs=16389&id=16

D6785: automation: upgrade to latest packages in requirements.txt

Closed by commit rHG6bf88befa027: automation: upgrade to latest packages in requirements.txt (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6785?vs=16388&id=1

D6825: contrib: start building a library for simple hooks

indygreg added a comment. I think we should go a step further and have some built-in hooks in Mercurial itself, like we do extensions. A good first implementation would be to define those hooks somewhere where they can be imported, add tests like they are standalone hooks. As a follow-up (re

D6808: revlog: introduce a `sidedata` method

indygreg added a comment. I think I see where you are going with this and it seems potentially very useful. I do wish the flag processors code could have been refactored without involving `sidedata`, as I would have taken the patches later in this series to remove the temporary `mixin`

D6814: revlog: add a `sidedata` parameters to addrevision

indygreg added inline comments. INLINE COMMENTS > remotefilelog.py:133 > def addrevision(self, text, transaction, linknode, p1, p2, > cachedelta=None, > -node=None, flags=revlog.REVIDX_DEFAULT_FLAGS): > +node=None, flags=revlog.REVIDX_DEFAULT_FLAGS,

D6807: flagprocessors: small code update to clarify parameters

This revision is now accepted and ready to land. indygreg added inline comments. indygreg accepted this revision. INLINE COMMENTS > flagutil.py:163 > return text, True > -if not operation in ('read', 'write'): > +if not operation in ('read', 'write', 'raw'): >

D6800: flagprocessors: introduce specialized functions

indygreg added inline comments. INLINE COMMENTS > flagutil.py:151 > + > +Returns a 2-tuple of ``(text, validatehash)`` where ``text`` is the > +processed text and ``validatehash`` is a bool indicating whether the Please follow-up with a fix for the docstring to reflect that this

D6800: flagprocessors: introduce specialized functions

This revision is now accepted and ready to land. indygreg added inline comments. indygreg accepted this revision. INLINE COMMENTS > flagutil.py:98 > +return self._processflagsread(text, flags) > +else: # write operation > +return self._processflagswrite(text, flags

D6796: flagutil: introduce a flagprocessorsmixin class

indygreg added a comment. I'm going to attempt to look at this series... REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6796/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6796 To: marmoute, yuja, durin42, indygreg, #hg-reviewers Cc: mercurial

D6788: hgweb: fix websub regex flag syntax on Python 3

This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. Nice catch! INLINE COMMENTS > webutil.py:794 > if flagin: > -for flag in flagin.upper(): > +for flag in flagin.upper().decode('ascii'): >

D6786: automation: implement "publish-windows-artifacts" command

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The new command and associated functionality can be used to automate the publishing of Windows release artifacts. It supports uploading wheels to PyPI (using tw

D6785: automation: upgrade to latest packages in requirements.txt

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Let's stay modern. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6785 AFFECTED FILES contrib/automation/requirements.txt CHANGE

D6754: contrib: proof of concept script to build Mac packages without system python

indygreg added a comment. This looks promising. I don't want to tell you not to work on this, but my bold plan is to get Mercurial using PyOxidizer and leaning on PyOxidizer for packaging. This will require shipping a Python 3 Mercurial, however. Until PyOxidizer is ready, you may w

D6741: interfaces: create a new folder for interfaces and move repository.py in it

This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. It sounds like we're in agreement that interfaces need to be split. Moving everything to a sub-package seems like a logical first step. REPOSITORY rHG Mercurial CHANGES SINCE LAST AC

D6732: localrepo: push manifestlog and changelog construction code into store

This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. The boundary between `localrepository` and `store` is a bit murky and definitely needs some work. When I last had things paged into my brain last year, I think I was trending towards br

D6714: automation: update packages in requirements files

Closed by commit rHG3495edddc78d: automation: update packages in requirements files (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6714?vs=16123&id=16135 CHA

D6716: automation: increase root volume size on Linux

Closed by commit rHG3e3fb15bfeea: automation: increase root volume size on Linux (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6716?vs=16125&id=16137 CHANGE

D6715: automation: install Rust in Linux environment

Closed by commit rHG89ba81771fc9: automation: install Rust in Linux environment (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6715?vs=16124&id=16136 CHANGES

D6713: automation: install latest Python versions

Closed by commit rHG6f7262fe671c: automation: install latest Python versions (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6713?vs=16122&id=16134 CHANGES SI

D6718: repository: suppress typing errors on functions without arguments

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY zope.interface uses class magic to define interfaces. Mypy doesn't like the methods without arguments and raises a warning for the dozens of them in repository.

D6717: mypy: add a mypy.ini config file

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Static analysis is good. Let's encourage its use by adding a mypy.ini config file to the repo that has reasonable defaults. With this file in place, `mypy` a

D6714: automation: update packages in requirements files

indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We like keeping up to date. The content of the autogenerated files changed slightly because I used a newer version of `pip-compile` than what was used

D6716: automation: increase root volume size on Linux

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It is close to full in the AMI. I actually ran out of space running tests without increasing the volume size! REPOSITORY rHG Mercurial REVISION DETAIL https

D6715: automation: install Rust in Linux environment

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will install Rust 1.31.1, 1.34.2, and whatever stable is at the time the install runs. We install 1.31.1 as our minimum supported Rust version (I think tha

D6713: automation: install latest Python versions

indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This required bumping the pyenv commit so the new versions are available. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/

D6664: transaction: leave unfinished without crashing when not properly released

indygreg added a comment. The presence of `__del__` is a bit dangerous and I've debugged a handful of issues related to having `__del__` on `transaction`. We still leak repo objects in places due to circular references. It's super annoying. Ideally we would use context managers everywher

D6673: automation: make Windows base image name configurable

Closed by commit rHGd80edcb0b30c: automation: make Windows base image name configurable (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6673?vs=16005&id=16030

D6674: contrib: install Python 3.8b2 instead of 3.8a2

Closed by commit rHG7fae3b0bd893: contrib: install Python 3.8b2 instead of 3.8a2 (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6674?vs=16006&id=16031 CHANGE

D6672: automation: extract strings to constants

Closed by commit rHG8804aa6c07a0: automation: extract strings to constants (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6672?vs=16004&id=16029 CHANGES SINC

D6671: automation: use newer Windows base image

Closed by commit rHG92a99822e731: automation: use newer Windows base image (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6671?vs=16003&id=16028 CHANGES SINC

D6671: automation: use newer Windows base image

indygreg added a comment. This series is for stable. (I forgot Phabricator didn't handle branch names well.) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6671/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6671 To: indygreg, #hg-reviewers C

D6673: automation: make Windows base image name configurable

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since automation broke in the middle of the 5.0 release cycle, there's a good chance it will break again in the future. While a robust solution might be to sear

D6674: contrib: install Python 3.8b2 instead of 3.8a2

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Let's install the most recent Python 3.8 distribution. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6674 AFFECTED FILES contrib

D6672: automation: extract strings to constants

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6672 AFFECTED FILES contrib/automation/hgautomation/aws.py CHANGE DETAILS diff --git a/contrib/autom

D6671: automation: use newer Windows base image

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It looks like the old base image disappeared. Let's use a newer image that exists today. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm

D5805: zeroconf: port to Python 3

Closed by commit rHGfa2071753dc2: zeroconf: port to Python 3 (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.or

D6417: context: get filesadded() and filesremoved() from changeset if configured

indygreg added a comment. I'm also not super crazy about abusing extras for this. But it is the best compromise considering the "better" solutions require a lot more effort and thought. At some point, I would like Mercurial's storage and wire protocol to grow official APIs for storing and ex

D6387: bookmarks: keep bookmarks in .hg/store if new config set

indygreg added a comment. I still need to look at this commit in detail, but any commit that alters the on-disk or on-network behavior of Mercurial should ideally be accompanied by a docs change to `mercurial/help/internals`. I say //ideally// because some things still aren't documented. But

D6319: automation: initial support for running Linux tests

This revision was automatically updated to reflect the committed changes. Closed by commit rHG65b3ef162b39: automation: initial support for running Linux tests (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6319?vs=14

D6318: automation: move image operations to own functions

This revision was automatically updated to reflect the committed changes. Closed by commit rHG195dcc10b3d7: automation: move image operations to own functions (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6318?vs=149

D6316: automation: do a force push to synchronize

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5c242c427897: automation: do a force push to synchronize (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6316?vs=14935&id=15

D6317: automation: add --version argument to build-all-windows-packages

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd137a3d5ad41: automation: add --version argument to build-all-windows-packages (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D6286: automation: wait for instance profiles and roles

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8dc22a209420: automation: wait for instance profiles and roles (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6286?vs=14933

D6315: automation: add check that hg source directory is a repo

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4274b1369b75: automation: add check that hg source directory is a repo (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6315?

D6288: automation: shore up rebooting behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe570106beda1: automation: shore up rebooting behavior (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6288?vs=14867&id=15092

D6285: automation: don't create resources when deleting things

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdd6a9723ae2b: automation: don't create resources when deleting things (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6285?v

D6287: automation: wait longer for WinRM connection

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf30184484dd1: automation: wait longer for WinRM connection (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6287?vs=14866&id=

D6284: automation: detach policies before deleting role

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfcb97cb91ff8: automation: detach policies before deleting role (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6284?vs=14861

D6283: automation: only iterate over our AMIs

This revision was automatically updated to reflect the committed changes. Closed by commit rHG730edbd836d8: automation: only iterate over our AMIs (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6283?vs=14860&id=15087

D6319: automation: initial support for running Linux tests

indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Building on top of our Windows automation support, this commit implements support for performing automated tasks on remote Linux machines. Specificall

D6318: automation: move image operations to own functions

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY An upcoming commit will need this functionality with slightly different values and it is enough code to not want to duplicate. Let's refactor into standalone fu

D6317: automation: add --version argument to build-all-windows-packages

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This lets us pass a version string through when building all Windows packages, just like we can do with the individual commands which produce installers. REPOS

D6316: automation: do a force push to synchronize

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We don't know what the state of the remote is. Force pushing will be more resilient. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org

D6315: automation: add check that hg source directory is a repo

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Synchronizing from e.g. source distributions is not yet supported. Let's add a check so we fail with an error message indicating such. REPOSITORY rHG Mercuri

D6286: automation: wait for instance profiles and roles

indygreg updated this revision to Diff 14933. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6286?vs=14865&id=14933 REVISION DETAIL https://phab.mercurial-scm.org/D6286 AFFECTED FILES contrib/automation/hgautomation/aws.py contrib/automation/require

D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

indygreg added a comment. Ideally the new part would be documented in `internals.bundle2`. But other narrow parts aren't documented, so maybe we can hold off... INLINE COMMENTS > narrowbundle2.py:160 > > +@bundle2.parthandler('Narrowspec') > +def _handlenarrowspecs(op, inpart): I don't be

D6298: phabricator: include commit (node) and parent in the local:commits metadata

indygreg added inline comments. INLINE COMMENTS > phabricator.py:403 > +b'commit': ctx.hex(), > +b'parents': [ctx.p1().hex()], > b'branch': ctx.branch(), What about p2? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/

D6294: commands: use byteskwargs() in verify()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG90d48c1c6224: commands: use byteskwargs() in verify() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6294?vs=14878&id=14880

D6293: match: use raw strings to avoid illegal baskslash escape

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfd384911f51b: match: use raw strings to avoid illegal baskslash escape (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6293?

D6294: commands: use byteskwargs() in verify()

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise Python 3 complains about the missing key. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6294 AFFECTED FILES mercurial/

D6293: match: use raw strings to avoid illegal baskslash escape

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Python 3.8 was complaining about the invalid escape sequences. Let's use raw strings to avoid the warning and double baskslashes. REPOSITORY rHG Mercurial R

D6267: incoming: detect if server send partial replies

indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > bundlerepo.py:642 > +ui.warn(_("warning: the server did not send all changes; " > + "the follow list is incomplete\n")) >

D6288: automation: shore up rebooting behavior

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There was a race condition in the old code. Use instance.stop()/instance.start() to eliminate it. As part of debugging this, I also found another race condit

D6287: automation: wait longer for WinRM connection

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I got a few timeouts waiting for only 120s for the WinRM connection to become available. Increasing to 180s seems to fix. I guess AWS isn't as consistent as I w

D6286: automation: wait for instance profiles and roles

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise there is a race condition between creating the resources and us attempting to use them / them becoming available. The role waiter API was recently

D6285: automation: don't create resources when deleting things

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise running these commands can result in resources being created. In the case of `purge-ec2-resources`, we will create resources only to delete them immed

D6284: automation: detach policies before deleting role

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY You can't delete an IAM role that has attached policies. With this change, the purge-ec2-resources command now works. REPOSITORY rHG Mercurial REVISION DET

D6283: automation: only iterate over our AMIs

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We can't delete AMIs that we don't own. Iterating over other AMIs won't work and slows down execution. REPOSITORY rHG Mercurial REVISION DETAIL https://phab

D6267: incoming: detect if server send partial replies

indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. +1 for feature. Needs some minor work to get review. INLINE COMMENTS > bundlerepo.py:639 > > +if rheads and any(x not in localrepo for x in rheads): > +u

D6259: [POC] revset: on-disk cache for children queries

indygreg added a comment. Do you have performance numbers to share? Substantial wins would definitely pique my interest :) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6259 To: joerg.sonnenberger, #hg-reviewers Cc: indygreg, mercurial-devel __

D6183: copies: add config option for writing copy metadata to file and/or changset

indygreg added a comment. An idea to consider (which may have been proposed already) is to write a *no copy metadata* entry into extras when writing copy metadata to the changelog. If we did things this way, a new client could know definitively that no copy metadata is available and to not f

D6183: copies: add config option for writing copy metadata to file and/or changset

indygreg added a comment. I support experimenting with putting copy metadata in the changelog. And the patches before this one did a lot of work to allow copy metadata to be read from alternate sources, which is great, since it can allow flexibility in the future (think copy caches, copy mod

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

indygreg added a comment. This patch is backwards incompatible over the wire protocol. The problem is a new client will blindly send part data to an old server expecting part parameters. The old server won't read the part data and it would be as if the includes and excludes were not sent

D6258: packaging: coerce paths to strings

indygreg added a comment. In https://phab.mercurial-scm.org/D6258#91055, @durin42 wrote: > Argh. This change appears to be wrong (!) so I'm going to drop it. Eh? I don't see anything wrong with this. Casting a `pathlib.Path` to `str` should just work! In fact, it is necessary for

D6200: perf: make perf.run-limits code work with Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG912d82daeda3: perf: make perf.run-limits code work with Python 3 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6200?vs=146

D6199: zstandard: vendor python-zstandard 0.11

This revision was automatically updated to reflect the committed changes. Closed by commit rHG675775c33ab6: zstandard: vendor python-zstandard 0.11 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6199?vs=14658&id=14672

D6198: cext: make osutil.c PY_SSIZE_T_CLEAN

This revision was automatically updated to reflect the committed changes. Closed by commit rHG668eff08387f: cext: make osutil.c PY_SSIZE_T_CLEAN (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6198?vs=14654&id=14671 R

D6197: cext: make parsers.c PY_SSIZE_T_CLEAN

This revision was automatically updated to reflect the committed changes. Closed by commit rHG896b19d12c08: cext: make parsers.c PY_SSIZE_T_CLEAN (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6197?vs=14653&id=14670

D6196: cext: make revlog.c PY_SSIZE_T_CLEAN

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb01bbb8ff1f2: cext: make revlog.c PY_SSIZE_T_CLEAN (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6196?vs=14652&id=14669 R

D6202: setup: use raw string for regular expression

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfecbd93a5f08: setup: use raw string for regular expression (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6202?vs=14661&id=

D6203: tests: add optional output for Python 2.7 deprecation

This revision was automatically updated to reflect the committed changes. Closed by commit rHG65ed223619ec: tests: add optional output for Python 2.7 deprecation (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6203?vs=

D6201: automation: use raw strings when there are backslashes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0e9066db5e44: automation: use raw strings when there are backslashes (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6201?vs

D6200: perf: make perf.run-limits code work with Python 3

indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We need b'' because perf.py isn't run through the source transformer. We need to cast the exception to bytes using pycompat.bytestr() because Val

D6202: setup: use raw string for regular expression

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise Python 3.8 complains about the backslash. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6202 AFFECTED FILES setup.py

D6203: tests: add optional output for Python 2.7 deprecation

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We already had one of these a few lines above. We need it here as well. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6203 AFFEC

D6201: automation: use raw strings when there are backslashes

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise Python 3.8 complains. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6201 AFFECTED FILES contrib/automation/hgautomatio

D6199: zstandard: vendor python-zstandard 0.11

indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The upstream source distribution from PyPI was extracted. Unwanted files were removed. The clang-format ignore list was updated to reflect the new

D6198: cext: make osutil.c PY_SSIZE_T_CLEAN

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is needed to avoid a deprecation warning on Python 3.8. With this change, we no longer see deprecation warnings for this issue on Python 3.8. REPOSITOR

D6197: cext: make parsers.c PY_SSIZE_T_CLEAN

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is needed to avoid a deprecation warning in Python 3.8. I believe the conversion of int to Py_ssize_t is harmless in the changed locations. But this being

D6196: cext: make revlog.c PY_SSIZE_T_CLEAN

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Without this, Python 3.8 emits a deprecation warning, as using int for # values is deprecated. Many existing modules use PY_SSIZE_T_CLEAN, so this shouldn't be

D6164: wix: add a hook for a prebuild script to inject extra libraries

indygreg added a comment. In https://phab.mercurial-scm.org/D6164#90074, @durin42 wrote: > In https://phab.mercurial-scm.org/D6164#90073, @indygreg wrote: > > > I would prefer you fix them :) > > > Okay, then what should we call it? `--extra-packages-script` since that's what it

D6164: wix: add a hook for a prebuild script to inject extra libraries

indygreg added a comment. I would prefer you fix them :) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6164 To: durin42, indygreg, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mer

D6164: wix: add a hook for a prebuild script to inject extra libraries

indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. Was a newer version of this patch with the requested changes going to be uploaded? It's weird to see additional patches in the series without this one updated... REPOSITORY

D6142: automation: perform tasks on remote machines

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb05a3e28cf24: automation: perform tasks on remote machines (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6142?vs=14510&id=

D6141: contrib: PowerShell script to install development dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rHGbf87d34a675c: contrib: PowerShell script to install development dependencies (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/

D6164: wix: add a hook for a prebuild script to inject extra libraries

indygreg added a comment. In https://phab.mercurial-scm.org/D6164#89915, @durin42 wrote: > In https://phab.mercurial-scm.org/D6164#89914, @indygreg wrote: > > > In https://phab.mercurial-scm.org/D6164#89913, @durin42 wrote: > > > > > > > > > > > How about we add an argument t

<    3   4   5   6   7   8   9   10   11   12   >