D6046: global: use raw strings for __slots__

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise Python 2 will coerce unicode to str at module load time. We don't like automatic string coercions. REPOSITORY rHG Mercurial REVISION DETAIL https:

D6051: encoding: use raw strings for encoding arguments

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This prevents the internals of Python from coercing a unicode to str on Python 2 and makes tests run with HGUNICODEPEDANTRY=1 a lot happier. REPOSITORY rHG M

D6050: revsetlang: use sysbytes() instead of blind encode()

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise we will call str.encode() on Python 2, which is wrong. sysbytes() does encode('utf-8) on Python 3. But the source is guaranteed ASCII, so it should

D6048: attr: don't attempt to .encode() a str on Python 2

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise it coerces automatically. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6048 AFFECTED FILES mercurial/thirdparty/attr/

D6047: procutil: use a raw string for module name

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise Python 2 will coerce unicode to str. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6047 AFFECTED FILES mercurial/utils

D6043: UnicodeEncoding:change the default encoding of the whole script to be 'UTF-8'(issue6040)

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. If we wanted to call ``sys.setdefaultencoding()``, we should call it once during ``hg`` or at the top of ``mercurial/__init__.py``. But we don't want to call ``sys.setdefa

D6045: inno: replace add_path.exe with a Pascal script

2019-03-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY While attempting to build the Inno installer, I was unable to find a copy of add_path.exe from the source site previously listed in the docs. Some quick Go

D5296: store: don't read the whole fncache in memory

2019-02-25 Thread indygreg (Gregory Szorc)
indygreg added a comment. I suspect https://phab.mercurial-scm.org/rHG9fca5b056c0a2f673aefa64f7ec7488bd9188d9d made things faster because the code before was using 1 I/O operation for every entry. I would also not be surprised if CPython from that era did something very inefficient with reg

D5976: tests: add more wildcards to test-extdiff.t

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG88d4477ac4f6: tests: add more wildcards to test-extdiff.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5976?vs=14115&id=1

D5975: url: don't pass strict argument on Python 3

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG544035846830: url: don't pass strict argument on Python 3 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5975?vs=14114&id=1

D5952: url: always use str for proxy configuration

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4028897dfa05: url: always use str for proxy configuration (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5952?vs=14113&id=1

D5974: tests: double escape \ in test-import-eol.t and test-mq-eol.t

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG140b542b0e59: tests: double escape \ in test-import-eol.t and test-mq-eol.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

D5951: py3: port tinyproxy.py to work with Python 3

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG97e2442a4595: py3: port tinyproxy.py to work with Python 3 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5951?vs=14054&id=

D5950: url: always access req._tunnel_host

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd20f1594ff4a: url: always access req._tunnel_host (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5950?vs=14053&id=14118 RE

D5973: tests: use raw string in test-impexp-branch.t

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7396508ad92b: tests: use raw string in test-impexp-branch.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5973?vs=14111&id

D5976: tests: add more wildcards to test-extdiff.t

2019-02-15 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The diff tool (which is `echo`) runs in the background and output order can therefore be non-deterministic. We need to glob over the file names to account for t

D5975: url: don't pass strict argument on Python 3

2019-02-15 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The argument was removed in Python 3.4. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5975 AFFECTED FILES mercurial/ur

D5952: url: always use str for proxy configuration

2019-02-15 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 14113. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5952?vs=14055&id=14113 REVISION DETAIL https://phab.mercurial-scm.org/D5952 AFFECTED FILES mercurial/url.py CHANGE DETAILS diff --git a/mercurial/url.py b/m

D5974: tests: double escape \ in test-import-eol.t and test-mq-eol.t

2019-02-15 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The shell eats the \\. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5974 AFFECTED FILES tests/test-import-eol.t tests/test-mq

D5973: tests: use raw string in test-impexp-branch.t

2019-02-15 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY On first glance, the escaping of \s seems correct. However, the shell eats the escape and we're left with '\s` in the written file. Let's use a raw string so we

D5972: exchange: raise error.Abort instead of ValueError

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3b0ba4575c8c: exchange: raise error.Abort instead of ValueError (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5972?vs=1410

D5971: tests: remove -q from test-lfs-serve.t

2019-02-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG47c4ac5035a6: tests: remove -q from test-lfs-serve.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5971?vs=14104&id=14106

D5972: exchange: raise error.Abort instead of ValueError

2019-02-15 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Raising ValueError results in an uncaught exception and a traceback being printed. In the context of servers, it can result in an HTTP 500 and an exception bein

D5971: tests: remove -q from test-lfs-serve.t

2019-02-15 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will make it easier to observe a behavior change in the next commit. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5971 AFF

D5958: remotefilelog: remove strkwargs()

2019-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4eeed5eac0f4: remotefilelog: remove strkwargs() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5958?vs=14082&id=14085 REVI

D5957: remotefilelog: use raw strings when looking for variable names

2019-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe37bd7ccfee3: remotefilelog: use raw strings when looking for variable names (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/

D5958: remotefilelog: remove strkwargs()

2019-02-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous commit activated previously unused code paths on Python 3 and revealed that we were calling strkwargs() on a dict that already had str keys. The on

D5957: remotefilelog: use raw strings when looking for variable names

2019-02-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Keys in self.__dict__ and vars() are always str. So we need to use raw strings to ensure lookups work on Python 3. 1. skip-blame just r'' prefixes REPOSITOR

D5947: revlog: use iterbytestr()

2019-02-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG389ad992d953: revlog: use iterbytestr() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5947?vs=14049&id=14064 REVISION DET

D5952: url: always use str for proxy configuration

2019-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, proxies didn't work on Python 3 for various reasons. First, the keys to the "proxies" dict are fed into a `setattr(self, "%s_open", ...)` call an

D5951: py3: port tinyproxy.py to work with Python 3

2019-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There were various str/bytes mismatches in the code. This caused the proxy server to misbehave at run-time. The manifestation was typically premature socket dis

D5950: url: always access req._tunnel_host

2019-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The getattr() was there to handle Python versions before 2.6, which lacked this attribute. We /might/ be able to further delete some code here. However, the

D5947: revlog: use iterbytestr()

2019-02-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise we iterate over integers in Python 3 and the character compare fails. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D594

D5925: py3: use raw strings and %d for formatting

2019-02-10 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG34ae00a14783: py3: use raw strings and %d for formatting (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5925?vs=14006&id=14

D5925: py3: use raw strings and %d for formatting

2019-02-10 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before the string compares on Python 3 failed because we were comparing bytes to str. Using raw strings ensures we are always comparing str. While we're he

D5816: global: make some docstrings raw strings

2019-02-05 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D5816#85618, @pulkit wrote: > Should we add `# skip-blame` to this and rest of the series as they are just adding of r'' prefixes? I'm not sure. If there are `\` in the string, adding the `r''` can change the value of th

D5817: attr: make some docstrings raw strings

2019-02-05 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa5493a251ad3: attr: make some docstrings raw strings (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5817?vs=13744&id=13805

D5846: tests: add syntax warnings on Python 3.8 in python-zstandard

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9f69ddb807f7: tests: add syntax warnings on Python 3.8 in python-zstandard (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5

D5845: check-py3-compat: manually format and print warnings

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGba7eaff26474: check-py3-compat: manually format and print warnings (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5845?vs=1

D5843: doc: escape backslash

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGeb14ab7db33e: doc: escape backslash (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5843?vs=13770&id=13797 REVISION DETAIL

D5844: check-py3-compat: provide filename to ast.parse()

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG01417ca7f2e2: check-py3-compat: provide filename to ast.parse() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5844?vs=1377

D5842: testparseutil: escape backslash in docstring

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG99b4c6d73a72: testparseutil: escape backslash in docstring (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5842?vs=13769&id=

D5841: tests: use raw strings in test-help.t

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG033a0f4b4a5f: tests: use raw strings in test-help.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5841?vs=13768&id=13795

D5840: tests: escape backslash in makepatch.py inline file

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7295279b9ea5: tests: escape backslash in makepatch.py inline file (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5840?vs=13

D5815: global: use raw strings for regular expressions with escapes

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbd3f03d8cc9f: global: use raw strings for regular expressions with escapes (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5

D5831: run-tests: set attributes in sorted order

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG20e62312e016: run-tests: set attributes in sorted order (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5831?vs=13758&id=137

D5839: tests: use raw strings in test-cbor.py

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1ea1bba1c5be: tests: use raw strings in test-cbor.py (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5839?vs=13766&id=13793

D5837: tests: use raw string in test-check-code.t

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf16c03c7a3d7: tests: use raw string in test-check-code.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5837?vs=13764&id=13

D5838: showstack: use raw docstring

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6dae1f31c6c9: showstack: use raw docstring (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5838?vs=13765&id=13792 REVISION

D5825: run-tests: use raw strings for regular expressions

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG17a6e063c886: run-tests: use raw strings for regular expressions (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5825?vs=137

D5830: revetbenchmarks: use raw string for regular expression with escapes

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfbb43514f342: revetbenchmarks: use raw string for regular expression with escapes (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm

D5817: attr: make some docstrings raw strings

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg added a comment. This is already fixed at https://github.com/python-attrs/attrs/pull/375. We'll presumably get it on next vendor. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5817 To: indygreg, #hg-reviewers Cc: durin42, mercurial-devel _

D5829: check-code: use raw string

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7d1798ec92a3: check-code: use raw string (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5829?vs=13756&id=13788 REVISION DE

D5828: tests: use raw strings for regular expressions with escapes

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdddf53473315: tests: use raw strings for regular expressions with escapes (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D58

D5827: drawdag: use raw strings for docstrings

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8d4ee2d9ffb8: drawdag: use raw strings for docstrings (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5827?vs=13754&id=13786

D5826: check-config: use raw strings for regular expressions

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG595a67a301ee: check-config: use raw strings for regular expressions (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5826?vs=

D5824: check-commit: use raw string for regular expression

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG45a4789d3ff2: check-commit: use raw string for regular expression (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5824?vs=13

D5822: configitems: use raw strings for hidden-{command,topic} items

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb5642239fb32: configitems: use raw strings for hidden-{command,topic} items (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

D5816: global: make some docstrings raw strings

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0f64091cc851: global: make some docstrings raw strings (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5816?vs=13743&id=1377

D5821: convert: use raw string for regular expressions

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfc09aafd3c36: convert: use raw string for regular expressions (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5821?vs=13748&

D5818: patch: properly escape \ in string literals

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG47c92f8ed128: patch: properly escape \ in string literals (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5818?vs=13745&id=1

D5820: graphmod: use raw string

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfb9e11fdcbba: graphmod: use raw string (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5820?vs=13747&id=13780 REVISION DETA

D5819: crecord: use raw string for regular expression

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7a90ff8cd14c: crecord: use raw string for regular expression (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5819?vs=13746&i

D5823: tests: add optional Python 2.7 deprecation output

2019-02-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG14983ac4a764: tests: add optional Python 2.7 deprecation output (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5823?vs=1375

D5846: tests: add syntax warnings on Python 3.8 in python-zstandard

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These are warnings from upstream test code. Let's just acknowledge them for now. These should go away in a future python-zstandard release :) REPOSITOR

D5843: doc: escape backslash

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This avoids a SyntaxWarning on Python 3.8 due to invalid \ escape. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5843 AFFECTED FIL

D5841: tests: use raw strings in test-help.t

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This avoids SyntaxWarning on Python 3.8 due to invalid \ escapes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5841 AFFECTED FILE

D5845: check-py3-compat: manually format and print warnings

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The warnings mechanism may print to stderr on Python 3. Independent buffering of stdout and stderr can lead to warnings output not being printed properly. Th

D5844: check-py3-compat: provide filename to ast.parse()

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This ensures any warning/error messages print a valid filename instead of potentially ''. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-sc

D5840: tests: escape backslash in makepatch.py inline file

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This avoids some SyntaxWarning on Python 3.8 due to unescaped \. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5840 AFFECTED FILES

D5842: testparseutil: escape backslash in docstring

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is funky. This inline Python code is part of a docstring, which means the string is interpreted first. So any backslashes need double escaping. So even tho

D5839: tests: use raw strings in test-cbor.py

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY To avoid SyntaxWarning on Python 3.8 due to invalid \ escape. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5839 AFFECTED FILES

D5838: showstack: use raw docstring

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Avoids a SyntaxWarning on Python 3.8 due to invalid \ escape. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5838 AFFECTED FILES

D5837: tests: use raw string in test-check-code.t

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY To avoid a SyntaxWarning on Python 3.8 due to invalid \ escape. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5837 AFFECTED FILES

D5831: run-tests: set attributes in sorted order

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Python 3.8 preserves insertion order in serialized output (https://bugs.python.org/issue34160). Older Pythons serialized in sorted order. Let's make insert

D5825: run-tests: use raw strings for regular expressions

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Avoids SyntaxWarning due to invalid \ escape on Python 3.8. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5825 AFFECTED FILES te

D5829: check-code: use raw string

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This avoids a SyntaxWarning in Python 3.8. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5829 AFFECTED FILES contrib/check-code.

D5830: revetbenchmarks: use raw string for regular expression with escapes

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This avoids a SyntaxWarning on Python 3.8. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5830 AFFECTED FILES contrib/revsetbench

D5828: tests: use raw strings for regular expressions with escapes

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Avoids SyntaxWarning on Python 3.8. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5828 AFFECTED FILES tests/hghave.py CHANGE DE

D5827: drawdag: use raw strings for docstrings

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Avoids SyntaxWarning for invalid \ escape on Python 3.8. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5827 AFFECTED FILES tests

D5826: check-config: use raw strings for regular expressions

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This avoids SyntaxWarning on Python 3.8 for invalid \ escapes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5826 AFFECTED FILES

D5824: check-commit: use raw string for regular expression

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Avoids SyntaxWarning on Python 3.8. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5824 AFFECTED FILES contrib/check-commit CHAN

D5823: tests: add optional Python 2.7 deprecation output

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY pip 19 will emit a Python 2.7 deprecation warning when used with Python 2.7. Let's add that as optional output to our pip test. REPOSITORY rHG Mercurial REVIS

D5815: global: use raw strings for regular expressions with escapes

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Escape sequences like \w, \s, and \d are technically invalid in str/bytes. This became a deprecation warning in Python 3.6 (https://bugs.python.org/issue27364).

D5816: global: make some docstrings raw strings

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Python 3.8 emits a SyntaxWarning when a str/bytes contains invalid \ escapes. Various docstrings in our code base contain inv

D5822: configitems: use raw strings for hidden-{command,topic} items

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These strings are regular expressions. The "\." needs to be string escaped. We use raw strings to avoid doing that and the SyntaxWarning we'd receive otherwise

D5818: patch: properly escape \ in string literals

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Python 3.8 will emit a SyntaxWarning for str/bytes with invalid escapes. This commit addresses 4 occurrences where we had a bare \ in a str/bytes. REPOSITORY

D5821: convert: use raw string for regular expressions

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This avoids a SyntaxWarning on Python 3.8. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5821 AFFECTED FILES hgext/convert/monot

D5820: graphmod: use raw string

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Needed to avoid a SyntaxWarning due to unescaped \ in Python 3.8. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5820 AFFECTED FILE

D5819: crecord: use raw string for regular expression

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY \s emits a SyntaxWarning in Python 3.8. Use a raw string to avoid escaping the \. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5

D5817: attr: make some docstrings raw strings

2019-02-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This avoids a SyntaxWarning in Python 3.8 due to invalid \ escapes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5817 AFFECTED

D5807: py3: add alternate output on Python 3

2019-02-02 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9955776e2adf: py3: add alternate output on Python 3 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5807?vs=13707&id=13710

D5804: zeroconf: Python 3 porting of vendored library

2019-02-02 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1c85b790ddb0: zeroconf: Python 3 porting of vendored library (authored by indygreg, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5804?vs=13704&id=13708#toc REPOSITORY rHG

D5806: py3: add Python 3 output for test-flagprocessor.t

2019-02-02 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa4392b5c69ce: py3: add Python 3 output for test-flagprocessor.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5806?vs=1370

D5807: py3: add alternate output on Python 3

2019-02-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is basically the same deal as https://phab.mercurial-scm.org/D5806. Python 3's exception printing output is different. We had to tweak the re

D5806: py3: add Python 3 output for test-flagprocessor.t

2019-02-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The exception is being generated from ui.traceback(), which simply calls traceback.format_*() to format exceptions. Since the output from the standard

D5804: zeroconf: Python 3 porting of vendored library

2019-02-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A quick glance through this module reveals that most of it "just works" on Python 3 with the source transformer active. There are a few places where we need to

D5805: zeroconf: port to Python 3

2019-02-02 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since we're using the source transformer on Python 3, calls into Zeroconf and return values from it are generally bytes. But various socket functions require

D5796: py3: conditionalize test-demandimport.py for Python 3

2019-02-01 Thread indygreg (Gregory Szorc)
indygreg added a comment. I didn't realize this was already queued with formatting changes fixed in flight. Ignore my latest upload. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5796 To: indygreg, #hg-reviewers Cc: yuja, mjpieters, mercurial-devel ___

D5796: py3: conditionalize test-demandimport.py for Python 3

2019-02-01 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 13697. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5796?vs=13687&id=13697 REVISION DETAIL https://phab.mercurial-scm.org/D5796 AFFECTED FILES tests/test-check-code.t tests/test-demandimport.py CHANGE DETAIL

<    5   6   7   8   9   10   11   12   13   14   >