D4934: narrow: don't compress the bundle2 when sending 'error:abort'

2018-10-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb9a07a58b44d: narrow: dont compress the bundle2 when sending error:abort (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4933: push:Added keyword remote to 'repository changed while pushing' error(Issue5971)(whitespaces fixed)

2018-10-10 Thread pulkit (Pulkit Goyal)
pulkit added a comment. @timeless suggested using the word 'destination' instead of 'remote'. I feel like destination is a better word. How do others feel? @taapas1128 no need to update the patch right now. REPOSITORY rHG Mercurial REVISION DETAIL

D4934: narrow: don't compress the bundle2 when sending 'error:abort'

2018-10-10 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is similar to waht getbundle() does and also explicitly specifies that we should get a

D4932: push:Added keyword remote to 'repository changed while pushing' error(Issue5971)

2018-10-10 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Hi Taapas, thanks for taking time and preparing this patch. This patch contains unrelated whitespace changes, can you undo them. There is not much left to do in this patch but still I will be happy to mentor you on this if required. I am pulkit25 on #mercurial on

D4931: narrow: only send the narrowspecs back if ACL in play

2018-10-10 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I am unable to think why we need to send narrowspecs back from the server. The current state

D4876: amend: add config to skip amend if only date is changed (issue5828)

2018-10-08 Thread pulkit (Pulkit Goyal)
pulkit added a comment. (Replying because I adviced Zharas to take up this issue and he is a new mercurial user and have less context on the problem) In https://phab.mercurial-scm.org/D4876#74017, @martinvonz wrote: > I'm not sure how I feel about this. I think we talked within the

D4901: narrow: move remaining narrow-limited dirstate walks to core

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit added a comment. > These places now end up doing an unrestricted dirstate walk after this > patch: > > debugfileset > perfwalk > sparse (but restricted to sparse config) > largefiles > > I'll let anyone who cares about these cases adapt them to work with > narrow

D4895: RFC: narrow: don't include manifests the client already has

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > changegroup.py:1056 > > -yield tree, deltas > +if not tree or not self._oldfilematcher.visitdir(store.tree[:-1] > or '.'): > +yield tree, deltas Also, I think this is not the right place to case this

D4895: RFC: narrow: don't include manifests the client already has

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit added a comment. @martinvonz Thanks a lot for putting time and effort in trying alternate approach. Sadly this does not work. I didn't tested this on our repo yet, but I tested this on test-narrow-widen-no-ellipsis.t. You can also do that, by removing the globs from this line

D4893: py3: add 8 new passing tests to whitelist found by buildbot

2018-10-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdaff528e00d7: py3: add 8 new passing tests to whitelist found by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4894: py3: use '%f' for floats instead of '%s'

2018-10-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2e9378f62232: py3: use %f for floats instead of %s (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4894?vs=11713=11718

D4891: narrow: move adding of narrow server capabilities to core

2018-10-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGad8d8dc9be3f: narrow: move adding of narrow server capabilities to core (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4890: wireprotoserver: move narrow capabilities to wireprototypes.py

2018-10-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf7011b44d205: wireprotoserver: move narrow capabilities to wireprototypes.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4889: narrow: introduce a config option to check if narrow is enabled or not

2018-10-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe92454e69dc3: narrow: introduce a config option to check if narrow is enabled or not (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4894: py3: use '%f' for floats instead of '%s'

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I remember Yuya saying we need to use bytestr() or '%r' because '%s' was clever. Not sure it applies to this or not. REPOSITORY rHG Mercurial REVISION DETAIL

D4893: py3: add 8 new passing tests to whitelist found by buildbot

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We are getting close! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4893 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS

D4892: narrow: drop the bundle2 capability since we have server capabilities (BC)

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch drops the narrow bundle2 capabilities since we introduced narrow server

D4891: narrow: move adding of narrow server capabilities to core

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We use the experimental.narrow config option introduced in one of the previous patch and

D4890: wireprotoserver: move narrow capabilities to wireprototypes.py

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is done because wireprotoserver import wireprotov1server, so you cannot import

D4889: narrow: introduce a config option to check if narrow is enabled or not

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch introduces a new config option experimental.narrow which is set to False by

D4888: narrow: move the code to generate a widening bundle2 to core

2018-10-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1ea80ac13f19: narrow: move the code to generate a widening bundle2 to core (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4887: narrow: don't include the manifests while widening a narrow clone

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11706. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4887?vs=11700=11706 REVISION DETAIL https://phab.mercurial-scm.org/D4887 AFFECTED FILES mercurial/bundle2.py mercurial/changegroup.py CHANGE DETAILS diff

D4886: changegroup: add a parts argument to cgpacker.generate()

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11705. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4886?vs=11699=11705 REVISION DETAIL https://phab.mercurial-scm.org/D4886 AFFECTED FILES mercurial/bundle2.py mercurial/changegroup.py CHANGE DETAILS diff

D4888: narrow: move the code to generate a widening bundle2 to core

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a part of moving more narrow related bits to core. REPOSITORY rHG Mercurial

D4887: narrow: don't include the manifests while widening a narrow clone

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D4887#73793, @martinvonz wrote: > > I'm still fine with queuing this for now if you need this patch somewhat urgently even though I think the code in this patch and in https://phab.mercurial-scm.org/D4886 should

D4838: narrow: start returning bundle2 from widen_bundle()

2018-10-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe8132a8897da: narrow: start returning bundle2 from widen_bundle() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4813: narrow: the first version of narrow_widen wireprotocol command

2018-10-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8feae5b989bc: narrow: the first version of narrow_widen wireprotocol command (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4838: narrow: start returning bundle2 from widen_bundle()

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11701. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4838?vs=11592=11701 REVISION DETAIL https://phab.mercurial-scm.org/D4838 AFFECTED FILES hgext/narrow/narrowbundle2.py hgext/narrow/narrowwirepeer.py CHANGE

D4813: narrow: the first version of narrow_widen wireprotocol command

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > indygreg wrote in narrowwirepeer.py:107 > This may want to catch `Exception`. Okay, I will followup if this got pushed. Also I copied it from getbundle, do we want to change it there also? REPOSITORY rHG Mercurial REVISION DETAIL

D4838: narrow: start returning bundle2 from widen_bundle()

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit planned changes to this revision. pulkit added a comment. This one does not apply cleanly on it's parent now. I will rebase and resend. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4838 To: pulkit, durin42, martinvonz, #hg-reviewers Cc: mercurial-devel

D4887: narrow: don't include the manifests while widening a narrow clone

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When a narrow clone is done initially the whole manifest is send. In case of treemanifests,

D4886: changegroup: add a parts argument to cgpacker.generate()

2018-10-05 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch removes the changelog argument added to cgpacker.generate() few weeks ago and

D3639: remotenames: add names argument to remotenames revset

2018-10-05 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6638bd3f061b: remotenames: add names argument to remotenames revset (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4882: obsolete: fixed ValueError when stored note contains ':' char (issue5783)

2018-10-04 Thread pulkit (Pulkit Goyal)
pulkit accepted this revision. pulkit added a comment. This series looks good to me but again since I helped Zharas prepare it, I won't queue it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4882 To: Zharaskhan, #hg-reviewers, pulkit Cc: pulkit,

D4876: amend: add config to skip amend if only date is changed (issue5828)

2018-10-04 Thread pulkit (Pulkit Goyal)
pulkit accepted this revision. pulkit added a comment. This looks good to me but since I helped Zharas in preparing the patch, I won't queue it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4876 To: Zharaskhan, #hg-reviewers, pulkit Cc: pulkit,

D4813: narrow: the first version of narrow_widen wireprotocol command

2018-10-04 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11675. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4813?vs=11591=11675 REVISION DETAIL https://phab.mercurial-scm.org/D4813 AFFECTED FILES

D4813: narrow: the first version of narrow_widen wireprotocol command

2018-10-04 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D4813#73534, @martinvonz wrote: > > I need to specify the arguments instead of just specifying "*". > > Don't forget this one. Did that! INLINE COMMENTS > indygreg wrote in narrowbundle2.py:329 > Because of how

D4851: streamclone: pass narrowing related info in generatev2() and _walkstreamfiles()

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds includes and excludes as argument to generatev2() and build a matcher using that and pass that into _walkstreamfiles(). This will help us in

D4850: store: pass matcher to store.datafiles() and filter files according to it

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY To get narrow stream clones working, we need a way to filter the storage files using a matcher. This patch adds matcher as an argument to store.walk() and

D4849: store: introduce a function to get tracked path from a fncache entry

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch introduces a function to get the trakced path from a fncache entry. This will be used to filter out files to streamclone using a narrowmatcher. The

D4786: narrow: factor out logic to create cg while widening into separate fn

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in narrowbundle2.py:54 > > I said that because there is a 'narrow:changespec' part being send from the > > server. > > I assumed that was the reason :) But I don't think we'll need that part > because we don't need to strip

D4847: manifest: remove an unused variable caught by pyflakes

2018-10-03 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe22016e83c1e: manifest: remove an unused variable caught by pyflakes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4848: py3: whitelist another passing tests caught by buildbot

2018-10-03 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa8ec8bce14c6: py3: whitelist another passing tests caught by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4813: narrow: the first version of narrow_widen wireprotocol command

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in narrowcommands.py:293-295 > As I said on IRC, I think we (Google) would appreciate it if this could > remain here for a while to give us more time to migrate our custom server to > the new wire protocol command. I was thinking

D4838: narrow: start returning bundle2 from widen_bundle()

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11592. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4838?vs=11573=11592 REVISION DETAIL https://phab.mercurial-scm.org/D4838 AFFECTED FILES hgext/narrow/narrowbundle2.py hgext/narrow/narrowwirepeer.py CHANGE

D4848: py3: whitelist another passing tests caught by buildbot

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I this indygreg recent patches made this test pass on Python 3. So thanks to him! REPOSITORY rHG Mercurial REVISION DETAIL

D4847: manifest: remove an unused variable caught by pyflakes

2018-10-03 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Uses of todel were removed in https://phab.mercurial-scm.org/D4843. This patch will make buildbots green again. REPOSITORY rHG Mercurial REVISION DETAIL

D4832: debugcommands: add a debugindexstats command

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Can we please add a simple test for the new command? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4832 To: martinvonz, #hg-reviewers Cc: pulkit, mercurial-devel ___ Mercurial-devel mailing

D4813: narrow: the first version of narrow_widen wireprotocol command

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11572. pulkit edited the summary of this revision. pulkit retitled this revision from "[RFC] narrow: the first version of narrow_widen wireprotocol command" to "narrow: the first version of narrow_widen wireprotocol command". REPOSITORY rHG Mercurial

D4838: narrow: start returning bundle2 from widen_bundle()

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11573. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4838?vs=11562=11573 REVISION DETAIL https://phab.mercurial-scm.org/D4838 AFFECTED FILES hgext/narrow/narrowbundle2.py hgext/narrow/narrowwirepeer.py CHANGE

D4789: narrow: check for servers' narrow support before doing anything (BC)

2018-10-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG06e75fbf9d6b: narrow: check for servers narrow support before doing anything (BC) (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4812: narrow: pass old includes and excludes to _widen()

2018-10-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1a4c1a3cc3f5: narrow: pass old includes and excludes to _widen() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

2018-10-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG693dda764efe: narrow: dont do the dirstate dance if ellipses is not enabled (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4787: narrow: pass 'narrow_widen' as source while generating changegroup

2018-10-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa2395659828: narrow: pass narrow_widen as source while generating changegroup (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4786: narrow: factor out logic to create cg while widening into separate fn

2018-10-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGad9ca365738b: narrow: factor out logic to create cg while widening into separate fn (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4786: narrow: factor out logic to create cg while widening into separate fn

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit added a comment. I have not changed this patch much, just added a XXX, saying we should return a bundle from here. I changed https://phab.mercurial-scm.org/D4813 to return a bundle2 instead of just sending the changegroup and added a patch on top of it for returning a bundle2 from

D4813: [RFC] narrow: the first version of narrow_widen wireprotocol command

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > indygreg wrote in narrowwirepeer.py:71-78 > Do we need to call `narrowspec.restrictpatterns()` anywhere in here? I am not sure, @martinvonz what do you think? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4813 To:

D4813: [RFC] narrow: the first version of narrow_widen wireprotocol command

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11561. pulkit edited the summary of this revision. Herald added a reviewer: martinvonz. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4813?vs=11520=11561 REVISION DETAIL https://phab.mercurial-scm.org/D4813

D4838: narrow: start returning bundle2 from widen_bundle()

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4838 AFFECTED FILES

D4787: narrow: pass 'narrow_widen' as source while generating changegroup

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11560. Herald added a reviewer: martinvonz. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4787?vs=11470=11560 REVISION DETAIL https://phab.mercurial-scm.org/D4787 AFFECTED FILES hgext/narrow/narrowbundle2.py

D4786: narrow: factor out logic to create cg while widening into separate fn

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11559. pulkit edited the summary of this revision. Herald added a reviewer: martinvonz. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4786?vs=11469=11559 REVISION DETAIL https://phab.mercurial-scm.org/D4786

D4837: narrow: remove narrowpatch instead of narrowcopies

2018-10-02 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG813eb942ca0a: narrow: remove narrowpatch instead of narrowcopies (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4837: narrow: remove narrowpatch instead of narrowcopies

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY https://phab.mercurial-scm.org/rHG84092edd5c88bbb3c2a5de377cfd9ca79019fa39 removed

D4823: narrow: drop unnecessary overrides of patch

2018-10-02 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > __init__.py:71 > narrowrepo.wraprepo(repo) > -narrowcopies.setup(repo) > narrowpatch.setup(repo) I think you want to delete narrowpatch here, not narrowcopies. REPOSITORY rHG Mercurial REVISION DETAIL

D4809: narrow: move the ellipses server capability to core

2018-10-01 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa24f4638d6c1: narrow: move the ellipses server capability to core (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4808: narrow: move the wireprotocol narrow capability name to core

2018-10-01 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd5498db5f86a: narrow: move the wireprotocol narrow capability name to core (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4809: narrow: move the ellipses server capability to core

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit added a comment. @martinvonz I have removed the logic of adding a new ellipses requirement from current series as coupling that and this series for review turned out to be a bad idea. This series now only tries to do some cleanup and introduce a new wireprotocol command. REPOSITORY

D4789: narrow: check for servers' narrow support before doing anything (BC)

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D4789#72717, @martinvonz wrote: > > This is BC because new clients won't be able to extend from old narrow-enabled servers. > > I think your previous patch was also BC in that sense since it started requiring the server to

D4810: repository: introduce an ellipses repo requirement

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit planned changes to this revision. pulkit added a comment. Let's do this step by step and get the wireprotocol command reviewed first. Once that is done, I will resend this one. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4810 To: pulkit,

D4813: [RFC] narrow: the first version of narrow_widen wireprotocol command

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11520. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4813?vs=11505=11520 REVISION DETAIL https://phab.mercurial-scm.org/D4813 AFFECTED FILES hgext/narrow/narrowcommands.py hgext/narrow/narrowwirepeer.py

D4789: narrow: check for servers' narrow support before doing anything (BC)

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11518. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4789?vs=11503=11518 REVISION DETAIL https://phab.mercurial-scm.org/D4789 AFFECTED FILES

D4812: narrow: pass old includes and excludes to _widen()

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11519. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4812?vs=11504=11519 REVISION DETAIL https://phab.mercurial-scm.org/D4812 AFFECTED FILES hgext/narrow/narrowcommands.py CHANGE DETAILS diff --git

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11517. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4788?vs=11502=11517 REVISION DETAIL https://phab.mercurial-scm.org/D4788 AFFECTED FILES hgext/narrow/narrowcommands.py tests/test-narrow-widen-no-ellipsis.t

D4809: narrow: move the ellipses server capability to core

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11516. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4809?vs=11500=11516 REVISION DETAIL https://phab.mercurial-scm.org/D4809 AFFECTED FILES hgext/narrow/narrowcommands.py hgext/narrow/narrowrepo.py

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D4788#72714, @martinvonz wrote: > In https://phab.mercurial-scm.org/D4788#72444, @pulkit wrote: > > > I am not sure about this one. I was unable to think of a reason why we need to do this dirstate dance in non-ellipses cases.

D4787: narrow: pass 'narrow_widen' as source while generating changegroup

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D4787#72712, @martinvonz wrote: > > Although this is called as a part of exchange.pull(), we don't want other > > extensions to wrap this pull call because it's not a normal pull and it's > > widening. > > I don't follow

D4786: narrow: factor out logic to create cg while widening into separate fn

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in narrowbundle2.py:54 > Do you plan to add support for ellipses to this too? I don't know if you need > that feature, but I think the coming wire protocol command should eventually > gain support for ellipsis nodes. Do you think

D4817: py3: whitelist two additional tests

2018-10-01 Thread pulkit (Pulkit Goyal)
pulkit added a comment. I removed the duplicate entry of `test-debugcommands.t` and amended the commit message to say one test and queued, many thanks! INLINE COMMENTS > python3-whitelist:107 > test-debugcommands.t > +test-debugcommands.t > test-debugextensions.t This already exists on

D4814: py3: add one more passing test to whitelist caught by buildbot

2018-10-01 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGeca452fa99b5: py3: add one more passing test to whitelist caught by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4810: repository: introduce an ellipses repo requirement

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in repository.py:22-24 > I'm not sure I understand what this says. > > The first sentence sounds too obvious to mention (kind of like "when it's > done, it should be working well"), but I suspect you mean something else. Do >

D4809: narrow: move the ellipses server capability to core

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in test-narrow-clone.t:48 > This doesn't look right. I suspect it was done by a mistaken `run-tests.py -i` I just ran `run-tests.py -i` and it popped up and I accepted it. I will check if the test pass without this change or not.

D4664: mergecommit: add a new extension to merge in-memory and create a commit

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Thinking about this more, I think I have not done a good job writing commit message. The extension is very useful when you have automation around merges or you do merges because of the following reasons: - The merge is done in-memory and is very fast if you

D4814: py3: add one more passing test to whitelist caught by buildbot

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Thanks to Matt Harbison who fixed the remaining failures of this test. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4814 AFFECTED

D4813: [RFC] narrow: the first version of narrow_widen wireprotocol command

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch introduces a wireprotocol command narrow_widen() which will be used to widen a narrow copy using `hg tracked` command

D4812: narrow: pass old includes and excludes to _widen()

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In future patches we will need to pass them in the widen wireprotocol command which we are building. REPOSITORY rHG Mercurial

D4789: narrow: check for servers' narrow support before doing anything (BC)

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11503. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4789?vs=11472=11503 REVISION DETAIL https://phab.mercurial-scm.org/D4789 AFFECTED FILES hgext/narrow/narrowcommands.py

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11502. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4788?vs=11471=11502 REVISION DETAIL https://phab.mercurial-scm.org/D4788 AFFECTED FILES

D4809: narrow: move the ellipses server capability to core

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11500. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4809?vs=11492=11500 REVISION DETAIL https://phab.mercurial-scm.org/D4809 AFFECTED FILES hgext/narrow/__init__.py hgext/narrow/narrowcommands.py

D4810: repository: introduce an ellipses repo requirement

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11501. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4810?vs=11493=11501 REVISION DETAIL https://phab.mercurial-scm.org/D4810 AFFECTED FILES mercurial/repository.py CHANGE DETAILS diff --git

D4808: narrow: move the wireprotocol narrow capability name to core

2018-09-30 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 11499. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4808?vs=11491=11499 REVISION DETAIL https://phab.mercurial-scm.org/D4808 AFFECTED FILES hgext/narrow/narrowcommands.py hgext/narrow/narrowrepo.py

D4811: py3: use util.forcebytestr() to convert error messages to bytes

2018-09-29 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7eb937f598d1: py3: use util.forcebytestr() to convert error messages to bytes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4811: py3: use util.forcebytestr() to convert error messages to bytes

2018-09-29 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes the python 3 buildbot green again. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4811

D4809: narrow: move the ellipses server capability to core

2018-09-29 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will be used in core logic to determining whether a server is ellipses enabled or not. And also this will ease moving narrow

D4810: repository: introduce an ellipses repo requirement

2018-09-29 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Right now there is no good way to check whether a repo is ellipses enabled or not. This patch introduces a ellipses repo requirement which will be used in

D4808: narrow: move the wireprotocol narrow capability name to core

2018-09-29 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We are trying to integrate the whole of narrow logic into core and it will be helpful for upcoming patches to have these

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

2018-09-28 Thread pulkit (Pulkit Goyal)
pulkit added a subscriber: martinvonz. pulkit added a comment. I am not sure about this one. I was unable to think of a reason why we need to do this dirstate dance in non-ellipses cases. @martinvonz @durin42 do you know why we do this? REPOSITORY rHG Mercurial REVISION DETAIL

D4789: narrow: check for servers' narrow support before doing anything (BC)

2018-09-28 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Recently we introduced narrow capabilities for the server. So we can check whether a server has narrow clone support or not

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

2018-09-28 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I believe we set dirstate parents to nullid before widening pull because in ellipses cases, the parent might be stripped off with

D4787: narrow: pass 'narrow_widen' as source while generating changegroup

2018-09-28 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Although this is called as a part of exchange.pull(), we don't want other extensions to wrap this pull call because it's not a

D4786: narrow: factor out logic to create cg while widening into separate fn

2018-09-28 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch takes out the logic which generates a changegroup for widening a narrow clone when ellipses are disabled. This is done

<    9   10   11   12   13   14   15   16   17   18   >