D7644: rebase: use cmdutil.check_incompatible_arguments() for --auto-orphans

pulkit added inline comments. INLINE COMMENTS > test-rebase-obsolete.t:2057 >$ hg rebase --stop --dry-run > - abort: cannot specify both --dry-run and --stop > + abort: cannot specify both --stop and --dry-run >[255] Unrelated change? REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7641: rebase: use cmdutil.check_at_most_one_arg() for --confirm/--dry-run

pulkit added a comment. In D7641#113027 , @yuja wrote: >>> Spotted in a later patch, need to replace `_` back to `-` before printing output. >> >> Strings are immutable in Python, so it wasn't actually replaced, right? Or do I

D7631: absorb: allowing committed changes to be absorbed into their ancestors

pulkit added a comment. Can you describe the feature a bit in the commit message. Specific things which I feel are missing: - what happens to wdir changes - what happens if source is a commit is not a head I understand them but after reading the tests, so might be worth to add

D7652: test: extract some generic data and utility from test-rust-ancestor.py

pulkit added inline comments. INLINE COMMENTS > revlog.py:34 > +cparsers is None, > +"The C Extension parsers module tests relies on is not available", > +) this and next message requires an oxford comma to help understand better. > test-rust-ancestor.py:34 > @unittest.skipIf( > -

D7624: rcutil: don't check if defaultrc/ is a directory -- we know it is

pulkit added a comment. I am unable to find some code or understand the reasoning behind `-- we know this` part. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7624/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7624 To: martinvonz,

D7627: config: drop debug messages saying where config was read from

pulkit added a comment. After recent iteration, commit message needs to be reworked. Maybe I am biased because I know what the old version was and is still parsing the commit message that way. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7627/new/

D7679: windows: if username(uid=None) is loaded, just use getpass

This revision is now accepted and ready to land. pulkit added inline comments. pulkit accepted this revision. INLINE COMMENTS > windows.py:566 > > If uid is None, return the name of the current user.""" > +if not uid: Nice, seems like the old documentation was wrong. REPOSITORY

D7641: rebase: use cmdutil.check_at_most_one_arg() for --confirm/--dry-run

pulkit added inline comments. INLINE COMMENTS > cmdutil.py:272 > if previous: > raise error.Abort( > _(b'cannot specify both --%s and --%s') % (previous, x) Spotted in a later patch, need to replace `_` back to `-` before printing output.

D7637: pathbomb: use cmdutil.check_at_most_one_arg()

pulkit added a comment. Renaming `pathbomb` to `patchbomb` in message title. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7637/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7637 To: martinvonz, #hg-reviewers, pulkit Cc:

D7633: clone: extract helper for checking mutually exclusive args

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in cmdutil.py:263 > I don't think I'd be able to guess what a function by that name did either. > `check_at_most_one_argument` seems clearer, but maybe too long. I'll wait a > bit for other ideas before I change anything. I

D7632: graft: reuse cmdutl.resolvecommitoptions()

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. After this, if both `--currentuser` and `--user` are passed, `--currentuser` takes precedence, which is not the behavior right now. But the new behavior is better and consistent with other

D7606: fuzz: fix mpatch_corpus to not have an overridden __repr__ on py3

pulkit added a comment. Amended following diff to make test-check-format.t happy: diff --git a/contrib/fuzz/mpatch_corpus.py b/contrib/fuzz/mpatch_corpus.py --- a/contrib/fuzz/mpatch_corpus.py +++ b/contrib/fuzz/mpatch_corpus.py @@ -16,11 +16,15 @@ args = ap.parse_args()

D7595: status: outputting structured unfinished-operation information

pulkit added a comment. Applying this on top of D7605 failed. So unfortunately you have to rebase again and resend. Also, I think you are `pip install black` away from preventing such conflicts. REPOSITORY rHG Mercurial BRANCH default CHANGES

D7605: formatting: fix some recent formatting regressions

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. Thanks for this. I installed black now, so I hope I will catch these next time before pushing changes. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION

D7601: fuzz: fix test-fuzz-targets.t to run with python3

pulkit added inline comments. INLINE COMMENTS > mharbison72 wrote in mpatch_corpus.py:53 > Doesn't `__repr__` have to return `str` on py3? It looks like there are few > other instances of this. ha, yep. @spectral can you send a follow-up for this? REPOSITORY rHG Mercurial CHANGES SINCE

D7506: phabricator: add a "phabstatus" show view

This revision now requires changes to proceed. pulkit added a comment. pulkit requested changes to this revision. `test-check-module-imports.t` says hi! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7506/new/ REVISION DETAIL

D7593: status: split morestatus data loading from display

pulkit added a comment. pulkit added a subscriber: martinvonz. I pushed @martinvonz D7591 , so these need to be rebased. Thanks! REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7593/new/ REVISION

D7524: rust-dirs-multiset: use `AsRef` instead of concrete types when possible

pulkit added a comment. This one fails to apply on default. Skipping pushing this and it's accepted children. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7524/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7524 To:

D7595: status: outputting structured unfinished-operation information

pulkit added inline comments. pulkit added subscribers: yuja, pulkit. INLINE COMMENTS > configitems.py:247 > coreconfigitem( > +b'commands', b'status.morestatus-item', default=False, > +) IMO the whole morestatus functionality is already behind a config option, so lets not have a config

D7557: annotate: describe --skip as taking a revset

pulkit added a comment. Isn't it that where ever we says `revisions` we imply `revsets`? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7557/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7557 To: durin42, #hg-reviewers Cc: pulkit, mjpieters,

D7521: amend: check for file modifications when updating dirstate (issue6233)

pulkit added a comment. Looks like I forgot to drop this from my queue and pushed it. :( REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7521/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7521 To: spectral, #hg-reviewers, mharbison72, pulkit

D7556: tests: remove hardcoded errno values

pulkit added a comment. This is for stable branch or default? REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7556/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7556 To: jcristau, #hg-reviewers, pulkit Cc: mercurial-devel

D7521: amend: check for file modifications when updating dirstate (issue6233)

pulkit added a comment. I get the following test failure: --- /home/pulkit/repo/hgpush/tests/test-amend.t +++ /home/pulkit/repo/hgpush/tests/test-amend.t#obsstore-off.err @@ -505,4 +505,23 @@

D7462: py3: make doc strings containing the deprected '\.' escape sequence raw strings

pulkit added a comment. Applied the following diff to commit message as `test-check-commit.t` was complaining: --- a/changeset-description +++ b/changeset-description @@ -1,3 +1,3 @@ -py3: make doc strings containing the deprected '\.' escape sequence raw strings +py3:

D7441: match: remove explicitdir attribute

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. Queued the series, many thanks! Thanks @Alphare for reviewing :) REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7441/new/

D7198: lock: refactor in preparation for next commit

pulkit added a comment. pulkit added subscribers: marmoute, pulkit. @marmoute can you have a look at these two patches? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7198/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7198 To:

D7221: hghave: fix bytes/string issue on Python 3

pulkit added a comment. This has already been pushed as https://www.mercurial-scm.org/repo/hg-committed/rev/c3bca833cb92 REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7221/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7221 To: durin42,

D7144: status: use unfiltered repo if we're getting status of working copy

pulkit added a comment. I am +1 on this idea. I see @marmoute has some concerns around extensions wrapping, once they are addressed, I will push it once the freeze ends. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7144/new/ REVISION DETAIL

D7146: [RFC] grep: add config option to grep PWD by default

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is motivated by a disscussion on IRC. TODO: need to add tests, register config option and add docs. Tests are not ran on this yet. REPOSITORY rHG

D7001: share: unmark --relative as EXPERIMENTAL

Closed by commit rHG7b0b902b8c19: share: unmark --relative as EXPERIMENTAL (authored by pulkit). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR TO COMMIT

D7113: automation: schedule an EC2Launch run on next boot

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in aws.py:1128 > black wants this line to be wrapped. I'll fix that in flight. I should install black, I was waiting for Augie's fix to land to prevent doing some extra work. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7107: rust-cross-platform: remove `unimplemented!` to get compile-time errors instead

pulkit added a comment. Edited the commit message and removed `instead` from end because `test-check-commit.t` was saying hi. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7107/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7107 To:

D7099: widening: pass in matchers instead of patterns

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. > The oldmatch is not used yet, but it should be used eventually when widening no longer resends manifests and files the client already has. You mean for ellipses case? If yes,

D7101: fix: match patterns relative to root

pulkit added a comment. Amended the following in flight: diff --git a/tests/test-fix.t b/tests/test-fix.t --- a/tests/test-fix.t +++ b/tests/test-fix.t @@ -157,8 +157,10 @@ Help text for fix. :skipclean suboption to false. The :pattern suboption

D7084: fix: make Fixer initialization more explicit for clarity

pulkit added a comment. Hm, IIUC this was edited in flight, not sure why. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7084/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7084 To: martinvonz, #hg-reviewers, pulkit Cc: mercurial-devel

D6659: graft: split graft code into seperate functions

pulkit added a comment. Turned out I have an unsubmitted comment. Also, the codebase was recently formatted, so these patches will need to be rebased. https://www.mercurial-scm.org/pipermail/mercurial-devel/2019-October/134537.html should help INLINE COMMENTS > pulkit wrote in

D6987: strip: move strip extension to core as debugstrip

pulkit added inline comments. INLINE COMMENTS > strip.py:3 > > -This extension allows you to strip changesets and all their descendants from > the > -repository. See the command help for details. > +strip extension has been renamed to debugstrip and moved to core. However, > +this extension

D7026: treemanifest: move out of experimental

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In recent sprint, we discussed that treemanifest should be moved out of experimental. The feature has been used inside Google,

D7023: tests: fix test-archive to specify feature as py38, not py-38

pulkit added a comment. Looks like D7016 fixed it. +1 to the docs you have added, if you rebase and resend with the commit message updated, I will be happy to push it. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6989: push: support config option to require revs be specified when running push

pulkit added a comment. Hm, looks like this needs to be rebased on tip of hg-committed because of recent blackening of codebase. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6989/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6989 To:

D6989: push: support config option to require revs be specified when running push

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. The current place for the check looks good. Can you follow-up by adding it to `ui.tweakdefaults`? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7024: destutil: add mechanism to specify ambiguous destination on rebase and merge

pulkit added a comment. IIUC, you mean `unambiguous` instead of `ambiguous` in the commit message? Re-reading I am confused. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7024/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7024 To:

D7025: rewriteutil: add configurable check to disallow obsoleting someone else cset

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One of the things about obsolete markers (especially prune markers) is that sharing them can lead to cases where you loose your data. The best example is that

D7001: share: unmark --relative as EXPERIMENTAL

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7001 AFFECTED FILES hgext/share.py CHANGE DETAILS diff --git a/hgext/share.py b/hgext/share.py ---

D6876: phabricator: support automatically obsoleting old revisions of pulled commits

pulkit added a comment. pulkit added subscribers: sheehan, pulkit. @sheehan this might be of interest to you. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6876/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6876 To: mharbison72,

D6874: uncommit: fix typo in help text

pulkit added a comment. Amended the following in flight: diff --git a/tests/test-uncommit.t b/tests/test-uncommit.t --- a/tests/test-uncommit.t +++ b/tests/test-uncommit.t @@ -34,7 +34,7 @@ Help for uncommit options ([+] can be repeated): -

D6848: narrow: add option for automatically removing unused includes

pulkit added inline comments. INLINE COMMENTS > narrowcommands.py:369 > +If --auto-remove-includes is specified, then those includes that don't > match > +any files modified by currently visible commits will be added to the set > of > +explicitly specified includes to remove.

D6848: narrow: add option for automatically removing unused includes

pulkit added inline comments. INLINE COMMENTS > narrowcommands.py:331 > ('', 'removeinclude', [], _('old paths to no longer include')), > + ('', 'auto-remove-includes', False, > + _('automatically choose unused includes to remove (EXPERIMENTAL)')), Following pattern of other

D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC)

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. In D6851#100690 , @idlsoft wrote: >>> Just `tracked --add-include`. A workaround to simplify the upgrade would be to change

D6848: narrow: add option for automatically removing unused includes

pulkit added inline comments. INLINE COMMENTS > narrowcommands.py:332 > + ('', 'auto-remove-includes', False, > + _('automatically choose unused includes to remove (EXPERIMENTAL)')), > ('', 'addexclude', [], _('new paths to exclude')), Can you add some help text below on how

D6709: config: add --registered flag to show all known configs

pulkit added a comment. In D6709#100698 , @av6 wrote: > And to make the review process easier, I propose doing this in 3 or 4 patches: > > - adding `--registered`: will simply show all registered options in key=value format > - adding

D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC)

pulkit added a comment. In D6851#100667 , @martinvonz wrote: > In D6851#100666 , @idlsoft wrote: > >>> @idlsoft and their company does use narrow extension. @idlsoft can you upgrade server and

D6851: narrow: don't hexify paths and double-hexify known nodes on wire (BC)

pulkit added a comment. pulkit added subscribers: idlsoft, pulkit. > This is clearly a breaking change, but the feature is experimental and > we're not aware of anyone running a server using this command yet. @idlsoft and their company does use narrow extension. @idlsoft can you

D6857: uncommit: enable support for adding a note

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. > Should these note options (including on amend) be marked advanced to keep the > help text clutter level down? Maybe, I don't have strong opinion here on any of the options.

D6776: bookmarks: validate changes on push (issue6193) (BC)

pulkit added a comment. I agree with @valentin.gatienbaron that `--force` is quite generic :(. It may create new heads on the server even if I don't want to. INLINE COMMENTS > bundle2.py:2149 > +hint= > +_("run 'hg pull', resolve conflicts,

D4664: mergecommit: add a new extension to merge in-memory and create a commit

pulkit added a comment. In D4664#100404 , @durin42 wrote: > Neat. I assume you normally check these out later? For now yes. The plan was to make `hg cat` support cat-ing maultiple files preventing to checkout. REPOSITORY rHG Mercurial

D6738: unshelve: add --unresolved flag to unshelve mergestate with unresolved files

pulkit added inline comments. INLINE COMMENTS > pulkit wrote in shelve.py:754 > Then we are somehow parsing or building the records in not correct way. Did you manage to find why that error comes up? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6736: shelve: add method for storing mergestate in changeset extras

pulkit added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in shelve.py:416 > i feel like the current approach is more simpler and easy to understand. It will be nice to use only way to encode mergestates at all the places. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6828: uncommit: add options to update to the current user or current date

pulkit added a comment. In D6828#100190 , @mharbison72 wrote: > In D6828#100139 , @pulkit wrote: > >> I guess `--interactive` is the only flag left which is extra in evolve version, right? >

D6828: uncommit: add options to update to the current user or current date

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. I guess `--interactive` is the only flag left which is extra in evolve version, right? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6828/new/

D6825: contrib: start building a library for simple hooks

pulkit added a comment. Thanks a lot for putting efforts here. I am +1 on this. I haven't looked at the code though, will try to review if no one else beats me to it. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6825/new/ REVISION DETAIL

D6757: bdiff-torture: fix pyflakes warning reporting undefined name 'inst'

Closed by commit rHG3316e59b0105: bdiff-torture: fix pyflakes warning reporting undefined name inst (authored by pulkit). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6741: interfaces: create a new folder for interfaces and move repository.py in it

Closed by commit rHG268662aac075: interfaces: create a new folder for interfaces and move repository.py in it (authored by pulkit). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6742: interfaceutil: move to interfaces/

Closed by commit rHG2c4f656c8e9f: interfaceutil: move to interfaces/ (authored by pulkit). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6742?vs=16260=16311 CHANGES SINCE LAST

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

pulkit added a comment. Queued the patches for stable, many thanks! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6731/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6731 To: navaneeth.suresh, #hg-reviewers, pulkit Cc: pulkit,

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

This revision is now accepted and ready to land. pulkit added inline comments. pulkit accepted this revision. INLINE COMMENTS > test-bookmarks-pushpull.t:1347 > Pushing the bookmark "foo" now fails as it contains a secret changeset > #if b2-pushkey >$ hg push -r foo removing the casing in

D6738: unshelve: add --unresolved flag to unshelve mergestate with unresolved files

pulkit added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in shelve.py:754 > i had tried to support it earlier. but, it throws the following error. i > think it's okay to use the latest format only since, we haven't stored any > mergestate using the previous format. the repo won't

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

pulkit added a comment. Looks like you forgot to update tests. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6731/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6731 To: navaneeth.suresh, #hg-reviewers Cc: pulkit, mercurial-devel

D6757: bdiff-torture: fix pyflakes warning reporting undefined name 'inst'

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Looks like I got a latest version of pyflakes somehow or it's running on py3 and it spotted this. REPOSITORY rHG Mercurial REVISION DETAIL

D6718: repository: suppress typing errors on functions without arguments

pulkit added a comment. I tried to queue but `test-check-code.t` and `test-check-commit.t` fails. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6718/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6718 To: indygreg, #hg-reviewers, durin42 Cc:

D6746: perf: don't pass experimental argument in config for older Mercurial versions

pulkit added a comment. Folded https://www.mercurial-scm.org/repo/hg-committed/rev/9f2189b6bf2a. This can be closed now. Thanks for the quick fix. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6746/new/ REVISION DETAIL

D6746: perf: don't pass experimental argument in config for older Mercurial versions

pulkit added a comment. In D6746#99035 , @martinvonz wrote: > When this patch is ready, could we fold this into `a11fd395e83f`? I have `extensions.perf=contrib/perf.py` in my config and it's pretty annoying to have any commit in the broken

D6741: interfaces: create a new folder for interfaces and move repository.py in it

pulkit added a comment. In D6741#98947 , @martinvonz wrote: >> I was trying to understand current interfaces and write new ones and I realized >> we need to improve how current interfaces are organised. > > And what was the reason we

D6748: hgit: define invalidatecaches for gitstore()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6748 AFFECTED FILES hgext/git/__init__.py CHANGE DETAILS diff --git a/hgext/git/__init__.py

D6747: hgit: fix some pyflakes and check-code warning

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I mostly added absolute_import and fixed warnings related to undefined name. This should get folded in the main hgit RFC patch. There are still more failures

D6746: perf: don't pass experimental argument in config for older Mercurial versions

pulkit added inline comments. INLINE COMMENTS > perf.py:270 > pass > +except TypeError: > +configitem(b'perf', b'presleep', Can you add the commit hash and hg version (5.2 in this case) as comment due to which the compatibility is need? REPOSITORY rHG Mercurial CHANGES SINCE LAST

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

pulkit added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in exchange.py:1044 > I'm getting the following error with the code snippet that you've suggested: > > + Traceback (most recent call last): > +File "/tmp/hgtests.nS3TJv/install/bin/hg", line 43, in > +

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

pulkit added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in exchange.py:1044 > updated to get rid of one return. if node is `None`, then hg will throw an > error there. If the node is None, then `if node and ` will be false and the second condition won't be executed.

D6735: update: added support for --abort flag(issue4404)

pulkit added a comment. Nice start! If I remember correctly, the mergestate stores the local version of the file. We can use that directly instead. INLINE COMMENTS > hg.py:992 > +for f in ms: > +ms.mark(f, mergemod.MERGE_RECORD_UNRESOLVED_PATH) > +ms.mark(f,

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

pulkit added a comment. Can you also add a test where we are pushing multiple heads/bookmarks and one of the bookmark is problematic? INLINE COMMENTS > exchange.py:1043 > +if ctx.phase() == phases.secret: > +raise error.Abort(_('bookmark %s points to a secret changeset') % b) >

D6740: tests: add test to demonstrate issue6159

pulkit added inline comments. INLINE COMMENTS > test-bookmarks-pushpull.t:1344 > +Move the bookmark "foo" to point at a secret changeset > + $ hg commit -qAm_ > + $ hg phase -s -f `--config phases.new-commit=secret` can be used here instead to create a secret commit. >

D6738: unshelve: add --unresolved flag to unshelve mergestate with unresolved files

pulkit added inline comments. INLINE COMMENTS > shelve.py:754 > +ms = merge.mergestate.clean(repo) > +ms._writerecordsv2(_decodemergerecords(records)) > + we should write both the versions, `_writerecords()` should be used. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6736: shelve: add method for storing mergestate in changeset extras

pulkit added inline comments. INLINE COMMENTS > shelve.py:416 > > +def _encodemergerecords(records): > +"""Encode mergestate records to store in changeset extras. What do you think about refactoring the code to write mergestate v2 on disk and use that encoding to achieve this?

D6741: interfaces: create a new folder for interfaces and move repository.py in it

pulkit created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I was trying to understand current interfaces and write new

D6742: interfaceutil: move to interfaces/

pulkit created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we have a dedicated folder for interfaces, let's move interfaceutil there. REPOSITORY rHG Mercurial REVISION DETAIL

D6479: shelve: first prototype of storing/restoring unresolved changes

pulkit added a comment. In D6479#98757 , @navaneeth.suresh wrote: > In D6479#98737 , @durin42 wrote: > >> The only thing I'm curious about really is why we have extrastorage and usualstorge. Can

D6735: update: added support for --abort flag(issue4404)

pulkit added inline comments. INLINE COMMENTS > test-merge-tools.t:2092 > + > +Test for 'hg update --abort' > + I suggest taking `update --abort` tests in a new file as we will need to extensively test that. > test-merge-tools.t:2129 > + merging file > + warning: conflicts while merging

D6731: exchange: abort on pushing bookmarks pointing to secret changesets (issue6159)

pulkit added a comment. In such cases, I like the idea of having fix as two patches, first which demonstrates the bug and the second which fixes the bug. What do you think? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6731/new/ REVISION DETAIL

D6728: config: add experimental argument to the config registrar

pulkit added inline comments. INLINE COMMENTS > perf.py:244 > default=mercurial.configitems.dynamicdefault, > +experimental=True, > ) This breaks `contrib/perf.py` with older versions of mercurial. Can you send a compatibility fix as followup? REPOSITORY rHG Mercurial

D6695: transplant: added support for --abort flag

pulkit added a comment. Let's rename this to `transplant --stop` instead. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6695/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6695 To: taapas1128, #hg-reviewers Cc: pulkit, mjpieters,

D6699: unshelve: abort on using --keep and --interactive together

This revision is now accepted and ready to land. pulkit added inline comments. pulkit accepted this revision. INLINE COMMENTS > shelve.py:970 > basename = shelved[0] > +if interactive and opts.get('keep'): > +raise error.Abort(_('--keep on --interactive is not yet

D6709: config: add --registered flag to show all known configs

pulkit added a comment. In D6709#98716 , @marmoute wrote: > We will need more than just matching the categoie name to detect experimental/deprecated config. There are such option outside of the `experimental` section, and we still need to hide

D6724: unshelve: forget unknown files after a partial unshelve

This revision is now accepted and ready to land. pulkit added inline comments. pulkit accepted this revision. INLINE COMMENTS > shelve.py:1009 > if not ispartialunshelve: > -_forgetunknownfiles(repo, shelvectx, addedbefore) > unshelvecleanup(ui, repo, basename,

D6722: fncache: make debugrebuildfncache not fail on broken fncache

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. Queued these for stable branch. Many thanks! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6722/new/ REVISION DETAIL

D6699: unshelve: abort on using --keep and --interactive together

pulkit added inline comments. INLINE COMMENTS > shelve.py:971 > +if interactive and opts.get('keep'): > +raise error.Abort(_('--keep on interactive is not yet supported')) > `--keep on --interactive ...` REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6709: config: add --registered flag to show all known configs

pulkit added inline comments. INLINE COMMENTS > commands.py:1888 > fm.condwrite(ui.debugflag, 'source', '%s: ', source) > +fm.data(defaultvalue=defaultvalue) > if uniquesel: unrequired change I guess > marmoute wrote in test-config.t:228 > Displaying the default vs

D6709: config: add --registered flag to show all known configs

pulkit added a comment. In D6709#98493 , @marmoute wrote: > In D6709#98479 , @navaneeth.suresh wrote: > >> @pulkit I couldn't figure out why the devel-warnings are coming. It's being shown for

D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

pulkit added a comment. Thanks @marmoute for the review. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6710/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6710 To: spectral, #hg-reviewers, marmoute, pulkit Cc: marmoute, mercurial-devel

D6695: transplant: added support for --abort flag

pulkit added a comment. Sorry for missing this earlier, but what happens when we are transplanting mutliple revisions and we have conflicts in a revision after the first one? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6695/new/ REVISION DETAIL

D6695: transplant: added support for --abort flag

pulkit added inline comments. INLINE COMMENTS > pulkit wrote in test-transplant.t:466 > A better candidate here will be to show `hg status -v` as that will show > whether there is an unfinished transplant or not. This one is not done. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

<    1   2   3   4   5   6   7   8   9   10   >