D6434: narrow: remove unrequired compat code for old versions of hg

pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As the comment says, that if is only required for servers having hg version 3.1 and 3.2.

D6412: py3: add one new passing test found by buildbot

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9166935da31f: py3: add one new passing test found by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6412: py3: add one new passing test found by buildbot

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6412 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist

D6391: py3: make contrib/testparseutil.py to work on str(unicodes)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5364ba1f796f: py3: make contrib/testparseutil.py to work on str(unicodes) (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6391: py3: make contrib/testparseutil.py to work on str(unicodes)

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY contrib/check-code work on unicodes and call functions from testparseutil.py which before this patch used to work on bytes. This path removes that

D6390: commit: move sorting of added and removed files list to lower level

pulkit added a comment. The changes looks okay but I can't think why you want to do that. Can you add some details about the motivation for this change to commit message? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6390 To: martinvonz, #hg-reviewers Cc:

D6377: py3: add a r'' to prevent transformer adding b''

This revision was automatically updated to reflect the committed changes. Closed by commit rHGeefe3d669beb: py3: add a r to prevent transformer adding b (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6378: py3: add 5 new passing tests

This revision was automatically updated to reflect the committed changes. Closed by commit rHG181583d30539: py3: add 5 new passing tests (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6378?vs=15113=15118 REVISION

D6377: py3: add a r'' to prevent transformer adding b''

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just r'' prefix REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6377 AFFECTED FILES mercurial/commands.py

D6378: py3: add 5 new passing tests

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6378 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist

D6375: commit: fix a typo ("form p1" -> "from p1")

pulkit added a comment. Amending the following diff in flight: diff --git a/tests/test-graft.t b/tests/test-graft.t --- a/tests/test-graft.t +++ b/tests/test-graft.t @@ -755,7 +755,7 @@ Transplants of grafts can find a destina committing files: b

D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff

pulkit added a comment. In https://phab.mercurial-scm.org/D6356#92695, @sangeet259 wrote: > In https://phab.mercurial-scm.org/D6356#92644, @pulkit wrote: > > > > Why do I need to split the patches into two ? > > > The reason to split what would have been a single patch into two is

D6359: test: change test's diff generation to use mdiff for nicer output

pulkit added a comment. The commit message has diff which confuses `hg import`. You need to indent those diffs. Also, remove the pastebin links as they are not required since we have diffs. > Download this bundle : http://bit.ly/2DuJjsS This link asks me to login. So

D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff

pulkit added a comment. > Patch 1/2 we don't add that to commit messages. INLINE COMMENTS > mdiff.py:531 > + > +def prepare_mdiff(expected, output): > +"""Prepare the inputs for the mdiff.unidiff function""" may be worth to rename it to `prepare_mdiff_input`. > mdiff.py:540 > +

D6333: remotefilelog: move most functions in onetimeclientsetup() to top level

pulkit added a comment. This fails to apply cleanly on tip of default. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6333 To: martinvonz, #hg-reviewers, pulkit Cc: mercurial-devel ___ Mercurial-devel mailing list

D6356: mdiff: prepare mdiff to be used for run-tests to replace unidiff

pulkit added a comment. > Why do I need to split the patches into two ? > The reason to split what would have been a single patch into two is because > for the next patch to be able to use the mdiff during tests, > this revision has to be there in the system's mercurial installation.

D6355: shelve: add `update --shelve` if shelve extension is loaded

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A lot of times, I need to update to some other cset with dirty working directory. Good number of times, I run `hg shelve` and `hg update` in order. Let's add

D6314: discovery: only calculate closed branches if required

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd0e773ad9077: discovery: only calculate closed branches if required (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6311: branchcache: store the maximum tip in a variable inside for loop

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9893d7aa7420: branchcache: store the maximum tip in a variable inside for loop (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG280f7a095df8: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019) (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6314: discovery: only calculate closed branches if required

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The number of new closed branches is required for printing in error message. So let's only calculate them if we need to print error about new branches.

D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit updated this revision to Diff 14930. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6310?vs=14919=14930 REVISION DETAIL https://phab.mercurial-scm.org/D6310 AFFECTED FILES

D6312: branchcache: update the filteredhash if we update the tiprev

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We update the tiprev and in next if statement we check whether the branchcache is valid or not. If the update of tiprev happens, then definitely self.validfor()

D6311: branchcache: store the maximum tip in a variable inside for loop

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Instead of assigning self.tiprev multiple times in the for loop, and calling cl.node() on it, let's store that in a temporary variable and assign it in the end

D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit added inline comments. INLINE COMMENTS > idlsoft wrote in narrowbundle2.py:34 > If we plan to change this to `narrowacl` at some point, perhaps now is the > time, since it's a major version change. I am not sure if we want to do that. @martinvonz do we? > idlsoft wrote in

D6038: push: added clear warning message when pushing closed branches(issue6080)

pulkit added a comment. Queuing this, many thanks! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6038 To: taapas1128, #hg-reviewers, pulkit Cc: pulkit, mharbison72, mercurial-devel ___ Mercurial-devel mailing list

D6281: branch: add tests which shows branch can be closed from a non-branchhead cset

pulkit accepted this revision. pulkit added a comment. Queueing this, many thanks! INLINE COMMENTS > khanchi97 wrote in test-branches.t:961 > I created this patch assuming that hg should not allow to create a branch > closing commit from a cset which is not a branch head. Let me know if I

D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit added a comment. Also, this patch is meant for stable branch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6310 To: pulkit, durin42, martinvonz, #hg-reviewers Cc: indygreg, idlsoft, mercurial-devel ___

D6297: phabricator: include branch in the diffproperty metadata

pulkit accepted this revision. pulkit added a comment. In https://phab.mercurial-scm.org/D6297#91657, @Kwan wrote: > In https://phab.mercurial-scm.org/D6297#91618, @pulkit wrote: > > > wow, does it work? > > > For future posterity, since I already replied to pulkit on IRC, this

D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit added a comment. In https://phab.mercurial-scm.org/D6310#91785, @indygreg wrote: > Ideally the new part would be documented in `internals.bundle2`. But other narrow parts aren't documented, so maybe we can hold off... My guess is that they are not documented because narrow

D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit updated this revision to Diff 14919. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6310?vs=14914=14919 REVISION DETAIL https://phab.mercurial-scm.org/D6310 AFFECTED FILES

D6308: context: check file exists before getting data from _wrappedctx

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2f3eae30719a: context: check file exists before getting data from _wrappedctx (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6307: tests: show IMM is broken when merging file empty in destination

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7a1ae0632829: tests: show IMM is broken when merging file empty in destination (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit added a comment. I created a new version at https://phab.mercurial-scm.org/D6310. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6218 To: pulkit, durin42, martinvonz, #hg-reviewers Cc: indygreg, idlsoft, mercurial-devel

D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit added a comment. This is a new version of https://phab.mercurial-scm.org/D6218. I updated that one but it was not showing in Yadda as that's already marked as closed. So creating a new one. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6310 To:

D6310: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, when ACL is involved, narrowspecs are send as bundle2 parameter for

D6308: context: check file exists before getting data from _wrappedctx

pulkit updated this revision to Diff 14913. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6308?vs=14911=14913 REVISION DETAIL https://phab.mercurial-scm.org/D6308 AFFECTED FILES mercurial/context.py tests/test-rebase-inmemory.t CHANGE DETAILS

D6307: tests: show IMM is broken when merging file empty in destination

pulkit updated this revision to Diff 14912. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6307?vs=14909=14912 REVISION DETAIL https://phab.mercurial-scm.org/D6307 AFFECTED FILES tests/test-rebase-inmemory.t CHANGE DETAILS diff --git

D6308: context: check file exists before getting data from _wrappedctx

pulkit updated this revision to Diff 14911. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6308?vs=14910=14911 REVISION DETAIL https://phab.mercurial-scm.org/D6308 AFFECTED FILES mercurial/context.py tests/test-rebase-inmemory.t CHANGE DETAILS

D6308: context: check file exists before getting data from _wrappedctx

pulkit updated this revision to Diff 14910. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6308?vs=14907=14910 REVISION DETAIL https://phab.mercurial-scm.org/D6308 AFFECTED FILES mercurial/context.py tests/test-rebase-inmemory.t CHANGE DETAILS

D6307: tests: show IMM is broken when merging file empty in destination

pulkit updated this revision to Diff 14909. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6307?vs=14906=14909 REVISION DETAIL https://phab.mercurial-scm.org/D6307 AFFECTED FILES tests/test-rebase-inmemory.t CHANGE DETAILS diff --git

D6308: context: check file exists before getting data from _wrappedctx

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in context.py:1827 > `_markdirty()` without a specified `data` argument seems to do that. The > documentation also seems to say that it can be `None` (line 1804 in this > version) Does `str?` means that it can be a str or a

D6308: context: check file exists before getting data from _wrappedctx

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in context.py:1827 > I would have expected the only change to be to add ` is not None` to this > line. Isn't that enough? I was unable to find some code which can set this to `None`. If you look at write() below in line 1993, it

D6307: tests: show IMM is broken when merging file empty in destination

pulkit added a comment. This series is meant for stable branch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6307 To: pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list

D6308: context: check file exists before getting data from _wrappedctx

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY overlayworkingctx class is used to do in-memory merging. The data() function of that class has logic to look for data() in the wrappedctx if the file data in

D6307: tests: show IMM is broken when merging file empty in destination

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When we are doing in-memory merging, and we are merging a file which is empty in merge destination, it leads to error 'abort: xxx not found in manifest'.

D6297: phabricator: include branch in the diffproperty metadata

pulkit added a comment. wow, does it work? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6297 To: Kwan, #hg-reviewers Cc: pulkit, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D6292: revbranchcache: use context manager in _writerevs() to write to file

This revision was automatically updated to reflect the committed changes. Closed by commit rHGececa45c80d8: revbranchcache: use context manager in _writerevs() to write to file (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6291: revbranchcache: factor logic to write names and revs in separate functions

This revision was automatically updated to reflect the committed changes. Closed by commit rHG09fd338522fa: revbranchcache: factor logic to write names and revs in separate functions (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6290: branchcache: don't verify all nodes while writing

This revision was automatically updated to reflect the committed changes. Closed by commit rHG07faf5c65190: branchcache: dont verify all nodes while writing (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6292: revbranchcache: use context manager in _writerevs() to write to file

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The other _writenames() is a bit complicated to use context manager. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6292 AFFECTED

D6291: revbranchcache: factor logic to write names and revs in separate functions

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, the write function was so populated with upto 4 level of indentation, it was hard to understand what's going on. REPOSITORY rHG Mercurial

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit updated this revision to Diff 14870. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6218?vs=14765=14870 REVISION DETAIL https://phab.mercurial-scm.org/D6218 AFFECTED FILES

D6290: branchcache: don't verify all nodes while writing

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY nodes are verified either when they are added or used. In case of commits. we will load the whole branchmap, only verify nodes for the branch on which we are

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit added a comment. In https://phab.mercurial-scm.org/D6218#91119, @martinvonz wrote: > In https://phab.mercurial-scm.org/D6218#91058, @indygreg wrote: > > > This patch is backwards incompatible over the wire protocol. > > > > The problem is a new client will blindly send part

D6241: narrow: drop unrequired if conditionals

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2003f0bffcb1: narrow: drop unrequired if conditionals (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6241?vs=14768=14769

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in narrowbundle2.py:152 > I'd drop these checks Sent https://phab.mercurial-scm.org/D6241. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6218 To: pulkit, durin42, martinvonz, #hg-reviewers Cc:

D6241: narrow: drop unrequired if conditionals

pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6241 AFFECTED FILES

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8a37c9b6cf0a: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019) (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6240: branchcache: only iterate over branches which needs to be verified

This revision was automatically updated to reflect the committed changes. Closed by commit rHG75e8e16ca107: branchcache: only iterate over branches which needs to be verified (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6236: branchcache: lazily validate nodes in iteritems()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf0203c3406e7: branchcache: lazily validate nodes in iteritems() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6239: branchcache: fix the docstring of _verifybranch()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd9dc0896e1d3: branchcache: fix the docstring of _verifybranch() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6238: branchcache: don't verify while creating a copy

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb26455ffa7fa: branchcache: dont verify while creating a copy (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6207: branchcache: add functions to validate changelog nodes

pulkit added a comment. In https://phab.mercurial-scm.org/D6207#90778, @yuja wrote: > Queued, thanks. > > > +def _verifybranch(self, branch): > > +""" verify head nodes for the given branch. If branch is None, verify > > +for all the branches """ > > "If

D6236: branchcache: lazily validate nodes in iteritems()

pulkit updated this revision to Diff 14759. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6236?vs=14743=14759 REVISION DETAIL https://phab.mercurial-scm.org/D6236 AFFECTED FILES mercurial/branchmap.py CHANGE DETAILS diff --git

D6240: branchcache: only iterate over branches which needs to be verified

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise we loop over all the branches and call _verifybranch() even if not required. REPOSITORY rHG Mercurial REVISION DETAIL

D6239: branchcache: fix the docstring of _verifybranch()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Initially the function was designed to support verifying all branches but later I decided to have a separate function. I forget to remove the doc related to

D6238: branchcache: don't verify while creating a copy

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The copy will not be mark as verified, so there is no need to verify nodes. Thanks to Yuya who spotted this while reviewing. REPOSITORY rHG Mercurial REVISION

D6211: branch: return early if we find an open named branch apart from default

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd6437f414437: branch: return early if we find an open named branch apart from default (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6210: branchcache: don't verify closed nodes in _branchtip()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGbe5eeaf5c24a: branchcache: dont verify closed nodes in _branchtip() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6208: branchcache: lazily validate nodes from the branchmap

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6578654916ae: branchcache: lazily validate nodes from the branchmap (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6209: branchcache: don't verify closed nodes in iteropen()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7c9d4cf23adf: branchcache: dont verify closed nodes in iteropen() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6207: branchcache: add functions to validate changelog nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2f8147521e59: branchcache: add functions to validate changelog nodes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6208: branchcache: lazily validate nodes from the branchmap

pulkit added a comment. In https://phab.mercurial-scm.org/D6208#90673, @yuja wrote: > The idea sounds good to me. Is this still an RFC (i.e. draft) patch? It's good to be reviewed. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6208 To: pulkit,

D6236: branchcache: lazily validate nodes in iteritems()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This saves ~0.30 sec on creating a new branch on our internal repo. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6236 AFFECTED

D6211: branch: return early if we find an open named branch apart from default

pulkit updated this revision to Diff 14742. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6211?vs=14680=14742 REVISION DETAIL https://phab.mercurial-scm.org/D6211 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git

D6228: discovery: stop direct use of attribute of partialdiscovery

pulkit added a comment. In https://phab.mercurial-scm.org/D6228#90671, @gracinet wrote: > Oops sorry, this one has already been queued by @pulkit (sent it by email, but it was still a draft in my stack). Can be marked as Abandoned. REPOSITORY rHG Mercurial REVISION DETAIL

D6206: branchmap: implement __contains__()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf0def07fa82f: branchmap: implement __contains__() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6206?vs=14675=14726

D6205: branchmap: prevent using __getitem__() in branchheads()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG29c22496dd97: branchmap: prevent using __getitem__() in branchheads() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6204: branchmap: dynamically resolve type of branchcache class

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf0fa0fc4900a: branchmap: dynamically resolve type of branchcache class (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit updated this revision to Diff 14711. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6218?vs=14691=14711 REVISION DETAIL https://phab.mercurial-scm.org/D6218 AFFECTED FILES hgext/narrow/narrowbundle2.py mercurial/exchange.py CHANGE DETAILS

D6221: py3: add b'' prefixes to new doctests in match.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5753e5949b51: py3: add b prefixes to new doctests in match.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6220: py3: add one new passing test found by buildbot

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf7fdb24d4178: py3: add one new passing test found by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6221: py3: add b'' prefixes to new doctests in match.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame as just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6221 AFFECTED FILES mercurial/match.py CHANGE

D6220: py3: add one new passing test found by buildbot

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6220 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist

D6183: copies: add config option for writing copy metadata to file and/or changset

pulkit added a comment. In https://phab.mercurial-scm.org/D6183#90498, @martinvonz wrote: > In https://phab.mercurial-scm.org/D6183#90486, @pulkit wrote: > > > In https://phab.mercurial-scm.org/D6183#90481, @martinvonz wrote: > > > > > In

D6183: copies: add config option for writing copy metadata to file and/or changset

pulkit added a comment. In https://phab.mercurial-scm.org/D6183#90481, @martinvonz wrote: > In https://phab.mercurial-scm.org/D6183#90327, @martinvonz wrote: > > > In https://phab.mercurial-scm.org/D6183#90300, @marmoute wrote: > > > > > I am quite enthousiastic for a non-filelog

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit added inline comments. INLINE COMMENTS > exchange.py:2217 > narrowspecpart = bundler.newpart('narrow:spec') > +data = '' > if include: I don't feel good about the fact that we are not encoding data here. Is there exists some function which I can use to encode

D6218: narrow: send specs as bundle2 data instead of param (issue5952) (issue6019)

pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, when ACL is involved, narrowspecs are send as bundle2 parameter for

D5628: diffstat: make --git work properly on renames (issue6025)

pulkit added inline comments. INLINE COMMENTS > patch.py:2811 > +elif line.startswith('rename to'): > +filename += ' => %s' % line.split()[-1] > addresult() This is unfortunately not working with hglib. hglib seems to be splitting data on '>' or only reading data after

D6178: crecord: new keys g & G to navigate to the top and bottom respectively

pulkit added a comment. Amending this diff to make test-check-code.t happy which complains about lines longer than 80. diff --git a/mercurial/crecord.py b/mercurial/crecord.py --- a/mercurial/crecord.py +++ b/mercurial/crecord.py @@ -1528,10 +1528,10 @@ the following are

D6210: branchcache: don't verify closed nodes in _branchtip()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We only do membership testing there. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6210 AFFECTED FILES mercurial/branchmap.py

D6209: branchcache: don't verify closed nodes in iteropen()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We expect that the nodes passed to iteropen() will be verified. We are only testing for membership in closed nodes set, so we don't need to verify the whole

D6208: [RFC] branchmap: lazily validate nodes from the branchmap

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY On my personal hg-repository with 365 entries in .hg/cache/branch2, following are the numbers for perfbranchmapload. Before this patch: ! wall 0.000866

D6207: branchcache: add functions to validate changelog nodes

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds functions to validate closed nodes, validate nodes for a certain branch and for all the branches. These functions will be used in upcoming

D6206: branchmap: implement __contains__()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have good occurences of `if branch in branchmap()` in our code. If __contains__() is not implemented then it will use __iter__() to find whether the element

D6205: branchmap: prevent using __getitem__() in branchheads()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY branchheads() can directly use self._entries instead. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6205 AFFECTED FILES

D6204: branchmap: dynamically resolve type of branchcache class

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is required to support subclassing. Thanks to Yuya for suggesting this in https://phab.mercurial-scm.org/D6151. REPOSITORY rHG Mercurial REVISION DETAIL

D6188: test/test-revset2.t: Unset environment variable P

pulkit added a comment. In https://phab.mercurial-scm.org/D6188#90212, @jerry.montfort wrote: > Hi, Used hg phasbsend which created https://phab.mercurial-scm.org/D6195. I've no clue how to merge/handle these two, so feel free to intervene. > Also added issueNNN to the commit

D6163: copies: extract function for deciding whether to use changeset-centric algos

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in copies.py:163 > Does that mean you're okay with the current form of this patch? Yes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6163 To: martinvonz, #hg-reviewers Cc: pulkit, mercurial-devel

<    3   4   5   6   7   8   9   10   11   12   >