D6031: py3: make contrib/debugshell.py work with Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb10bbbe995eb: py3: make contrib/debugshell.py work with Python 3 (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D6031?vs=14257=14267#toc REPOSITORY rHG

D6033: py3: convert return values of inspect.getabsfile() to bytes

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's weird that python docs for inspect does not mention getabsfile(). REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6033 AFFECTED

D6032: py3: add two new passing tests found by buildbot

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6032 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist

D6031: py3: make contrib/debugshell.py work with Python 3

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I changed default mercurial installation of my personal laptop to one installed with python 3.7. debugshell is one of the extension which I have enabled and it

D5296: store: don't read the whole fncache in memory

pulkit updated this revision to Diff 14256. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5296?vs=14255=14256 REVISION DETAIL https://phab.mercurial-scm.org/D5296 AFFECTED FILES mercurial/store.py CHANGE DETAILS diff --git a/mercurial/store.py

D5296: store: don't read the whole fncache in memory

pulkit added a comment. In https://phab.mercurial-scm.org/D5296#87890, @indygreg wrote: > I suspect https://phab.mercurial-scm.org/rHG9fca5b056c0a2f673aefa64f7ec7488bd9188d9d made things faster because the code before was using 1 I/O operation for every entry. I would also not be

D5296: store: don't read the whole fncache in memory

pulkit added a comment. In https://phab.mercurial-scm.org/D5296#87892, @yuja wrote: > (resend without the "On ... wrote:" line) > > > Seeing the performance benefit it brings on our repo, I want to try other ways we can do this. Do we like having a conditional which checks the

D5296: store: don't read the whole fncache in memory

pulkit updated this revision to Diff 14255. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5296?vs=12583=14255 REVISION DETAIL https://phab.mercurial-scm.org/D5296 AFFECTED FILES mercurial/store.py CHANGE

D6030: store: move logic to check for invalid entry in fncache to own function

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This helps separate the original reading logic from the one which finds for an invalid entry. REPOSITORY rHG Mercurial REVISION DETAIL

D6028: branchmap: prevent reading the file twice through different iterators

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8ad46ac6728e: branchmap: prevent reading the file twice through different iterators (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977)

pulkit added a comment. In https://phab.mercurial-scm.org/D5940#87925, @martinvonz wrote: > In https://phab.mercurial-scm.org/D5940#87924, @pulkit wrote: > > > In https://phab.mercurial-scm.org/D5940#87923, @martinvonz wrote: > > > > > Do we really want to tell the user to set an

D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977)

pulkit added a comment. In https://phab.mercurial-scm.org/D5940#87923, @martinvonz wrote: > Do we really want to tell the user to set an experimental option? I prefer exposing it as --allow-dirty-working-copy. Well I am happy with that. We should delete the config option then.

D4664: mergecommit: add a new extension to merge in-memory and create a commit

pulkit added a comment. I don't aim for this to get reviewed and pushed. This is here right now for sharing. We are using this extension internally for months now and has shown good results. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4664 To: pulkit,

D4664: mergecommit: add a new extension to merge in-memory and create a commit

pulkit updated this revision to Diff 14248. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4664?vs=11198=14248 REVISION DETAIL https://phab.mercurial-scm.org/D4664 AFFECTED FILES hgext/mergecommit.py mercurial/filemerge.py

D6025: remotefilelog: fix format str, blobsize isn't always a #, can be "(missing)"

pulkit added inline comments. INLINE COMMENTS > debugcommands.py:279 > blobsize = "(missing)" > -ui.write("%s %s %s%d\n" % ( > +ui.write("%s %s %s%s\n" % ( > hashformatter(node), It was changed to `%d` because `%s % int` does not

D6028: branchmap: prevent reading the file twice through different iterators

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise, test-static-http.t breaks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6028 AFFECTED FILES mercurial/branchmap.py

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

pulkit added a comment. This patch does not changes any code. It only changes some test output. You need to change the error message in the code. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6026 To: akshjain.jain74, #hg-reviewers Cc: pulkit, mercurial-devel

D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977)

pulkit added a comment. This patch changes uncommit behavior to always require `experimental.uncommitondirtywdir` option if wdir is dirty. However what we want when wdir is dirty is as follows: `hg uncommit` : abort and require `experimental.uncommitondirtywdir` `hg uncommit PATH`:

D6023: branchcache: move loading of branch names and nodes into it's own function

This revision was automatically updated to reflect the committed changes. Closed by commit rHG68bbcc70e274: branchcache: move loading of branch names and nodes into its own function (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5296: store: don't read the whole fncache in memory

pulkit added a comment. Ping! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5296 To: pulkit, #hg-reviewers Cc: yuja, mjpieters, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D6023: branchcache: move loading of branch names and nodes into it's own function

pulkit added a comment. I am trying to make branchcache make lazy load and only validate nodes if required. This will speed up operations and loading of branchcache. Right now loading of branchcache validates all the nodes which is not required until the branch which has that node is

D6023: branchcache: move loading of branch names and nodes into it's own function

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will help me in implementing lazy loading of the branchcache in upcoming patches. REPOSITORY rHG Mercurial REVISION DETAIL

D6007: diff: make sure we output stat info even when --git is not passed (issue4037)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG251332dbf33d: diff: make sure we output stat even when --git is not passed (issue4037) (BC) (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6006: tests: add test to demonstrate issue4037

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7b04b1154c15: tests: add test to demonstrate issue4037 (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6006?vs=14194=14226

D6007: diff: make sure we output stat info even when --git is not passed (issue4037)

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, `hg diff --stat` will give an empty output. It will not show the stat information. I debugged and found that the underlying code does not

D6006: tests: add test to demonstrate issue4037

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `hg diff --stat -q --config diff.git=0` does not output anything whereas it should print the stat. This is a quiet old bug dating to 2013 and looking at code I

D5410: merge: allow to merge non-conflicting changes outside narrowspec

pulkit added a comment. In https://phab.mercurial-scm.org/D5410#85244, @martinvonz wrote: > In https://phab.mercurial-scm.org/D5410#85232, @pulkit wrote: > > > In https://phab.mercurial-scm.org/D5410#80207, @martinvonz wrote: > > > > > I'm pretty sure this doesn't actually perform

D5979: py3: whitelist 5 new passing tests caught by buildbot

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5f522c8daf8d: py3: whitelist 5 new passing tests caught by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5982: narrow: fix command name in error messsage

This revision was automatically updated to reflect the committed changes. Closed by commit rHGebbc4e70ebd1: narrow: fix command name in error messsage (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5982?vs=14140=14141

D5982: narrow: fix command name in error messsage

pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5982 AFFECTED FILES

D5792: uncommit: added interactive mode(issue6062)

pulkit added a comment. In https://phab.mercurial-scm.org/D5792#87320, @taapas1128 wrote: > @durin42 I have sent the patch for `hg-stable` repo (https://www.mercurial-scm.org/repo/hg-stable) . Maybe it is this the reason you are unable to apply the patch. Should I send a patch for `hg`

D5980: py3: add a new file with only failing tests

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have only 5 failing tests left now according to buildbot. So let's have a list of failing tests instead of passing one. I am not deleting python3-whitelist

D5979: py3: whitelist 5 new passing tests caught by buildbot

pulkit created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Thanks to indygreg and durin42 recent patches. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5979 AFFECTED FILES

D5782: changegroup: don't try to prune manifest nodes if not ellipses

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5f9d057ba28c: changegroup: dont try to prune manifest nodes if not ellipses (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5933: branchmap: improve doc about BranchMapCache class

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa87ca1d7e61d: branchmap: improve doc about BranchMapCache class (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5968: obsutil: don't assume leftctx and rightctx repo as same

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9de6c4f61608: obsutil: dont assume leftctx and rightctx repo as same (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5969: uncommit: inform user if the commit is empty after uncommit

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in uncommit.py:87 > I added a `note: ` in front instead. I think we usually use parentheses for > hints. > > I also changed s/preserving/keeping/ to match the term we use in the `--keep` > flag (and the upcoming config option).

D5969: uncommit: inform user if the commit is empty after uncommit

pulkit added inline comments. INLINE COMMENTS > uncommit.py:87 > +if not files: > +repo.ui.status(_("all files uncommitted, the commit is now empty\n")) > + how about something like this `(preserving the empty commit)`. The reason is that we need to tell that the empty commit is

D5940: uncommit: add --allowdirtywcopy when possibly hiding data (issue5977)

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in uncommit.py:140 > Doesn't that mean the whole patch is unnecessary? It pretty much just > provides an easier way of saying `--config > experimental.uncommitondirtywdir=yes`, doesn't it? Nice point. I had to revisit the bug to

D5968: obsutil: don't assume leftctx and rightctx repo as same

pulkit updated this revision to Diff 14103. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5968?vs=14099=14103 REVISION DETAIL https://phab.mercurial-scm.org/D5968 AFFECTED FILES mercurial/obsutil.py CHANGE DETAILS diff --git a/mercurial/obsutil.py

D5792: uncommit: added interactive mode(issue6062)

pulkit added a comment. In https://phab.mercurial-scm.org/D5792#87115, @taapas1128 wrote: > @pulkit I have updated the description . Great thanks! As mentioned before I will let someone else review this :) REPOSITORY rHG Mercurial REVISION DETAIL

D5940: uncommit: add --allowdirtywcopy when possibly hiding data (issue5977)

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in uncommit.py:140 > Could you rename --force to e.g. --allow-dirty-working-copy so it's clearer > what's being allowed? we have a config for that already, let's prevent to introduce flags for config options and vice versa here.

D5940: uncommit: add --allowdirtywcopy when possibly hiding data (issue5977)

pulkit added a comment. Your current patch is doing more than one thing. Let's split this up and make one patch do one thing. INLINE COMMENTS > uncommit.py:168 > > +if old.p2(): > +raise error.Abort(_("outstanding uncommitted merge")) this merits a different patch and

D5968: obsutil: don't assume leftctx and rightctx repo as same

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Backed out changeset https://phab.mercurial-scm.org/rHG520514af2d9378d9d5815f0c4edc01617968356d. hgsubversion can pass leftctx and rightctx which are instances

D5940: uncommit: add -f/--force when possibly hiding data (issue5977)

pulkit added a comment. In https://phab.mercurial-scm.org/D5940#87087, @navaneeth.suresh wrote: > In https://phab.mercurial-scm.org/D5940#87026, @pulkit wrote: > > > Hi, it will be good if you specify that the patch is authored by someone else, mention their name and also provide the

D5941: tweakdefault: Add better documentation for ui.tweakdefault(issue6000)

pulkit requested changes to this revision. pulkit added a comment. This revision now requires changes to proceed. In https://phab.mercurial-scm.org/D5941#87025, @akshjain.jain74 wrote: > @pulkit like what else we required to improve the documentation for the issue , in general what

D5940: uncommit: add -f/--force when possibly hiding data (issue5977)

pulkit added a comment. Hi, it will be good if you specify that the patch is authored by someone else, mention their name and also provide the link to the original PR of this patch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5940 To: navaneeth.suresh,

D5941: tweakdefault: Add better documentation for ui.tweakdefault(issue6000)

pulkit added a comment. Hi, thanks for the patch. This is adding just un required churn to help text. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5941 To: akshjain.jain74, #hg-reviewers Cc: pulkit, mercurial-devel

D5792: uncommit: added interactive mode(issue6062)

pulkit added a comment. The import looks fine to me. I will let someone else review the code because I authored this code in first place in evolve extension. Also it will be nice if you specify that the code is imported from evolve extension and also specify the commit hash from which you

D5836: zsh: fix `hg resolve` completion when in a subdirectory (issue6067)

pulkit added subscribers: av6, pulkit. pulkit accepted this revision. pulkit added a comment. Queued as per @av6 review. INLINE COMMENTS > zsh_completion:251 > > - _hg_cmd resolve -l ./$PREFIX | while read rstate rpath > + _hg_cmd resolve -l ./$PREFIX -T'{mergestatus}\

D5813: revset: add expect to check the size of a set

pulkit added inline comments. INLINE COMMENTS > revset.py:866 > +def expectsize(repo, subset, x, order): > +"""Abort if the revset doesn't expect given size""" > +args = getargsdict(x, 'expectsize', 'set size') Can you improve this documentation as a follow-up? We should mentioned about

D5932: branchmap: decode a label only once

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9d0d8793e847: branchmap: decode a label only once (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5932?vs=14022=14028

D5931: branchmap: move __init__ up in branchcache class

This revision was automatically updated to reflect the committed changes. Closed by commit rHGbfc49f1df615: branchmap: move __init__ up in branchcache class (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5933: branchmap: improve doc about BranchMapCache class

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It was confusing that we are having two different branchcache and BranchMapCache classes. The doc in BranchMapCache class was not much helpful to understand the

D5932: branchmap: decode a label only once

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This moves decoding of a label out of for loop. Minor speed up expected in cases when one branch has multiple heads. For example: someone using bookmarks as

D5931: branchmap: move __init__ up in branchcache class

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Making __init__ the first function defined helps understanding the class much better. REPOSITORY rHG Mercurial REVISION DETAIL

D5914: cat: respect ui.relative-paths for "skipping missing subrepository"

pulkit added a comment. This does not has any dependency in phabricator but fails to apply cleanly on @ in hg-committed. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5914 To: martinvonz, #hg-reviewers, pulkit Cc: mercurial-devel

D5878: py3: make sure __repr__ returns str

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3751595ec45e: py3: make sure __repr__ returns str (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5878?vs=13887=13954

D5879: py3: use bytes.startswith() instead of comparing with bytes[0]

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7c4e205f71ca: py3: use bytes.startswith() instead of comparing with bytes[0] (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5638: branchmap: encapsulate cache updating in the map itself

pulkit added a comment. This looks good to me. @martinvonz do you have any concerns? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5638 To: mjpieters, #hg-reviewers Cc: pulkit, martinvonz, mercurial-devel ___

D5792: uncommit: added interactive mode(issue6062)

pulkit added a comment. In https://phab.mercurial-scm.org/D5792#85236, @taapas1128 wrote: > @pulkit I was able to import the tests and make them compatible with `hg-stable` . Some tests which include commands like `hg obslog` , `hg amend --extract` , and `hg uncommit -n` which are not

D5880: fsmonitor: rename new verbose config knob

pulkit added a comment. I am unable to find any docs for this config option, can you add them as a follow-up? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5880 To: lothiraldan, #hg-reviewers, pulkit Cc: pulkit, mjpieters, mercurial-devel

D5880: fsmonitor: rename new verbose config knob

pulkit accepted this revision. pulkit added inline comments. INLINE COMMENTS > __init__.py:178 > if isinstance(ex, watchmanclient.Unavailable): > # experimental config: hgwatchman.verbose > +if ex.warn and ui.configbool('fsmonitor', 'verbose'): will change this one also in

D5880: fsmonitor: rename new verbose config knob

pulkit added a comment. Looks like you missed updating the users of this config. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5880 To: lothiraldan, #hg-reviewers Cc: pulkit, mjpieters, mercurial-devel ___

D5878: py3: make sure __repr__ returns str

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY No test fails but I found it while debugging test-commit-interactive-curses.t failure. 1. skip-blame because just r'' prefix REPOSITORY rHG Mercurial

D5870: extdiff: support tools that can be run simultaneously

pulkit abandoned this revision. pulkit added a comment. Misfired a phabsend. Sorry for noise. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5870 To: pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel

D5870: extdiff: support tools that can be run simultaneously

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5870 AFFECTED FILES hgext/extdiff.py tests/test-extdiff.t tests/test-extension.t CHANGE DETAILS

D5865: largefiles: use wrappedfunction() for matchandpats() override in overridelog()

pulkit added a comment. This one somehow ended up as not being part of stack https://phab.mercurial-scm.org/D5866:https://phab.mercurial-scm.org/D5869 in phabricator. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5865 To: martinvonz, #hg-reviewers, pulkit

D5864: py3: use pycompat.bytestr() on extra values because it can be int

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb436059c1cca: py3: use pycompat.bytestr() on extra values because it can be int (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5863: py3: add some b'' prefixes in hgext/convert/monotone.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG83d62df28ab6: py3: add some b prefixes in hgext/convert/monotone.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5862: py3: use '%d' for integers instead of '%s'

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9b4a142a2035: py3: use %d for integers instead of %s (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5862?vs=13829=13833

D5861: py3: add 1 new passing test found by buildbot

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf9ad1b65d3c3: py3: add 1 new passing test found by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5862: py3: use '%d' for integers instead of '%s'

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think this is the last of these occurences because I have got the test passing on python3 in a later patch. REPOSITORY rHG Mercurial REVISION DETAIL

D5864: py3: use pycompat.bytestr() on extra values because it can be int

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One such example is {'close': 1} which marks a branch as closed. This makes test-convert-mtn.t pass on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL

D5863: py3: add some b'' prefixes in hgext/convert/monotone.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5863 AFFECTED FILES

D5860: scmutil: delete now-unused origpath()

pulkit added a comment. This should be marked as API IIUC, right? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5860 To: martinvonz, #hg-reviewers Cc: pulkit, mercurial-devel ___ Mercurial-devel mailing list

D5849: merge: don't unnecessarily calculate absolute path

pulkit accepted this revision. pulkit added a comment. > I think this also makes the code clearer (and prepares for the next > patch). I don't see a next patch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5849 To: martinvonz, #hg-reviewers, pulkit

D5816: global: make some docstrings raw strings

pulkit added a comment. Should we add `# skip-blame` to this and rest of the series as they are just adding of r'' prefixes? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5816 To: indygreg, martinvonz, #hg-reviewers Cc: pulkit, mercurial-devel

D5814: match: teach diffmatcher.visitdir() to return 'all' if possible

This revision was automatically updated to reflect the committed changes. Closed by commit rHG990aa150fd02: match: teach diffmatcher.visitdir() to return all if possible (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5814: match: teach diffmatcher.visitdir() to return 'all' if possible

pulkit updated this revision to Diff 13740. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5814?vs=13739=13740 REVISION DETAIL https://phab.mercurial-scm.org/D5814 AFFECTED FILES mercurial/match.py tests/test-match.py CHANGE DETAILS diff --git

D5814: match: teach diffmatcher.visitdir() to return 'all' if possible

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch teaches differencematcher.visitdir() to return 'all' when m1.visitdir() returns 'all' and m2 does not matches. Before this patch, from a

D5410: merge: allow to merge non-conflicting changes outside narrowspec

pulkit added a comment. In https://phab.mercurial-scm.org/D5410#80207, @martinvonz wrote: > I'm pretty sure this doesn't actually perform the merge, it just drops the changes outside the narrowspec. On commit, we need to record that outside/ has the new nodeid that we got from the side

D5813: revset: add expect to check the size of a set

pulkit added subscribers: durin42, pulkit. pulkit added a comment. > This then allows an alias for hg next to be update -r one(children(.)) > with sane failure behavior, and also makes some other scripting tasks > a little less difficult. Just for record, `hg next` has a nice prompt

D5811: py3: add some b'' prefixes in test-notify.t

This revision was automatically updated to reflect the committed changes. Closed by commit rHG02a8c912d2cb: py3: add some b prefixes in test-notify.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5811?vs=13715=13725

D5810: py3: use pycompat.long in hgext/convert/monotone.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHGae79747a1920: py3: use pycompat.long in hgext/convert/monotone.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5809: py3: add three new passing tests found by buildbot

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3b5228f74887: py3: add three new passing tests found by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5808: py3: do a fsdecode(), fsencode() dance in posix.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG512eb4af4295: py3: do a fsdecode(), fsencode() dance in posix.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5792: uncommit: added interactive mode(issue6062)

pulkit added a comment. In https://phab.mercurial-scm.org/D5792#85088, @taapas1128 wrote: > @pulkit I have made an attempt to import the code please review. @lothiraldan can you please review and help me if I have missed out any portion of interactive from `evolve` @taapas1128

D5812: py3: pass str into ValueError to prevent b'' prefix in output

pulkit added a comment. I am not whether this is correct. This should have fix failure of `test-lfs-serve.t#lfsremote-on` failure on py3 but it does not. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5812 To: pulkit, durin42, martinvonz, #hg-reviewers Cc:

D5812: py3: pass str into ValueError to prevent b'' prefix in output

pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because mostly just r'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL

D5811: py3: add some b'' prefixes in test-notify.t

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame as just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5811 AFFECTED FILES tests/test-notify.t CHANGE

D5810: py3: use pycompat.long in hgext/convert/monotone.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5810 AFFECTED FILES hgext/convert/monotone.py CHANGE DETAILS diff --git a/hgext/convert/monotone.py

D5809: py3: add three new passing tests found by buildbot

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5809 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist

D5808: py3: do a fsdecode(), fsencode() dance in posix.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have to use `fsdecode()` instead of sysstr() because they are abusing `PyUnicode_EncodeFSDefault()` to get back bytes. REPOSITORY rHG Mercurial REVISION

D5794: py3: pass str into grp.getgrnam

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe011c78da629: py3: pass str into grp.getgrnam (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5794?vs=13678=13683 REVISION

D5739: montone: fix addition to list by using .append() instead of '+'

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa97e000b63c8: montone: fix addition to list by using .append() instead of + (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5794: py3: pass str into grp.getgrnam

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY grp.getgrnam expects str on Python 3. This fixes test-acl.t on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5794

D5739: montone: fix addition to list by using .append() instead of '+'

pulkit updated this revision to Diff 13677. pulkit retitled this revision from "py3: use pycompat.bytestr() so that slicing does not result in ascii values" to "montone: fix addition to list by using .append() instead of '+'". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5792: uncommit: added interactive mode(issue6062)

pulkit added a comment. In https://phab.mercurial-scm.org/D5792#84959, @taapas1128 wrote: > Thanks for the review @pulkit . By importing do you suggest importing the code for interactive or someway is there is someway to link `evolve` to `hg-stable` ? I mean importing the code.

D5792: uncommit: added interactive mode(issue6062)

pulkit added subscribers: lothiraldan, pulkit. pulkit added a comment. Hi, thanks for the patch. Your patch is a good start at implementing `uncommit -i`. It misses multiple things like dirstate handling. The good news is that you don't need to implement all that. There is an evolve

<    5   6   7   8   9   10   11   12   13   14   >