D9081: git: add test showing `hg commit -i` working on a git repo

sheehan created this revision. Herald added a reviewer: durin42. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Shows `hg commit -i` working on a git repo via the `git` extension. Adds working directory changes to files `alpha` and

D9068: git: pass `id` attribute of `pygit2.Tree` object

sheehan created this revision. Herald added a reviewer: durin42. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY `pygit2`'s Repository object expects an instance of `Oid` to return the corresponding object, instead of the object itself.

D8781: infinitepush: fix `{get,put}_args` formatting on Python 3

sheehan created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Calling `.format()` on a byte-string does not work, thus causing an exception on Python 3. This commit adds a function to paper over the difference.

D8780: infinitepush: replace `NamedTemporaryFile` with `pycompat.namedtempfile`

sheehan created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Fixes a Python 3 compat error when using the external bundle store. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL

D8573: fsmonitor: coerce `clock` variable to byte-string (issue6321)

sheehan created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY Callers of `fsmonitor.state.setlastclock` pass their arguments wrapped in `pycompat.sysbytes` to ensure the value is a `bytes` on Python 3. However in

D7810: packaging: update Ubuntu docker build dependencies to Python 3

Closed by commit rHGb084ad4875a4: packaging: update Ubuntu docker build dependencies to Python 3 (authored by sheehan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7810: packaging: update Ubuntu docker build dependencies to Python 3

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Changeset 7574ccd87200f02e updated the Debian docker builds to Python 3. In doing

D6840: hgweb: add a `message` attribute to `hgweb.common.ErrorResponse`

sheehan added a comment. The error I mentioned looks like this: Traceback (most recent call last): File "/var/hg/venv_hgweb/lib64/python3.6/site-packages/mercurial/hgweb/hgwebdir_mod.py", line 358, in run_wsgi for r in self._runwsgi(req, res): File

D6840: hgweb: add a `message` attribute to `hgweb.common.ErrorResponse`

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This fixes a Python 3 bug where hgweb assumes an Exception subclass will have a `.message` attribute after running `Exception.__init__`.[1] The Python 3 way to

D6832: highlight: fix encoding issues to enable Py3 compatibility

sheehan created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit fixes various encoding issues with the `highlight` extension to enable compatibility with Python 3. Python

D6788: hgweb: fix websub regex flag syntax on Python 3

sheehan updated this revision to Diff 16466. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6788?vs=16391=16466 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6788/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6788 AFFECTED FILES

D6788: hgweb: fix websub regex flag syntax on Python 3

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The `websub` config section for hgweb is broken under Python 3 when using regex flags syntax (ie the optional `i` in the example from `hg help config.websub`:

D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3

sheehan abandoned this revision. sheehan added a comment. > Either way, we'll be deploying this to Mozilla's hg servers in the next few months and testing it out. Perhaps after it's been in production for some time we will have a stronger case for inclusion in core. :) Going to deploy

D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3

sheehan added a comment. In https://phab.mercurial-scm.org/D5194#77606, @martinvonz wrote: > Is this useful enough to others that it should live in the hg core repo? It doesn't seem like it to me, but maybe I'm wrong. My thought process was that since the new wire protocol

D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3

sheehan added a subscriber: indygreg. sheehan added a comment. Throwing this up for review now, but there are a few things that could be done to improve this. A cache expiration policy might be useful, but is difficult to test with the S3 bucket expiration rules. It may also be desirable to

D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With wireprotocol version two introducing command response caching and enabling content redirect responses, it is possible to store response objects in an

D5090: wireproto: fix incorrect function name in docstring

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4821affc154f: wireproto: fix incorrect function name in docstring (authored by sheehan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5090: wireproto: fix incorrect function name in docstring

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The docstring for `iwireprotocolcommandcacher` references an `onoutputfinished` method. The actual name of the function is `onfinished`. REPOSITORY rHG

D4283: webcommands: fix `@webcommand` decorator

sheehan planned changes to this revision. sheehan added a comment. In https://phab.mercurial-scm.org/D4283#65988, @indygreg wrote: > This seems like a strict improvement. > > But the proper way to register web commands from extensions would be to go through the `registrar` API and

D4283: webcommands: fix `@webcommand` decorator

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit fixes the `@webcommand` decorator used to define webcommands. Although webcommands are currently using this decorator, it does not behave as

D3001: templatefuncs: remove redundant "or author" from mailmap return statement

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3685a79ea51b: templatefuncs: remove redundant or author from mailmap return statement (authored by sheehan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3002: stringutil: rename local email/names variables to their plural forms

This revision was automatically updated to reflect the committed changes. Closed by commit rHG54b896f195d1: stringutil: rename local email/names variables to their plural forms (authored by sheehan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3002?vs=7478=7482#toc

D3004: stringutil: edit comment to reflect actual data type name

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2ed180117f76: stringutil: edit comment to reflect actual data type name (authored by sheehan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3003: stringutil: improve check for failed mailmap line parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0e7550b0964c: stringutil: improve check for failed mailmap line parsing (authored by sheehan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3003?vs=7479=7484#toc REPOSITORY

D3003: stringutil: improve check for failed mailmap line parsing

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The existing check for a bad mailmap file entry fails with inputs like b'>@<'. This commit adds a function to check if a sufficient amount of information has

D3002: stringutil: rename local email/names variables to their plural forms

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY email and name variables are renamed to emails and names (respectively). This is because the email variable name shadows the email function within the

D3001: templatefuncs: remove redundant "or author" from mailmap return statement

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3001 AFFECTED FILES mercurial/templatefuncs.py CHANGE DETAILS diff --git

D3004: stringutil: edit comment to reflect actual data type name

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In development the data type used to hold an email/name pair was called a "mailmaptup" since it was implemented as a namedtuple. The implementation has since

D2903: utils: add isauthorwellformed function

sheehan abandoned this revision. sheehan added a comment. Abandoning, this was landed as another differential. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2903 To: sheehan, #hg-reviewers Cc: yuja, lothiraldan, pulkit, mercurial-devel

D2904: templatefuncs: add mailmap template function

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2a2ce93e12f4: templatefuncs: add mailmap template function (authored by sheehan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2904?vs=7381=7453#toc REPOSITORY rHG

D2904: templatefuncs: add mailmap template function

sheehan updated this revision to Diff 7381. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2904?vs=7361=7381 REVISION DETAIL https://phab.mercurial-scm.org/D2904 AFFECTED FILES mercurial/templatefuncs.py mercurial/utils/stringutil.py

D2960: stringutil: move person function from templatefilters

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfb7140f1d09d: stringutil: move person function from templatefilters (authored by sheehan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2960?vs=7360=7380#toc REPOSITORY

D2959: stringutil: add isauthorwellformed function

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf8e1f48de118: stringutil: add isauthorwellformed function (authored by sheehan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2959?vs=7359=7379#toc REPOSITORY rHG

D2904: templatefuncs: add mailmap template function

sheehan updated this revision to Diff 7361. sheehan marked 3 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2904?vs=7345=7361 REVISION DETAIL https://phab.mercurial-scm.org/D2904 AFFECTED FILES mercurial/templatefuncs.py

D2960: stringutil: move person function from templatefilters

sheehan updated this revision to Diff 7360. sheehan marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2960?vs=7344=7360 REVISION DETAIL https://phab.mercurial-scm.org/D2960 AFFECTED FILES mercurial/templatefilters.py

D2959: stringutil: add isauthorwellformed function

sheehan updated this revision to Diff 7359. sheehan marked 3 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2959?vs=7343=7359 REVISION DETAIL https://phab.mercurial-scm.org/D2959 AFFECTED FILES mercurial/utils/stringutil.py

D2904: templatefuncs: add mailmap template function

sheehan updated this revision to Diff 7345. sheehan marked 5 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2904?vs=7163=7345 REVISION DETAIL https://phab.mercurial-scm.org/D2904 AFFECTED FILES mercurial/templatefuncs.py

D2959: stringutil: add isauthorwellformed function

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The regular expression for this function formerly lived at https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hghooks/mozhghooks/author_format.py#l13

D2960: stringutil: move person function from templatefilters

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Move the person function from template filters to the stringutil module, so it can be reused in the mailmap template function. REPOSITORY rHG Mercurial

D2904: templatefuncs: add mailmap template function

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit adds a template function to support the .mailmap file in Mercurial repositories. The .mailmap file comes from git, and can be used to map new emails

D2903: utils: add isauthorwellformed function

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Adds a function to determine if an author field is formatted correctly (ie "Contributor Name ") REPOSITORY rHG Mercurial REVISION