D6503: statecheck: added support for STATES

taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in test-graft.t:284 > What caused this change? the `stopflag`. Since graft supports `--stop`. It should be displayed in `hg status --verbose` and similar should happen with any extension in future which supports `--stop`. >

D6503: statecheck: added support for STATES

taapas1128 added a comment. taapas1128 marked 3 inline comments as done. I forgot to add tests for hg status -v case of interrupted update. That is added now. INLINE COMMENTS > martinvonz wrote in state.py:215 > Note that I didn't suggest changing `getrepostate()` -- I said (or tried to > s

D6484: states: moved cmdutil.unfinishedstates to state.py

taapas1128 updated this revision to Diff 15586. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6484?vs=15582&id=15586 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6484/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6484 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 edited the summary of this revision. taapas1128 marked an inline comment as done. taapas1128 updated this revision to Diff 15587. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15584&id=15587 CHANGES SINCE LAST ACTION https://phab.merc

D6484: states: moved cmdutil.unfinishedstates to state.py

taapas1128 updated this revision to Diff 15582. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6484?vs=15569&id=15582 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6484/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6484 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15584. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15581&id=15584 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FI

D6504: statecheck: fix for hint message format

taapas1128 updated this revision to Diff 15585. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15571&id=15585 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6502: state: moved cmdutil.STATES and utilities to state.py

taapas1128 updated this revision to Diff 15583. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6502?vs=15579&id=15583 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6502/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6502 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 marked an inline comment as done. taapas1128 updated this revision to Diff 15581. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15565&id=15581 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL http

D6503: statecheck: added support for STATES

taapas1128 added inline comments. taapas1128 marked 3 inline comments as done. INLINE COMMENTS > martinvonz wrote in state.py:215 > I can see that `getrepostate()` is unchanged, but I cannot see that > `checkunfinished()` is unchanged (line 187 includes `'bisect'` in the version > I'm looking a

D6502: state: moved cmdutil.STATES and utilities to state.py

taapas1128 marked an inline comment as done. taapas1128 updated this revision to Diff 15579. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6502?vs=15552&id=15579 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6502/new/ REVISION DETAIL http

D6504: statecheck: fix for hint message format

taapas1128 edited the summary of this revision. taapas1128 retitled this revision from "statecheck: changed hint message format" to "statecheck: fix for hint message format". taapas1128 updated this revision to Diff 15571. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercu

D6484: states: moved cmdutil.unfinishedstates to state.py

taapas1128 updated this revision to Diff 15569. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6484?vs=15402&id=15569 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6484/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6484 AFFECTED FI

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 marked 2 inline comments as done. taapas1128 updated this revision to Diff 15570. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6501?vs=15564&id=15570 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6501/new/ REVISION DETAIL http

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 added inline comments. taapas1128 marked 2 inline comments as done. INLINE COMMENTS > pulkit wrote in phabricator.py:53 > unrelated change? need to amend it D6484 . sorry. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercu

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 added inline comments. taapas1128 marked 4 inline comments as done. INLINE COMMENTS > av6 wrote in state.py:151 > It's funny how Pulkit's comment is now at this line and looks like asking to > add spaces around `=` here. But in this case `=` is not an operator, it's > used to indicat

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15565. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15556&id=15565 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FI

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15566. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15557&id=15566 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 updated this revision to Diff 15564. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6501?vs=15551&id=15564 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6501/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6501 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in test-graft.t:281 > We generally (always?) use a short lowercase message for the hint. I'm not > sure we want to change that. OTOH, I also don't want to make the morestatus > (`hg status -v`) output inconsistent like this pa

D6503: statecheck: added support for STATES

taapas1128 marked an inline comment as done. taapas1128 updated this revision to Diff 15556. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=1&id=15556 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL http

D6503: statecheck: added support for STATES

taapas1128 added a comment. > we should keep this message, can you see how we can prevent this change? amended that. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6503 To: taapas1128, d

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15557. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15554&id=15557 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 1. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15553&id=1 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in state.py:215 > Why was the comment above marked as done? Did I just miss the answer? because the hard-coded values were removed. And regarding bisect as you can see nothing has been changed it is not handled by `checkunfini

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15554. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15542&id=15554 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15553. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15541&id=15553 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FI

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 added a comment. @martinvonz I have updated it. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6501/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6501 To: taapas1128, durin42, martinvonz, #hg-reviewers Cc: Kwan, pulkit, mjpieters,

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 updated this revision to Diff 15551. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6501?vs=15535&id=15551 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6501/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6501 AFFECTED FI

D6502: state: moved cmdutil.STATES and utilities to state.py

taapas1128 updated this revision to Diff 15552. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6502?vs=15536&id=15552 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6502/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6502 AFFECTED FI

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 added a comment. I was talking about the way in which `registrar` takes in data. eg: see line `168` of `hgweb_mod.py`. Also wherever registrar is imported see data structure for `cmdtable`. If you still want to break it up into an argument based function I can do that too. REPOSI

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15542. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15540&id=15542 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15541. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15539&id=15541 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 added a comment. > Ah, because those were already in both unfinishedstates and in STATES. I assume there are still some small functional changes. For example, hg status -v should now mentioning an unfinished transplant operation (the transplant extension added an entry to unfinish

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15540. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15538&id=15540 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15539. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15537&id=15539 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FI

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15538. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15530&id=15538 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 marked an inline comment as not done. taapas1128 updated this revision to Diff 15537. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15529&id=15537 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL

D6501: state: created new class statecheck to handle unfinishedstates

Herald added a subscriber: Kwan. taapas1128 edited the summary of this revision. taapas1128 marked 5 inline comments as done. taapas1128 updated this revision to Diff 15535. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6501?vs=15527&id=15535 CHANGES SINC

D6502: state: moved cmdutil.STATES and utilities to state.py

taapas1128 updated this revision to Diff 15536. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6502?vs=15528&id=15536 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6502/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6502 AFFECTED FI

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in state.py:110 > I'm not sure the `cmd` prefix in `cmdmsg` and `cmdhint` adds anything I did that to keep a different name as compared to default messages. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in state.py:142 > I think it would be simpler to make `addunfinished()` take four arguments > instead of a dict. That's what we usually do. @pulkit, what do you think? Is > there are reason to pass a single dict here? there a

D6503: statecheck: added support for STATES

taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in test-graft.t:281 > I think we probably we want separate messages for morestatus and > checkunfinished so this doesn't have to change. In D6504 is not the message method alright? REPO

D6503: statecheck: added support for STATES

taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in state.py:154 > Why does bisect have to be treated differently? This was suggested by @pulkit to keep bisect last too. > martinvonz wrote in test-strip.t:276 > This doesn't seem right. Did you forget to update this patch aft

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15530. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15507&id=15530 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 edited the summary of this revision. taapas1128 updated this revision to Diff 15529. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15516&id=15529 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL h

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 edited the summary of this revision. taapas1128 updated this revision to Diff 15527. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6501?vs=15514&id=15527 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6501/new/ REVISION DETAIL h

D6502: state: moved cmdutil.STATES and utilities to state.py

taapas1128 updated this revision to Diff 15528. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6502?vs=15515&id=15528 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6502/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6502 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15516. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15506&id=15516 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FI

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 updated this revision to Diff 15514. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6501?vs=15438&id=15514 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6501/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6501 AFFECTED FI

D6502: state: moved cmdutil.STATES and utilities to state.py

taapas1128 updated this revision to Diff 15515. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6502?vs=15439&id=15515 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6502/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6502 AFFECTED FI

D6529: strip: during merge allow strip only when -f is used

Closed by commit rHG1acaa9f37377: strip: during merge allow strip only when -f is used (authored by taapas1128). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6529: strip: during merge allow strip only when -f is used

taapas1128 updated this revision to Diff 15511. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6529?vs=15510&id=15511 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6529/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6529 AFFECTED FI

D6529: strip: during merge allow strip only when -f is used

taapas1128 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This ensures to abort strip to `hg strip` when we have a merge in progress and allow it only when a `--force` flag is used. REPOSITORY rHG Mercurial REVISIO

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15506. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15503&id=15506 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FI

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15507. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15504&id=15507 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 added a comment. @martinvonz @pulkit passing `merge` through `checkunfinished()` with the correct `allowcommit` flag has led to change in the tests most of which are positive and the merge in progress which were detected by separate methods earlier can be detected by `checkunfin

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15503. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15501&id=15503 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FI

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15504. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15502&id=15504 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15501. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15499&id=15501 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FI

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15502. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15500&id=15502 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15499. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15497&id=15499 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FI

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15500. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15498&id=15500 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15497. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15480&id=15497 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6503/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FI

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15498. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15481&id=15498 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 added inline comments. INLINE COMMENTS > cmdutil.py:622 > > +def addunfinished(**cmddata): > +cmdname = cmddata['cmdname'] @martinvonz have a look this is making sure bisect and merge stays the last. > taapas1128 wrote in state.py:174 > I went through the code this is happening

D6503: statecheck: added support for STATES

Herald added a reviewer: martinvonz. Herald added a subscriber: mjpieters. taapas1128 edited the summary of this revision. taapas1128 updated this revision to Diff 15480. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15440&id=15480 CHANGES SINCE L

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15481. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15441&id=15481 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6504/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FI

D6503: statecheck: added support for STATES

taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in state.py:174 > So what happens if we check merge state too here? I know we didn't do it > before, but would it make sense to do it? It would probably belong in a > separate patch if we did it. I went through the code this

D6503: statecheck: added support for STATES

taapas1128 added a comment. taapas1128 marked an inline comment as done. yes, they do . as they did earlier no extra case has been generated. INLINE COMMENTS > martinvonz wrote in state.py:161 > I know that's what you did regarding merge (as I said). I suggested a > different solution (or th

[Differential] D6503: statecheck: added support for STATES

taapas1128 added a comment. taapas1128 marked an inline comment as not done. @martinvonz I haven't changed anything regarding rebase and update on interrupted states hence not added any tests. INLINE COMMENTS > martinvonz wrote in state.py:161 > Did you mean None instead of 'None'? I will c

[Differential] D6503: statecheck: added support for STATES

taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in state.py:161 > There was a comment somewhere saying that merge has to come last. It seems > merge is no longer last and you've solved it by checking specifically for > 'merge' in many places. I think it would be better to c

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15441. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15430&id=15441 REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FILES hgext/transplant.py mercurial/state.py tests/test-absorb-unfi

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15440. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15428&id=15440 REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FILES mercurial/cmdutil.py mercurial/state.py tests/test-graft.t

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 updated this revision to Diff 15438. taapas1128 marked 5 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6501?vs=15424&id=15438 REVISION DETAIL https://phab.mercurial-scm.org/D6501 AFFECTED FILES hgext/histedit.py

D6502: state: moved cmdutil.STATES and utilities to state.py

taapas1128 updated this revision to Diff 15439. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6502?vs=15425&id=15439 REVISION DETAIL https://phab.mercurial-scm.org/D6502 AFFECTED FILES mercurial/cmdutil.py mercurial/state.py CHANGE DETAILS diff -

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 added inline comments. INLINE COMMENTS > taapas1128 wrote in state.py:140 > oh I will correct that. Strange it wasn't caught in test-check-code.t. I > always try to run that. I tried again it was not detected. Should I file this as a bug ? REPOSITORY rHG Mercurial REVISION DETAIL

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 added inline comments. INLINE COMMENTS > pulkit wrote in state.py:140 > needs space between `=` operator. I guess this is caught by `test-check*`, > make sure you run tests. oh I will correct that. Strange it wasn't caught in test-check-code.t. I always try to run that. REPOSITORY

D6503: statecheck: added support for STATES

taapas1128 added a subscriber: martinvonz. taapas1128 added inline comments. INLINE COMMENTS > pulkit wrote in state.py:186 > the previous patch moves all this code, and this patch just removes it > mostly. I think we can prevent the code-movement then. Yes but this is according to the splittin

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15430. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15427&id=15430 REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FILES hgext/histedit.py hgext/rebase.py hgext/transplant.py mercu

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15428. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15426&id=15428 REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FILES mercurial/cmdutil.py mercurial/state.py tests/test-graft.t

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15427. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15415&id=15427 REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FILES hgext/histedit.py hgext/rebase.py hgext/transplant.py mercu

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15426. taapas1128 marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15414&id=15426 REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FILES mercurial/cmdutil.py

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 updated this revision to Diff 15424. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6501?vs=15412&id=15424 REVISION DETAIL https://phab.mercurial-scm.org/D6501 AFFECTED FILES hgext/histedit.py hgext/rebase.py hgext/shelve.py hgext/tra

D6502: state: moved cmdutil.STATES and utilities to state.py

taapas1128 updated this revision to Diff 15425. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6502?vs=15413&id=15425 REVISION DETAIL https://phab.mercurial-scm.org/D6502 AFFECTED FILES mercurial/cmdutil.py mercurial/state.py CHANGE DETAILS diff -

D6503: statecheck: added support for STATES

taapas1128 marked 3 inline comments as done. taapas1128 added inline comments. INLINE COMMENTS > pulkit wrote in state.py:147 > This change should be a part of patch where isunfinished was introduced. mergecheck is introduced in this patch now so now this change must be okay I suppose. REPOSIT

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15415. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15409&id=15415 REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FILES hgext/histedit.py hgext/rebase.py hgext/transplant.py mercu

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15414. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15408&id=15414 REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FILES mercurial/cmdutil.py mercurial/state.py tests/test-graft.t

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 updated this revision to Diff 15412. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6501?vs=15407&id=15412 REVISION DETAIL https://phab.mercurial-scm.org/D6501 AFFECTED FILES hgext/histedit.py hgext/rebase.py hgext/shelve.py hgext/tra

D6502: state: moved cmdutil.STATES and utilities to state.py

taapas1128 updated this revision to Diff 15413. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6502?vs=15404&id=15413 REVISION DETAIL https://phab.mercurial-scm.org/D6502 AFFECTED FILES mercurial/cmdutil.py mercurial/state.py CHANGE DETAILS diff -

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15409. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15406&id=15409 REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FILES hgext/histedit.py hgext/rebase.py hgext/transplant.py mercu

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15408. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15405&id=15408 REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FILES mercurial/cmdutil.py mercurial/state.py tests/test-graft.t

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 updated this revision to Diff 15407. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6501?vs=15403&id=15407 REVISION DETAIL https://phab.mercurial-scm.org/D6501 AFFECTED FILES hgext/histedit.py hgext/rebase.py hgext/shelve.py hgext/tra

D6502: state: moved cmdutil.STATES and utilities to state.py

taapas1128 added inline comments. INLINE COMMENTS > taapas1128 wrote in state.py:185 > `morestatus` functionality is left in `cmdutil.py` only the place where it > checks for unfinished states that is `_morestatus` has been moved here. `_getrepostate` not more status REPOSITORY rHG Mercurial

D6502: state: moved cmdutil.STATES and utilities to state.py

taapas1128 added inline comments. INLINE COMMENTS > martinvonz wrote in state.py:185 > This feels a lot like morestatus functionality and should perhaps have been > left in cmdutil.py. `morestatus` functionality is left in `cmdutil.py` only the place where it checks for unfinished states that

D6504: statecheck: changed hint message format

taapas1128 updated this revision to Diff 15406. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6504?vs=15396&id=15406 REVISION DETAIL https://phab.mercurial-scm.org/D6504 AFFECTED FILES hgext/histedit.py hgext/rebase.py hgext/transplant.py mercu

D6484: states: moved cmdutil.unfinishedstates to state.py

taapas1128 updated this revision to Diff 15402. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6484?vs=15392&id=15402 REVISION DETAIL https://phab.mercurial-scm.org/D6484 AFFECTED FILES hgext/absorb.py hgext/fix.py hgext/histedit.py hgext/phabri

D6503: statecheck: added support for STATES

taapas1128 updated this revision to Diff 15405. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6503?vs=15395&id=15405 REVISION DETAIL https://phab.mercurial-scm.org/D6503 AFFECTED FILES mercurial/cmdutil.py mercurial/state.py tests/test-graft.t

D6501: state: created new class statecheck to handle unfinishedstates

taapas1128 updated this revision to Diff 15403. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6501?vs=15400&id=15403 REVISION DETAIL https://phab.mercurial-scm.org/D6501 AFFECTED FILES hgext/histedit.py hgext/rebase.py hgext/shelve.py hgext/tra

D6502: state: moved cmdutil.STATES and utilities to state.py

taapas1128 updated this revision to Diff 15404. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6502?vs=15401&id=15404 REVISION DETAIL https://phab.mercurial-scm.org/D6502 AFFECTED FILES mercurial/cmdutil.py mercurial/state.py CHANGE DETAILS diff -

<    1   2   3   4   5   >