taapas1128 added a comment.
@durin42 to which rev should I rebase it to ?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5792
To: taapas1128, #hg-reviewers, durin42
Cc: durin42, pulkit, lothiraldan, mercurial-devel
___
taapas1128 marked an inline comment as done.
taapas1128 added a comment.
@durin42 I have made the change. Please review.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5792
To: taapas1128, #hg-reviewers, durin42
Cc: durin42, pulkit, lothiraldan, mercurial-devel
taapas1128 updated this revision to Diff 14132.
taapas1128 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5792?vs=13915&id=14132
REVISION DETAIL
https://phab.mercurial-scm.org/D5792
AFFECTED FILES
hgext/uncommit.py
taapas1128 added a comment.
@pulkit I have updated the description .
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5792
To: taapas1128, #hg-reviewers
Cc: pulkit, lothiraldan, mercurial-devel
___
Mercurial-devel mailin
taapas1128 added a comment.
@pulkit Can you please review this . I did not send a patch regarding `-n`
flag because tests could be completed without it and also it would mean i would
have to import large chunks of code.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm
taapas1128 added a comment.
@pulkit Apparently it seems removing `-n` flag altogether will not interfere
with the tests and they can be completed without that flag too . I have added
inline comments please review.
INLINE COMMENTS
> test-uncommit-interactive.t:134
> +
> +
> +
taapas1128 updated this revision to Diff 13915.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5792?vs=13738&id=13915
REVISION DETAIL
https://phab.mercurial-scm.org/D5792
AFFECTED FILES
hgext/uncommit.py
tests/test-uncommit-interactive.t
tests/tes
taapas1128 added a comment.
@pulkit I have added some inline comments . So what do you suggest one way
can be merging this and I will send a follow up for integrating `-n` to `hg
uncommit`and then amending the tests. The other way is I should send a request
for `-n` flag and then make all th
taapas1128 added a comment.
@pulkit I was able to import the tests and make them compatible with
`hg-stable` . Some tests which include commands like `hg obslog` , `hg amend
--extract` , and `hg uncommit -n` which are not part of `hg-stable` but
`evolve` are not running else all tests are no
taapas1128 updated this revision to Diff 13738.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5792?vs=13737&id=13738
REVISION DETAIL
https://phab.mercurial-scm.org/D5792
AFFECTED FILES
hgext/uncommit.py
tests/test-uncommit-interactive.t
tests/tes
taapas1128 updated this revision to Diff 13737.
taapas1128 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5792?vs=13701&id=13737
REVISION DETAIL
https://phab.mercurial-scm.org/D5792
AFFECTED FILES
hgext/uncommit.py
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf3f6719951a3: revert: add prompt before undeleting a file
in -i (issue6008) (authored by taapas1128, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org
taapas1128 added a comment.
@yuja thanks for the review . I have updated the revision please tell if
anything else needs to be done.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5803
To: taapas1128, #hg-reviewers
Cc: yuja, mercurial-devel
taapas1128 updated this revision to Diff 13711.
taapas1128 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5803?vs=13703&id=13711
REVISION DETAIL
https://phab.mercurial-scm.org/D5803
AFFECTED FILES
mercurial/cmdutil
taapas1128 updated this revision to Diff 13703.
taapas1128 retitled this revision from "revert: added prompt before undeleting
a file(issue6008)" to "revert: added prompt before undeleting a file in
-i(issue6008)".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-sc
taapas1128 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5803
AFFECTED FILES
mercurial/cmdutil.py
tests/test-revert-interactive.t
CHANGE DETAILS
diff --g
taapas1128 added a comment.
@pulkit I have made an attempt to import the code please review. @lothiraldan
can you please review and help me if I have missed out any portion of
interactive from `evolve`
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5792
To: t
taapas1128 updated this revision to Diff 13701.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5792?vs=13669&id=13701
REVISION DETAIL
https://phab.mercurial-scm.org/D5792
AFFECTED FILES
hgext/uncommit.py
tests/test-uncommit.t
CHANGE DETAILS
diff -
taapas1128 added a comment.
Thanks for the review @pulkit . By importing do you suggest importing the
code for interactive or someway is there is someway to link `evolve` to
`hg-stable` ?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5792
To: taapas1128, #hg-
taapas1128 updated this revision to Diff 13669.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5792?vs=13668&id=13669
REVISION DETAIL
https://phab.mercurial-scm.org/D5792
AFFECTED FILES
hgext/uncommit.py
tests/test-uncommit.t
CHANGE DETAILS
diff -
taapas1128 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5792
AFFECTED FILES
hgext/uncommit.py
tests/test-uncommit.t
CHANGE DETAILS
diff --git a/tests/te
taapas1128 added a comment.
@lothiraldan I am not sure but my aim is to supply mock values to
`dateutil.makedate()` everytime is it called but I will go through what
`devel.default-date` does .
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5577
To: taapas1128
taapas1128 added a comment.
@lothiraldan I am not sure that would work because my aim is to supply mock
values everytime `dateutil.makedate()` is called so as to avoid the change in
test results at any time the test is executed.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.merc
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8633c716f908: tests: replace mockmakedate function in
test-amend.t (authored by taapas1128, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5577?vs
taapas1128 added a subscriber: yuja.
taapas1128 added a comment.
@yuja please review this.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5577
To: taapas1128, #hg-reviewers
Cc: yuja, mercurial-devel
___
Mercurial-devel
taapas1128 added a comment.
@yuja thanks for the edits and queuing .
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
To: taapas1128, durin42, #hg-reviewers
Cc: yuja, pulkit, mercurial-devel
___
Mercurial-devel mail
taapas1128 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5577
AFFECTED FILES
tests/test-amend.t
CHANGE DETAILS
diff --git a/tests/test-amend.t b/tests/test
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6459797090ea: histedit: add rewrite.update-timestamp
support to fold and mess (authored by taapas1128, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D5554?vs=13201&id=13202#toc
taapas1128 updated this revision to Diff 13201.
taapas1128 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5554?vs=13200&id=13201
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
AFFECTED FILES
hgext/histedit.py
taapas1128 added a comment.
I have extracted mockdate function as `tests/mockdate.py` and dealt with the
commas and spaces.
> def commiteditor(self):
> """The editor to be used to edit the commit message."""
>
> @@ -800,6 +804,8 @@
>
> 1. date if self.firstdate(): comm
taapas1128 updated this revision to Diff 13200.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5554?vs=13199&id=13200
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
AFFECTED FILES
hgext/histedit.py
tests/mockmakedate.py
tests/test-histedit-e
taapas1128 updated this revision to Diff 13199.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5554?vs=13198&id=13199
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
AFFECTED FILES
hgext/histedit.py
tests/mockmakedate.py
tests/test-histedit-e
taapas1128 updated this revision to Diff 13198.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5554?vs=13197&id=13198
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
AFFECTED FILES
hgext/histedit.py
tests/mockmakedate.py
tests/test-histedit-e
taapas1128 updated this revision to Diff 13197.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5554?vs=13138&id=13197
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
AFFECTED FILES
hgext/histedit.py
tests/test-histedit-edit.t
tests/test-histe
taapas1128 updated this revision to Diff 13138.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5554?vs=13137&id=13138
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
AFFECTED FILES
hgext/histedit.py
tests/test-histedit-edit.t
tests/test-histe
taapas1128 added a subscriber: pulkit.
taapas1128 added a comment.
@pulkit please review. I will add a `test-histedit-mess.t` if required.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
To: taapas1128, durin42, #hg-reviewers
Cc: pulkit, mercurial-devel
taapas1128 created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
AFFECTED FILES
hgext/histedit.py
tests/test-histedit-fold.t
taapas1128 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5513
AFFECTED FILES
mercurial/cmdutil.py
CHANGE DETAILS
diff --git a/mercurial/cmdutil.py b/mercur
taapas1128 added a comment.
Thanks for queueing. I will make the follow up patch for the inline comments.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5491
To: taapas1128, #hg-reviewers, pulkit
Cc: pulkit, mercurial-devel
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGec51a430ec51: amend: added config option to update time to
current in hg amend(issue5828) (authored by taapas1128, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D5491?vs=13013&
taapas1128 added a comment.
@pulkit done . Please review.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5491
To: taapas1128, #hg-reviewers
Cc: pulkit, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@m
taapas1128 updated this revision to Diff 13013.
taapas1128 edited the summary of this revision.
taapas1128 retitled this revision from "amend: added config option to update
time to current and avoid update when other attribs are unchanged (issue5828)"
to "amend: added config option to update time
taapas1128 updated this revision to Diff 13012.
taapas1128 retitled this revision from "amend: added config option to update
time to current in hg amend (issue5828)" to "amend: added config option to
update time to current and avoid update when other attribs are unchanged
(issue5828)".
REPOSITO
taapas1128 marked an inline comment as done.
taapas1128 added a comment.
@pulkit dealt with //test-check-code.t// and //test-check-commit.t// . And
dealt with test-amend.t by making `mockmakedate()` as in //test-journal.t// .
Please review.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https
taapas1128 updated this revision to Diff 13010.
taapas1128 retitled this revision from "amend:added config option to update
time to current in hg amend(issue5828)" to "amend: added config option to
update time to current in hg amend (issue5828)".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UP
taapas1128 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5492
AFFECTED FILES
.hgsigs
CHANGE DETAILS
diff --git a/.hgsigs b/.hgsigs
--- a/.hgsigs
+++ b/.hgs
taapas1128 added a comment.
no the date is updated in 2560. So below that it wont work
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5491
To: taapas1128, #hg-reviewers
Cc: pulkit, mercurial-devel
___
Mercurial-devel m
taapas1128 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5491
AFFECTED FILES
mercurial/cmdutil.py
mercurial/configitems.py
mercurial/help/config.txt
te
taapas1128 added a comment.
I think that would not be correct because we need to avoid date change
update-timestamp is true and when no option is passed and no attribute is
changed . Only when there is change in any of the attributes then only date is
to be updated which can only be tested t
taapas1128 marked an inline comment as done.
taapas1128 added a comment.
@pulkit I have updated the revision accordingly. Please review
REVISION DETAIL
https://phab.mercurial-scm.org/D5483
To: taapas1128, #hg-reviewers
Cc: pulkit, yuja, mercurial-devel
__
taapas1128 updated this revision to Diff 13005.
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5483?vs=12998&id=13005
REVISION DETAIL
https://phab.mercurial-scm.org/D5483
AFFECTED FILES
mercurial/cmdutil.py
mercurial/configitems.py
mercurial/help/config.txt
tests/test-amen
taapas1128 added a comment.
@pulkit I have updated the revision. Sorry about the tests.Please review when
you are free.
REVISION DETAIL
https://phab.mercurial-scm.org/D5483
To: taapas1128, #hg-reviewers
Cc: pulkit, yuja, mercurial-devel
___
Mercu
taapas1128 updated this revision to Diff 12998.
taapas1128 retitled this revision from "amend:added rewrite.updatetimestamp
config option(issue5828)" to "amend:added config option to update time to
current in hg amend(issue5828)".
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5483
taapas1128 added a comment.
@yuja Please review this
REVISION DETAIL
https://phab.mercurial-scm.org/D5483
To: taapas1128, #hg-reviewers
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercur
taapas1128 added a comment.
@yuja Corrected the tests. Added in config.txt and changed the config option
according to the guideline. Please review when you are free.
REVISION DETAIL
https://phab.mercurial-scm.org/D5483
To: taapas1128, #hg-reviewers
Cc: yuja, mercurial-devel
__
taapas1128 updated this revision to Diff 12987.
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5483?vs=12979&id=12987
REVISION DETAIL
https://phab.mercurial-scm.org/D5483
AFFECTED FILES
mercurial/cmdutil.py
mercurial/configitems.py
mercurial/help/config.txt
tests/test-amen
taapas1128 added a comment.
@yuja I have updated the revision . Please review.
REVISION DETAIL
https://phab.mercurial-scm.org/D5483
To: taapas1128, #hg-reviewers
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-
taapas1128 updated this revision to Diff 12979.
taapas1128 retitled this revision from "amend:Added current time update config
option(issue5828)" to "amend:Added rewrite.updatetimestamp config
option(issue5828)".
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5483?vs=12977&id=12979
taapas1128 added a comment.
In the tests I added two parts one with config option False and and another
with True. I will correct the heading that part is with config turned off.
Okay I will change the config option to
rewrite.updatetimestamp
and will see how to get current times
taapas1128 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5483
AFFECTED FILES
mercurial/cmdutil.py
mercurial/configitems.py
tests/test-amend.t
CHANGE DET
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG10e628a05725: push:Added keyword remote to 'repository
changed while pushing' error… (authored by taapas1128, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercuria
taapas1128 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4933
AFFECTED FILES
mercurial/bundle2.py
tests/test-bundle2-exchange.t
tests/test-bundle2-format
taapas1128 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4932
AFFECTED FILES
mercurial/bundle2.py
tests/test-bundle2-exchange.t
tests/test-bundle2-format
401 - 463 of 463 matches
Mail list logo