Re: [PATCH] makefile: run Rust tests if cargo is installed

2019-08-22 Thread Raphaël Gomès
That makes it easier indeed, thanks. On 8/22/19 2:50 PM, Yuya Nishihara wrote: On Thu, 22 Aug 2019 21:41:40 +0900, Yuya Nishihara wrote: On Thu, 22 Aug 2019 07:47:30 +0200, Raphaël Gomès wrote: I'm not sure I agree, checking for execute this way seems very common and looks more semantic to

Re: [PATCH] makefile: run Rust tests if cargo is installed

2019-08-22 Thread Yuya Nishihara
On Thu, 22 Aug 2019 21:41:40 +0900, Yuya Nishihara wrote: > On Thu, 22 Aug 2019 07:47:30 +0200, Raphaël Gomès wrote: > > I'm not sure I agree, checking for execute this way seems very common > > and looks more semantic to me. > > [ -x path ] is valid, but why do you want to test the result of >

Re: [PATCH] makefile: run Rust tests if cargo is installed

2019-08-22 Thread Yuya Nishihara
On Thu, 22 Aug 2019 07:47:30 +0200, Raphaël Gomès wrote: > I'm not sure I agree, checking for execute this way seems very common > and looks more semantic to me. [ -x path ] is valid, but why do you want to test the result of `command -v cmd` again? It maybe an empty string if the cmd doesn't

Re: [PATCH] makefile: run Rust tests if cargo is installed

2019-08-22 Thread Raphaël Gomès
Good catch. I somehow screwed up twice in the same patch with the comment and this bit. The original patch did not even apply locally, go figure. My follow up should address that. On 8/22/19 6:44 AM, Anton Shestakov wrote: On Wed, 21 Aug 2019 18:09:33 +0200 Raphaël Gomès wrote: # HG

Re: [PATCH] makefile: run Rust tests if cargo is installed

2019-08-21 Thread Raphaël Gomès
I'm not sure I agree, checking for execute this way seems very common and looks more semantic to me. On 8/22/19 1:37 AM, Yuya Nishihara wrote: On Thu, 22 Aug 2019 08:31:50 +0900, Yuya Nishihara wrote: On Wed, 21 Aug 2019 18:09:33 +0200, Raphaël Gomès wrote: # HG changeset patch # User

Re: [PATCH] makefile: run Rust tests if cargo is installed

2019-08-21 Thread Anton Shestakov
On Wed, 21 Aug 2019 18:09:33 +0200 Raphaël Gomès wrote: > # HG changeset patch > # User Raphaël Gomès > # Date 1566403010 -7200 > # Wed Aug 21 17:56:50 2019 +0200 > # Branch stable > # Node ID 5b9efc6098154fb5079f06b3c485b58363e0f43d > # Parent 302dbc9d52beeb2ef677aa18b3fa005bbce2134e >

Re: [PATCH] makefile: run Rust tests if cargo is installed

2019-08-21 Thread Yuya Nishihara
On Thu, 22 Aug 2019 08:31:50 +0900, Yuya Nishihara wrote: > On Wed, 21 Aug 2019 18:09:33 +0200, Raphaël Gomès wrote: > > # HG changeset patch > > # User Raphaël Gomès > > # Date 1566403010 -7200 > > # Wed Aug 21 17:56:50 2019 +0200 > > # Branch stable > > # Node ID

Re: [PATCH] makefile: run Rust tests if cargo is installed

2019-08-21 Thread Yuya Nishihara
On Wed, 21 Aug 2019 18:09:33 +0200, Raphaël Gomès wrote: > # HG changeset patch > # User Raphaël Gomès > # Date 1566403010 -7200 > # Wed Aug 21 17:56:50 2019 +0200 > # Branch stable > # Node ID 5b9efc6098154fb5079f06b3c485b58363e0f43d > # Parent 302dbc9d52beeb2ef677aa18b3fa005bbce2134e >

Re: [PATCH] makefile: run Rust tests if cargo is installed

2019-08-21 Thread Raphaël Gomès
I figured patchbomb would add [PATCH STABLE], but I was wrong, it has to be specified. So this patch is for the stable branch. On 8/21/19 6:09 PM, Raphaël Gomès wrote: # HG changeset patch # User Raphaël Gomès # Date 1566403010 -7200 # Wed Aug 21 17:56:50 2019 +0200 # Branch stable #

[PATCH] makefile: run Rust tests if cargo is installed

2019-08-21 Thread Raphaël Gomès
# HG changeset patch # User Raphaël Gomès # Date 1566403010 -7200 # Wed Aug 21 17:56:50 2019 +0200 # Branch stable # Node ID 5b9efc6098154fb5079f06b3c485b58363e0f43d # Parent 302dbc9d52beeb2ef677aa18b3fa005bbce2134e makefile: run Rust tests if cargo is installed While no particular minimum