timeit and (micro)benchmarks (was Re: [PATCH] performance: disable workaround for an old bug of Python)

2016-08-22 Thread Augie Fackler
On Sun, Aug 21, 2016 at 06:49:45PM +0200, Maciej Fijalkowski wrote: > On Sun, Aug 21, 2016 at 5:19 PM, Yuya Nishihara wrote: > > On Sat, 20 Aug 2016 23:04:06 +0200, Maciej Fijalkowski wrote: > >> Well you're using TIMEIT to do GC benchmarks - it's a terrible > >> idea, ever,

Re: [PATCH] performance: disable workaround for an old bug of Python

2016-08-12 Thread Maciej Fijalkowski
Well, seems the comment is out of date. I know the issue - the GC got triggered every X objects in 2.6, which caused O(n^2) performance when allocating lots of objects. These days (since 2.7) it adapts the threshold, which means it always amortizes to O(n). Either way, I don't care if we disable