Re: [PATCH 01 of 13 V3] scmutil: add a method to convert environment variables to config items

2017-03-23 Thread Martin von Zweigbergk via Mercurial-devel
On Thu, Mar 23, 2017 at 1:21 PM, Kevin Bullock wrote: >> On Mar 23, 2017, at 13:27, Jun Wu wrote: >> >> Thanks for the detailed review and especially for raising the pattern >> issue! I think you have a very good point, and I actually prefer the

Re: [PATCH 01 of 13 V3] scmutil: add a method to convert environment variables to config items

2017-03-23 Thread Kevin Bullock
> On Mar 23, 2017, at 13:27, Jun Wu wrote: > > Thanks for the detailed review and especially for raising the pattern > issue! I think you have a very good point, and I actually prefer the less > commits way. > > I'd like to provide the reason for this particular series. The

Re: [PATCH 01 of 13 V3] scmutil: add a method to convert environment variables to config items

2017-03-23 Thread Jun Wu
Thanks for the detailed review and especially for raising the pattern issue! I think you have a very good point, and I actually prefer the less commits way. I'd like to provide the reason for this particular series. The general question will be left for others to comment. The reason was simple -

Re: [PATCH 01 of 13 V3] scmutil: add a method to convert environment variables to config items

2017-03-22 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Mar 22, 2017 at 10:23 AM, Jun Wu wrote: > # HG changeset patch > # User Jun Wu > # Date 1489449998 25200 > # Mon Mar 13 17:06:38 2017 -0700 > # Node ID 04259bd73d263306f16e25bd4e6bc53faf80911c > # Parent 55c6788c54e2faf80ec14f2b0844bfe429012bc3 > #

[PATCH 01 of 13 V3] scmutil: add a method to convert environment variables to config items

2017-03-22 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1489449998 25200 # Mon Mar 13 17:06:38 2017 -0700 # Node ID 04259bd73d263306f16e25bd4e6bc53faf80911c # Parent 55c6788c54e2faf80ec14f2b0844bfe429012bc3 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull