Re: [PATCH 02 of 10 V2] revlog: fix pure python slicing code when chain contains nullrev

2019-01-02 Thread Boris FELD
On 30/12/2018 09:06, Yuya Nishihara wrote: > On Fri, 28 Dec 2018 19:07:04 +0100, Boris FELD wrote: >> On 28/12/2018 06:23, Yuya Nishihara wrote: >>> On Fri, 28 Dec 2018 00:24:48 +0100, Boris FELD wrote: > Can you turn these tests into a unittest to cover both pure and C > implementations?

Re: [PATCH 02 of 10 V2] revlog: fix pure python slicing code when chain contains nullrev

2018-12-30 Thread Yuya Nishihara
On Fri, 28 Dec 2018 19:07:04 +0100, Boris FELD wrote: > On 28/12/2018 06:23, Yuya Nishihara wrote: > > On Fri, 28 Dec 2018 00:24:48 +0100, Boris FELD wrote: > >>> Can you turn these tests into a unittest to cover both pure and C > >>> implementations? > >> Turning this specific test is a bit more

Re: [PATCH 02 of 10 V2] revlog: fix pure python slicing code when chain contains nullrev

2018-12-28 Thread Boris FELD
On 28/12/2018 06:23, Yuya Nishihara wrote: > On Fri, 28 Dec 2018 00:24:48 +0100, Boris FELD wrote: >>> Can you turn these tests into a unittest to cover both pure and C >>> implementations? >> Turning this specific test is a bit more complicated than we would like >> as we are taking advantage of

Re: [PATCH 02 of 10 V2] revlog: fix pure python slicing code when chain contains nullrev

2018-12-27 Thread Yuya Nishihara
On Fri, 28 Dec 2018 00:24:48 +0100, Boris FELD wrote: > > Can you turn these tests into a unittest to cover both pure and C > > implementations? > Turning this specific test is a bit more complicated than we would like > as we are taking advantage of _testrevlog flexibility to produce a > simple

Re: [PATCH 02 of 10 V2] revlog: fix pure python slicing code when chain contains nullrev

2018-12-21 Thread Yuya Nishihara
On Fri, 21 Dec 2018 12:47:05 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1545296356 -3600 > # Thu Dec 20 09:59:16 2018 +0100 > # Node ID df9b79e863d6e5215175487330b1469067e20bbd > # Parent d51d82a46d9545235be727b875deeffd9de324e9 > # EXP-Topic sparse-revlog

[PATCH 02 of 10 V2] revlog: fix pure python slicing code when chain contains nullrev

2018-12-21 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1545296356 -3600 # Thu Dec 20 09:59:16 2018 +0100 # Node ID df9b79e863d6e5215175487330b1469067e20bbd # Parent d51d82a46d9545235be727b875deeffd9de324e9 # EXP-Topic sparse-revlog # Available At https://bitbucket.org/octobus/mercurial-devel/ #