Re: [PATCH 2 of 3] configitems: use codemod script to register coreconfigitems

2017-07-14 Thread Martin von Zweigbergk via Mercurial-devel
On Fri, Jul 14, 2017 at 11:59 AM, Augie Fackler wrote: > >> On Jul 14, 2017, at 14:58, Jun Wu wrote: >> >> Excerpts from Augie Fackler's message of 2017-07-14 14:39:17 -0400: >>> Urg. This is kind of unreviewable, because it's gathering configitems >>> from

Re: [PATCH 2 of 3] configitems: use codemod script to register coreconfigitems

2017-07-14 Thread Augie Fackler
> On Jul 14, 2017, at 14:58, Jun Wu wrote: > > Excerpts from Augie Fackler's message of 2017-07-14 14:39:17 -0400: >> Urg. This is kind of unreviewable, because it's gathering configitems >> from everywhere and splatting them in one big file, so it's hard to >> audit defaults etc.

Re: [PATCH 2 of 3] configitems: use codemod script to register coreconfigitems

2017-07-14 Thread Jun Wu
Excerpts from Augie Fackler's message of 2017-07-14 14:39:17 -0400: > Urg. This is kind of unreviewable, because it's gathering configitems > from everywhere and splatting them in one big file, so it's hard to > audit defaults etc. Why is audit needed if defaults are written by code, not human?

Re: [PATCH 2 of 3] configitems: use codemod script to register coreconfigitems

2017-07-14 Thread Augie Fackler
On Wed, Jul 12, 2017 at 06:22:47PM -0700, Jun Wu wrote: > # HG changeset patch > # User Jun Wu > # Date 1499898287 25200 > # Wed Jul 12 15:24:47 2017 -0700 > # Node ID a0df53ed55b26539c62584231cfcb567594ab34a > # Parent 695702ea1caedaeeed9a6d63473c0e338adf35f4 > # Available At

Re: [PATCH 2 of 3] configitems: use codemod script to register coreconfigitems

2017-07-14 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Jul 12, 2017 at 6:22 PM, Jun Wu wrote: > # HG changeset patch > # User Jun Wu > # Date 1499898287 25200 > # Wed Jul 12 15:24:47 2017 -0700 > # Node ID a0df53ed55b26539c62584231cfcb567594ab34a > # Parent 695702ea1caedaeeed9a6d63473c0e338adf35f4 > #

Re: [PATCH 2 of 3] configitems: use codemod script to register coreconfigitems

2017-07-12 Thread Jun Wu
Excerpts from Jun Wu's message of 2017-07-12 18:22:47 -0700: > This is the result of running: > > contrib/codemod/codemod_configitems.py mercurial/**/*.py This line should be: contrib/codemod/codemod_configitems.py {mercurial,hgext}/**/*.py I have got it right in some local commits. But I

[PATCH 2 of 3] configitems: use codemod script to register coreconfigitems

2017-07-12 Thread Jun Wu
# HG changeset patch # User Jun Wu # Date 1499898287 25200 # Wed Jul 12 15:24:47 2017 -0700 # Node ID a0df53ed55b26539c62584231cfcb567594ab34a # Parent 695702ea1caedaeeed9a6d63473c0e338adf35f4 # Available At https://bitbucket.org/quark-zju/hg-draft # hg pull