Re: [PATCH 2 of 4 V2] lfs: infer the blob store URL from paths.default

2018-04-11 Thread Yuya Nishihara
On Wed, 11 Apr 2018 07:57:56 -0400, Matt Harbison wrote: > >> +url = util.url(bytes(defaulturl)) > > > > Nit: perhaps no need to reparse the url since defaulturl is a url object. > > I don’t have the code in front of me, but I think there is an _originalpath > member that doesn’t

Re: [PATCH 2 of 4 V2] lfs: infer the blob store URL from paths.default

2018-04-11 Thread Matt Harbison
> On Apr 11, 2018, at 7:29 AM, Yuya Nishihara wrote: > >> On Tue, 10 Apr 2018 16:09:24 -0400, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1523154140 14400 >> # Sat Apr 07 22:22:20 2018 -0400 >> # Node ID

Re: [PATCH 2 of 4 V2] lfs: infer the blob store URL from paths.default

2018-04-11 Thread Yuya Nishihara
On Tue, 10 Apr 2018 16:09:24 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1523154140 14400 > # Sat Apr 07 22:22:20 2018 -0400 > # Node ID b784de3b414876f25964778b02e684f9b0a3787f > # Parent

[PATCH 2 of 4 V2] lfs: infer the blob store URL from paths.default

2018-04-10 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1523154140 14400 # Sat Apr 07 22:22:20 2018 -0400 # Node ID b784de3b414876f25964778b02e684f9b0a3787f # Parent 473a8954c957945d1642d08eeefc8fe706597b59 lfs: infer the blob store URL from paths.default If `lfs.url` is