Re: [PATCH 3 of 3] histedit: test that an aborted histedit can be rerun (with obsolete)

2017-03-27 Thread Augie Fackler
On Mon, Mar 27, 2017 at 02:04:44PM +0200, Pierre-Yves David wrote: > > > On 03/27/2017 12:31 PM, Jun Wu wrote: > > Excerpts from Pierre-Yves David's message of 2017-03-27 09:19:52 +0200: > > > > > > On 03/26/2017 08:42 PM, Jun Wu wrote: > > > > Excerpts from Jun Wu's message of 2017-03-26 09:59:43

Re: [PATCH 3 of 3] histedit: test that an aborted histedit can be rerun (with obsolete)

2017-03-27 Thread Pierre-Yves David
On 03/27/2017 12:31 PM, Jun Wu wrote: Excerpts from Pierre-Yves David's message of 2017-03-27 09:19:52 +0200: On 03/26/2017 08:42 PM, Jun Wu wrote: Excerpts from Jun Wu's message of 2017-03-26 09:59:43 -0700: I'm -1 on this series. If the goal is to workaround obsolete cycles, the code

Re: [PATCH 3 of 3] histedit: test that an aborted histedit can be rerun (with obsolete)

2017-03-27 Thread Jun Wu
Excerpts from Pierre-Yves David's message of 2017-03-27 09:19:52 +0200: > > On 03/26/2017 08:42 PM, Jun Wu wrote: > > Excerpts from Jun Wu's message of 2017-03-26 09:59:43 -0700: > >> I'm -1 on this series. > >> > >> If the goal is to workaround obsolete cycles, the code could do additional > >>

Re: [PATCH 3 of 3] histedit: test that an aborted histedit can be rerun (with obsolete)

2017-03-26 Thread Jun Wu
I'm -1 on this series. If the goal is to workaround obsolete cycles, the code could do additional checks "if the destination is obsoleted" and do "hg touch"-like thing automatically. That workaround will be no longer necessary if my obsolete cycle patches are landed. Internally, we have several