Re: [PATCH 3 of 7] parsers: avoid PyList_Append when parsing obs markers

2017-03-18 Thread Gregory Szorc
On Thu, Mar 16, 2017 at 10:47 AM, Augie Fackler wrote: > > On Mar 16, 2017, at 10:43, Gregory Szorc wrote: > > Last time we had the Rust discussion, we couldn't ship Rust due to distro > packaging support. Has that changed? > > > My gut feeling with my

Re: [PATCH 3 of 7] parsers: avoid PyList_Append when parsing obs markers

2017-03-16 Thread Augie Fackler
> On Mar 16, 2017, at 10:43, Gregory Szorc wrote: > > Last time we had the Rust discussion, we couldn't ship Rust due to distro > packaging support. Has that changed? My gut feeling with my maintainer hat on is that any rust speedups would need to be opt-in, much

Re: [PATCH 3 of 7] parsers: avoid PyList_Append when parsing obs markers

2017-03-16 Thread Gregory Szorc
On Thu, Mar 16, 2017 at 10:12 AM, Augie Fackler wrote: > > > On Mar 16, 2017, at 10:09, Gregory Szorc > wrote: > > > >> On Thu, Mar 16, 2017 at 9:50 AM, Augie Fackler wrote: > >> On Mon, Mar 13, 2017 at 10:24:21PM -0700, Gregory

Re: [PATCH 3 of 7] parsers: avoid PyList_Append when parsing obs markers

2017-03-16 Thread Augie Fackler
> On Mar 16, 2017, at 10:09, Gregory Szorc wrote: > >> On Thu, Mar 16, 2017 at 9:50 AM, Augie Fackler wrote: >> On Mon, Mar 13, 2017 at 10:24:21PM -0700, Gregory Szorc wrote: >> > On Mon, Mar 13, 2017 at 10:15 PM, Gregory Szorc

Re: [PATCH 3 of 7] parsers: avoid PyList_Append when parsing obs markers

2017-03-16 Thread Gregory Szorc
On Thu, Mar 16, 2017 at 9:50 AM, Augie Fackler wrote: > On Mon, Mar 13, 2017 at 10:24:21PM -0700, Gregory Szorc wrote: > > On Mon, Mar 13, 2017 at 10:15 PM, Gregory Szorc > > > wrote: > > Assuming there is some truth to the numbers, holy cow the

Re: [PATCH 3 of 7] parsers: avoid PyList_Append when parsing obs markers

2017-03-16 Thread Augie Fackler
On Mon, Mar 13, 2017 at 10:24:21PM -0700, Gregory Szorc wrote: > On Mon, Mar 13, 2017 at 10:15 PM, Gregory Szorc > wrote: > Assuming there is some truth to the numbers, holy cow the overhead of > PyObject creation is crazy. I suddenly feel like auditing the C code for >

Re: [PATCH 3 of 7] parsers: avoid PyList_Append when parsing obs markers

2017-03-16 Thread Yuya Nishihara
On Mon, 13 Mar 2017 22:15:45 -0700, Gregory Szorc wrote: > # HG changeset patch > # User Gregory Szorc > # Date 1489454332 25200 > # Mon Mar 13 18:18:52 2017 -0700 > # Node ID 6d3b13f243bea2c9200eecb827d7ec0ea771fc54 > # Parent

Re: [PATCH 3 of 7] parsers: avoid PyList_Append when parsing obs markers

2017-03-13 Thread Gregory Szorc
On Mon, Mar 13, 2017 at 10:15 PM, Gregory Szorc wrote: > # HG changeset patch > # User Gregory Szorc > # Date 1489454332 25200 > # Mon Mar 13 18:18:52 2017 -0700 > # Node ID 6d3b13f243bea2c9200eecb827d7ec0ea771fc54 > # Parent

[PATCH 3 of 7] parsers: avoid PyList_Append when parsing obs markers

2017-03-13 Thread Gregory Szorc
# HG changeset patch # User Gregory Szorc # Date 1489454332 25200 # Mon Mar 13 18:18:52 2017 -0700 # Node ID 6d3b13f243bea2c9200eecb827d7ec0ea771fc54 # Parent 3b997adb7efece7395fb585a70b2d70522626648 parsers: avoid PyList_Append when parsing obs markers