Re: [PATCH 8 of 8 v4] convert: return commit objects for revisions in the revmap

2016-12-14 Thread Kostia Balytskyi
On 12/14/16 5:55 PM, David Soria Parra wrote: > On Wed, Dec 14, 2016 at 04:53:24PM +, Kostia Balytskyi wrote: >> >> On 12/14/16 9:46 AM, David Soria Parra wrote: >>> # HG changeset patch >>> # User David Soria Parra >>> # Date 1481704712 28800 >>> # Wed Dec 14 00:38:32

Re: [PATCH 8 of 8 v4] convert: return commit objects for revisions in the revmap

2016-12-14 Thread David Soria Parra
On Wed, Dec 14, 2016 at 04:53:24PM +, Kostia Balytskyi wrote: > > > On 12/14/16 9:46 AM, David Soria Parra wrote: > > # HG changeset patch > > # User David Soria Parra > > # Date 1481704712 28800 > > # Wed Dec 14 00:38:32 2016 -0800 > > # Node ID

Re: [PATCH 8 of 8 v4] convert: return commit objects for revisions in the revmap

2016-12-14 Thread Kostia Balytskyi
Other than the nit below, this series LGTM. On 12/14/16 4:53 PM, Kostia Balytskyi wrote: > > On 12/14/16 9:46 AM, David Soria Parra wrote: >> # HG changeset patch >> # User David Soria Parra >> # Date 1481704712 28800 >> # Wed Dec 14 00:38:32 2016 -0800 >> # Node ID

Re: [PATCH 8 of 8 v4] convert: return commit objects for revisions in the revmap

2016-12-14 Thread Kostia Balytskyi
On 12/14/16 9:46 AM, David Soria Parra wrote: > # HG changeset patch > # User David Soria Parra > # Date 1481704712 28800 > # Wed Dec 14 00:38:32 2016 -0800 > # Node ID eb4a6df3de20deb31e681aa7eba408dc352440c3 > # Parent 26ec2474ab06fdaf1aca034c54309245ded267b0 > convert:

[PATCH 8 of 8 v4] convert: return commit objects for revisions in the revmap

2016-12-14 Thread David Soria Parra
# HG changeset patch # User David Soria Parra # Date 1481704712 28800 # Wed Dec 14 00:38:32 2016 -0800 # Node ID eb4a6df3de20deb31e681aa7eba408dc352440c3 # Parent 26ec2474ab06fdaf1aca034c54309245ded267b0 convert: return commit objects for revisions in the revmap Source