Re: Internal-changeset concept (was: re: [PATCH RFC] repo: add an ability to hide nodes in an appropriate way)

2017-04-01 Thread Jun Wu
IIRC at the sprint that people tend to agree on root based hidden separated from phase root. I was about to ask questions about "strip", and some "obsstore" interaction, but I think the main focus should be in the obsstore thread. So I'd not distract you here. See inline comments, mainly about

Internal-changeset concept (was: re: [PATCH RFC] repo: add an ability to hide nodes in an appropriate way)

2017-03-31 Thread Pierre-Yves David
[And here is the actual reply, sorry for the initial misstep] On 03/30/2017 07:08 PM, Ryan McElroy wrote: On 3/30/17 3:15 PM, Pierre-Yves David wrote: […] I hope this long message help to clarify various concept. We have way forward to reduce the use of stripping without abusing the

Internal-changeset concept (was: re: [PATCH RFC] repo: add an ability to hide nodes in an appropriate way)

2017-03-31 Thread Pierre-Yves David
On 03/30/2017 07:08 PM, Ryan McElroy wrote: On 3/30/17 3:15 PM, Pierre-Yves David wrote: […] I hope this long message help to clarify various concept. We have way forward to reduce the use of stripping without abusing the obsolescence concept in a way that will create issue for users. These

Re: [PATCH RFC] repo: add an ability to hide nodes in an appropriate way

2017-03-30 Thread Martin von Zweigbergk via Mercurial-devel
On Thu, Mar 30, 2017 at 10:08 AM, Ryan McElroy wrote: > On 3/30/17 3:15 PM, Pierre-Yves David wrote: >> >> On 03/27/2017 07:24 PM, Augie Fackler wrote: >>> >>> On Mon, Mar 27, 2017 at 10:27:33AM +0200, Pierre-Yves David wrote: On 03/27/2017 12:32 AM, Kostia

Re: [PATCH RFC] repo: add an ability to hide nodes in an appropriate way

2017-03-30 Thread Ryan McElroy
On 3/30/17 3:15 PM, Pierre-Yves David wrote: On 03/27/2017 07:24 PM, Augie Fackler wrote: On Mon, Mar 27, 2017 at 10:27:33AM +0200, Pierre-Yves David wrote: On 03/27/2017 12:32 AM, Kostia Balytskyi wrote: # HG changeset patch # User Kostia Balytskyi # Date 1490567500 25200

Re: [PATCH RFC] repo: add an ability to hide nodes in an appropriate way

2017-03-30 Thread Pierre-Yves David
On 03/27/2017 07:24 PM, Augie Fackler wrote: On Mon, Mar 27, 2017 at 10:27:33AM +0200, Pierre-Yves David wrote: On 03/27/2017 12:32 AM, Kostia Balytskyi wrote: # HG changeset patch # User Kostia Balytskyi # Date 1490567500 25200 # Sun Mar 26 15:31:40 2017 -0700 # Node

Re: [PATCH RFC] repo: add an ability to hide nodes in an appropriate way

2017-03-27 Thread Jun Wu
Excerpts from Augie Fackler's message of 2017-03-27 13:24:22 -0400: > On Mon, Mar 27, 2017 at 10:27:33AM +0200, Pierre-Yves David wrote: > > > > > > On 03/27/2017 12:32 AM, Kostia Balytskyi wrote: > > > # HG changeset patch > > > # User Kostia Balytskyi > > > # Date 1490567500

Re: [PATCH RFC] repo: add an ability to hide nodes in an appropriate way

2017-03-27 Thread Augie Fackler
On Sun, Mar 26, 2017 at 04:44:11PM -0700, Jun Wu wrote: > I think this is a good direction. See inline comments. > > Not related directly to this patch, but I was thinking introducing some > "post-transaction" mechanism for transaction. So the caller won't need to > put the "strip" outside a

Re: [PATCH RFC] repo: add an ability to hide nodes in an appropriate way

2017-03-27 Thread Augie Fackler
On Mon, Mar 27, 2017 at 10:27:33AM +0200, Pierre-Yves David wrote: > > > On 03/27/2017 12:32 AM, Kostia Balytskyi wrote: > > # HG changeset patch > > # User Kostia Balytskyi > > # Date 1490567500 25200 > > # Sun Mar 26 15:31:40 2017 -0700 > > # Node ID

Re: [PATCH RFC] repo: add an ability to hide nodes in an appropriate way

2017-03-27 Thread Pierre-Yves David
On 03/27/2017 12:32 AM, Kostia Balytskyi wrote: # HG changeset patch # User Kostia Balytskyi # Date 1490567500 25200 # Sun Mar 26 15:31:40 2017 -0700 # Node ID 43cd56f38c1ca2ad1920ed6804e1a90a5e263c0d # Parent c60091fa1426892552dd6c0dd4b9c49e3c3da045 repo: add an ability

Re: [PATCH RFC] repo: add an ability to hide nodes in an appropriate way

2017-03-26 Thread Jun Wu
I think this is a good direction. See inline comments. Not related directly to this patch, but I was thinking introducing some "post-transaction" mechanism for transaction. So the caller won't need to put the "strip" outside a transaction. Compare: Currently: if obsmarker-enabled:

[PATCH RFC] repo: add an ability to hide nodes in an appropriate way

2017-03-26 Thread Kostia Balytskyi
# HG changeset patch # User Kostia Balytskyi # Date 1490567500 25200 # Sun Mar 26 15:31:40 2017 -0700 # Node ID 43cd56f38c1ca2ad1920ed6804e1a90a5e263c0d # Parent c60091fa1426892552dd6c0dd4b9c49e3c3da045 repo: add an ability to hide nodes in an appropriate way Potentially