Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Jun Wu
Excerpts from Augie Fackler's message of 2016-12-05 18:13:14 -0500: > I'd rather see a new ProgrammingError or something in error.py, and have > it inherit from RuntimeError for six months or so and then cut the cord on > this silliness. +1 on ProgrammingError. I was actually a bit surprised that

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Kevin Bullock
> On Dec 5, 2016, at 17:42, Augie Fackler wrote: > >> On Dec 5, 2016, at 18:41, Kevin Bullock >> wrote: >> >>> On Dec 5, 2016, at 16:51, Jun Wu wrote: >>> >>> Excerpts from Augie Fackler's message of 2016-12-05 17:07:47

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Augie Fackler
> On Dec 5, 2016, at 18:41, Kevin Bullock > wrote: > >> On Dec 5, 2016, at 16:51, Jun Wu wrote: >> >> Excerpts from Augie Fackler's message of 2016-12-05 17:07:47 -0500: >>> On Dec 5, 2016, at 16:54, Jun Wu wrote:

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Kevin Bullock
> On Dec 5, 2016, at 16:51, Jun Wu wrote: > > Excerpts from Augie Fackler's message of 2016-12-05 17:07:47 -0500: >> >>> On Dec 5, 2016, at 16:54, Jun Wu wrote: >>> +e = _("Invalid value in a simple key-value file") +raise

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Augie Fackler
> On Dec 5, 2016, at 17:51, Jun Wu wrote: > > Excerpts from Augie Fackler's message of 2016-12-05 17:07:47 -0500: >> >>> On Dec 5, 2016, at 16:54, Jun Wu wrote: >>> +e = _("Invalid value in a simple key-value file") +raise

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Jun Wu
Excerpts from Augie Fackler's message of 2016-12-05 17:07:47 -0500: > > > On Dec 5, 2016, at 16:54, Jun Wu wrote: > > > >> +e = _("Invalid value in a simple key-value file") > >> +raise self.InvalidValueInFileException(e) > > > > These sound like a

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Kostia Balytskyi
On 12/5/16 9:54 PM, Jun Wu wrote: > Excerpts from Kostia Balytskyi's message of 2016-12-03 15:37:55 -0800: >> # HG changeset patch >> # User Kostia Balytskyi >> # Date 1480808065 28800 >> # Sat Dec 03 15:34:25 2016 -0800 >> # Node ID c4312906ef7d06dc3be1575ee5cde574b915c9c4

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Augie Fackler
> On Dec 5, 2016, at 16:54, Jun Wu wrote: > >> +e = _("Invalid value in a simple key-value file") >> +raise self.InvalidValueInFileException(e) > > These sound like a programmer error. Maybe just raise RuntimeError. I'm not comfortable with that,

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Jun Wu
Excerpts from Kostia Balytskyi's message of 2016-12-03 15:37:55 -0800: > # HG changeset patch > # User Kostia Balytskyi > # Date 1480808065 28800 > # Sat Dec 03 15:34:25 2016 -0800 > # Node ID c4312906ef7d06dc3be1575ee5cde574b915c9c4 > # Parent

Re: [PATCH RFC] scmutil: add a simple key-value file helper

2016-12-05 Thread Augie Fackler
> On Dec 3, 2016, at 18:37, Kostia Balytskyi wrote: > > # HG changeset patch > # User Kostia Balytskyi > # Date 1480808065 28800 > # Sat Dec 03 15:34:25 2016 -0800 > # Node ID c4312906ef7d06dc3be1575ee5cde574b915c9c4 > # Parent

[PATCH RFC] scmutil: add a simple key-value file helper

2016-12-03 Thread Kostia Balytskyi
# HG changeset patch # User Kostia Balytskyi # Date 1480808065 28800 # Sat Dec 03 15:34:25 2016 -0800 # Node ID c4312906ef7d06dc3be1575ee5cde574b915c9c4 # Parent 715232cf9182f904d5153862a1ec4905faaeee6e scmutil: add a simple key-value file helper The purpose of the added