Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

2016-12-06 Thread Kostia Balytskyi
On 12/6/16 2:45 PM, Jun Wu wrote: > Excerpts from Kostia Balytskyi's message of 2016-12-06 14:30:18 +: >> On 12/6/16 2:08 PM, Jun Wu wrote: >>> Excerpts from Kostia Balytskyi's message of 2016-12-06 13:54:02 +: This is what happens if you don't inherit the class or don't override

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

2016-12-06 Thread Jun Wu
Excerpts from Kostia Balytskyi's message of 2016-12-06 14:30:18 +: > > On 12/6/16 2:08 PM, Jun Wu wrote: > > Excerpts from Kostia Balytskyi's message of 2016-12-06 13:54:02 +: > >> This is what happens if you don't inherit the class or don't override > >> the empty KEYS list in the

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

2016-12-06 Thread Kostia Balytskyi
On 12/6/16 2:08 PM, Jun Wu wrote: > Excerpts from Kostia Balytskyi's message of 2016-12-06 13:54:02 +: >> This is what happens if you don't inherit the class or don't override >> the empty KEYS list in the inherited class. > If KEYS is used to verify existence, how about just making it a

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

2016-12-06 Thread Kostia Balytskyi
On 12/6/16 1:48 PM, Jun Wu wrote: > Excerpts from Kostia Balytskyi's message of 2016-12-06 13:39:31 +: >> Hm, I don't see how upper/lower-case instead of explicit boolean flag >> handles that... > I didn't realize the issue either, before Yuya's reply. > >> But to answer your question: >> 1.

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

2016-12-06 Thread Jun Wu
Excerpts from Kostia Balytskyi's message of 2016-12-06 13:39:31 +: > Hm, I don't see how upper/lower-case instead of explicit boolean flag > handles that... I didn't realize the issue either, before Yuya's reply. > But to answer your question: > 1. When you add a new field and you mark it

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

2016-12-06 Thread Kostia Balytskyi
On 12/6/16 1:28 PM, Jun Wu wrote: > Excerpts from Kostia Balytskyi's message of 2016-12-06 13:22:40 +: >> On 12/6/16 1:04 PM, Yuya Nishihara wrote: >>> On Mon, 5 Dec 2016 15:03:35 -0800, Kostia Balytskyi wrote: # HG changeset patch # User Kostia Balytskyi #

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

2016-12-06 Thread Jun Wu
Excerpts from Kostia Balytskyi's message of 2016-12-06 13:22:40 +: > On 12/6/16 1:04 PM, Yuya Nishihara wrote: > > On Mon, 5 Dec 2016 15:03:35 -0800, Kostia Balytskyi wrote: > >> # HG changeset patch > >> # User Kostia Balytskyi > >> # Date 1480978778 28800 > >> # Mon Dec

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

2016-12-06 Thread Kostia Balytskyi
On 12/6/16 1:04 PM, Yuya Nishihara wrote: > On Mon, 5 Dec 2016 15:03:35 -0800, Kostia Balytskyi wrote: >> # HG changeset patch >> # User Kostia Balytskyi >> # Date 1480978778 28800 >> # Mon Dec 05 14:59:38 2016 -0800 >> # Node ID bdc49209b0b926214e865f9a98ea987866f64d68 >> #

Re: [PATCH RFC v3] scmutil: add a simple key-value file helper

2016-12-05 Thread Kevin Bullock
> On Dec 5, 2016, at 17:03, Kostia Balytskyi wrote: > > # HG changeset patch > # User Kostia Balytskyi > # Date 1480978778 28800 > # Mon Dec 05 14:59:38 2016 -0800 > # Node ID bdc49209b0b926214e865f9a98ea987866f64d68 > # Parent

[PATCH RFC v3] scmutil: add a simple key-value file helper

2016-12-05 Thread Kostia Balytskyi
# HG changeset patch # User Kostia Balytskyi # Date 1480978778 28800 # Mon Dec 05 14:59:38 2016 -0800 # Node ID bdc49209b0b926214e865f9a98ea987866f64d68 # Parent 243ecbd4f5c9f452275d4435866359cf84dc03ff scmutil: add a simple key-value file helper The purpose of the added