Re: [PATCH STABLE] changegroup: retry read() when partial data returned

2017-03-29 Thread Gregory Szorc
> On Mar 27, 2017, at 08:59, Yuya Nishihara wrote: > > On Mon, 27 Mar 2017 08:25:41 -0700, Gregory Szorc wrote: On Mar 27, 2017, at 08:13, Yuya Nishihara wrote: On Sun, 26 Mar 2017 11:56:59 -0700, Gregory Szorc wrote: # HG changeset patch #

Re: [PATCH STABLE] changegroup: retry read() when partial data returned

2017-03-27 Thread Yuya Nishihara
On Mon, 27 Mar 2017 08:25:41 -0700, Gregory Szorc wrote: > > On Mar 27, 2017, at 08:13, Yuya Nishihara wrote: > >> On Sun, 26 Mar 2017 11:56:59 -0700, Gregory Szorc wrote: > >> # HG changeset patch > >> # User Gregory Szorc > >> # Date 1490554582 25200 >

Re: [PATCH STABLE] changegroup: retry read() when partial data returned

2017-03-27 Thread Gregory Szorc
> On Mar 27, 2017, at 08:13, Yuya Nishihara wrote: > >> On Sun, 26 Mar 2017 11:56:59 -0700, Gregory Szorc wrote: >> # HG changeset patch >> # User Gregory Szorc >> # Date 1490554582 25200 >> # Sun Mar 26 11:56:22 2017 -0700 >> # Branch stable >> #

Re: [PATCH STABLE] changegroup: retry read() when partial data returned

2017-03-27 Thread Yuya Nishihara
On Sun, 26 Mar 2017 11:56:59 -0700, Gregory Szorc wrote: > # HG changeset patch > # User Gregory Szorc > # Date 1490554582 25200 > # Sun Mar 26 11:56:22 2017 -0700 > # Branch stable > # Node ID 414128ddd876eb33f70b0dd95d110e29a9308c93 > # Parent

Re: [PATCH STABLE] changegroup: retry read() when partial data returned

2017-03-26 Thread Gregory Szorc
On Sun, Mar 26, 2017 at 12:17 PM, Jun Wu wrote: > The direction looks good. I'd like to see more solid code. Commented below. > > Excerpts from Gregory Szorc's message of 2017-03-26 11:56:59 -0700: > > +# Retry to get remaining data. In cases where the stream has > errored or >

Re: [PATCH STABLE] changegroup: retry read() when partial data returned

2017-03-26 Thread Jun Wu
The direction looks good. I'd like to see more solid code. Commented below. Excerpts from Gregory Szorc's message of 2017-03-26 11:56:59 -0700: > +# Retry to get remaining data. In cases where the stream has errored or > +# is at EOF, this will do a bit of redundant work. But it helps

[PATCH STABLE] changegroup: retry read() when partial data returned

2017-03-26 Thread Gregory Szorc
# HG changeset patch # User Gregory Szorc # Date 1490554582 25200 # Sun Mar 26 11:56:22 2017 -0700 # Branch stable # Node ID 414128ddd876eb33f70b0dd95d110e29a9308c93 # Parent ed5b25874d998ababb181a939dd37a16ea644435 changegroup: retry read() when partial data